Subject: [bug#30798] [PATCH 2/2] gnu: Add emacs-deft

From: Oleg Pykhalov <[email-masked]>
Date: Thu, 15 Mar 2018 11:38:12 +0300

Hello Konrad,

First of all thank you for your contribution!

Konrad Hinsen <[email-masked]> writes:

> * gnu/packages/emacs.scm (emacs-deft): New variable.
> ---
>  gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 9c9c399fd..07ac1f0fe 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -7389,3 +7389,26 @@ to inherit a login shell's environment variables.  It also allows other
>  environment variables to be retrieved from the shell, so that Emacs will
>  see the same values you get in a terminal.")
>      (license license:gpl3+)))
> +
> +(define-public emacs-deft
> +  (package
> +    (name "emacs-deft")
> +    (version "0.8")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "http://stable.melpa.org/packages/deft-"
> +             version
> +             ".el"))

Unfortunately, we can't use sources from MELPA.  The problem is: when a
repository get a new commit, the old tarball is *REPLACED* with the new
one on MELPA, so the package could never be built anymore, since the
source disappeared.  That's why we use tarballs directly from source.

You could use Deft source tarball https://github.com/jrblevin/deft/tags

BTW, to make a recipe more polished you could remove unnecessary new
lines, for example:

       (uri (string-append "http://stable.melpa.org/packages/deft-"
             version ".el"))

> +       (sha256
> +        (base32
> +         "1vb9cjxskc7c0yyf9pvxy1fzypg1vrcgwnjz0m3hslinsgdyig58"))))
> +    (build-system emacs-build-system)
> +    (home-page "https://jblevins.org/projects/deft/")
> +    (synopsis
> +     "Quickly browse, filter, and edit plain text notes")

Likewise, unnecessary new line.

> +    (description
> +     "Deft is an Emacs mode for quickly browsing, filtering, and editing
> +directories of plain text notes, inspired by Notational Velocity.")
> +    (license license:gpl3+)))

The home page says Deft is licensed under BSD license.  Could you check
it, please?

Oleg.