Subject: bug#30798: closed (Re: [bug#30798] [PATCH 2/2] gnu: Add emacs-deft)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 16 Mar 2018 14:15:04 +0000

Your bug report

#30798: [PATCH 2/2] gnu: Add emacs-deft

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
30798: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=30798
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#30798] [PATCH 2/2] gnu: Add emacs-deft
From: Oleg Pykhalov <[email-masked]>
To: Konrad Hinsen <[email-masked]>
Cc: [email-masked], [email-masked]
Date: Fri, 16 Mar 2018 17:13:33 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

Konrad Hinsen <[email-masked]> writes:

> * gnu/packages/emacs.scm (emacs-deft): New variable.
> ---
>  gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 35acfdd20..f51f696fd 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -7386,3 +7386,26 @@ inherit a login shell's environment variables.  It also allows other
>  environment variables to be retrieved from the shell, so that Emacs will see
>  the same values you get in a terminal.")
>      (license license:gpl3+)))
> +

[…]

> +    ;; A comment in the code says "may be freely distributed and modified
> +    ;; under the BSD license". I take this to mean the original
> +    ;; BSD license, called bsd-4 in Guix.
> +    (license license:bsd-4)))

Thank you for investigation, but it's a BSD 3-Clause license.  It's easy
to check, because there are *3 clauses* in the license text:

    ;; Redistribution and use in source and binary forms, with or
    ;; without modification, are permitted provided that the following
    ;; conditions are met:
    ;; 1. Redistributions of source code must retain the above copyright
    ;;    notice, this list of conditions and the following disclaimer.
    ;; 2. Redistributions in binary form must reproduce the above
    ;;    copyright notice, this list of conditions and the following
    ;;    disclaimer in the documentation and/or other materials
    ;;    provided with the distribution.
    ;; 3. Neither the names of the copyright holders nor the names of
    ;;    any contributors may be used to endorse or promote products
    ;;    derived from this software without specific prior written
    ;;    permission.

As a tip,  we have a ‘licensecheck’ program in Guix package collection,
which could parse a source code file and tell a license.

Also don't forget a dot at the end in commit message.

Pushed with changes above as 5d818b3557cc3b546d5bd0639359c14c7c0ab685

I'll close the bug report.

Thanks,
Oleg.

Subject: [PATCH 2/2] gnu: Add emacs-deft
From: Konrad Hinsen <[email-masked]>
To: [email-masked]
Date: Tue, 13 Mar 2018 16:47:41 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/emacs.scm (emacs-deft): New variable.
---
 gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 9c9c399fd..07ac1f0fe 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -7389,3 +7389,26 @@ to inherit a login shell's environment variables.  It also allows other
 environment variables to be retrieved from the shell, so that Emacs will
 see the same values you get in a terminal.")
     (license license:gpl3+)))
+
+(define-public emacs-deft
+  (package
+    (name "emacs-deft")
+    (version "0.8")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "http://stable.melpa.org/packages/deft-"
+             version
+             ".el"))
+       (sha256
+        (base32
+         "1vb9cjxskc7c0yyf9pvxy1fzypg1vrcgwnjz0m3hslinsgdyig58"))))
+    (build-system emacs-build-system)
+    (home-page "https://jblevins.org/projects/deft/")
+    (synopsis
+     "Quickly browse, filter, and edit plain text notes")
+    (description
+     "Deft is an Emacs mode for quickly browsing, filtering, and editing
+directories of plain text notes, inspired by Notational Velocity.")
+    (license license:gpl3+)))
-- 
2.16.2