GNU bug report logs - #30797
[PATCH 1/2] gnu: Add emacs-exec-path-from-shell

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30797 in the body.
You can then email your comments to 30797 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Konrad Hinsen <konrad.hinsen <at> fastmail.net>
To: guix-patches <at> gnu.org
Subject: [PATCH 1/2] gnu: Add emacs-exec-path-from-shell
Date: Tue, 13 Mar 2018 16:47:01 +0100

* gnu/packages/emacs.scm (emacs-exec-path-from-shell): New variable.
---
 gnu/packages/emacs.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index c2c162c75..9c9c399fd 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -7361,3 +7361,31 @@ highlighting and indentation support.")
 @uref{https://www.terraform.io/, Terraform} configuration files.  Most of the
 functionality is inherited from @code{hcl-mode}.")
     (license license:gpl3+)))
+
+(define-public emacs-exec-path-from-shell
+  (package
+    (name "emacs-exec-path-from-shell")
+    (version "1.11")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "http://stable.melpa.org/packages/exec-path-from-shell-"
+             version
+             ".el"))
+       (sha256
+        (base32
+         "03qjgb81cq1l3j54lvlf98r75vmmgd06mj6qh5wa6mz4xzp4w26r"))))
+    (build-system emacs-build-system)
+    (home-page
+     "https://github.com/purcell/exec-path-from-shell")
+    (synopsis
+     "Get environment variables such as $PATH from the shell")
+    (description
+     "This library allows the user to set Emacs' @code{exec-path} and @code{$PATH}
+from the shell path, so that @code{shell-command}, @code{compile} and the
+like work as expected on systems on which Emacs is not guaranteed
+to inherit a login shell's environment variables.  It also allows other
+environment variables to be retrieved from the shell, so that Emacs will
+see the same values you get in a terminal.")
+    (license license:gpl3+)))
-- 
2.16.2

Message #8 received at 30797 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Konrad Hinsen <konrad.hinsen <at> fastmail.net>
Cc: 30797 <at> debbugs.gnu.org
Subject: Re: [bug#30797] [PATCH 1/2] gnu: Add emacs-exec-path-from-shell
Date: Thu, 15 Mar 2018 11:50:53 +0300

[Message part 1 (text/plain, inline)]

Hello Konrad,

Konrad Hinsen <konrad.hinsen <at> fastmail.net> writes:

> * gnu/packages/emacs.scm (emacs-exec-path-from-shell): New variable.
> ---
>  gnu/packages/emacs.scm | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index c2c162c75..9c9c399fd 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -7361,3 +7361,31 @@ highlighting and indentation support.")
>  @uref{https://www.terraform.io/, Terraform} configuration files.  Most of the
>  functionality is inherited from @code{hcl-mode}.")
>      (license license:gpl3+)))
> +
> +(define-public emacs-exec-path-from-shell
> +  (package
> +    (name "emacs-exec-path-from-shell")
> +    (version "1.11")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "http://stable.melpa.org/packages/exec-path-from-shell-"
> +             version
> +             ".el"))

Same as in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=30798#8

    Unfortunately, we can't use sources from MELPA.  The problem is:
    when a repository get a new commit, the old tarball is *REPLACED*
    with the new one on MELPA, so the package could never be built
    anymore, since the source disappeared.  That's why we use tarballs
    directly from source.

    BTW, to make a recipe more polished you could remove unnecessary new
    lines, for example:

           (uri (string-append "http://stable.melpa.org/packages/deft-"
                 version ".el"))

> +       (sha256
> +        (base32
> +         "03qjgb81cq1l3j54lvlf98r75vmmgd06mj6qh5wa6mz4xzp4w26r"))))
> +    (build-system emacs-build-system)
> +    (home-page
> +     "https://github.com/purcell/exec-path-from-shell")
> +    (synopsis 
> +     "Get environment variables such as $PATH from the shell")

Likewise (new line).

> +    (description
> +     "This library allows the user to set Emacs' @code{exec-path} and @code{$PATH}
                                                  ^
                                                  unnecessary apostrophe?

Also this line is too long (more than 80 symbols).

> +from the shell path, so that @code{shell-command}, @code{compile} and the
> +like work as expected on systems on which Emacs is not guaranteed
> +to inherit a login shell's environment variables.  It also allows other
> +environment variables to be retrieved from the shell, so that Emacs will
> +see the same values you get in a terminal.")
> +    (license license:gpl3+)))

Otherwise LGTM.

Thanks,
Oleg.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 30797 <at> debbugs.gnu.org (full text, mbox):

From: Konrad Hinsen <konrad.hinsen <at> fastmail.net>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 30797 <at> debbugs.gnu.org
Subject: Re: [bug#30797] [PATCH 1/2] gnu: Add emacs-exec-path-from-shell
Date: Fri, 16 Mar 2018 13:11:09 +0100

* gnu/packages/emacs.scm (emacs-exec-path-from-shell): New variable.
---
 gnu/packages/emacs.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index c2c162c75..35acfdd20 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -7361,3 +7361,28 @@ highlighting and indentation support.")
 @uref{https://www.terraform.io/, Terraform} configuration files.  Most of the
 functionality is inherited from @code{hcl-mode}.")
     (license license:gpl3+)))
+
+(define-public emacs-exec-path-from-shell
+  (package
+    (name "emacs-exec-path-from-shell")
+    (version "1.11")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://stable.melpa.org/packages/exec-path-from-shell-"
+             version ".el"))
+       (sha256
+        (base32
+         "03qjgb81cq1l3j54lvlf98r75vmmgd06mj6qh5wa6mz4xzp4w26r"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/purcell/exec-path-from-shell")
+    (synopsis "Get environment variables such as $PATH from the shell")
+    (description
+     "This library allows the user to set Emacs' @code{exec-path} and
+@code{$PATH} from the shell path, so that @code{shell-command}, @code{compile}
+and the like work as expected on systems on which Emacs is not guaranteed to
+inherit a login shell's environment variables.  It also allows other
+environment variables to be retrieved from the shell, so that Emacs will see
+the same values you get in a terminal.")
+    (license license:gpl3+)))
-- 
2.16.2

Message #14 received at 30797 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Konrad Hinsen <konrad.hinsen <at> fastmail.net>
Cc: 30797-done <at> debbugs.gnu.org, 30797 <at> debbugs.gnu.org
Subject: Re: [bug#30797] [PATCH 1/2] gnu: Add emacs-exec-path-from-shell
Date: Fri, 16 Mar 2018 17:13:45 +0300

[Message part 1 (text/plain, inline)]

Hello Konrad,

Konrad Hinsen <konrad.hinsen <at> fastmail.net> writes:

> * gnu/packages/emacs.scm (emacs-exec-path-from-shell): New variable.
> ---
>  gnu/packages/emacs.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index c2c162c75..35acfdd20 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -7361,3 +7361,28 @@ highlighting and indentation support.")
>  @uref{https://www.terraform.io/, Terraform} configuration files.  Most of the
>  functionality is inherited from @code{hcl-mode}.")
>      (license license:gpl3+)))
> +

[…]

> +    (description
> +     "This library allows the user to set Emacs' @code{exec-path} and

I still think this apostrophe is unnecessary.  I removed it if you don't
mind.  ;-)

-     "This library allows the user to set Emacs' @code{exec-path} and
+     "This library allows the user to set Emacs @code{exec-path} and

[…]


In addition, according to Bash documentation [1] variables don't have
‘$’ in their description.

-    (synopsis "Get environment variables such as $PATH from the shell")
+    (synopsis "Get environment variables such as @var{PATH} from the shell")

- [1]  https://www.gnu.org/software/bash/manual/html_node/Bash-Variables.html


And in the description, we could use ‘@var’ instead of ‘@code’:

-This library allows the user to set Emacs @code{exec-path} and
+This library allows the user to set Emacs @var{exec-path} and

-@code{$PATH} from the shell path, so that @code{shell-command},
+@var{PATH} from the shell @var{PATH}, so that @code{shell-command},


Also don't forget a dot at end the in commit message.

    gnu: Add emacs-exec-path-from-shell.


Pushed with changes above as 22d628148ce857b620f5b8e48dc7cabe004313c5

I'll close the bug report.

Thanks,
Oleg.

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 30797 <at> debbugs.gnu.org (full text, mbox):

From: Konrad Hinsen <konrad.hinsen <at> fastmail.net>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 30797-done <at> debbugs.gnu.org, 30797 <at> debbugs.gnu.org
Subject: Re: [bug#30797] [PATCH 1/2] gnu: Add emacs-exec-path-from-shell
Date: Fri, 16 Mar 2018 15:42:03 +0100

Hi Oleg,

>> +     "This library allows the user to set Emacs' @code{exec-path} and
>
> I still think this apostrophe is unnecessary.  I removed it if you don't
> mind.  ;-)

Well, I don't mind, but according to rules of English grammar, it's
either "Emacs'" or "Emacs's'" but not simply "Emacs". See for example:

   http://www.grammar.cl/rules/genitive-case.htm

   4. Singular noun ending in –s:

   It depends…
   a. Most names: add 's (apostrophe S)

   * They had a really good time at James’s barbecue last Friday. 
   * We spent the day admiring Frances’s new car. 

   b. Classical or religious names: add ' (only the apostrophe)

   * Jesus’ disciples carried out the teachings of Jesus. 
   * Sophocles’ plays are still performed today. 


> And in the description, we could use ‘@var’ instead of ‘@code’:
>
> -This library allows the user to set Emacs @code{exec-path} and
> +This library allows the user to set Emacs @var{exec-path} and

I actually hesitated in this case, after consulting the Texinfo manual:

   7.1.7 @var{metasyntactic-variable}

   Use the @var command to indicate metasyntactic variables. A
   metasyntactic variable is something that stands for another piece of
   text. For example, you should use a metasyntactic variable in the
   documentation of a function to describe the arguments that are passed
   to that function.

   Do not use @var for the names of normal variables in computer
   programs. These are specific names, so @code is correct for them
   (@code). For example, the Emacs Lisp variable texinfo-tex-command is
   not a metasyntactic variable; it is properly formatted using @code.

I must confess I don't understand the difference between a metasyntactic
variable and a normal variable. The examples don't help: for me, a
function argument is just a pre-initialized "normal" variable.

> Pushed with changes above as 22d628148ce857b620f5b8e48dc7cabe004313c5
>
> I'll close the bug report.

Great, thanks!

Konrad.

Message #28 received at 30797 <at> debbugs.gnu.org (full text, mbox):

From: Clément Lassieur <clement <at> lassieur.org>
To: Konrad Hinsen <konrad.hinsen <at> fastmail.net>
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>, 30797 <at> debbugs.gnu.org,
 30797-done <at> debbugs.gnu.org
Subject: Re: [bug#30797] [PATCH 1/2] gnu: Add emacs-exec-path-from-shell
Date: Fri, 16 Mar 2018 16:05:05 +0100

Konrad Hinsen <konrad.hinsen <at> fastmail.net> writes:

> Hi Oleg,
>
>>> +     "This library allows the user to set Emacs' @code{exec-path} and
>>
>> I still think this apostrophe is unnecessary.  I removed it if you don't
>> mind.  ;-)
>
> Well, I don't mind, but according to rules of English grammar, it's
> either "Emacs'" or "Emacs's'" but not simply "Emacs". See for example:
>
>    http://www.grammar.cl/rules/genitive-case.htm
>
>    4. Singular noun ending in –s:
>
>    It depends…
>    a. Most names: add 's (apostrophe S)
>
>    * They had a really good time at James’s barbecue last Friday. 
>    * We spent the day admiring Frances’s new car. 
>
>    b. Classical or religious names: add ' (only the apostrophe)
>
>    * Jesus’ disciples carried out the teachings of Jesus. 
>    * Sophocles’ plays are still performed today. 

This has been discussed there:
https://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00649.html.

:-)

Message #34 received at 30797 <at> debbugs.gnu.org (full text, mbox):

From: Konrad Hinsen <konrad.hinsen <at> fastmail.net>
To: Clément Lassieur <clement <at> lassieur.org>
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>, 30797 <at> debbugs.gnu.org,
 30797-done <at> debbugs.gnu.org
Subject: Re: [bug#30797] [PATCH 1/2] gnu: Add emacs-exec-path-from-shell
Date: Fri, 16 Mar 2018 16:28:53 +0100

Clément Lassieur <clement <at> lassieur.org> writes:

> This has been discussed there:
> https://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00649.html.
>
> :-)

Well, then... I don't expect anything else than a proclamation by Richard
Stallman can settle the question ;-)

Konrad.

Message #40 received at 30797 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Konrad Hinsen <konrad.hinsen <at> fastmail.net>
Cc: 30797 <at> debbugs.gnu.org
Subject: Re: [bug#30797] [PATCH 1/2] gnu: Add emacs-exec-path-from-shell
Date: Fri, 16 Mar 2018 19:16:06 +0300

[Message part 1 (text/plain, inline)]

Konrad Hinsen <konrad.hinsen <at> fastmail.net> writes:

[…]

>> And in the description, we could use ‘@var’ instead of ‘@code’:
>>
>> -This library allows the user to set Emacs @code{exec-path} and
>> +This library allows the user to set Emacs @var{exec-path} and
>
> I actually hesitated in this case, after consulting the Texinfo manual:
>
>    7.1.7 @var{metasyntactic-variable}
>
>    Use the @var command to indicate metasyntactic variables. A
>    metasyntactic variable is something that stands for another piece of
>    text. For example, you should use a metasyntactic variable in the
>    documentation of a function to describe the arguments that are passed
>    to that function.
>
>    Do not use @var for the names of normal variables in computer
>    programs. These are specific names, so @code is correct for them
>    (@code). For example, the Emacs Lisp variable texinfo-tex-command is
>    not a metasyntactic variable; it is properly formatted using @code.
>
> I must confess I don't understand the difference between a metasyntactic
> variable and a normal variable. The examples don't help: for me, a
> function argument is just a pre-initialized "normal" variable.

From Emacs source code in ‘doc/lispref/files.texi’:

    Typical values for @var{path} are @code{exec-path}
    (@pxref{Subprocess Creation}) when looking for executable programs,
    or @code{load-path} (@pxref{Library Search}) when looking for Lisp
    files.  If @var{filename} is absolute, @var{path} has no effect, but
    the suffixes in @var{suffixes} are still tried.


A proper piece of sentence according to a quote above I could think of:

   This library allows the user to set Emacs @code{exec-path} and
   @var{path} from the shell @env{PATH}

WDYT?

Thanks,
Oleg.

[signature.asc (application/pgp-signature, inline)]

Message #43 received at 30797 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Konrad Hinsen <konrad.hinsen <at> fastmail.net>
Cc: 30797-done <at> debbugs.gnu.org,
 Clément Lassieur <clement <at> lassieur.org>,
 30797 <at> debbugs.gnu.org
Subject: Re: [bug#30797] [PATCH 1/2] gnu: Add emacs-exec-path-from-shell
Date: Fri, 16 Mar 2018 19:16:30 +0300

[Message part 1 (text/plain, inline)]

Konrad Hinsen <konrad.hinsen <at> fastmail.net> writes:

> Clément Lassieur <clement <at> lassieur.org> writes:
>
>> This has been discussed there:
>> https://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00649.html.
>>
>> :-)
>
> Well, then... I don't expect anything else than a proclamation by Richard
> Stallman can settle the question ;-)

Wolfgang

    On Thu, Feb 23 2012, Glenn Morris wrote:
    > A critical question. What is the standard form in GNU manuals for using
    > the possessive apostrophe with singular nouns ending in "s"?
    >
    >   This is one of Emacs's most important features.
    >
    > or
    >
    >   This is one of Emacs' most important features.

    Actually, [1] states that the latter form can be used only with
    /regular/ nouns ending in "s", but many people use the plural form
    "Emacsen", so, in current usage, "Emacs" is not a regular noun.

    [1] http://en.wikipedia.org/wiki/Saxon_genitive

RMS

    It's worse than that: "Emacs" is a plural form used as singular.
    "Emacs" originally stood for "Editing macros".


It's not clear to me what is the right form to use.


In Emacs source code repository:

$ ag -H --nobreak --nofilename "Emacs' @" | wc -l
=> 0

$ ag -H --nobreak --nofilename "Emacs's @" | wc -l
=> 9

$ ag -H --nobreak --nofilename "Emacs @" | wc -l
=> 68

So, I think we should stick to “Emacs” or “Emacs's”.

[Message part 2 (text/plain, attachment)]

[Message part 3 (text/plain, attachment)]

[Message part 4 (text/plain, inline)]

Oleg.

[signature.asc (application/pgp-signature, inline)]

Message #49 received at 30797 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: Konrad Hinsen <konrad.hinsen <at> fastmail.net>
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>, 30797 <at> debbugs.gnu.org,
 30797-done <at> debbugs.gnu.org
Subject: Re: [bug#30797] [PATCH 1/2] gnu: Add emacs-exec-path-from-shell
Date: Sat, 17 Mar 2018 12:46:46 +0100

Hello,

an interesting bike shedding discussion!

On Fri, Mar 16, 2018 at 03:42:03PM +0100, Konrad Hinsen wrote:
> >> +     "This library allows the user to set Emacs' @code{exec-path} and

How about using the genitive with "of", "to set the @code{exec-path} of Emacs"?
I thought that "'s" was only used for people.

Or circumvent the question altogether by using a compound noun?
"to set the Emacs @code{exec-path}".

Andreas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.