Subject: Re: [bug#30771] [PATCH] gnu: Add kdenlive.

From: [email-masked] (Ludovic Courtès)
Date: Sat, 29 Sep 2018 23:52:39 +0200

Hello Gábor!

Gábor Boskovits <[email-masked]> skribis:

> From: Mark Meyer <[email-masked]>
>
> * gnu/packages/kde.scm (kdenlive): New variable.
>
> Co-authored-by: Gábor Boskovits <[email-masked]>
> Signed-off-by: Gábor Boskovits <[email-masked]>

[...]

> +           (add-after 'install 'wrap-executable
> +             (lambda* (#:key inputs outputs #:allow-other-keys)
> +               (let* ((out (assoc-ref outputs "out"))
> +                      (qtquickcontrols (assoc-ref inputs "qtquickcontrols"))
> +                      (qtbase (assoc-ref inputs "qtbase"))
> +                      (qtdeclarative (assoc-ref inputs "qtdeclarative"))
> +                      (frei0r (assoc-ref inputs "frei0r-plugins"))
> +                      (qml "/lib/qt5/qml"))
> +                 (wrap-program (string-append out "/bin/kdenlive")
> +                   `("QT_PLUGIN_PATH" ":" prefix
> +                     ,(map (lambda (label)
> +                             (string-append (assoc-ref inputs label)
> +                                            "/lib/qt5/plugins/"))
> +                           '("qtbase", "qtsvg")))
> +                   `("FREI0R_PATH" ":" =
> +                     (,(string-append frei0r "/lib/frei0r-1/")))
> +                   `("QT_QPA_PLATFORM_PLUGIN_PATH" ":" =
> +                     (,(string-append qtbase "/lib/qt5/plugins/platforms")))
> +                   `("QML2_IMPORT_PATH" ":" prefix
> +                     (,(string-append qtquickcontrols qml)
> +                      ,(string-append qtdeclarative qml))))))))))

Please explicitly return #t.

Apart from this very minor issue, it LGTM.  Thank you!

Ludo’.