GNU bug report logs - #30765
[PATCH] gnu: qtox: Propagate qtsvg and fix misplaced comma (unquote).

Previous Next

Package: guix-patches;

Reported by: Diego Nicola Barbato <dnbarbato <at> posteo.de>

Date: Sat, 10 Mar 2018 22:12:02 UTC

Severity: normal

Tags: patch

Done: ludo <at> gnu.org (Ludovic Courtès)

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: ludo <at> gnu.org (Ludovic Courtès)
To: Diego Nicola Barbato <dnbarbato <at> posteo.de>
Cc: 30765 <at> debbugs.gnu.org
Subject: [bug#30765] [PATCH] gnu: qtox: Propagate qtsvg and fix misplaced comma (unquote).
Date: Mon, 12 Mar 2018 15:42:32 +0100

Hello Diego,

Diego Nicola Barbato <dnbarbato <at> posteo.de> skribis:

> This patch fixes an issue where qTox failed to display some icons by
> moving qtsvg to propagated-inputs.
> I also took the liberty of fixing a misplaced comma (unquote).

The patch LGTM, but can you explain why propagating qtsvg allows icons
to be displayed?

In general we try to avoid propagated inputs because they “pollute” the
user’s profile, so we should make sure there’s no other solution and add
a comment explaining why we do that.

Thanks!

Ludo’.
This bug report was last modified 7 years and 74 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.