GNU bug report logs - #30765
[PATCH] gnu: qtox: Propagate qtsvg and fix misplaced comma (unquote).

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Diego Nicola Barbato <dnbarbato <at> posteo.de>
Subject: bug#30765: closed (Re: [bug#30765] [PATCH] gnu: qtox: Propagate
 qtsvg and fix misplaced comma (unquote).)
Date: Thu, 15 Mar 2018 21:19:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#30765: [PATCH] gnu: qtox: Propagate qtsvg and fix misplaced comma (unquote).

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 30765 <at> debbugs.gnu.org.

-- 
30765: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=30765
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: ludo <at> gnu.org (Ludovic Courtès)
To: Diego Nicola Barbato <dnbarbato <at> posteo.de>
Cc: Marius Bakke <mbakke <at> fastmail.com>, 30765-done <at> debbugs.gnu.org
Subject: Re: [bug#30765] [PATCH] gnu: qtox: Propagate qtsvg and fix misplaced
 comma (unquote).
Date: Thu, 15 Mar 2018 22:18:14 +0100

Diego Nicola Barbato <dnbarbato <at> posteo.de> skribis:

>>From 17c78d051b723b3fb9cabec724a32d151b00be68 Mon Sep 17 00:00:00 2001
> From: Diego Nicola Barbato <dnbarbato <at> posteo.de>
> Date: Thu, 15 Mar 2018 02:19:51 +0100
> Subject: [PATCH] gnu: qtox: Wrap executable and fix misplaced comma (unquote).
>
> * gnu/packages/messaging.scm (qtox)[arguments]: Add phase
> "wrap-executable".
> [inputs]: Fix misplaced comma (unquote).

Perfect.  Applied, thanks!

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Diego Nicola Barbato <dnbarbato <at> posteo.de>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: qtox: Propagate qtsvg and fix misplaced comma (unquote).
Date: Sat, 10 Mar 2018 23:10:42 +0100

[Message part 4 (text/plain, inline)]

This patch fixes an issue where qTox failed to display some icons by
moving qtsvg to propagated-inputs.
I also took the liberty of fixing a misplaced comma (unquote).

[0001-gnu-qtox-Propagate-qtsvg-and-fix-misplaced-comma-unq.patch (text/x-patch, inline)]

From 016bd5e32c3f3aa44468b324e8c652ff44b3c1a1 Mon Sep 17 00:00:00 2001
From: Diego Nicola Barbato <dnbarbato <at> posteo.de>
Date: Sat, 10 Mar 2018 22:09:12 +0100
Subject: [PATCH] gnu: qtox: Propagate qtsvg and fix misplaced comma (unquote).

* gnu/packages/messaging.scm (qtox)[inputs]: Move qtsvg to
propagated-inputs.
[inputs]: Fix misplaced comma (unquote).
---
 gnu/packages/messaging.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index b6323c39b..51be46d5c 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -875,9 +875,11 @@ instant messenger with audio and video chat capabilities.")
                (("__TIME__") "\"\"")
                (("TIMESTAMP") "\"\""))
              #t)))))
+    (propagated-inputs
+     `(("qtsvg" ,qtsvg)))
     (inputs
      `(("ffmpeg" ,ffmpeg)
-       ("filteraudio", filteraudio)
+       ("filteraudio" ,filteraudio)
        ("glib" ,glib)
        ("gtk+" ,gtk+-2)
        ("libsodium" ,libsodium)
@@ -890,7 +892,6 @@ instant messenger with audio and video chat capabilities.")
        ("openal" ,openal)
        ("qrencode" ,qrencode)
        ("qtbase" ,qtbase)
-       ("qtsvg" ,qtsvg)
        ("sqlcipher" ,sqlcipher)))
     (native-inputs
      `(("pkg-config" ,pkg-config)
-- 
2.16.2

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.