GNU bug report logs - #30748
[PATCH] gnu: Add nsd.

Previous Next

Full log

Message #8 received at 30748 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>, 30748 <at> debbugs.gnu.org
Subject: Re: [bug#30748] [PATCH] gnu: Add nsd.
Date: Sat, 10 Mar 2018 10:18:00 +0100

[Message part 1 (text/plain, inline)]

Tobias Geerinckx-Rice <me <at> tobias.gr> writes:

> * gnu/packages/dns.scm (nsd): New public variable.

[...]

> +         (add-before 'configure 'patch-installation-paths
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let* ((out (assoc-ref outputs "out"))
> +                    (doc (string-append out "/share/doc/" ,name "-" ,version)))
> +               (substitute* "Makefile.in"
> +                 (((string-append ".*\\$\\(DESTDIR\\)\\$\\("
> +                                  "(config|pid|xfr|db)dir"
> +                                  "\\).*"))
> +                  "")

Can you add a comment about what's going on here?  Would setting
DESTDIR=(assoc-ref %outputs "out") in #:make-flags suffice?

Apart from that LGTM.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.