GNU bug report logs - #30746
window-text-pixel-width includes width of following propertized space

Previous Next

Package: emacs;

Reported by: Clément Pit-Claudel <clement.pitclaudel <at> live.com>

Date: Wed, 7 Mar 2018 22:14:01 UTC

Severity: normal

Fixed in version 26.1

Done: Stefan Kangas <stefan <at> marxist.se>

Bug is archived. No further changes may be made.

Full log


Message #24 received at control <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Clément Pit-Claudel <clement.pitclaudel <at> live.com>
Cc: 30746 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#30746: window-text-pixel-width includes width of following
 propertized space
Date: Sat, 28 Sep 2019 23:51:04 +0200
fixed 30746 26.1
close 30746
quit

Clément Pit-Claudel <clement.pitclaudel <at> live.com> writes:

> On 2018-03-16 12:13, Eli Zaretskii wrote:
>>> Cc: 30746 <at> debbugs.gnu.org
>>> From: Clément Pit-Claudel <clement.pitclaudel <at> live.com>
>>> Date: Fri, 16 Mar 2018 10:09:40 -0400
>>>
>>> Thanks a lot; the width is indeed fixed.  However, the fix seems to have broken the height calculation: the first snippet above now returns (8 . 0), whereas the second one returns (8 . 16).
>>
>> Fixed.
>
> Works perfectly. Thanks a lot.

This was fixed by:

commit c4db7662bb4740f069e494cfe632c76a0d21d6d7
Author: Eli Zaretskii <eliz <at> gnu.org>
Date:   Fri Mar 16 18:11:07 2018 +0200

    Another followup to fixing 'window-text-pixel-width'

    * src/xdisp.c (Fwindow_text_pixel_size): Adjust the return value
    when we stop one buffer position short of TO.  (Bug#30746)

And:

commit f1f12d8be3ddc5aa0a79658f5b339c78742321fa
Author: Eli Zaretskii <eliz <at> gnu.org>
Date:   Thu Mar 8 15:32:23 2018 +0200

    Fix 'window-text-pixel-size' when display properties are around

    * src/xdisp.c (Fwindow_text_pixel_size): Correct the result when
    there's a display property at the  TO position, and the call to
    move_it_to overshoots.  (Bug#30746)

I'm therefore closing this bug report.

Best regards,
Stefan Kangas




This bug report was last modified 5 years and 232 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.