GNU bug report logs - #30744
[PATCH 1/2] services: dovecot: Copy dovecot.conf to /etc/dovecot.

Previous Next

Full log

View this message in rfc822 format

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Clément Lassieur <clement <at> lassieur.org>
Cc: 30744 <at> debbugs.gnu.org
Subject: [bug#30744] [PATCH] tests: mail: Add test for dovecot.
Date: Fri, 09 Mar 2018 12:31:38 +0300

[Message part 1 (text/plain, inline)]

Hello Clément,

Clément Lassieur <clement <at> lassieur.org> writes:

> Oleg Pykhalov <go.wigust <at> gmail.com> writes:

[…]

>> +          ;; Give the service time to start talking.
>> +          (wait-for-file "/var/run/dovecot/master.pid" marionette)
>
> Could you put it in a test context (test-assert with file-exists? for
> example, see tests/messaging.scm)?

OK.

I replaced ‘(wait-for-file …)’ and a comment with:
--8<---------------cut here---------------start------------->8---
;; Check Dovecot service's PID.
(test-assert "service process id"
  (let ((pid
         (number->string (wait-for-file "/var/run/dovecot/master.pid"
                                        marionette))))
    (marionette-eval `(file-exists? (string-append "/proc/" ,pid))
                     marionette)))
--8<---------------cut here---------------end--------------->8---

[…]

>> +                  (match (scandir TESTBOX/new)
>> +                    ((cwd .. message-file)
>
> You need to use double quotes, like ("." ".." message-file) I believe.

It works.  Thank you!

[…]

I think it's ready for a push to ‘origin/master’.  WDYT?

Oleg.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.