GNU bug report logs - #30738
Invalid timezone (tzalloc failure) treated as out-of-memory

Previous Next

Full log

View this message in rfc822 format

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Valery Ushakov <uwe <at> stderr.spb.ru>
Cc: 30738 <at> debbugs.gnu.org
Subject: bug#30738: Invalid timezone (tzalloc failure) treated as out-of-memory
Date: Mon, 19 Mar 2018 16:55:25 -0700

[Message part 1 (text/plain, inline)]

On 03/19/2018 09:29 AM, Valery Ushakov wrote:
> special casing 0 is still a good idea as it saves a call to
> tzalloc().

Fair enough; I installed the first attached patch.


> this patch also needs to #include <sys/param.h>
> where __NetBSD_Version__ is defined.

Thanks, I installed the second attached patch to do that.


> tzbuf_format can
> probably drop that artisanal &"-"[...] and its corresponding %s, and
> just pass -hour instead.

That would mishandle time zones like -00:30:00 (i.e., 30 minutes behind 
UTC). That is, the sign is a property of the minutes and the seconds 
too, not just the hours.

[0001-Tune-time-zone-0.patch (text/x-patch, attachment)]

[0001-Improve-port-to-NetBSD-tzalloc.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.