From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 06 14:26:15 2018 Received: (at submit) by debbugs.gnu.org; 6 Mar 2018 19:26:15 +0000 Received: from localhost ([127.0.0.1]:48026 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1etIE3-0002Tw-2z for submit@debbugs.gnu.org; Tue, 06 Mar 2018 14:26:15 -0500 Received: from eggs.gnu.org ([208.118.235.92]:36527) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1etIE1-0002Ti-00 for submit@debbugs.gnu.org; Tue, 06 Mar 2018 14:26:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1etIDu-0001OE-FI for submit@debbugs.gnu.org; Tue, 06 Mar 2018 14:26:07 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:36576) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1etIDu-0001O3-C2 for submit@debbugs.gnu.org; Tue, 06 Mar 2018 14:26:06 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55709) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etIDs-00076m-NP for bug-gnu-emacs@gnu.org; Tue, 06 Mar 2018 14:26:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1etIDp-0001LB-Fa for bug-gnu-emacs@gnu.org; Tue, 06 Mar 2018 14:26:04 -0500 Received: from mail-wr0-x234.google.com ([2a00:1450:400c:c0c::234]:35622) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1etIDp-0001J8-5A for bug-gnu-emacs@gnu.org; Tue, 06 Mar 2018 14:26:01 -0500 Received: by mail-wr0-x234.google.com with SMTP id l43so22134267wrc.2 for ; Tue, 06 Mar 2018 11:26:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=message-id:subject:from:to:date:mime-version :content-transfer-encoding; bh=O2LwhUtYyFeJuot89xu0LGLXV8bJGen7dXU5aDztTEg=; b=kB8HS0UvJWhlf5IzVGJdPyFXvK/njyRpClG5gjQjLnRT0Wqb0Mj9ZpmcPKOGsI9FEg KStj38KbhLKGtKiy0DFMbi6Codrd8KKaaC/bM6XSjsmN2AqKgce/2rrbJvffZqlmEjss xrSiMjJ0cBGuqE6T39MxLJTnF0eA4Ex1Kb/fCo2IW725XO2DWmwHaj/NJ69+qU2OheaF jIlQ3MzvUcvlRNqfqF7ZcDamkEyqfgrcOpdCFfy0aDruOLvpzw+/INwA+1EiM1H4UFNX kOcb7hszWAFPHT6bCLXnC63gfHWLfwW3zvWVgeTtkg3aDBnN8Z8AP3Nh6YTcAGi9WZ00 2sXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:mime-version :content-transfer-encoding; bh=O2LwhUtYyFeJuot89xu0LGLXV8bJGen7dXU5aDztTEg=; b=OerYDGHnvsGB5kdQcZe8LES/PRcoCMm27D+8BUVUZr1Kj7FgBoSj0cpZrg3ndwpPkN HwEMXe91TzR87jQPpolPxZoH1m37f6HtNLar20KvVvqSJie+IMxHuXXn3cuhtLjbuUcn zccLhm6QCJCHocXoe3wJ1dSNADtm+kg0j2upDDnjqRzHeSIYBVVfPJPQBPEJHUh8aBFe NkSdBXKsGJULF9/3jL1YCoztq2Dwve5VEly7UjYn7b3bg08iNDgWe/tKeV0xWQWgqL+e mmeNOjhcy24eOtFYA9RQf1V1dd0YbLMXdFPW6Uv2JSL+wjUwxNCk15VBfrJbVCo0TPVW PAKA== X-Gm-Message-State: APf1xPDrWRb48lARqxGlUSeSnlYfubXvz937geSKMH+5Ro2LlbFONB0C Z/33dXGUifb71FcL95hBEXpAqOSD X-Google-Smtp-Source: AG47ELvMOkUInGXh+Gcyp1Q5Bzx7fjBkcP9sQYSYlktV1ok/PH4p9COiS9QBQs7eKScGb4BUijlGcA== X-Received: by 10.223.195.206 with SMTP id d14mr18302546wrg.0.1520364359352; Tue, 06 Mar 2018 11:25:59 -0800 (PST) Received: from laptop ([77.70.2.229]) by smtp.gmail.com with ESMTPSA id q11sm18166690wrb.74.2018.03.06.11.25.57 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 06 Mar 2018 11:25:58 -0800 (PST) Message-ID: <1520364356.10274.1.camel@googlemail.com> Subject: 25.3; slow comment c++-mode From: ngeiswei@googlemail.com To: bug-gnu-emacs@gnu.org Date: Tue, 06 Mar 2018 21:25:56 +0200 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.5 (3.26.5-1.fc27) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) 1. Open the following file (make sure you have write privilege) https://raw.githubusercontent.com/opencog/atomspace/master/tests/unify/ UnifyUTest.cxxtest 2. Enable c++-mode (M-x c++-mode) 3. Mark a large region of that file (say l.175 to the end) 4. Comment out that region (M-;) 5. Meditate in the church of Emacs for a few minutes If c++-mode is disabled (using fundamental-mode for instance) commenting that same region is instantaneous. After running some profiling it seems most of the CPU resources is spent in c-syntactic-skip-backward. The same slowness occurs with Emacs 25.1. I couldn't try older versions due to temacs Segfault compiling issue (unresolved by disabling randomize_va_space). In GNU Emacs 25.3.1 (x86_64-redhat-linux-gnu, GTK+ Version 3.22.19) of 2017-09-15 built on buildvm-31.phx2.fedoraproject.org Windowing system distributor 'Fedora Project', version 11.0.11906000 Configured using: 'configure --build=x86_64-redhat-linux-gnu --host=x86_64-redhat-linux-gnu --program-prefix= --disable-dependency-tracking --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc --datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib64 --libexecdir=/usr/libexec --localstatedir=/var --sharedstatedir=/var/lib --mandir=/usr/share/man --infodir=/usr/share/info --with-dbus --with-gif --with-jpeg --with- png --with-rsvg --with-tiff --with-xft --with-xpm --with-x-toolkit=gtk3 --with-gpm=no --with-xwidgets --with-modules build_alias=x86_64-redhat-linux-gnu host_alias=x86_64-redhat-linux-gnu 'CFLAGS=-DMAIL_USE_LOCKF -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic' LDFLAGS=-Wl,-z,relro PKG_CONFIG_PATH=:/usr/lib64/pkgconfig:/usr/share/pkgconfig' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND DBUS GCONF GSETTINGS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 MODULES XWIDGETS Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: C++/l Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t abbrev-mode: t Recent messages: Saved text until ", ts_expected)); } #undef al #undef an " Mark set [2 times] Saved text from "#include #inclu" Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message dired format-spec rfc822 mml mml-sec password-cache epg epg-config gnus-util mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util help-fns mail-prsvr mail-utils cl-extra help-mode cc-mode cc-fonts easymenu cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs cl-loaddefs pcase cl-lib time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa- hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting xwidget-internal move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 136237 5145) (symbols 48 21890 0) (miscs 40 56 157) (strings 32 19783 4769) (string-bytes 1 778551) (vectors 16 14190) (vector-slots 8 458261 5239) (floats 8 167 43) (intervals 56 9646 10) (buffers 976 18)) From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 06 15:01:34 2018 Received: (at 30735) by debbugs.gnu.org; 6 Mar 2018 20:01:34 +0000 Received: from localhost ([127.0.0.1]:48039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1etImE-0003IC-Ef for submit@debbugs.gnu.org; Tue, 06 Mar 2018 15:01:34 -0500 Received: from mail-wr0-f174.google.com ([209.85.128.174]:35416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1etImC-0003Hy-II for 30735@debbugs.gnu.org; Tue, 06 Mar 2018 15:01:33 -0500 Received: by mail-wr0-f174.google.com with SMTP id l43so22228897wrc.2 for <30735@debbugs.gnu.org>; Tue, 06 Mar 2018 12:01:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=from:to:message-id:date:user-agent:mime-version:content-language :content-transfer-encoding; bh=iBUkqmepNJYsON/Drz5MVW4RpkKcBS3ujGdrvJ3Atzs=; b=JNKXVzsNzZ2C6Sz0zo3r6CqZbPiwvS7hDM131LpYNd9DthzZ/QD2NSCEo+KzDf0kKq r2vRKKeX2VnhNCs8xJujMJcL34Na3MZ9lkPPBk2zVgb7lTwKESaMd/LLIY7llzQDF931 WLv2xnZLWvWO/E6rAQWNbySU5rFOToxl7f81jYaTrxCGUm7jrhED9iRIxW+EwVSJ2I41 yaJr+CFzkLRr0y8CbQWe0oLhgInyTz/UiIXRUK4tW4fivgzdA6CGBT7nfHmohB/P27EO UxVcZ0cTyaC/A62ATot486f0WoLznnYhKoWoYhI8TOdR732h9yY17VDPHMSobxgdtknK 1ICg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=iBUkqmepNJYsON/Drz5MVW4RpkKcBS3ujGdrvJ3Atzs=; b=EnokQ8XTbrCvEJKRo555N05ccEbrRVSUjenUwRG7fIKwPj69utVSXwv0Lef9oL9EIa wklBULrk1UY50uxaPyg4aqH5ib+uDYq4tv9pB3eYxQ77jDjLecTJ0NV1GYJ5Qrbfzk0u kJatPSyrKS5KzmyH/z1ad6dYnTNuDdxhv8orvTpkVNWBJrI86vns3hFe0jIauAlR/7zm FEFvOgoe4L8eoS6EoHYuHD6prj5YOS3MKc+uwQDomjXtWjNVE4BgCb+TO+krMvz3+RMw 0Fg/+v0g77A52IeRlWhjj8iYCHy+WoihqP+YnL3a1Upne1WoGTHL/tUEGn4wexKL2tkB jM7w== X-Gm-Message-State: APf1xPDK09CipUEgKp3td2veW5H89qxSG3mh4ePrwstE4EMYGBSSy8ue bxaL9Uz/Pxt4PGtjdywK7CePJGkH X-Google-Smtp-Source: AG47ELs8+xc6FxxKpw0QshVH8HsP0RGr6Z1FOs/fyHBjj81Jv4r8WyR1MhUnU/mh90d7aJ3rNzZJZg== X-Received: by 10.223.139.9 with SMTP id n9mr17923052wra.73.1520366485774; Tue, 06 Mar 2018 12:01:25 -0800 (PST) Received: from [192.168.1.101] ([77.70.2.229]) by smtp.gmail.com with ESMTPSA id 67sm9511964wmw.17.2018.03.06.12.01.24 for <30735@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Mar 2018 12:01:24 -0800 (PST) From: Nil Geisweiller X-Google-Original-From: Nil Geisweiller To: 30735@debbugs.gnu.org Message-ID: <27e9df1b-0e20-d456-14a5-7135368727ba@gmail.com> Date: Tue, 6 Mar 2018 22:01:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Important info: the slow down occurs in 24.4.1 but does not in 23.3.1 [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.174 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.128.174 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (ngeiswei[at]googlemail.com) 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject X-Debbugs-Envelope-To: 30735 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Important info: the slow down occurs in 24.4.1 but does not in 23.3.1 [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.174 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.128.174 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (ngeiswei[at]googlemail.com) 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject Important info: the slow down occurs in 24.4.1 but does not in 23.3.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 07 15:23:47 2018 Received: (at 30735) by debbugs.gnu.org; 7 Mar 2018 20:23:47 +0000 Received: from localhost ([127.0.0.1]:49857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1etfbG-0008N7-UF for submit@debbugs.gnu.org; Wed, 07 Mar 2018 15:23:47 -0500 Received: from mail-wr0-f171.google.com ([209.85.128.171]:37254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1etfbF-0008Ms-7w for 30735@debbugs.gnu.org; Wed, 07 Mar 2018 15:23:45 -0500 Received: by mail-wr0-f171.google.com with SMTP id z12so3480395wrg.4 for <30735@debbugs.gnu.org>; Wed, 07 Mar 2018 12:23:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=from:to:message-id:date:user-agent:mime-version:content-language :content-transfer-encoding; bh=e2fX7xuTyfD1DxXHHz9X5LaOQU6v6bE1HInlEnPQseQ=; b=Xgbznawd/F2pIi8PEhMrR6BAa/sMsuG6l6jBvCkLX38hlnY+d9h+2nIyj/0HKhPbKK cvB2ahlK+HeZOUD3rgLC0FUsiLXoE0rqc86PjBWokb5b/o7rKtnDvkUvPDYdiHuBw+Q0 QFTGYZJIpw3XfiRq+wnWylCPLHqsPxL8NVQaBEs+6DCDbidE+irDRSAK8I/Vil6Fvtm4 LDUtincZScuQ2JatVpE5IzU5sVP+bYmSUjDpHW0FY42plBlV5JIAsWlprz2K78f5Q1yL t8k1c484CXRdorTrAs28Y3EooQ5QgRGfXZFfuRsvhzqKRtx/ZMIpicrHYY2o4bUzRjil G0kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=e2fX7xuTyfD1DxXHHz9X5LaOQU6v6bE1HInlEnPQseQ=; b=owWikVXiwrr3RilRlPo2AyjPwaNW3Aqs22wp3BCm4F76iPYx32JIYrhILNWCwhpPRb 76nExX9qgyaXBKaAOSft2NN75P7W8SupenMgDfPGYSNasxt1qSj5xg0pB09zAVuYCyqV snTv/gF8+JhW1Y/bxYeEmyww93iBtSpDwC/F2RB3oxosqrX8h/XpqIzvxNg/yL2wjhpE cLZRVVSZmPyn+PCNmNgtCuVK5J++vzGhT+zLY1SuyO0fDG8NW3eq6nZWsjgR6CfiIPo2 IUfCyVCuJYAgYxtEF/6Pn2ThG2EO7l7xXaBztpNBLoGZslPwp6ubf/GYGYdAXMdNeLF0 H0zA== X-Gm-Message-State: APf1xPAHBsp7wfZ8mwYkrJkTmFVpgRBODBUmLFy7My3fbVUoWUqXvr8p O510zAGrOm0qYIFTb5Vy82CdID5X X-Google-Smtp-Source: AG47ELvJNEnT1H0uifTbUic2YhzgJtc8IDTgtCWdN2krqBOIJUfLzT3/ocoyrYtzFVk/0Id0HgTpWg== X-Received: by 10.223.186.66 with SMTP id t2mr22262893wrg.155.1520454219039; Wed, 07 Mar 2018 12:23:39 -0800 (PST) Received: from [192.168.1.101] ([77.70.2.229]) by smtp.gmail.com with ESMTPSA id 59sm16551807wro.57.2018.03.07.12.23.37 for <30735@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Mar 2018 12:23:37 -0800 (PST) From: Nil Geisweiller X-Google-Original-From: Nil Geisweiller To: 30735@debbugs.gnu.org Message-ID: <30aa6549-7548-e400-479e-c357c90553af@gmail.com> Date: Wed, 7 Mar 2018 22:23:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: In case it helps, I should mention that the slow down occurs in 24.3.1 as well. [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.128.171 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.171 listed in wl.mailspike.net] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (ngeiswei[at]googlemail.com) -0.0 SPF_PASS SPF: sender matches SPF record 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid X-Debbugs-Envelope-To: 30735 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: In case it helps, I should mention that the slow down occurs in 24.3.1 as well. [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.128.171 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.171 listed in wl.mailspike.net] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (ngeiswei[at]googlemail.com) -0.0 SPF_PASS SPF: sender matches SPF record 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid In case it helps, I should mention that the slow down occurs in 24.3.1 as well. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 11 09:01:43 2018 Received: (at 30735) by debbugs.gnu.org; 11 Mar 2018 13:01:43 +0000 Received: from localhost ([127.0.0.1]:54764 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ev0be-0006CD-W3 for submit@debbugs.gnu.org; Sun, 11 Mar 2018 09:01:43 -0400 Received: from colin.muc.de ([193.149.48.1]:32855 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1ev0bc-0006C1-8L for 30735@debbugs.gnu.org; Sun, 11 Mar 2018 09:01:41 -0400 Received: (qmail 17949 invoked by uid 3782); 11 Mar 2018 13:01:38 -0000 Date: 11 Mar 2018 13:01:38 -0000 Message-ID: <20180311130138.17948.qmail@mail.muc.de> From: Alan Mackenzie To: ngeiswei@googlemail.com Subject: Re: bug#30735: 25.3; slow comment c++-mode Organization: muc.de e.V. In-Reply-To: X-Newsgroups: gnu.emacs.bug User-Agent: tin/2.4.1-20161224 ("Daill") (UNIX) (FreeBSD/11.1-RELEASE-p4 (amd64)) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30735 Cc: 30735@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hello, Nil. In article you wrote: > 1. Open the following file (make sure you have write privilege) > https://raw.githubusercontent.com/opencog/atomspace/master/tests/unify/ > UnifyUTest.cxxtest > 2. Enable c++-mode (M-x c++-mode) > 3. Mark a large region of that file (say l.175 to the end) > 4. Comment out that region (M-;) > 5. Meditate in the church of Emacs for a few minutes > If c++-mode is disabled (using fundamental-mode for instance) > commenting that same region is instantaneous. After running some > profiling it seems most of the CPU resources is spent in > c-syntactic-skip-backward. Thanks for taking the trouble to report this bug. Commenting out 2300 lines in fundamental mode is going to be instantaneous. However, in C++ Mode, the mode has to check whether the syntax (i.e. whether in a string/comment, and particularly, whether any < or > characters are template delimiters) has changed, at any buffer modification. It also has to check whether any "starting position" of a (possibly nested) declaration or function has changed. This all takes time. However, it is taking too much time. The problem is in a routine which determines a backward search limit n non-literal characters back (where "literal" means string or comment). The lines being commented contain no such non-literals at all, so each backward limit was being determined to be n characters before line 175. Thus the time taken was quadratic with the size of the section to be commented out. I've amended the two critical parts of the code so that there is an absolute limit to how far back this backward search limit may be. The code is now significantly faster. The timings for commenting out those lines with the latest version of CC Mode running on the unreleased Emacs-26.0.91 are: o - (without patch) 622.9 seconds; o - (with patch) 40.3 seconds. 40 seconds may still feel too long, but we are talking about over 2000 lines. > The same slowness occurs with Emacs 25.1. I couldn't try older versions > due to temacs Segfault compiling issue (unresolved by disabling > randomize_va_space). I've adapted the patch to apply to Emacs 25.3. Would you please try applying it, recompiling the two changed files (which are in .../emacs/lisp/progmodes/) and let me know whether the result is satisfactory. (If you want any help applying the patch or byte compiling the lisp files, feel free to ask me by private mail.) > In GNU Emacs 25.3.1 (x86_64-redhat-linux-gnu, GTK+ Version 3.22.19) > of 2017-09-15 built on buildvm-31.phx2.fedoraproject.org Here's the patch: --- cc-engine.el~ 2018-03-11 10:11:17.488821748 +0000 +++ cc-engine.el 2018-03-11 09:59:50.592847587 +0000 @@ -4677,10 +4677,10 @@ (t 'c))) ; Assuming the range is valid. range)) -(defsubst c-determine-limit-get-base (start try-size) +(defsubst c-determine-limit-get-base (start try-size &optional abs-limit) ;; Get a "safe place" approximately TRY-SIZE characters before START. - ;; This doesn't preserve point. - (let* ((pos (max (- start try-size) (point-min))) + ;; This defsubst doesn't preserve point. + (let* ((pos (max (- start try-size) (point-min) (or abs-limit 0))) (base (c-state-semi-safe-place pos)) (s (save-restriction (widen) @@ -4688,18 +4688,18 @@ (cand (if (or (nth 4 s) (nth 3 s)) ; comment or string (nth 8 s) pos))) - (if (>= cand (point-min)) + (if (>= cand (max (point-min) (or abs-limit 0))) cand (parse-partial-sexp pos start nil nil s 'syntax-table) (point)))) -(defun c-determine-limit (how-far-back &optional start try-size) +(defun c-determine-limit (how-far-back &optional abs-limit start try-size) ;; Return a buffer position HOW-FAR-BACK non-literal characters from ;; START (default point). The starting position, either point or ;; START may not be in a comment or string. ;; - ;; The position found will not be before POINT-MIN and won't be in a - ;; literal. + ;; The position found will not be before POINT-MIN, won't be before + ;; ABS-LIMIT, and won't be in a literal. ;; ;; We start searching for the sought position TRY-SIZE (default ;; twice HOW-FAR-BACK) bytes back from START. @@ -4708,7 +4708,7 @@ (save-excursion (let* ((start (or start (point))) (try-size (or try-size (* 2 how-far-back))) - (base (c-determine-limit-get-base start try-size)) + (base (c-determine-limit-get-base start try-size abs-limit)) (pos base) (s (parse-partial-sexp pos pos)) ; null state. @@ -4760,10 +4760,11 @@ (+ (car elt) (- count how-far-back))) ((eq base (point-min)) (point-min)) - ((> base (- start try-size)) ; Can only happen if we hit point-min. - (car elt)) + ((> base (- start try-size)) ; Can only happen if we hit + ; point-min or ABS-LIMIT. + (or (car elt) base)) (t - (c-determine-limit (- how-far-back count) base try-size)))))) + (c-determine-limit (- how-far-back count) abs-limit base try-size)))))) (defun c-determine-+ve-limit (how-far &optional start-pos) ;; Return a buffer position about HOW-FAR non-literal characters forward @@ -5621,7 +5622,7 @@ ;; Locate the earliest < after the barrier before the changed region, ;; which isn't already marked as a paren. (goto-char (if beg-lit-limits (car beg-lit-limits) beg)) - (setq beg-limit (c-determine-limit 512)) + (setq beg-limit (c-determine-limit 512 (- (point) 1024))) ;; Remove the syntax-table/category properties from each pertinent <...> ;; pair. Firstly, the ones with the < before beg and > after beg.... --- cc-mode.el~ 2018-03-11 10:12:03.419820020 +0000 +++ cc-mode.el 2018-03-11 10:02:01.447842665 +0000 @@ -1195,7 +1195,7 @@ (goto-char (c-point 'bol new-pos)) (when lit-limits ; Comment or string. (goto-char (car lit-limits))) - (setq bod-lim (c-determine-limit 500)) + (setq bod-lim (c-determine-limit 500 (- (point) 1000))) (while ;; Go to a less nested declaration each time round this loop. -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 11 16:15:24 2018 Received: (at 30735) by debbugs.gnu.org; 11 Mar 2018 20:15:25 +0000 Received: from localhost ([127.0.0.1]:55712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ev7NM-0005XU-Oi for submit@debbugs.gnu.org; Sun, 11 Mar 2018 16:15:24 -0400 Received: from mail-wr0-f181.google.com ([209.85.128.181]:45783) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ev7NL-0005XH-43 for 30735@debbugs.gnu.org; Sun, 11 Mar 2018 16:15:23 -0400 Received: by mail-wr0-f181.google.com with SMTP id h2so6373749wre.12 for <30735@debbugs.gnu.org>; Sun, 11 Mar 2018 13:15:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=from:to:message-id:date:user-agent:mime-version:content-language :content-transfer-encoding; bh=GvovXR5T6Jh/VwSL5/CZz3wwj0efTPFu94YTkSyk1nY=; b=Ev3KNqJTvJ+ACsCQqjWU55r4gxVzoD7TR1pnkI9KO1TZlVy00LmL/QVUQexR7XmeNl F4KqJ0a5pYM9L1k8NKi3bTAO1arFI/4YYt27n+3RhPtQbu0iHtyUbDNcpXCBXjj+84JL XJyOgInX7KBqd7ERduOzjLOVccCGwVnx1O4OreyxcO7h3JuXAffoNG4WqRqxwAB9Te1g L7L3eDn0uSBGorQgv/897txhO45Jmow/a2czqbWAqtTVYsfURsOUN0xn7slnly0P41iZ yjnHIZslCHQH0jFUzRiyiITAr1EqlmFIEUNoCvCWgYrCxCPa4lTQ3Z/ZRpw0zTrCpJch IE0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=GvovXR5T6Jh/VwSL5/CZz3wwj0efTPFu94YTkSyk1nY=; b=FjdsxqUxSDVbsRBEyEEP4geB5ASDPfKrAX3gQXkCBIYhsbkJv2FhlM569jptCca1vD P95wyIc4r6fqBIwbcKTxj2tiRnHQu5puQC87NhM4/wsdTePWXWk0ccnwUKvfuQ1EtRf5 Z/pHR7RHevp+1bN6Y7DXRARO3lKF39dIrhL6wKQ1JNuFO8q2abumkpZkJirKk2Y71rSh N1EFyerqtT+52ONNJpDKAFYpeqBVu8TJJIO8ei/gkWd01yUKf74p0R6ay4IXy3a9Po7U iqTIGH2FXpvBXfeUeoB7PzjaN7JWl4t2MZwxKHBIRQAt6t9jqervPX/rhY57ljHtAYyJ 4tzQ== X-Gm-Message-State: AElRT7GDDr78Fkv2IeW2UoZhEli9H8yG67ZuS/AQvxQhBiHjCpeZ78PP TaJGDlmcXj1NUV2rVM81AwoJCOSW X-Google-Smtp-Source: AG47ELvomRWj6OpOfxRPqQKjgkWfg4XZuv3UBCuqiA1aSMZ/j1OVaaCjpgn2U7viQy1L3fuevCBc1A== X-Received: by 10.223.201.11 with SMTP id m11mr4741359wrh.146.1520799317162; Sun, 11 Mar 2018 13:15:17 -0700 (PDT) Received: from [192.168.1.103] ([77.70.2.229]) by smtp.gmail.com with ESMTPSA id p12sm5091047wre.89.2018.03.11.13.15.16 for <30735@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 11 Mar 2018 13:15:16 -0700 (PDT) From: Nil Geisweiller X-Google-Original-From: Nil Geisweiller To: 30735@debbugs.gnu.org Message-ID: Date: Sun, 11 Mar 2018 22:15:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Thank you soooooooo much for taking the trouble to fix it! I tried myself but I'm very far behind. Unfortunately, I couldn't apply the patch completely because I couldn't get my hand on the source code of 25.3.1, only 25.3. I did patch as far as possible, the result is that it comments out really fast but the syntax highlighting is wrong for the last few lines. [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.128.181 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (ngeiswei[at]googlemail.com) -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.181 listed in wl.mailspike.net] 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid X-Debbugs-Envelope-To: 30735 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Thank you soooooooo much for taking the trouble to fix it! I tried myself but I'm very far behind. Unfortunately, I couldn't apply the patch completely because I couldn't get my hand on the source code of 25.3.1, only 25.3. I did patch as far as possible, the result is that it comments out really fast but the syntax highlighting is wrong for the last few lines. [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.128.181 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.181 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (ngeiswei[at]googlemail.com) 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid Thank you soooooooo much for taking the trouble to fix it! I tried myself but I'm very far behind. Unfortunately, I couldn't apply the patch completely because I couldn't get my hand on the source code of 25.3.1, only 25.3. I did patch as far as possible, the result is that it comments out really fast but the syntax highlighting is wrong for the last few lines. So I'm sorry I can't give you feedback to test your fix on 25.3.1. That is said, I'm perfectly happy if you directly push your fix on the master, I'll use HEAD instead of 25.3.1. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 13 11:39:24 2018 Received: (at 30735) by debbugs.gnu.org; 13 Mar 2018 15:39:25 +0000 Received: from localhost ([127.0.0.1]:59703 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1evm1M-00056D-Oh for submit@debbugs.gnu.org; Tue, 13 Mar 2018 11:39:24 -0400 Received: from mail-oi0-f53.google.com ([209.85.218.53]:33132) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1evm1K-00055x-TV for 30735@debbugs.gnu.org; Tue, 13 Mar 2018 11:39:23 -0400 Received: by mail-oi0-f53.google.com with SMTP id e9so45073oii.0 for <30735@debbugs.gnu.org>; Tue, 13 Mar 2018 08:39:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=bH+pyHZRsQw/6uqVGJycw1sL0LJ2rNU0JjQm21rkDJU=; b=kv4US7AggrAJewCgLW9k1epd0SExPcHpGvp14Z3nK4JFc8GELP8/RbLMmP5opxzCZs vKbUMYEJno8hvLknAOeMYZvSQ8hw5lPk/tam6C3zOReFzX1+GPXutPJs7dkmkVo99e6/ p0qXzLxZvpPnUZjegMTw+ivwi8rCDH7+gM7fHHx+WLdvHcdJfgzTAAVgpdbWIBLQxaoh rpPzs7AQkdk12wXMRWALUHna8keRee76sni5cFc5ROSZFqwQMxEgfAa+vr5+aVGdF6jV 6lH7CWzy0/vgD0AZpezQg+DhR5mY8r051KpzJyUxpfbT/UQtxeFu9vQ7JMKTFAiFqns6 UgCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=bH+pyHZRsQw/6uqVGJycw1sL0LJ2rNU0JjQm21rkDJU=; b=Devx07EMbI9k7dmsxu9EuQTn0qq8aFAqDIgrLx/4EG48C4lW1aopJoKqlOE/q4GfyV bLyaDoX1MPf30OxK39If7VVhZdg5qnHqplciiloiwXVVhl1D0AIIODrdNao9/3wrHLS5 HQq20gzSzD8enZuLr7Z2cwJXL1W+c5hJp2ggQQXk1tIPC9+bgjWGI93vvoYFCSX+H4hu i6khVovFmUe64txuMi8tJlN7sD563VKwEJTDOIS1Z0l/f8A26kyPAOQS3RAd6CK5fsjT yt/m2ybU3qIifCxtG+nBwp4yI/1jOevsNDsm4wAWRPWFkpvBBjUKugLjlFzVVujLoYOS IUpQ== X-Gm-Message-State: AElRT7GX5sAKeW/tBc56DWHlszu/ZXpPCWDPHl/dm2v27Onw2X5tjRLH ZJ4vaFy9FgF942sLYd9mKa2/p2MuYYMIiPmgIlI= X-Google-Smtp-Source: AG47ELt0Q7wzMHyS7+pgHa8gcJvsrOU83tzS/nKr7m8eADLjft+KgmPBFxf5gWKc4HzSswuZtdadDUb6YKG5dDDsiec= X-Received: by 10.202.85.143 with SMTP id j137mr718489oib.211.1520955557171; Tue, 13 Mar 2018 08:39:17 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.212.23 with HTTP; Tue, 13 Mar 2018 08:39:16 -0700 (PDT) From: Noam Postavsky Date: Tue, 13 Mar 2018 11:39:16 -0400 Message-ID: Subject: Re: bug#30735: 25.3; slow comment c++-mode To: Nil Geisweiller Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30735 Cc: Alan Mackenzie , 30735@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Sun, Mar 11, 2018 at 4:15 PM, Nil Geisweiller wrote: > Unfortunately, I couldn't apply the patch completely because I couldn't get > my hand on the source code of 25.3.1, only 25.3. 25.3 is the same as 25.3.1, the ".1" just refers to the build number (i.e., how many times you've built that version of Emacs). That said, it seems that the patch is against emacs-26 or master, not 25.3. In particular, the first hunk: @@ -4677,10 +4677,10 @@ (t 'c))) ; Assuming the range is valid. range)) -(defsubst c-determine-limit-get-base (start try-size) +(defsubst c-determine-limit-get-base (start try-size &optional abs-limit) ;; Get a "safe place" approximately TRY-SIZE characters before START. - ;; This doesn't preserve point. - (let* ((pos (max (- start try-size) (point-min))) + ;; This defsubst doesn't preserve point. + (let* ((pos (max (- start try-size) (point-min) (or abs-limit 0))) (base (c-state-semi-safe-place pos)) (s (save-restriction (widen) In 25.3, the end context would look like this: (base (c-state-semi-safe-place pos)) (s (parse-partial-sexp base pos))) (if (or (nth 4 s) (nth 3 s)) ; comment or string From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 14 15:51:43 2018 Received: (at 30735) by debbugs.gnu.org; 14 Mar 2018 19:51:43 +0000 Received: from localhost ([127.0.0.1]:33650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewCR5-0002wu-BR for submit@debbugs.gnu.org; Wed, 14 Mar 2018 15:51:43 -0400 Received: from mail-wm0-f54.google.com ([74.125.82.54]:32986) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewCR4-0002we-0d for 30735@debbugs.gnu.org; Wed, 14 Mar 2018 15:51:42 -0400 Received: by mail-wm0-f54.google.com with SMTP id s206so20014239wme.0 for <30735@debbugs.gnu.org>; Wed, 14 Mar 2018 12:51:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=from:to:message-id:date:user-agent:mime-version:content-language :content-transfer-encoding; bh=/tBO0stapKTzfISA9GczRKxoS9L6yYR8LsCDAbKcffE=; b=BlVP8ic0+HgUMhj65r5Dj/qVOhbxbfWEwFf5aiAAGlTAZygFe0mlj+7aacDNvF1WDJ PKuijh5FbxSccR/+R7PWjcWicZ1cwvC4iN/64pw/5HQlbR4mpBFS7tEug+XtCWUGaRHT Mq1nS5DQSg/8baTCAugVeoGfgwiDvUZ4b8yE0ozhXpjNxwScrAi5lnWHDpru/MUTmLtC wHdeVZAVHi6pmy/5EcpaGhejXYgV67p+ERusMWkf+Nmry4io/srveQy+FGhMY5bf8Ioo +7x50ZGvwJyiKwK/xtNGZPs/W175NOtE1Bmpud7hCMgk7/LJcdqN1KA0D1gQ4mOrOjql +EAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=/tBO0stapKTzfISA9GczRKxoS9L6yYR8LsCDAbKcffE=; b=CtGCk8LITyYCuTW6i+zolml0Y+HXp9pm911VF5Sotm1ZCIQuHqoNyEz6rm99F70d9O r5kQQQx745sgJNmipCCz/EHC/uJZ6IY9ghA/fa/GovFVZo/yLz8pokQbqaHg9VE4t4w0 l/7lS+PlSid4FGiZTlykKRvJlACY/Qujq4zyZ8OinPDZyuMWMvCrUsYem3stzFY9xiTj adrpyBhn/NCBiv2pGDg3iZWWoGQYO6fWNWrNg2LUbimzgaQItqxnnZssoOVEXKpKQuA/ dtzvMHaKrw2IdMJmMhtz3rhRtfPEVgsHMa3BhQPlhdqnXxTOzrl/icS670HL8V759lWT U4wQ== X-Gm-Message-State: AElRT7HCW2+ooK1t6cKTsJTbXtPyVkyvpBwo8m/to3ffGaRV0iZYei/F DUmuk+76cVUc16PtL7w6NENFxPFy X-Google-Smtp-Source: AG47ELs+pEPPV3LKe5PGvwtYMrgJbpbVmS5gThFSq1SAZSneRtSsRy3NBF98eGE30fpnsMUHN5tGKA== X-Received: by 10.28.194.84 with SMTP id s81mr2862360wmf.31.1521057096111; Wed, 14 Mar 2018 12:51:36 -0700 (PDT) Received: from [192.168.1.103] ([77.70.2.229]) by smtp.gmail.com with ESMTPSA id 74sm2332062wmf.26.2018.03.14.12.51.34 for <30735@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Mar 2018 12:51:35 -0700 (PDT) From: Nil Geisweiller X-Google-Original-From: Nil Geisweiller To: 30735@debbugs.gnu.org Message-ID: Date: Wed, 14 Mar 2018 21:51:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: With a bit of tweaking I managed to apply the entire patch to HEAD and it works!!! I get a similar result as yours, 40s with the patch, 10m without. A massive speed increase, and IMO completely acceptable given that commenting out that many lines is rather rare. [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (ngeiswei[at]googlemail.com) -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [74.125.82.54 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [74.125.82.54 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: 30735 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: With a bit of tweaking I managed to apply the entire patch to HEAD and it works!!! I get a similar result as yours, 40s with the patch, 10m without. A massive speed increase, and IMO completely acceptable given that commenting out that many lines is rather rare. [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [74.125.82.54 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [74.125.82.54 listed in wl.mailspike.net] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (ngeiswei[at]googlemail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders With a bit of tweaking I managed to apply the entire patch to HEAD and it works!!! I get a similar result as yours, 40s with the patch, 10m without. A massive speed increase, and IMO completely acceptable given that commenting out that many lines is rather rare. Thanks again! From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 04 12:31:47 2018 Received: (at 30735-done) by debbugs.gnu.org; 4 Apr 2018 16:31:47 +0000 Received: from localhost ([127.0.0.1]:38525 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f3lK7-0005NY-Le for submit@debbugs.gnu.org; Wed, 04 Apr 2018 12:31:47 -0400 Received: from colin.muc.de ([193.149.48.1]:42902 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1f3lK6-0005NQ-1r for 30735-done@debbugs.gnu.org; Wed, 04 Apr 2018 12:31:46 -0400 Received: (qmail 21147 invoked by uid 3782); 4 Apr 2018 16:31:44 -0000 Received: from acm.muc.de (p5B147557.dip0.t-ipconnect.de [91.20.117.87]) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 04 Apr 2018 18:31:43 +0200 Received: (qmail 7958 invoked by uid 1000); 4 Apr 2018 16:31:08 -0000 Date: Wed, 4 Apr 2018 16:31:08 +0000 To: 30735-done@debbugs.gnu.org Subject: Re: bug#30735: (no subject) Message-ID: <20180404163108.GA7896@ACM> References: <1520364356.10274.1.camel@googlemail.com> <27e9df1b-0e20-d456-14a5-7135368727ba@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <27e9df1b-0e20-d456-14a5-7135368727ba@gmail.com> User-Agent: Mutt/1.7.2 (2016-11-26) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Bug (excessively slow comment-region in CC-Mode) fixed by these commits: eb0d10d567af76967d8e738e51a79ef4998470b7 424103a6e351a6d2d8b94f86998c90fdf6afea27 b393ecf8e288f1e1b6a8ac55006715fa1046a5d4 . [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.0 SLIGHTLY_BAD_SUBJECT Subject contains something slightly spammy -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -0.0 SPF_PASS SPF: sender matches SPF record X-Debbugs-Envelope-To: 30735-done Cc: Nil Geisweiller X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Bug (excessively slow comment-region in CC-Mode) fixed by these commits: eb0d10d567af76967d8e738e51a79ef4998470b7 424103a6e351a6d2d8b94f86998c90fdf6afea27 b393ecf8e288f1e1b6a8ac55006715fa1046a5d4 . [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.0 SLIGHTLY_BAD_SUBJECT Subject contains something slightly spammy -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -0.0 SPF_PASS SPF: sender matches SPF record Bug (excessively slow comment-region in CC-Mode) fixed by these commits: eb0d10d567af76967d8e738e51a79ef4998470b7 424103a6e351a6d2d8b94f86998c90fdf6afea27 b393ecf8e288f1e1b6a8ac55006715fa1046a5d4 . -- Alan Mackenzie (Nuremberg, Germany). From unknown Fri Jun 20 07:24:33 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 03 May 2018 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator