GNU bug report logs - #30734
[PATCH core-updates 0/3] nologin and ifconfig profile conflicts

Previous Next

Full log

View this message in rfc822 format

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 30734 <at> debbugs.gnu.org
Subject: [bug#30734] [PATCH core-updates 3/3] gnu: net-tools: Don't install 'ifconfig'.
Date: Tue, 6 Mar 2018 21:20:09 +0100

[Message part 1 (text/plain, inline)]

Hi Marius,

On Tue,  6 Mar 2018 17:56:42 +0100
Marius Bakke <mbakke <at> fastmail.com> wrote:

> * gnu/packages/linux.scm (net-tools)[arguments]: In
> REMOVE-REDUNDANT-COMMANDS-PHASE, add regexp for ifconfig.
> ---
>  gnu/packages/linux.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> index dffe2c49c..8c07d1fdd 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -1290,7 +1290,7 @@ inadequately in modern network environments, and both should be deprecated.")
>                 ;; Remove commands and man pages redundant with Inetutils.
>                 (let* ((out (assoc-ref outputs "out"))
>                        (dup (append-map (cut find-files out <>)
> -                                       '("^hostname"
> +                                       '("^hostname" "^ifconfig"
>                                           "^(yp|nis|dns)?domainname"))))
>                   (for-each delete-file dup)

Is there a reason why those regular expressions don't end in "$" (meaning "at the end")?

Otherwise LGTM!

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.