GNU bug report logs - #30734
[PATCH core-updates 0/3] nologin and ifconfig profile conflicts

Previous Next

Full log

Message #17 received at 30734 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 30734 <at> debbugs.gnu.org
Subject: Re: [bug#30734] [PATCH core-updates 2/3] gnu: util-linux: Move
 '.la' files to static output.
Date: Tue, 6 Mar 2018 18:04:49 +0100

[Message part 1 (text/plain, inline)]

Hi Marius,

On Tue,  6 Mar 2018 17:56:41 +0100
Marius Bakke <mbakke <at> fastmail.com> wrote:

> index e63abcea4..dffe2c49c 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -608,10 +608,16 @@ providing the system administrator with some help in common tasks.")
>                         (mkdir-p (string-append static "/lib"))
>                         (with-directory-excursion out
>                           (for-each (lambda (file)
> +                                     ;; The dynamic linker does not need the '.la'
> +                                     ;; files, but libtool might.  Make sure they
> +                                     ;; refer to the right output.
> +                                     (when (string= ".la" (string-take-right file 3))

string-take-right errors out when given an argument which is longer than the length of FILE.

I suggest using (string-suffix? ".la" file) instead.

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.