GNU bug report logs - #30733
[PATCH staging 0/3] Updating evolution-data-server

Previous Next

Full log

Message #28 received at 30733-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 30733-done <at> debbugs.gnu.org
Subject: Re: [bug#30733] [PATCH staging 1/3] gnu: evolution-data-server:
 Update to 3.26.6.
Date: Wed, 07 Mar 2018 15:12:07 +0100

[Message part 1 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

>> +         (add-before 'configure 'dont-override-rpath
>> +           (lambda _
>> +             (substitute* "CMakeLists.txt"
>> +               (("SET\\(CMAKE_INSTALL_RPATH .*") ""))
>
> Is this because cmake fails to determine the right RUNPATH?  Perhaps add
> a short comment about this.

The #:configure-flags "hack" is needed because cmake fails to determine
the correct RUNPATH.  The CMakeLists.txt substitution is needed because
it overrides the one set in #:configure-flags.

I added a comment and pushed in ac033c7ba1e14da42a67f493802be5a59dc66a57.

Thanks for reviewing!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.