From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 06 03:29:55 2018 Received: (at submit) by debbugs.gnu.org; 6 Mar 2018 08:29:55 +0000 Received: from localhost ([127.0.0.1]:46806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1et7yt-0006JT-7L for submit@debbugs.gnu.org; Tue, 06 Mar 2018 03:29:55 -0500 Received: from eggs.gnu.org ([208.118.235.92]:49538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1et7yp-0006JE-Bk for submit@debbugs.gnu.org; Tue, 06 Mar 2018 03:29:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1et7yi-0000eb-UH for submit@debbugs.gnu.org; Tue, 06 Mar 2018 03:29:45 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41731) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1et7yi-0000eV-RE for submit@debbugs.gnu.org; Tue, 06 Mar 2018 03:29:44 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40509) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1et7yh-0003R1-Df for guix-patches@gnu.org; Tue, 06 Mar 2018 03:29:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1et7yc-0000cs-FV for guix-patches@gnu.org; Tue, 06 Mar 2018 03:29:43 -0500 Received: from dd26836.kasserver.com ([85.13.145.193]:33270) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1et7yc-0000cN-7j for guix-patches@gnu.org; Tue, 06 Mar 2018 03:29:38 -0500 Received: from dayas.3.home (77.118.199.63.wireless.dyn.drei.com [77.118.199.63]) by dd26836.kasserver.com (Postfix) with ESMTPSA id B32E833614A4; Tue, 6 Mar 2018 09:29:35 +0100 (CET) From: Danny Milosavljevic To: guix-patches@gnu.org Subject: [PATCH] gnu: inetutils: Drop "vmunix: " prefix for messages read from /dev/kmsg in syslogd. Date: Tue, 6 Mar 2018 09:27:15 +0100 Message-Id: <20180306082715.22305-1-dannym@scratchpost.org> X-Mailer: git-send-email 2.15.1 Tags: patch X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) * gnu/packages/patches/inetutils-syslogd-disable-vmunix.patch: New file. * gnu/local.mk: Add it. * gnu/packages/admin.scm (inetutils)[source]: Add it. --- gnu/local.mk | 1 + gnu/packages/admin.scm | 7 +++++-- gnu/packages/patches/inetutils-syslogd-disable-vmunix.patch | 12 ++++++++++++ 3 files changed, 18 insertions(+), 2 deletions(-) create mode 100644 gnu/packages/patches/inetutils-syslogd-disable-vmunix.patch diff --git a/gnu/local.mk b/gnu/local.mk index d091a89b8..f231900e4 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -781,6 +781,7 @@ dist_patch_DATA = \ %D%/packages/patches/icecat-use-system-harfbuzz.patch \ %D%/packages/patches/id3lib-CVE-2007-4460.patch \ %D%/packages/patches/ilmbase-fix-tests.patch \ + %D%/packages/patches/inetutils-syslogd-disable.vmunix.patch \ %D%/packages/patches/intltool-perl-compatibility.patch \ %D%/packages/patches/isl-0.11.1-aarch64-support.patch \ %D%/packages/patches/jacal-fix-texinfo.patch \ diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm index 554c1679e..805faa638 100644 --- a/gnu/packages/admin.scm +++ b/gnu/packages/admin.scm @@ -326,7 +326,9 @@ re-executing them as necessary.") version ".tar.gz")) (sha256 (base32 - "05n65k4ixl85dc6rxc51b1b732gnmm8xnqi424dy9f1nz7ppb3xy")))) + "05n65k4ixl85dc6rxc51b1b732gnmm8xnqi424dy9f1nz7ppb3xy")) + (patches + (search-patches "inetutils-syslogd-disable-vmunix.patch")))) (build-system gnu-build-system) (arguments `(#:configure-flags '("--localstatedir=/var" @@ -341,7 +343,8 @@ re-executing them as necessary.") #:parallel-tests? #f)) (inputs `(("ncurses" ,ncurses) ("readline" ,readline))) ;for 'ftp' - (native-inputs `(("netstat" ,net-tools))) ;for tests + (native-inputs `(("help2man" ,help2man) + ("netstat" ,net-tools))) ;for tests (home-page "https://www.gnu.org/software/inetutils/") (synopsis "Basic networking utilities") (description diff --git a/gnu/packages/patches/inetutils-syslogd-disable-vmunix.patch b/gnu/packages/patches/inetutils-syslogd-disable-vmunix.patch new file mode 100644 index 000000000..e21f87a05 --- /dev/null +++ b/gnu/packages/patches/inetutils-syslogd-disable-vmunix.patch @@ -0,0 +1,12 @@ +diff -ru o/inetutils-1.9.4/src/syslogd.c inetutils-1.9.4/src/syslogd.c +--- o/inetutils-1.9.4/src/syslogd.c 2015-05-12 14:13:25.000000000 +0200 ++++ inetutils-1.9.4/src/syslogd.c 2018-03-06 09:19:41.394046776 +0100 +@@ -1108,7 +1108,7 @@ + char *lp, *q, line[MAXLINE + 1]; + const char *p; + +- strcpy (line, "vmunix: "); ++ strcpy (line, ""); + lp = line + strlen (line); + for (p = msg; *p != '\0';) + { From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 07 07:41:10 2018 Received: (at 30727) by debbugs.gnu.org; 7 Mar 2018 12:41:10 +0000 Received: from localhost ([127.0.0.1]:48505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1etYNZ-0000Yn-Sf for submit@debbugs.gnu.org; Wed, 07 Mar 2018 07:41:10 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:44826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1etYNW-0000Yd-GA for 30727@debbugs.gnu.org; Wed, 07 Mar 2018 07:41:07 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 7ADF811FA3; Wed, 7 Mar 2018 13:41:05 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZELOtLvGX-yw; Wed, 7 Mar 2018 13:41:04 +0100 (CET) Received: from ribbon (vpn-0-27.aquilenet.fr [IPv6:2a0c:e300:4:27::]) by hera.aquilenet.fr (Postfix) with ESMTPSA id E1C1D10F77; Wed, 7 Mar 2018 13:41:03 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Danny Milosavljevic Subject: Re: [bug#30727] [PATCH] gnu: inetutils: Drop "vmunix: " prefix for messages read from /dev/kmsg in syslogd. References: <20180306082715.22305-1-dannym@scratchpost.org> Date: Wed, 07 Mar 2018 13:40:55 +0100 In-Reply-To: <20180306082715.22305-1-dannym@scratchpost.org> (Danny Milosavljevic's message of "Tue, 6 Mar 2018 09:27:15 +0100") Message-ID: <87tvtst5wo.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 30727 Cc: 30727@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hello! Danny Milosavljevic skribis: > +--- o/inetutils-1.9.4/src/syslogd.c 2015-05-12 14:13:25.000000000 +0200 > ++++ inetutils-1.9.4/src/syslogd.c 2018-03-06 09:19:41.394046776 +0100 > +@@ -1108,7 +1108,7 @@ > + char *lp, *q, line[MAXLINE + 1]; > + const char *p; > +=20 > +- strcpy (line, "vmunix: "); > ++ strcpy (line, ""); I=E2=80=99d rather not do that. :-) I think it=E2=80=99s good that syslogd distinguishes between =E2=80=9Creal= =E2=80=9D syslog messages and messages coming from the kernel. It=E2=80=99s also useful if = one is to filter messages. WDYT? Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 07 14:10:51 2018 Received: (at 30727-done) by debbugs.gnu.org; 7 Mar 2018 19:10:51 +0000 Received: from localhost ([127.0.0.1]:49830 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eteSh-0006QQ-D9 for submit@debbugs.gnu.org; Wed, 07 Mar 2018 14:10:51 -0500 Received: from dd26836.kasserver.com ([85.13.145.193]:58412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eteSg-0006QJ-6x for 30727-done@debbugs.gnu.org; Wed, 07 Mar 2018 14:10:50 -0500 Received: from localhost (77.118.251.160.wireless.dyn.drei.com [77.118.251.160]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 03CC93360481; Wed, 7 Mar 2018 20:10:48 +0100 (CET) Date: Wed, 7 Mar 2018 20:10:21 +0100 From: Danny Milosavljevic To: ludo@gnu.org (Ludovic =?ISO-8859-1?Q?Court=E8s?=) Subject: Re: [bug#30727] [PATCH] gnu: inetutils: Drop "vmunix: " prefix for messages read from /dev/kmsg in syslogd. Message-ID: <20180307201021.5112840b@scratchpost.org> In-Reply-To: <87tvtst5wo.fsf@gnu.org> References: <20180306082715.22305-1-dannym@scratchpost.org> <87tvtst5wo.fsf@gnu.org> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/LyzC/NLU8WUcTtY.GzgSvM4"; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 30727-done Cc: 30727-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --Sig_/LyzC/NLU8WUcTtY.GzgSvM4 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludo, On Wed, 07 Mar 2018 13:40:55 +0100 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > I=E2=80=99d rather not do that. :-) >=20 > I think it=E2=80=99s good that syslogd distinguishes between =E2=80=9Crea= l=E2=80=9D syslog > messages and messages coming from the kernel. It=E2=80=99s also useful i= f one > is to filter messages. Yeah, I wasn't 100% serious ;-) It would be possible to do the patch - but I think there are vastly better syslog daemons that already do all those things correctly (and also parse the kmsg timestamps) (syslog-ng etc). But I figured out how to do it - and I don't actually want to do it on my system, so now we have an archived version. I'd just go the UNIX way and ignore the problem and hope it goes away ;-) We can already filter via vmunix.*shepherd as-is, that should work anyhow. --Sig_/LyzC/NLU8WUcTtY.GzgSvM4 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlqgOR0ACgkQ5xo1VCww uqXQUQf+LetJ/Lefji0t+ibcSi4JunzBmkKdZVpQinBtH3Tb96Alii5aULcms0a6 p62DOK5k9G832PeaBDvxeQmBkHm9IjbkMesC7EgfBWxMcaByj7Jo3a9KN3LnGWgw BBgh6KfiU7QnxUUl8R1SURxN/Cf7RwZBNQC6aiDMpl8dmiLeAJp2gxQriUNvCxlS FPrudhvkVbjgHBUIXS3kVmofj8NkiJsLly+Bl0A5pqdamQYYfqf9MetaDrbu305B FofZdsxXEl9lBGPoNwWQYnlKdeQ/Pyma5GXxYDY8LpufdXfhNtkesR8nzuyJ6nEB wybVDCnrJ/gzsAkQ+6xCN0NdSBRGmQ== =qZJP -----END PGP SIGNATURE----- --Sig_/LyzC/NLU8WUcTtY.GzgSvM4-- From unknown Sun Jun 22 11:39:48 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 05 Apr 2018 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator