GNU bug report logs - #30716
guix pull: error: Git error: unable to parse OID - contains invalid characters when COMMIT-ID is shortened

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Björn Höfling
 <bjoern.hoefling <at> bjoernhoefling.de>
Subject: bug#30716: closed (Re: bug#30716: guix pull: error: Git error:
 unable to parse OID - contains invalid characters when COMMIT-ID is
 shortened)
Date: Sat, 17 Mar 2018 23:06:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#30716: guix pull: error: Git error: unable to parse OID - contains invalid characters when COMMIT-ID is shortened

which was filed against the guix package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 30716 <at> debbugs.gnu.org.

-- 
30716: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=30716
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: ludo <at> gnu.org (Ludovic Courtès)
To: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
Cc: 30716-done <at> debbugs.gnu.org
Subject: Re: bug#30716: guix pull: error: Git error: unable to parse OID -
 contains invalid characters when COMMIT-ID is shortened
Date: Sun, 18 Mar 2018 00:04:58 +0100

Hi Björn,

Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de> skribis:

> $>guix pull --commit=d20647722ad36024a3a0b6e1e75c1ba49b9f61dz
> Updating from Git repository at 'https://git.savannah.gnu.org/git/guix.git'...
> guix pull: error: Git error: unable to parse OID - contains invalid characters

This was actually and out-of-bounds read in Guile-Git (!), now fixed:

  https://gitlab.com/guile-git/guile-git/commit/d37a40de69d727529fe2aebb6afcf362bf8e9ba7

Furthermore, ‘guix pull’ now supports short IDs provided a recent-enough
Guile-Git is available:

  https://git.savannah.gnu.org/cgit/guix.git/commit/?id=95bd9f65a8ee64d17707a76aebc8720bbd961b68

Thanks,
Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: <bug-guix <at> gnu.org>
Subject: guix pull: error: Git error: unable to parse OID - contains invalid
 characters when COMMIT-ID is shortened
Date: Mon, 5 Mar 2018 21:29:12 +0100

[Message part 4 (text/plain, inline)]

Guix pull has the wrong error message when the commit-id for the
"--commit" parameter is too short:

$>guix pull --commit=d20647722ad36024a3a0b6e1e75c1ba49b9f61d
Updating from Git repository at
'https://git.savannah.gnu.org/git/guix.git'... guix pull: error: Git
error: unable to parse OID - contains invalid characters

Instead of that error-message it should complain that the OID is too
short.

Even better, it should just accept a shortened OID and use it, as long
as it is unique.

Note: When there really is a wrong character used, this error message
is also correctly shown:

$>guix pull --commit=d20647722ad36024a3a0b6e1e75c1ba49b9f61dz
Updating from Git repository at 'https://git.savannah.gnu.org/git/guix.git'...
guix pull: error: Git error: unable to parse OID - contains invalid characters


Note: If the OID is long enough and well-formed, but just non-existent,
the error message is adequately correct:

$> guix pull --commit=d20647722ad36024a3a0b6e1e75c1ba49b9f61dd 
Updating from Git repository at 
'https://git.savannah.gnu.org/git/guix.git'... guix pull: error: Git
error: object not found - no match for id
(d20647722ad36024a3a0b6e1e75c1ba49b9f61dd)


Björn

[Message part 5 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.