From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 05 15:29:31 2018 Received: (at submit) by debbugs.gnu.org; 5 Mar 2018 20:29:31 +0000 Received: from localhost ([127.0.0.1]:46268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eswji-0004mC-QV for submit@debbugs.gnu.org; Mon, 05 Mar 2018 15:29:31 -0500 Received: from eggs.gnu.org ([208.118.235.92]:45739) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eswjh-0004ly-Jr for submit@debbugs.gnu.org; Mon, 05 Mar 2018 15:29:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eswjb-0004zu-8U for submit@debbugs.gnu.org; Mon, 05 Mar 2018 15:29:24 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37666) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eswjb-0004zi-56 for submit@debbugs.gnu.org; Mon, 05 Mar 2018 15:29:23 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36684) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eswjZ-0003jT-SL for bug-guix@gnu.org; Mon, 05 Mar 2018 15:29:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eswjW-0004xu-Ll for bug-guix@gnu.org; Mon, 05 Mar 2018 15:29:21 -0500 Received: from m4s11.vlinux.de ([83.151.27.109]:51526 helo=bjoernhoefling.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eswjW-0004wN-DP for bug-guix@gnu.org; Mon, 05 Mar 2018 15:29:18 -0500 Received: from alma-ubu (pD951FC9C.dip0.t-ipconnect.de [217.81.252.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by bjoernhoefling.de (Postfix) with ESMTPSA id 324F940709 for ; Mon, 5 Mar 2018 21:29:14 +0100 (CET) Date: Mon, 5 Mar 2018 21:29:12 +0100 From: =?UTF-8?B?QmrDtnJuIEjDtmZsaW5n?= To: Subject: guix pull: error: Git error: unable to parse OID - contains invalid characters when COMMIT-ID is shortened Message-ID: <20180305212912.625ecf29@alma-ubu> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/I0Q=IErw.coJ_FlOFJw4DqB"; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --Sig_/I0Q=IErw.coJ_FlOFJw4DqB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Guix pull has the wrong error message when the commit-id for the "--commit" parameter is too short: $>guix pull --commit=3Dd20647722ad36024a3a0b6e1e75c1ba49b9f61d Updating from Git repository at 'https://git.savannah.gnu.org/git/guix.git'... guix pull: error: Git error: unable to parse OID - contains invalid characters Instead of that error-message it should complain that the OID is too short. Even better, it should just accept a shortened OID and use it, as long as it is unique. Note: When there really is a wrong character used, this error message is also correctly shown: $>guix pull --commit=3Dd20647722ad36024a3a0b6e1e75c1ba49b9f61dz Updating from Git repository at 'https://git.savannah.gnu.org/git/guix.git'= ... guix pull: error: Git error: unable to parse OID - contains invalid charact= ers Note: If the OID is long enough and well-formed, but just non-existent, the error message is adequately correct: $> guix pull --commit=3Dd20647722ad36024a3a0b6e1e75c1ba49b9f61dd=20 Updating from Git repository at=20 'https://git.savannah.gnu.org/git/guix.git'... guix pull: error: Git error: object not found - no match for id (d20647722ad36024a3a0b6e1e75c1ba49b9f61dd) Bj=C3=B6rn --Sig_/I0Q=IErw.coJ_FlOFJw4DqB Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlqdqJgACgkQvyhstlk+X/12HACfW4XDQl4pIrvhJJCTOZ9aUJQ0 zPUAoKDUf03If3R7+vKtf/i4y4KG4+sy =UqPm -----END PGP SIGNATURE----- --Sig_/I0Q=IErw.coJ_FlOFJw4DqB-- From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 17 19:05:04 2018 Received: (at 30716-done) by debbugs.gnu.org; 17 Mar 2018 23:05:04 +0000 Received: from localhost ([127.0.0.1]:38829 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exKsq-00083v-Bv for submit@debbugs.gnu.org; Sat, 17 Mar 2018 19:05:04 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:49646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exKsm-00083P-Tt for 30716-done@debbugs.gnu.org; Sat, 17 Mar 2018 19:05:01 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id EA4621327A; Sun, 18 Mar 2018 00:04:59 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JdKkHE9F-ufq; Sun, 18 Mar 2018 00:04:58 +0100 (CET) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 9F61613278; Sun, 18 Mar 2018 00:04:58 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: =?utf-8?Q?Bj=C3=B6rn_H=C3=B6fling?= Subject: Re: bug#30716: guix pull: error: Git error: unable to parse OID - contains invalid characters when COMMIT-ID is shortened References: <20180305212912.625ecf29@alma-ubu> Date: Sun, 18 Mar 2018 00:04:58 +0100 In-Reply-To: <20180305212912.625ecf29@alma-ubu> (=?utf-8?Q?=22Bj=C3=B6rn?= =?utf-8?Q?_H=C3=B6fling=22's?= message of "Mon, 5 Mar 2018 21:29:12 +0100") Message-ID: <87vadujobp.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 30716-done Cc: 30716-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hi Bj=C3=B6rn, Bj=C3=B6rn H=C3=B6fling skribis: > $>guix pull --commit=3Dd20647722ad36024a3a0b6e1e75c1ba49b9f61dz > Updating from Git repository at 'https://git.savannah.gnu.org/git/guix.gi= t'... > guix pull: error: Git error: unable to parse OID - contains invalid chara= cters This was actually and out-of-bounds read in Guile-Git (!), now fixed: https://gitlab.com/guile-git/guile-git/commit/d37a40de69d727529fe2aebb6af= cf362bf8e9ba7 Furthermore, =E2=80=98guix pull=E2=80=99 now supports short IDs provided a = recent-enough Guile-Git is available: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=3D95bd9f65a8ee64d17= 707a76aebc8720bbd961b68 Thanks, Ludo=E2=80=99. From unknown Sun Jun 22 00:25:11 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 15 Apr 2018 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator