GNU bug report logs - #30701
[PATCH 0/4] PostgreSQL service changes (add record type, and system test)

Previous Next

Full log

View this message in rfc822 format

From: Clément Lassieur <clement <at> lassieur.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 30701-done <at> debbugs.gnu.org
Subject: [bug#30701] [PATCH 1/3] services: Rework the PostgreSQL config file to use a record type.
Date: Sun, 18 Mar 2018 01:34:48 +0100

Christopher Baines <mail <at> cbaines.net> writes:

> Clément Lassieur <clement <at> lassieur.org> writes:
>
>> Christopher Baines <mail <at> cbaines.net> writes:
>>
>>> Sorry, I made some changes, and merged these patches on the weekend, but
>>> I forgot to reply.
>>
>> [...]
>>
>>>>> +        `(("log_destination" ,@(with-single-quotes log-destination))
>>>>> +          ("hba_file" ,@(with-single-quotes hba-file))
>>>>> +          ("ident_file" ,@(with-single-quotes ident-file))
>>>>                                     ^
>>>> Could you please use a shorter name?  Like "enclose", so that we won't
>>>> go over 80 columns too easily :-).
>>>
>>> I went with quote' as I think that works well.
>>
>> I don't like it because:
>>
>>   • The extra \' doesn't help describing what the function does.  One
>>     could believe it's a variant of 'quote', but it's actually very
>>     different.
>>
>>   • It doesn't follow our coding style.  See
>>     https://mumble.net/~campbell/scheme/style.txt.  "Symbolic names are
>>     written with English words separated by hyphens."  See also the part
>>     about "Funny Characters".
>
> Fair enough, I've changed it to single-quote in
> 533808383f7fca6563aee1452f5202e0cd1b66b8.

Thank you Christopher!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.