GNU bug report logs - #30701
[PATCH 0/4] PostgreSQL service changes (add record type, and system test)

Previous Next

Full log

Message #20 received at 30701 <at> debbugs.gnu.org (full text, mbox):

From: Clément Lassieur <clement <at> lassieur.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 30701 <at> debbugs.gnu.org
Subject: Re: [bug#30701] [PATCH 1/4] services: Rework the PostgreSQL config
 file to use a record type.
Date: Mon, 05 Mar 2018 01:32:10 +0100

Hi Christopher,

Christopher Baines <mail <at> cbaines.net> writes:

> For the default config file representation. This makes it possible to more
> easily change the configuration file, and have dynamic content. In particular,
> I'm looking at adding a pid file location to the config file.
>
> * gnu/services/databases.scm (<postgresql-config-file>): New record type.
>   (%default-postgres-config): Remove this, it's been replaced by the
>   configuration file.
>   (<postgresql-configuration>): Alter the default for the config file field.
>   (postgresql-service): Alter the default value for the config-file parameter.
> ---
>  gnu/services/databases.scm | 86 +++++++++++++++++++++++++++++++++++-----------
>  1 file changed, 66 insertions(+), 20 deletions(-)

Thank you for this work!

> +(define-gexp-compiler (postgresql-config-file-compiler
> +                       (file <postgresql-config-file>) system target)
> +  (match file
> +    (($ <postgresql-config-file> log-destination hba-file
> +                                 ident-file extra-config)
> +     (define (quote string)
> +       (if string
> +           (list "'" string "'")
> +           (list)))

I don't think it's a good thing to hide one of the most important lisp
functions :-).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.