Subject: Re: bug#30683: [PATCH] build: add a configure flag to force --sandbox

From: Eric Blake <[email-masked]>
Date: Fri, 2 Mar 2018 17:20:07 -0600

On 03/02/2018 05:07 PM, Assaf Gordon wrote:

> On Fri, Mar 02, 2018 at 05:28:15PM -0500, Mike Frysinger wrote:
>> * configure.ac: Add --enable-forced-sandbox option, and define
>> ENABLE_FORCED_SANDBOX when enabled.
> 
> Conceptually I like your idea (since I've added the original
> --sandbox option to both gnu sed and gawk).
> 
> However,
> Adding such "--enable" options to "./configure" goes against the gnu coding standards,
> which say:
> 
>     No ‘--enable’ option should ever cause one feature to replace another.
>     No ‘--enable’ option should ever substitute one useful behavior for
>     another useful behavior. The only proper use for ‘--enable’ is for
>     questions of whether to build part of the program or exclude it.
>     (source: https://www.gnu.org/prep/standards/html_node/Configuration.html)

Would a different spelling, such as 
'--with-forced-sandbox-default=on/off' be better?

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org