GNU bug report logs - #30682
[PATCH] sed: note in --help what commands are disabled by --sandbox

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Assaf Gordon <assafgordon <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#30682: closed ([PATCH] sed: note in --help what commands are
 disabled by --sandbox)
Date: Sat, 03 Mar 2018 00:00:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 2 Mar 2018 16:59:01 -0700
with message-id <20180302235901.GA10984 <at> tomato>
and subject line Re: bug#30682: [PATCH] sed: note in --help what commands are disabled by --sandbox
has caused the debbugs.gnu.org bug report #30682,
regarding [PATCH] sed: note in --help what commands are disabled by --sandbox
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
30682: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=30682
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Mike Frysinger <vapier <at> gentoo.org>
To: bug-sed <at> gnu.org
Subject: [PATCH] sed: note in --help what commands are disabled by --sandbox
Date: Fri,  2 Mar 2018 17:11:07 -0500

From: Mike Frysinger <vapier <at> chromium.org>

* sed/sed.c (usage): Add "(disable e/r/w commands)" to --sandbox text.
---
 sed/sed.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sed/sed.c b/sed/sed.c
index 26de1a8dbb44..65bcab5ac58a 100644
--- a/sed/sed.c
+++ b/sed/sed.c
@@ -168,7 +168,7 @@ Usage: %s [OPTION]... {script-only-if-no-other-script} [input-file]...\n\
                  consider files as separate rather than as a single,\n\
                  continuous long stream.\n"));
   fprintf(out, _("      --sandbox\n\
-                 operate in sandbox mode.\n"));
+                 operate in sandbox mode (disable e/r/w commands).\n"));
   fprintf(out, _("  -u, --unbuffered\n\
                  load minimal amounts of data from the input files and flush\n\
                  the output buffers more often\n"));
-- 
2.16.1

[Message part 3 (message/rfc822, inline)]

From: Assaf Gordon <assafgordon <at> gmail.com>
To: Jim Meyering <jim <at> meyering.net>
Cc: 30682-done <at> debbugs.gnu.org, Mike Frysinger <vapier <at> gentoo.org>
Subject: Re: bug#30682: [PATCH] sed: note in --help what commands are
 disabled by --sandbox
Date: Fri, 2 Mar 2018 16:59:01 -0700

On Fri, Mar 02, 2018 at 03:34:50PM -0800, Jim Meyering wrote:
> On Fri, Mar 2, 2018 at 3:25 PM, Assaf Gordon <assafgordon <at> gmail.com> wrote:
> > Hello Mike,
> >
> > On Fri, Mar 02, 2018 at 05:11:07PM -0500, Mike Frysinger wrote:
> >> * sed/sed.c (usage): Add "(disable e/r/w commands)" to --sandbox text.
> >
> > Thanks.
> > Attached same patch with slightly modified commit message (added 'subject'
> > and 'copyright-exempt').
> >
> > I'll push soon if there are no objections.
> 
> Thanks. That looks fine.

Thanks for the quick review, pushed here:
https://git.savannah.gnu.org/cgit/sed.git/commit/?id=ef9fcbc4

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.