Subject: [bug#30678] [PATCH] Update VLC to 3.0.1

From: Marius Bakke <[email-masked]>
Date: Mon, 26 Mar 2018 20:30:38 +0200

Hello!

Sorry for the sloooow response.

[email-masked] writes:

> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> index 8190b0ffc..d668d8235 100644
> --- a/gnu/packages/video.scm
> +++ b/gnu/packages/video.scm

Can you resubmit this patch using "git format-patch"?  Please also take
a look at the git log for conventions.  Some comments below.

>      (build-system gnu-build-system)
>      (native-inputs
>       `(("git" ,git) ; needed for a test
> +       ("gcc" ,gcc)

Do you know why GCC is needed?  Normally the one provided by
gnu-build-system is sufficient.

> @@ -857,16 +863,54 @@ audio/video codec library.")
>         ("perl" ,perl)
>         ("pulseaudio" ,pulseaudio)
>         ("python" ,python-wrapper)
> -       ("qtbase" ,qtbase)
> +       ;; Qt required instead of just qtbase as it was
> +       ;; before, otherwise check_POTFILES.sh test fails.
> +       ("qt" ,qt) 

The "qt" package frequently lags behind the "modular" Qt, so we try to
get rid of the former.  Maybe it requires some of the other Qt
"modules"?  What is the error message?

>         ("qtx11extras" ,qtx11extras)
>         ("sdl" ,sdl)
>         ("sdl-image" ,sdl-image)
>         ("speex" ,speex)
>         ("x265" ,x265)
> -       ("xcb-util-keysyms" ,xcb-util-keysyms)))
> +       ("xcb-util-keysyms" ,xcb-util-keysyms)
> +       ;Optional inputs
> +       ;("lua" ,lua) ;Configure phase doesn't find this
> +       ("libarchive" ,libarchive)
> +       ("livemedia-utils" ,livemedia-utils)
> +       ("libbluray" ,libbluray)
> +       ("samba" ,samba)
> +       ;("nfs-utils" ,(@ (gnu packages nfs) nfs-utils)) ;configure phase doesn't find this
> +       ;("freerdp" ,(@ (gnu packages rdesktop) freerdp)) ;causes compilation failure
> +       ("libshout" ,libshout)
> +       ("libebml" ,libebml)
> +       ("libmatroska" ,libmatroska)
> +       ("libmodplug" ,libmodplug)
> +       ("mpg123" ,mpg123)
> +       ;("gstreamer"
> +       ; ,(@ (gnu packages gstreamer) gstreamer)) ;configure phase doesn't find this.
> +       ("libva" ,libva)
> +       ("twolame" ,twolame)
> +       ("libdca" ,libdca)
> +       ("libmpeg2" ,libmpeg2)
> +       ("speexdsp" ,speexdsp)
> +       ("fluidsynth" ,fluidsynth)
> +       ("libass" ,libass)
> +       ("fribidi" ,fribidi)
> +       ("librsvg" ,librsvg)
> +       ("libcaca" ,libcaca)
> +       ("jack" ,jack-1)
> +       ("soxr" ,soxr)
> +       ("chromaprint" ,chromaprint)
> +       ("protobuf" ,protobuf)
> +       ("eudev" ,eudev)
> +       ("libmtp" ,libmtp)
> +       ("libupnp" ,libupnp)
> +       ("taglib" ,taglib)
> +       ("libsecret" ,libsecret)
> +       ("libnotify" ,libnotify)))

Wooooow, that's a lot of new dependencies!  Can you preserve the
alphabetical sorting of inputs?

Thanks for working on it!