From unknown Fri Sep 19 16:38:58 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#30675 <30675@debbugs.gnu.org> To: bug#30675 <30675@debbugs.gnu.org> Subject: Status: Ask the user what to do when shr-make-table: Variable binding depth exceeds max-specpdl-size Reply-To: bug#30675 <30675@debbugs.gnu.org> Date: Fri, 19 Sep 2025 23:38:58 +0000 retitle 30675 Ask the user what to do when shr-make-table: Variable binding= depth exceeds max-specpdl-size reassign 30675 emacs submitter 30675 =E7=A9=8D=E4=B8=B9=E5=B0=BC Dan Jacobson severity 30675 wishlist tag 30675 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 01 21:40:26 2018 Received: (at submit) by debbugs.gnu.org; 2 Mar 2018 02:40:26 +0000 Received: from localhost ([127.0.0.1]:39929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eracU-0004QS-4u for submit@debbugs.gnu.org; Thu, 01 Mar 2018 21:40:26 -0500 Received: from eggs.gnu.org ([208.118.235.92]:44567) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eracS-0004QE-Oa for submit@debbugs.gnu.org; Thu, 01 Mar 2018 21:40:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eracL-0006mq-Pf for submit@debbugs.gnu.org; Thu, 01 Mar 2018 21:40:18 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40490) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eracL-0006mb-K3 for submit@debbugs.gnu.org; Thu, 01 Mar 2018 21:40:17 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35523) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eracK-0002VL-Ha for bug-gnu-emacs@gnu.org; Thu, 01 Mar 2018 21:40:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eracH-0006gU-AO for bug-gnu-emacs@gnu.org; Thu, 01 Mar 2018 21:40:16 -0500 Received: from homie.mail.dreamhost.com ([208.97.132.208]:50888 helo=homiemail-a5.g.dreamhost.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eracH-0006e3-3j for bug-gnu-emacs@gnu.org; Thu, 01 Mar 2018 21:40:13 -0500 Received: from homiemail-a5.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a5.g.dreamhost.com (Postfix) with ESMTP id B0CDF70406E; Thu, 1 Mar 2018 18:40:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=jidanni.org; h=from:to:cc :subject:references:date:message-id:mime-version:content-type; s=jidanni.org; bh=wtEue7CyknL1kuWOg1MI/XyNMIw=; b=T5iIddag12ZYN HkSIVDwB/FtY+/slB4Y0v7OUmbe7Km/ML1l7Dgx2wXiltCTQ1qNs1lgR+1H41nPT s20JNv/sizp2pHeqS5Tb+gQyEAmYTsZwRt9HnHK7FTinVBBlDGnApLgxJjBBzcxW JiinvS+zAcTmvnJTTw2kvsaNGLaUbE= Received: from jidanni.org (111-246-84-128.dynamic-ip.hinet.net [111.246.84.128]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: jidanni@jidanni.org) by homiemail-a5.g.dreamhost.com (Postfix) with ESMTPSA id 6D03C704060; Thu, 1 Mar 2018 18:40:10 -0800 (PST) From: =?utf-8?B?56mN5Li55bC8?= Dan Jacobson To: bug-gnu-emacs@gnu.org Subject: Ask the user what to do when shr-make-table: Variable binding depth exceeds max-specpdl-size References: <877eqwbqvc.fsf@jidanni.org> Date: Fri, 02 Mar 2018 10:40:07 +0800 Message-ID: <87po4n19q0.fsf_-_@jidanni.org> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: Katsumi Yamaoka X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Instead of warning the user when this happens KY> (defun shr-descend (dom) KY> ... KY> (if (> shr-depth (/ max-specpdl-size 15)) KY> (setq shr-warning "Too deeply nested to render properly; consider increasing `max-specpdl-size'") KY> else ...)) it should ask the user "Should we try 15 levels deeper? y-n and if that is still not enough, it should ask the user "Should we try 25 levels even more deeper? y-n ... Why? Because the user is facing a probably one-time bad html message. He doesn't want to change his .emacs to always let them pass. He also wants the choice: no I don't want to go deeper for this promotional coupon. yes my grandmom sent me this so I want to see it. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 01 21:51:48 2018 Received: (at 30675) by debbugs.gnu.org; 2 Mar 2018 02:51:48 +0000 Received: from localhost ([127.0.0.1]:39936 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eranT-0004gI-Jq for submit@debbugs.gnu.org; Thu, 01 Mar 2018 21:51:48 -0500 Received: from mail-io0-f170.google.com ([209.85.223.170]:36053) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eranR-0004fu-62; Thu, 01 Mar 2018 21:51:45 -0500 Received: by mail-io0-f170.google.com with SMTP id e30so9381665ioc.3; Thu, 01 Mar 2018 18:51:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=xyC3116fnPJSFqxEZNMtABm/hbRoZG2vtlrXLYUkUcM=; b=qYiiSNm9Hj6rUC9fGToIuYP5PUolOjzmfUVsnWrF/fiO9YNVwVsyHwgl6Yp0/kx3QD Onx4WMeWF7HKDbvbZiXghhagR3ub4/xpC+bu8oG8hDXaBazPo1K9Gz7x+wWB15z8F3th Q0FKKu/XAzWOOLw1d1jEqXAPoxvvYt7lVhIgOdLFyQuK4Sw2yxfsvcGTznkDluYvjJ/X HYMaI9IsFw0ZJ2zMatVvdV/WA5MYvCyoMPEd81UynARfEBzeGbtrpsg5hYLzUOMU/GoY i+0rho/7nYfmY0fpsacn4lzzvVWLT8pd00lHAqZGZkhwMqxGs4KCaz0HXQl85xJfouiE cOUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=xyC3116fnPJSFqxEZNMtABm/hbRoZG2vtlrXLYUkUcM=; b=b8qRJNK1iGrHSeveiG91I171veAMlaFNslkCx/BDVEQhHlj5PrQALP8xdxCp+NDuc3 GPGHikJMwZyN+SBdj+zBW2oCLsy+z7IWCItGC4bjc9+BWJf9Tt1Tgw6lbySsNOwoBrVf +wqMGwChp5FC39kUBTzYngvGtNBqqVOyRph0f/Qx13XqZsOGWxMQKQr0BDS2v1vYbXQB UjBd6XU54H3dLasjIHAJGaCHnAIVAp8funyYgLIaKI9asVMjmb3YGMnmTvf0WZZXV/Ff Qb/BCvyVssc7bXfVeZ2g6BEp/7f1xMNj3V2vmDCp+jL4+Had44gmTII8Q9r77NZfa5pC dJRg== X-Gm-Message-State: AElRT7FoFYgYgUrpxfnj5OAbH/XTdlEPR+qDcZRb3a+c89H7uInTkZXO 8ALcH/9VB+JyLsJmapWwIMOOTw== X-Google-Smtp-Source: AG47ELvYWw7Kv4sllHHw22aFaXRmDdP0bQLKMdOzvUDZBSfAEbXLx7kTK08/WDefZiwOBuA3gJnbUw== X-Received: by 10.107.29.205 with SMTP id d196mr4887052iod.18.1519959099551; Thu, 01 Mar 2018 18:51:39 -0800 (PST) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id s70sm494187itb.0.2018.03.01.18.51.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 01 Mar 2018 18:51:38 -0800 (PST) From: Noam Postavsky To: =?utf-8?B?56mN5Li55bC8?= Dan Jacobson Subject: Re: bug#30675: Ask the user what to do when shr-make-table: Variable binding depth exceeds max-specpdl-size References: <877eqwbqvc.fsf@jidanni.org> <87po4n19q0.fsf_-_@jidanni.org> Date: Thu, 01 Mar 2018 21:51:36 -0500 In-Reply-To: <87po4n19q0.fsf_-_@jidanni.org> (=?utf-8?B?IuepjeS4ueWwvA==?= Dan Jacobson"'s message of "Fri, 02 Mar 2018 10:40:07 +0800") Message-ID: <87efl342br.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30675 Cc: 30675@debbugs.gnu.org, Katsumi Yamaoka X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) severity 30675 wishlist quit =E7=A9=8D=E4=B8=B9=E5=B0=BC Dan Jacobson writes: > Instead of warning the user when this happens > > KY> (defun shr-descend (dom) > KY> ... > KY> (if (> shr-depth (/ max-specpdl-size 15)) > KY> (setq shr-warning "Too deeply nested to render properly; consider in= creasing `max-specpdl-size'") > KY> else ...)) > > it should ask the user "Should we try 15 levels deeper? y-n > > and if that is still not enough, > > it should ask the user "Should we try 25 levels even more deeper? y-n > ... > > Why? > > Because the user is facing a probably one-time bad html message. > > He doesn't want to change his .emacs to always let them pass. > > He also wants the choice: > no I don't want to go deeper for this promotional coupon. > yes my grandmom sent me this so I want to see it. On the other hand, if you say go deeper too far Emacs will crash. It's a bit hard to predict how far is too far, so I'm not sure if this prompt is such a great idea. See Bug#16999 "calc crashes when computation limit is increased" for an example of such a prompt. https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D16999 From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 12 19:49:53 2018 Received: (at 30675) by debbugs.gnu.org; 12 Apr 2018 23:49:53 +0000 Received: from localhost ([127.0.0.1]:48848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6lyS-0004Um-Sf for submit@debbugs.gnu.org; Thu, 12 Apr 2018 19:49:53 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:46227) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6lyQ-0004Ud-Pk for 30675@debbugs.gnu.org; Thu, 12 Apr 2018 19:49:51 -0400 Received: from 46.67.12.60.tmi.telenormobil.no ([46.67.12.60] helo=corrigan) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1f6lyN-0007Qa-DH; Fri, 13 Apr 2018 01:49:49 +0200 Received: from larsi by corrigan with local (Exim 4.89) (envelope-from ) id 1f6lyG-0007EP-7Q; Fri, 13 Apr 2018 01:49:40 +0200 From: Lars Ingebrigtsen To: =?utf-8?B?56mN5Li55bC8?= Dan Jacobson Subject: Re: bug#30675: Ask the user what to do when shr-make-table: Variable binding depth exceeds max-specpdl-size References: <877eqwbqvc.fsf@jidanni.org> <87po4n19q0.fsf_-_@jidanni.org> Date: Fri, 13 Apr 2018 01:49:39 +0200 In-Reply-To: <87po4n19q0.fsf_-_@jidanni.org> (=?utf-8?B?IuepjeS4ueWwvA==?= Dan Jacobson"'s message of "Fri, 02 Mar 2018 10:40:07 +0800") Message-ID: <87bmeoc7e4.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30675 Cc: 30675@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) =E7=A9=8D=E4=B8=B9=E5=B0=BC Dan Jacobson writes: > Instead of warning the user when this happens > > KY> (defun shr-descend (dom) > KY> ... > KY> (if (> shr-depth (/ max-specpdl-size 15)) > KY> (setq shr-warning "Too deeply nested to render properly; consider in= creasing `max-specpdl-size'") > KY> else ...)) > > it should ask the user "Should we try 15 levels deeper? y-n Or perhaps shr should just bind that variable to, like, 10x what it normally is? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 12 20:06:16 2018 Received: (at 30675) by debbugs.gnu.org; 13 Apr 2018 00:06:16 +0000 Received: from localhost ([127.0.0.1]:48882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6mEJ-0006v6-En for submit@debbugs.gnu.org; Thu, 12 Apr 2018 20:06:16 -0400 Received: from homie.mail.dreamhost.com ([208.97.132.208]:56169 helo=homiemail-a9.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6mED-0006ut-JF for 30675@debbugs.gnu.org; Thu, 12 Apr 2018 20:06:14 -0400 Received: from homiemail-a9.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a9.g.dreamhost.com (Postfix) with ESMTP id B479A5BE066; Thu, 12 Apr 2018 17:06:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=jidanni.org; h=from:to:cc :subject:references:date:message-id:mime-version:content-type; s=jidanni.org; bh=sNDHDNb6m0cDdApysoUBqeE90sY=; b=mP5YBMNEQIWO7 dF3F6CPPMwg+9F9TjjDMpKDenk0rPv9xyLFzlUQe4hmytbdHSnQ88AfUhgoQWFbN xdoq5iEP7LO8FgIG2kFRAg+x7J8lU2bLVix7hzj/nxnTA+EV+yn/tG/xjzX5+30W 0F5WEUiK9RhPJt4KK89FnZ+dkPDDA0= Received: from jidanni.org (36-234-68-239.dynamic-ip.hinet.net [36.234.68.239]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: jidanni@jidanni.org) by homiemail-a9.g.dreamhost.com (Postfix) with ESMTPSA id 6F6E15BE064; Thu, 12 Apr 2018 17:06:08 -0700 (PDT) From: =?utf-8?B?56mN5Li55bC8?= Dan Jacobson To: Lars Ingebrigtsen Subject: Re: bug#30675: Ask the user what to do when shr-make-table: Variable binding depth exceeds max-specpdl-size References: <877eqwbqvc.fsf@jidanni.org> <87po4n19q0.fsf_-_@jidanni.org> <87bmeoc7e4.fsf@mouse.gnus.org> Date: Fri, 13 Apr 2018 08:06:05 +0800 Message-ID: <87k1tc3r82.fsf@jidanni.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 30675 Cc: 30675@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) >>>>> "LI" == Lars Ingebrigtsen writes: LI> Or perhaps shr should just bind that variable to, like, 10x what it LI> normally is? You're the boss. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 12 20:27:38 2018 Received: (at 30675) by debbugs.gnu.org; 13 Apr 2018 00:27:38 +0000 Received: from localhost ([127.0.0.1]:48910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6mYy-0007Td-Ox for submit@debbugs.gnu.org; Thu, 12 Apr 2018 20:27:38 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:47753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6mYt-0007TR-TB for 30675@debbugs.gnu.org; Thu, 12 Apr 2018 20:27:35 -0400 Received: from 46.67.12.60.tmi.telenormobil.no ([46.67.12.60] helo=corrigan) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1f6mYn-00073g-QX; Fri, 13 Apr 2018 02:27:31 +0200 Received: from larsi by corrigan with local (Exim 4.89) (envelope-from ) id 1f6mYh-0007U9-Qv; Fri, 13 Apr 2018 02:27:19 +0200 From: Lars Ingebrigtsen To: =?utf-8?B?56mN5Li55bC8?= Dan Jacobson Subject: Re: bug#30675: Ask the user what to do when shr-make-table: Variable binding depth exceeds max-specpdl-size References: <877eqwbqvc.fsf@jidanni.org> <87po4n19q0.fsf_-_@jidanni.org> <87bmeoc7e4.fsf@mouse.gnus.org> <87k1tc3r82.fsf@jidanni.org> Date: Fri, 13 Apr 2018 02:27:19 +0200 In-Reply-To: <87k1tc3r82.fsf@jidanni.org> (=?utf-8?B?IuepjeS4ueWwvA==?= Dan Jacobson"'s message of "Fri, 13 Apr 2018 08:06:05 +0800") Message-ID: <87h8ogar2w.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30675 Cc: 30675@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) =E7=A9=8D=E4=B8=B9=E5=B0=BC Dan Jacobson writes: >>>>>> "LI" =3D=3D Lars Ingebrigtsen writes: > > LI> Or perhaps shr should just bind that variable to, like, 10x what it > LI> normally is? > > You're the boss. No, I'm not. Eli is. :-) --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 13 05:29:37 2018 Received: (at 30675) by debbugs.gnu.org; 13 Apr 2018 09:29:37 +0000 Received: from localhost ([127.0.0.1]:49094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6v1S-0005DN-31 for submit@debbugs.gnu.org; Fri, 13 Apr 2018 05:29:37 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45209) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6v1Q-0005D8-7F for 30675@debbugs.gnu.org; Fri, 13 Apr 2018 05:29:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f6v1G-0002d0-4r for 30675@debbugs.gnu.org; Fri, 13 Apr 2018 05:29:27 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60668) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f6v1G-0002cp-0b; Fri, 13 Apr 2018 05:29:22 -0400 Received: from [176.228.60.248] (port=2126 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1f6v1F-0004SI-Dz; Fri, 13 Apr 2018 05:29:21 -0400 Date: Fri, 13 Apr 2018 12:29:17 +0300 Message-Id: <83r2nj5uaa.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-reply-to: <87h8ogar2w.fsf@mouse.gnus.org> (message from Lars Ingebrigtsen on Fri, 13 Apr 2018 02:27:19 +0200) Subject: Re: bug#30675: Ask the user what to do when shr-make-table: Variable binding depth exceeds max-specpdl-size References: <877eqwbqvc.fsf@jidanni.org> <87po4n19q0.fsf_-_@jidanni.org> <87bmeoc7e4.fsf@mouse.gnus.org> <87k1tc3r82.fsf@jidanni.org> <87h8ogar2w.fsf@mouse.gnus.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30675 Cc: 30675@debbugs.gnu.org, jidanni@jidanni.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Lars Ingebrigtsen > Date: Fri, 13 Apr 2018 02:27:19 +0200 > Cc: 30675@debbugs.gnu.org > > 積丹尼 Dan Jacobson writes: > > >>>>>> "LI" == Lars Ingebrigtsen writes: > > > > LI> Or perhaps shr should just bind that variable to, like, 10x what it > > LI> normally is? > > > > You're the boss. > > No, I'm not. Eli is. :-) I am? Well, if I need to give my opinion on this, then blindly increasing the limit ten-fold is something that'd make me worry about a potential C stack overflow. I'd feel much better with a lower factor, e.g. some value that is just enough to cover this case plus some slack. Bonus points for providing a defcustom with the factor, so that users could change that. The idea of asking the user whether to increase by N levels sounds OK to me, provided that its implementation is not out-worldly hard. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 13 07:48:38 2018 Received: (at 30675) by debbugs.gnu.org; 13 Apr 2018 11:48:38 +0000 Received: from localhost ([127.0.0.1]:49151 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6xC2-0002P7-1f for submit@debbugs.gnu.org; Fri, 13 Apr 2018 07:48:38 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:49437) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6xC0-0002Oz-Mo for 30675@debbugs.gnu.org; Fri, 13 Apr 2018 07:48:37 -0400 Received: from 46.67.12.60.tmi.telenormobil.no ([46.67.12.60] helo=corrigan) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1f6xBt-0008Ok-7r; Fri, 13 Apr 2018 13:48:31 +0200 Received: from larsi by corrigan with local (Exim 4.89) (envelope-from ) id 1f6xBn-0007uO-9C; Fri, 13 Apr 2018 13:48:23 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#30675: Ask the user what to do when shr-make-table: Variable binding depth exceeds max-specpdl-size References: <877eqwbqvc.fsf@jidanni.org> <87po4n19q0.fsf_-_@jidanni.org> <87bmeoc7e4.fsf@mouse.gnus.org> <87k1tc3r82.fsf@jidanni.org> <87h8ogar2w.fsf@mouse.gnus.org> <83r2nj5uaa.fsf@gnu.org> Date: Fri, 13 Apr 2018 13:48:22 +0200 In-Reply-To: <83r2nj5uaa.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 13 Apr 2018 12:29:17 +0300") Message-ID: <87fu3z9vjt.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30675 Cc: 30675@debbugs.gnu.org, jidanni@jidanni.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > I'd feel much better with a lower factor, e.g. some value that is just > enough to cover this case plus some slack. Bonus points for providing > a defcustom with the factor, so that users could change that. The problem is that HTML may nest arbitrarily deep, so there isn't really any way to cover this completely. But the larger the stack size is, the lower the possibility for hitting the limit is. FWIW, I haven't hit the limit in about a year, so it's rare for people to encounter HTML that's that deeply nested. > The idea of asking the user whether to increase by N levels sounds OK > to me, provided that its implementation is not out-worldly hard. I kinda feel that stack size is something that a user has little idea of what it would mean. Emacs: "We hit a magical limit! Raise the limit?" User: "Sure!" Emacs: "Now it worked!" I mean... why consult the user at all? :-) > Well, if I need to give my opinion on this, then blindly > increasing the limit ten-fold is something that'd make me worry about > a potential C stack overflow. Hm... On what architectures is there a potential for a C stack overflow? I thought that these days, C stack overflows basically didn't happened, and we only had the max-specpdl-size as a sanity check to avoid deep lisp backtraces and stuff, but I may well have misunderstood things. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 13 08:16:10 2018 Received: (at 30675) by debbugs.gnu.org; 13 Apr 2018 12:16:10 +0000 Received: from localhost ([127.0.0.1]:49161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6xcc-00034h-KX for submit@debbugs.gnu.org; Fri, 13 Apr 2018 08:16:09 -0400 Received: from mail-io0-f172.google.com ([209.85.223.172]:33241) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6xcX-00033s-6b for 30675@debbugs.gnu.org; Fri, 13 Apr 2018 08:16:05 -0400 Received: by mail-io0-f172.google.com with SMTP id p139so9985015iod.0 for <30675@debbugs.gnu.org>; Fri, 13 Apr 2018 05:16:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=WqNhv8P6kuXFyjPZSBVuWhG5pt/e+IN47bz8q3g5ELI=; b=g7pilupQ/iXk19+f8Med7LA63oIxDHfnaXrZ2XsRwRy8gJbcPqIe8K90fGdG8LmudQ 9GsJkwQpq7HqajBFJ1iegG7mVMpLbgW9HRaKtmCAxT7KGmPmc4+5psTvj2xo46VIuDlp dJCozTIkA8wSB1MtgG4oVtIElrtVM9RPVpA848tHtfsH8e5+MDBPNCdkQQ0yTF7t6b6h c3ReqzryqA1tLlXXcOZqv6RlmLhsCzvqPRg0btGfvxWKvDyYjzwoYO2eKz3Swj9v9mBn ah54rKFYIg1JSqSvSl1g34iXsriotyuJ8seYvjUaAjyq6BCn53jcBHORKdkyzFXfhQQ7 kOAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=WqNhv8P6kuXFyjPZSBVuWhG5pt/e+IN47bz8q3g5ELI=; b=DJgIJAg5yYzEc3jWVFbHdcJF6Wkz2jv+x7TXZT8CJYM/LOS/O/nQagTvw9tdFj5p0e 1y/Y8QAkK7m3Z9O0RD8XGN8+IEaf4dB3wTyReSwiAjNrv2lLQKYtK7qYOhmP+hZ116Gg g/b4OcsPext00+AfkyLSkc1ERqqp0Jmz6AnxafEYOljfokEk5mbCmugTmtfzYiYAJX3c YSk1naRPIdFSMVl2DgJXoPGb13ginV+e1WI/1Ep9gTmhwWBzsQoD6v3PJrFSrXQR5V4D XyO2Z7Twu78j62V/REYSZ9LvAd2d5ommd2iGU3MrwPGhvu4Zup4i/Y4S35iUE1DDkU9T KfQg== X-Gm-Message-State: ALQs6tByos1kjh/3yIvy6wBxqZ0mbK92hnTMlz1hvEDRGGwZVCyYRzHa bxl4j+6w5b5kjGycSgM71i+TKA== X-Google-Smtp-Source: AIpwx4+l06SDCMH0A5q82hDpFrIzvhDYT1S1/sgKTPJNWD99w1GcffBEnU+cXCUxLCgrN+XLbH231Q== X-Received: by 10.107.48.143 with SMTP id w137mr2816044iow.40.1523621755697; Fri, 13 Apr 2018 05:15:55 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id z71-v6sm2593570ita.0.2018.04.13.05.15.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 13 Apr 2018 05:15:54 -0700 (PDT) From: Noam Postavsky To: Lars Ingebrigtsen Subject: Re: bug#30675: Ask the user what to do when shr-make-table: Variable binding depth exceeds max-specpdl-size References: <877eqwbqvc.fsf@jidanni.org> <87po4n19q0.fsf_-_@jidanni.org> <87bmeoc7e4.fsf@mouse.gnus.org> <87k1tc3r82.fsf@jidanni.org> <87h8ogar2w.fsf@mouse.gnus.org> <83r2nj5uaa.fsf@gnu.org> <87fu3z9vjt.fsf@mouse.gnus.org> Date: Fri, 13 Apr 2018 08:15:53 -0400 In-Reply-To: <87fu3z9vjt.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Fri, 13 Apr 2018 13:48:22 +0200") Message-ID: <87zi27jo92.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30675 Cc: Eli Zaretskii , 30675@debbugs.gnu.org, jidanni@jidanni.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Hm... On what architectures is there a potential for a C stack > overflow? I thought that these days, C stack overflows basically didn't > happened, and we only had the max-specpdl-size as a sanity check to > avoid deep lisp backtraces and stuff, but I may well have misunderstood > things. The default stack size soft ulimit on GNU/Linux seems to be 8MB, Emacs tries to increase the limit by some fixed amount. It can be set to unlimited (I wouldn't expect most users to do that though). On macOS, there seems to be a hard limit of 64MB, so setting to unlimited doesn't work. Recent changes to Emacs have caused `read' to use more stack space, so it's definitely possible to hit the limits when reading a deeply nested structure (see bugs #27571 and #27779). Not sure how likely it is when reading deeply nested HTML, but I'm sure if you increase max-specpdl-size enough with the right HTML page you can manage it :) From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 13 08:33:05 2018 Received: (at 30675) by debbugs.gnu.org; 13 Apr 2018 12:33:05 +0000 Received: from localhost ([127.0.0.1]:49211 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6xt3-0005To-3Y for submit@debbugs.gnu.org; Fri, 13 Apr 2018 08:33:05 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:50365) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6xt1-0005Tg-DU for 30675@debbugs.gnu.org; Fri, 13 Apr 2018 08:33:03 -0400 Received: from 46.67.12.60.tmi.telenormobil.no ([46.67.12.60] helo=corrigan) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1f6xsx-00071o-Bc; Fri, 13 Apr 2018 14:33:01 +0200 Received: from larsi by corrigan with local (Exim 4.89) (envelope-from ) id 1f6xsr-0008HU-9t; Fri, 13 Apr 2018 14:32:53 +0200 From: Lars Ingebrigtsen To: Noam Postavsky Subject: Re: bug#30675: Ask the user what to do when shr-make-table: Variable binding depth exceeds max-specpdl-size References: <877eqwbqvc.fsf@jidanni.org> <87po4n19q0.fsf_-_@jidanni.org> <87bmeoc7e4.fsf@mouse.gnus.org> <87k1tc3r82.fsf@jidanni.org> <87h8ogar2w.fsf@mouse.gnus.org> <83r2nj5uaa.fsf@gnu.org> <87fu3z9vjt.fsf@mouse.gnus.org> <87zi27jo92.fsf@gmail.com> Date: Fri, 13 Apr 2018 14:32:52 +0200 In-Reply-To: <87zi27jo92.fsf@gmail.com> (Noam Postavsky's message of "Fri, 13 Apr 2018 08:15:53 -0400") Message-ID: <87sh7z8ex7.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30675 Cc: Eli Zaretskii , 30675@debbugs.gnu.org, jidanni@jidanni.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Noam Postavsky writes: > The default stack size soft ulimit on GNU/Linux seems to be 8MB, Emacs > tries to increase the limit by some fixed amount. It can be set to > unlimited (I wouldn't expect most users to do that though). On macOS, > there seems to be a hard limit of 64MB, so setting to unlimited doesn't > work. I see. > Recent changes to Emacs have caused `read' to use more stack space, so > it's definitely possible to hit the limits when reading a deeply nested > structure (see bugs #27571 and #27779). Not sure how likely it is when > reading deeply nested HTML, but I'm sure if you increase > max-specpdl-size enough with the right HTML page you can manage it :) Yeah, and that makes me want to query the user even less. Emacs: "Do this thing you have no idea what is?" User: "Yes." Emacs: *CRASH*. So perhaps we should just leave things be and not increase the variable and not prompt the user... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 13 08:40:26 2018 Received: (at 30675) by debbugs.gnu.org; 13 Apr 2018 12:40:26 +0000 Received: from localhost ([127.0.0.1]:49235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6y07-0005fX-Pi for submit@debbugs.gnu.org; Fri, 13 Apr 2018 08:40:25 -0400 Received: from homie.mail.dreamhost.com ([208.97.132.208]:56971 helo=homiemail-a2.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6y06-0005fP-2d for 30675@debbugs.gnu.org; Fri, 13 Apr 2018 08:40:22 -0400 Received: from homiemail-a2.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a2.g.dreamhost.com (Postfix) with ESMTP id 2B65228006E; Fri, 13 Apr 2018 05:40:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=jidanni.org; h=from:to:cc :subject:references:date:message-id:mime-version:content-type; s=jidanni.org; bh=e/Rxx3ETFprioYhouwRSCMBv0EA=; b=U1hv4lX8ro69H va08eQSiZpOcpSMmKdvRcAAotQfp1AqUkchUqJZjLXB0iyf8DteKfZMqieF0Lw1n CAmIHqmjIfZ4DjKyX4Fgcohc1ee2feY0viGCCaKIKUJP6xdLgA6cRBuIX5Qclgpr 9WuISwx/GZJ6SETc6phaoi0dpbIesA= Received: from jidanni.org (111-246-97-203.dynamic-ip.hinet.net [111.246.97.203]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: jidanni@jidanni.org) by homiemail-a2.g.dreamhost.com (Postfix) with ESMTPSA id DF4CF280069; Fri, 13 Apr 2018 05:40:20 -0700 (PDT) From: =?utf-8?B?56mN5Li55bC8?= Dan Jacobson To: Eli Zaretskii Subject: Re: bug#30675: Ask the user what to do when shr-make-table: Variable binding depth exceeds max-specpdl-size References: <877eqwbqvc.fsf@jidanni.org> <87po4n19q0.fsf_-_@jidanni.org> <87bmeoc7e4.fsf@mouse.gnus.org> <87k1tc3r82.fsf@jidanni.org> <87h8ogar2w.fsf@mouse.gnus.org> <83r2nj5uaa.fsf@gnu.org> Date: Fri, 13 Apr 2018 20:40:18 +0800 Message-ID: <87y3hrb7pp.fsf@jidanni.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 30675 Cc: Lars Ingebrigtsen , 30675@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) EZ> some slack. Bonus points for providing a defcustom with the factor, EZ> so that users could change that. We always want to change it just once, to see if that would help reading the web page we were trying to read. We don't want to keep it changed, so that random websites go wild without it asking us. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 13 08:43:38 2018 Received: (at 30675) by debbugs.gnu.org; 13 Apr 2018 12:43:39 +0000 Received: from localhost ([127.0.0.1]:49239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6y3B-0005kN-9H for submit@debbugs.gnu.org; Fri, 13 Apr 2018 08:43:36 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6y36-0005k8-Mh for 30675@debbugs.gnu.org; Fri, 13 Apr 2018 08:43:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f6y2w-00049G-LO for 30675@debbugs.gnu.org; Fri, 13 Apr 2018 08:43:23 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46088) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f6y2w-00049B-HX; Fri, 13 Apr 2018 08:43:18 -0400 Received: from [176.228.60.248] (port=2684 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1f6y2v-0006P4-6h; Fri, 13 Apr 2018 08:43:17 -0400 Date: Fri, 13 Apr 2018 15:43:14 +0300 Message-Id: <83muy75lb1.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-reply-to: <87fu3z9vjt.fsf@mouse.gnus.org> (message from Lars Ingebrigtsen on Fri, 13 Apr 2018 13:48:22 +0200) Subject: Re: bug#30675: Ask the user what to do when shr-make-table: Variable binding depth exceeds max-specpdl-size References: <877eqwbqvc.fsf@jidanni.org> <87po4n19q0.fsf_-_@jidanni.org> <87bmeoc7e4.fsf@mouse.gnus.org> <87k1tc3r82.fsf@jidanni.org> <87h8ogar2w.fsf@mouse.gnus.org> <83r2nj5uaa.fsf@gnu.org> <87fu3z9vjt.fsf@mouse.gnus.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30675 Cc: 30675@debbugs.gnu.org, jidanni@jidanni.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Lars Ingebrigtsen > Cc: jidanni@jidanni.org, 30675@debbugs.gnu.org > Date: Fri, 13 Apr 2018 13:48:22 +0200 > > Eli Zaretskii writes: > > > I'd feel much better with a lower factor, e.g. some value that is just > > enough to cover this case plus some slack. Bonus points for providing > > a defcustom with the factor, so that users could change that. > > The problem is that HTML may nest arbitrarily deep, so there isn't > really any way to cover this completely. But the larger the stack size > is, the lower the possibility for hitting the limit is. > > FWIW, I haven't hit the limit in about a year, so it's rare for people > to encounter HTML that's that deeply nested. Which probably means ten-fold increase is too much. Would increasing the limit twice fix this problem? If so, then let's do that in shr.el. > why consult the user at all? :-) Because there's a possibility of infinite recursion. So the question actually boils down to "how much do you trust the code which caused this?" And I'm guessing the answer will tend to be NO with each additional prompt from the same command. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 13 11:34:24 2018 Received: (at 30675) by debbugs.gnu.org; 13 Apr 2018 15:34:24 +0000 Received: from localhost ([127.0.0.1]:50770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f70iV-0001A8-Ow for submit@debbugs.gnu.org; Fri, 13 Apr 2018 11:34:23 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:55129) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f70iV-0001A1-3s for 30675@debbugs.gnu.org; Fri, 13 Apr 2018 11:34:23 -0400 Received: from 46.67.12.60.tmi.telenormobil.no ([46.67.12.60] helo=corrigan) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1f70iO-00049B-Si; Fri, 13 Apr 2018 17:34:18 +0200 Received: from larsi by corrigan with local (Exim 4.89) (envelope-from ) id 1f70iJ-0001Oc-8J; Fri, 13 Apr 2018 17:34:11 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#30675: Ask the user what to do when shr-make-table: Variable binding depth exceeds max-specpdl-size References: <877eqwbqvc.fsf@jidanni.org> <87po4n19q0.fsf_-_@jidanni.org> <87bmeoc7e4.fsf@mouse.gnus.org> <87k1tc3r82.fsf@jidanni.org> <87h8ogar2w.fsf@mouse.gnus.org> <83r2nj5uaa.fsf@gnu.org> <87fu3z9vjt.fsf@mouse.gnus.org> <83muy75lb1.fsf@gnu.org> Date: Fri, 13 Apr 2018 17:34:10 +0200 In-Reply-To: <83muy75lb1.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 13 Apr 2018 15:43:14 +0300") Message-ID: <87a7u7w26l.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30675 Cc: 30675@debbugs.gnu.org, jidanni@jidanni.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > Which probably means ten-fold increase is too much. Would increasing > the limit twice fix this problem? If so, then let's do that in > shr.el. I'm thinking that any increase might be unsafe, and that we should just leave the variable be. We don't want to crash an Emacs where the user has already increased the limit. > Because there's a possibility of infinite recursion. So the question > actually boils down to "how much do you trust the code which caused > this?" And I'm guessing the answer will tend to be NO with each > additional prompt from the same command. That's true. But if there's a chance that Emacs may crash by the user holding down `y' a bit, then that's no fun, either... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 15 13:02:25 2018 Received: (at 30675) by debbugs.gnu.org; 15 Apr 2018 17:02:25 +0000 Received: from localhost ([127.0.0.1]:54360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7l2k-0004S0-01 for submit@debbugs.gnu.org; Sun, 15 Apr 2018 13:02:25 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:37242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7l2d-0004Rn-PO for 30675@debbugs.gnu.org; Sun, 15 Apr 2018 13:02:19 -0400 Received: from 46.67.12.60.tmi.telenormobil.no ([46.67.12.60] helo=corrigan) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1f7l2W-00077c-Ee; Sun, 15 Apr 2018 19:02:14 +0200 Received: from larsi by corrigan with local (Exim 4.89) (envelope-from ) id 1f7l2O-0003yM-Cm; Sun, 15 Apr 2018 19:02:00 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#30675: Ask the user what to do when shr-make-table: Variable binding depth exceeds max-specpdl-size References: <877eqwbqvc.fsf@jidanni.org> <87po4n19q0.fsf_-_@jidanni.org> <87bmeoc7e4.fsf@mouse.gnus.org> <87k1tc3r82.fsf@jidanni.org> <87h8ogar2w.fsf@mouse.gnus.org> <83r2nj5uaa.fsf@gnu.org> <87fu3z9vjt.fsf@mouse.gnus.org> <83muy75lb1.fsf@gnu.org> <87a7u7w26l.fsf@mouse.gnus.org> Date: Sun, 15 Apr 2018 19:02:00 +0200 In-Reply-To: <87a7u7w26l.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Fri, 13 Apr 2018 17:34:10 +0200") Message-ID: <87muy49zef.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30675 Cc: 30675@debbugs.gnu.org, jidanni@jidanni.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: >> Because there's a possibility of infinite recursion. So the question >> actually boils down to "how much do you trust the code which caused >> this?" And I'm guessing the answer will tend to be NO with each >> additional prompt from the same command. > > That's true. But if there's a chance that Emacs may crash by the user > holding down `y' a bit, then that's no fun, either... I've now done this on master, so we'll see how this works out in practice. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 15 13:02:14 2018 Received: (at control) by debbugs.gnu.org; 15 Apr 2018 17:02:15 +0000 Received: from localhost ([127.0.0.1]:54357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7l2c-0004Rf-PQ for submit@debbugs.gnu.org; Sun, 15 Apr 2018 13:02:14 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:37235) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7l2Z-0004RV-JU for control@debbugs.gnu.org; Sun, 15 Apr 2018 13:02:13 -0400 Received: from 46.67.12.60.tmi.telenormobil.no ([46.67.12.60] helo=corrigan) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1f7l2W-00079y-E5 for control@debbugs.gnu.org; Sun, 15 Apr 2018 19:02:10 +0200 Received: from larsi by corrigan with local (Exim 4.89) (envelope-from ) id 1f7l2Q-0003yQ-Ll for control@debbugs.gnu.org; Sun, 15 Apr 2018 19:02:02 +0200 To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #30675 Message-Id: Date: Sun, 15 Apr 2018 19:02:02 +0200 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 30675 fixed close 30675 From unknown Fri Sep 19 16:38:58 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 14 May 2018 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator