From unknown Sat Sep 13 02:34:35 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#30660 <30660@debbugs.gnu.org> To: bug#30660 <30660@debbugs.gnu.org> Subject: Status: mention describe-bindings on (info "(emacs) Keymaps") Reply-To: bug#30660 <30660@debbugs.gnu.org> Date: Sat, 13 Sep 2025 09:34:35 +0000 retitle 30660 mention describe-bindings on (info "(emacs) Keymaps") reassign 30660 emacs submitter 30660 =E7=A9=8D=E4=B8=B9=E5=B0=BC Dan Jacobson severity 30660 wishlist thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 28 17:44:17 2018 Received: (at submit) by debbugs.gnu.org; 28 Feb 2018 22:44:17 +0000 Received: from localhost ([127.0.0.1]:38041 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1erASN-0000Go-7y for submit@debbugs.gnu.org; Wed, 28 Feb 2018 17:44:15 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1erASJ-0000GP-Qf for submit@debbugs.gnu.org; Wed, 28 Feb 2018 17:44:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1erARL-0003Nj-9Q for submit@debbugs.gnu.org; Wed, 28 Feb 2018 17:43:13 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:33458) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1erARL-0003Mx-1H for submit@debbugs.gnu.org; Wed, 28 Feb 2018 17:43:11 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48185) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1erARJ-0005ce-7T for bug-gnu-emacs@gnu.org; Wed, 28 Feb 2018 17:43:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1erARH-0003FS-S9 for bug-gnu-emacs@gnu.org; Wed, 28 Feb 2018 17:43:09 -0500 Received: from homie.mail.dreamhost.com ([208.97.132.208]:57177 helo=homiemail-a60.g.dreamhost.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1erARH-0003Cl-F9 for bug-gnu-emacs@gnu.org; Wed, 28 Feb 2018 17:43:07 -0500 Received: from homiemail-a60.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a60.g.dreamhost.com (Postfix) with ESMTP id 78022282069 for ; Wed, 28 Feb 2018 14:43:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=jidanni.org; h=from:to :subject:date:message-id:mime-version:content-type; s= jidanni.org; bh=+Ak5emm5pmKH4I7qDQ0HJT8U2GA=; b=k7SkXqpE+aKu15xl jx+Z8ztBlu+mF8VKzeiGV7NYY4IQoUgLWLcIQcyOGKqxKYLTWcYV9HfA8msKonoa 8rhfWezMt2FO5YRAbmLjIBTa8P5ulxIvxwuZtb0rLLdFeIJUUlrOx5eCyXMsiFH6 dGIVD7UzQc4R+5rXRzQM4Q12+Zo= Received: from jidanni.org (114-46-61-159.dynamic-ip.hinet.net [114.46.61.159]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: jidanni@jidanni.org) by homiemail-a60.g.dreamhost.com (Postfix) with ESMTPSA id 7C0CA282068 for ; Wed, 28 Feb 2018 14:43:05 -0800 (PST) From: =?utf-8?B?56mN5Li55bC8?= Dan Jacobson To: bug-gnu-emacs@gnu.org Subject: mention describe-bindings on (info "(emacs) Keymaps") Date: Thu, 01 Mar 2018 04:25:55 +0800 Message-ID: <87lgfc3lpo.fsf@jidanni.org> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) (info "(emacs) Keymaps") should mention the best way to view a keymap. If the user just uses describe-variable, he will see (67108910 . flyspell-auto-correct-word) etc. So mention he should use describe-bindings. From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 28 18:29:57 2018 Received: (at 30660) by debbugs.gnu.org; 28 Feb 2018 23:29:57 +0000 Received: from localhost ([127.0.0.1]:38051 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1erBAa-0001Kt-P4 for submit@debbugs.gnu.org; Wed, 28 Feb 2018 18:29:56 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:43686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1erBAY-0001Kf-Td for 30660@debbugs.gnu.org; Wed, 28 Feb 2018 18:29:55 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w1SNRFfQ164730; Wed, 28 Feb 2018 23:29:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=Dc+5sEAJLo/thcmSPGDGbt4PUVkpRapmWzTCSAXHc3s=; b=iizkaAP4lS+rN8guOLX8nUhnwX+9cU9bN8xU4f0ee+hz3xZj1/dDgjz6s5ZzIJERplrD czusiTWxns7F/9qo90LI0cEzYKs3RCKau83kycEGF0wZJEYY0i8xrSOQ1grdyV0NENsX Y/vIZ288Nz9jpvimBvBArwzRJ+mhJj7SD1fbvkeZxn0RQXl7rczCk0ITeLoTtyHnCn4q 6tj8Z1jvDsBk3EYi3q5ZiJ2wwIuIiwBYJ0M2L+VaNNxkBbabBYwEZnKg2wV8Yi2IW7sV 4bYo0y3kRpS1pPsUyZs/0kI2Sf/DQuhZItLRCljk0ZPCMulFQMwQOUnRf/u+5beKkLIZ eg== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp2120.oracle.com with ESMTP id 2ge5jj04fd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 28 Feb 2018 23:29:48 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w1SNTl4t015507 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 28 Feb 2018 23:29:47 GMT Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w1SNTlfJ031825; Wed, 28 Feb 2018 23:29:47 GMT MIME-Version: 1.0 Message-ID: <1bb8d816-6ec6-47d1-8e49-d3bc1e756784@default> Date: Wed, 28 Feb 2018 15:29:45 -0800 (PST) From: Drew Adams To: =?iso-2022-jp?B?GyRCQFFDMEZ0GyhCIERhbiBKYWNvYnNvbg==?= , 30660@debbugs.gnu.org Subject: RE: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") References: <87lgfc3lpo.fsf@jidanni.org> In-Reply-To: <87lgfc3lpo.fsf@jidanni.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4654.0 (x86)] Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8818 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=982 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1802280280 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30660 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) > (info "(emacs) Keymaps") should mention the best way to view a keymap. > If the user just uses describe-variable, he will see > (67108910 . flyspell-auto-correct-word) > etc. So mention he should use `describe-bindings'. `describe-bindings' does not describe the bindings of a given keymap. S?he should use `describe-keymap' (`C-h M-k'), from `help-fns+.el'. It describes the bindings in a keymap in the usual human-readable way. You are prompted for a keymap variable (e.g., `ctl-x-map`), with completion. (Non-interactively, the argument can be a keymap itself or a keymap variable.) This or similar code should be in vanilla Emacs. (I've offered any and all of my code.) https://www.emacswiki.org/emacs/download/help-fns%2b.el From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 23 03:19:03 2019 Received: (at 30660) by debbugs.gnu.org; 23 Aug 2019 07:19:03 +0000 Received: from localhost ([127.0.0.1]:39026 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i13qg-0006dd-LL for submit@debbugs.gnu.org; Fri, 23 Aug 2019 03:19:03 -0400 Received: from mail-pf1-f181.google.com ([209.85.210.181]:34218) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i13qd-0006d9-TT for 30660@debbugs.gnu.org; Fri, 23 Aug 2019 03:19:00 -0400 Received: by mail-pf1-f181.google.com with SMTP id b24so5881956pfp.1 for <30660@debbugs.gnu.org>; Fri, 23 Aug 2019 00:18:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc :content-transfer-encoding; bh=e3N2b2+Gm4FpQ7UI7BJBcMhguy/C+ttrkan/2nuyaVs=; b=Is6xB5gnZxKcri/HTKy3CjLjCzhF2tC+RYnDEVbS7RgBv5P5Ob/eWR6u9KGQAZ7fZ5 eXadkzorNjlrHC0OLXHHcTJUlfljl4odWzm3oD8/6G0L8w5CnCCLs2KVV07duyx9viWV 8oVNXsLHXtWp54pTG4ZefRYfQtNFaS1vo/xk7r9or45r3CNDe/bFR/RS00GW57c+2nwZ jsi7AxhFliZ4aHXyLdViVC0aQe2Km1gqJIUqyK+iVeJN3+PepbF1ucuJEmNFdbrmDogr xN0ulTBhrCGvesaId9l8bGnmlLjhGaqky2evMShLSM/0Hr9XhmYwAPb+VnvTXx7zzNvR G0nw== X-Gm-Message-State: APjAAAXmIgoTR3YATvJdklamMQm76/bqRrdyk5Cx5Be/9XQcdgrJYRnW c9VJUiZuvbl1g9c2YwBsLZtnMg4Q+NA8Y+B4ofU= X-Google-Smtp-Source: APXvYqyEBSEcXCVX3EpkLGAP/Dvh+txoXEx6sjGTHDo5MZdSuG/hN0MNKkvIN7EVHurZS86czEAIcTP+VCQ7DEjLDA8= X-Received: by 2002:a63:4c5c:: with SMTP id m28mr2817642pgl.333.1566544734035; Fri, 23 Aug 2019 00:18:54 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Fri, 23 Aug 2019 09:18:43 +0200 Message-ID: Subject: Re: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") To: Drew Adams Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 30660 Cc: 30660@debbugs.gnu.org, =?UTF-8?B?56mN5Li55bC8IERhbiBKYWNvYnNvbg==?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Drew Adams writes: >> (info "(emacs) Keymaps") should mention the best way to view a keymap. >> If the user just uses describe-variable, he will see >> (67108910 . flyspell-auto-correct-word) >> etc. So mention he should use `describe-bindings'. > > `describe-bindings' does not describe the bindings of a given > keymap. > > S?he should use `describe-keymap' (`C-h M-k'), from `help-fns+.el'. > > It describes the bindings in a keymap in the usual human-readable > way. You are prompted for a keymap variable (e.g., `ctl-x-map`), > with completion. (Non-interactively, the argument can be a keymap > itself or a keymap variable.) > > This or similar code should be in vanilla Emacs. (I've offered > any and all of my code.) > > https://www.emacswiki.org/emacs/download/help-fns%2b.el I copied and evaluated the describe-keymap function, but when I typed M-x describe-keymap I got the following error: save-current-buffer: Symbol=E2=80=99s function definition is void: Info-make-manuals-xref I couldn't find the definition of a function by that name in the file you indicated, so I'm guessing there's some dependencies involved and that I don't have. Could you provide a version of this function which works on current master without requiring these extra packages? Thanks, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 23 14:44:37 2019 Received: (at 30660) by debbugs.gnu.org; 23 Aug 2019 18:44:37 +0000 Received: from localhost ([127.0.0.1]:41192 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1EY9-0003Yd-Ef for submit@debbugs.gnu.org; Fri, 23 Aug 2019 14:44:37 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:54460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1EY7-0003YH-0d for 30660@debbugs.gnu.org; Fri, 23 Aug 2019 14:44:36 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7NIXlXU108554; Fri, 23 Aug 2019 18:44:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type; s=corp-2019-08-05; bh=mnWI4M3s6M0aCquseLoUranUoUtJnnc7uJKJ7Acw8Sg=; b=PL6HAMi58y4a/nGF4ddno/sUo0TI7t93Kr894BvDvHtoBDGe1Sx6m5UScZeypTFnSchr /HsRYfoqwDsLH6ioc//C66bFmZMvqqg1jRZw2mGlSnSCqVrdw9SwehCpT0dsIAw3I81A 1B4gz+vLWy8RsnZApYc6Q+UbNy/TGQLaKsDV2TEHUuZ+fvpWJ9UJARX7v1yILW/5Hwzj z/qrSYeyzbwTla7e0j0tGRWL+tte1GwBFTsvdu+AfKWdwlB/3yf7y4EMYg6+FhTnJ/zg rUdo1G0IygTENqKKLxAqCtVcL5jxw6ZQBZ209zx8ih/2kJWT5V1B3yX2sBRnyfaxR9vI vQ== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2130.oracle.com with ESMTP id 2ue90u6jkv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 23 Aug 2019 18:44:28 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7NIXN1c126057; Fri, 23 Aug 2019 18:44:27 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3020.oracle.com with ESMTP id 2uj1y0t6hu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 23 Aug 2019 18:44:27 +0000 Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x7NIiRjB007707; Fri, 23 Aug 2019 18:44:27 GMT MIME-Version: 1.0 Message-ID: Date: Fri, 23 Aug 2019 11:44:25 -0700 (PDT) From: Drew Adams To: Stefan Kangas Subject: RE: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") References: In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4873.0 (x86)] Content-Type: multipart/mixed; boundary="__1566585866880271493abhmp0010.oracle.com" X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9358 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908230175 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9358 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908230175 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 30660 Cc: 30660@debbugs.gnu.org, =?utf-8?B?56mN5Li55bC8IERhbiBKYWNvYnNvbg==?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --__1566585866880271493abhmp0010.oracle.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable > > `describe-bindings' does not describe the bindings of a given > > keymap. > > > > S?he should use `describe-keymap' (`C-h M-k'), from `help-fns+.el'. > > > > It describes the bindings in a keymap in the usual human-readable > > way. You are prompted for a keymap variable (e.g., `ctl-x-map`), > > with completion. (Non-interactively, the argument can be a keymap > > itself or a keymap variable.) > > > > This or similar code should be in vanilla Emacs. (I've offered > > any and all of my code.) > > > > https://urldefense.proofpoint.com/v2/url?u=3Dhttps- > 3A__www.emacswiki.org_emacs_download_help-2Dfns- > 252b.el&d=3DDwIFaQ&c=3DRoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=3DkI= 3P6l > jGv6CTHIKju0jqInF6AOwMCYRDQUmqX22rJ98&m=3DyA0xm3W_AykCUU9THjbJlpxhVhQlA3X > AncZSWRe2Wc0&s=3DP11PKX0Nhl4PaaXOh-0ZYcfDDhlprpw4pnWG5QqizvQ&e=3D >=20 > I copied and evaluated the describe-keymap function, but when I typed > M-x describe-keymap I got the following error: >=20 > save-current-buffer: Symbol=E2=80=99s function definition is void: > Info-make-manuals-xref >=20 > I couldn't find the definition of a function by that name in the file > you indicated, so I'm guessing there's some dependencies involved and > that I don't have. Could you provide a version of this function which > works on current master without requiring these extra packages? `Info-make-manuals-xref' _is_ defined in help-fns+.el. And no extra packages are needed for help-fns+.el. But adding the functionality of `Info-make-manuals-xref' is not necessarily something that vanilla Emacs would want now. That should probably be discussed separately. Similarly, there are other features used by `describe-keymap' that I'm not sure you want to add now to vanilla Emacs. And you definitely don't need the code that supports older Emacs versions. Bottom line, if you want to add only bare-bones `describe-keymap' to vanilla Emacs then just use the attached definition. --__1566585866880271493abhmp0010.oracle.com Content-Type: application/octet-stream; name="throw-describe-keymap-for-vanilla.el" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="throw-describe-keymap-for-vanilla.el" KGRlZnVuIGRlc2NyaWJlLWtleW1hcCAoa2V5bWFwICZvcHRpb25hbCBzZWFyY2gtc3ltYm9scy1w KSA7IEJvdW5kIHRvIGBDLWggTS1rJwogICJEZXNjcmliZSBrZXkgYmluZGluZ3MgaW4gS0VZTUFQ LgpJbnRlcmFjdGl2ZWx5LCBwcm9tcHQgZm9yIGEgdmFyaWFibGUgdGhhdCBoYXMgYSBrZXltYXAg dmFsdWUuCkNvbXBsZXRpb24gaXMgYXZhaWxhYmxlIGZvciB0aGUgdmFyaWFibGUgbmFtZS4KCk5v bi1pbnRlcmFjdGl2ZWx5OgoqIEtFWU1BUCBjYW4gYmUgc3VjaCBhIGtleW1hcCB2YXJpYWJsZSBv ciBhIGtleW1hcC4KKiBOb24tbmlsIG9wdGlvbmFsIGFyZyBTRUFSQ0gtU1lNQk9MUy1QIG1lYW5z IHRoYXQgaWYgS0VZTUFQIGlzIG5vdCBhCiAgc3ltYm9sIHRoZW4gc2VhcmNoIGFsbCB2YXJpYWJs ZXMgZm9yIG9uZSB3aG9zZSB2YWx1ZSBpcyBLRVlNQVAuIgogIChpbnRlcmFjdGl2ZSAobGlzdCAo aW50ZXJuIChjb21wbGV0aW5nLXJlYWQgIktleW1hcDogIiBvYmFycmF5CiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAobGFtYmRhIChtKSAoYW5kIChib3VuZHAg bSkgIChrZXltYXBwIChzeW1ib2wtdmFsdWUgbSkpKSkKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHQgbmlsICd2YXJpYWJsZS1uYW1lLWhpc3RvcnkpKSkpCiAg KHVubGVzcyAoYW5kIChzeW1ib2xwIGtleW1hcCkgIChib3VuZHAga2V5bWFwKSAgKGtleW1hcHAg KHN5bWJvbC12YWx1ZSBrZXltYXApKSkKICAgIChpZiAobm90IChrZXltYXBwIGtleW1hcCkpCiAg ICAgICAgKGVycm9yICIlc290IGEga2V5bWFwJXMiCiAgICAgICAgICAgICAgIChpZiAoc3ltYm9s cCBrZXltYXApIChmb3JtYXQgImAlUycgaXMgbiIga2V5bWFwKSAiTiIpCiAgICAgICAgICAgICAg IChpZiAoc3ltYm9scCBrZXltYXApICIgdmFyaWFibGUiICIiKSkKICAgICAgKGxldCAoKHN5bSAg bmlsKSkKICAgICAgICAod2hlbiBzZWFyY2gtc3ltYm9scy1wCiAgICAgICAgICAoc2V0cSBzeW0g IChjYXRjaCAnZGVzY3JpYmUta2V5bWFwCiAgICAgICAgICAgICAgICAgICAgICAgKG1hcGF0b21z IChsYW1iZGEgKHN5bWIpICh3aGVuIChhbmQgKGJvdW5kcCBzeW1iKQogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoZXEgKHN5bWJvbC12YWx1ZSBz eW1iKSBrZXltYXApCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIChub3QgKGVxIHN5bWIgJ2tleW1hcCkpCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICh0aHJvdyAnZGVzY3JpYmUta2V5bWFwIHN5 bWIpKSkpKQogICAgICAgICAgICAgICAgICAgICAgIG5pbCkpKQogICAgICAgICh1bmxlc3Mgc3lt CiAgICAgICAgICAoc2V0cSBzeW0gIChnZW50ZW1wICJLRVlNQVAgT0JKRUNUIChubyB2YXJpYWJs ZSkgIikpCiAgICAgICAgICAoc2V0IHN5bSBrZXltYXApKQogICAgICAgIChzZXRxIGtleW1hcCAg c3ltKSkpKQogIChzZXRxIGtleW1hcCAgKG9yIChpZ25vcmUtZXJyb3JzIChpbmRpcmVjdC12YXJp YWJsZSBrZXltYXApKSAga2V5bWFwKSkgOyBGb2xsb3cgYWxpYXNpbmcuCiAgKGxldCogKChuYW1l ICAoc3ltYm9sLW5hbWUga2V5bWFwKSkKICAgICAgICAgKGRvYyAgIChsZXQgKChyYXctZG9jICAo ZG9jdW1lbnRhdGlvbi1wcm9wZXJ0eSBrZXltYXAgJ3ZhcmlhYmxlLWRvY3VtZW50YXRpb24gJ1JB VykpKQogICAgICAgICAgICAgICAgICAoc3Vic3RpdHV0ZS1jb21tYW5kLWtleXMgcmF3LWRvYykp KQogICAgICAgICAoZG9jICAgKGFuZCAobm90IChlcXVhbCAiIiBkb2MpKSAgZG9jKSkpCiAgICAo aGVscC1zZXR1cC14cmVmIChsaXN0ICMnZGVzY3JpYmUta2V5bWFwIGtleW1hcCkgKGNhbGxlZC1p bnRlcmFjdGl2ZWx5LXAgJ2ludGVyYWN0aXZlKSkKICAgICh3aXRoLWhlbHAtd2luZG93IChoZWxw LWJ1ZmZlcikKICAgICAgKHByaW5jIG5hbWUpICh0ZXJwcmkpIChwcmluYyAobWFrZS1zdHJpbmcg KGxlbmd0aCBuYW1lKSA/LSkpICh0ZXJwcmkpICh0ZXJwcmkpCiAgICAgICh3aGVuIGRvYyAocHJp bmMgZG9jKSAodGVycHJpKSAodGVycHJpKSkKICAgICAgOzsgVXNlIGBpbnNlcnQnIGluc3RlYWQg b2YgYHByaW5jJywgc28gY29udHJvbCBjaGFycyAoZS5nLiBcMzc3KSBpbnNlcnQgY29ycmVjdGx5 LgogICAgICAod2l0aC1jdXJyZW50LWJ1ZmZlciAiKkhlbHAqIiAoaW5zZXJ0IChzdWJzdGl0dXRl LWNvbW1hbmQta2V5cyAoY29uY2F0ICJcXHsiIG5hbWUgIn0iKSkpKSkpKQo= --__1566585866880271493abhmp0010.oracle.com-- From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 23 18:40:55 2019 Received: (at 30660) by debbugs.gnu.org; 23 Aug 2019 22:40:55 +0000 Received: from localhost ([127.0.0.1]:41386 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1IEo-00063K-Q7 for submit@debbugs.gnu.org; Fri, 23 Aug 2019 18:40:55 -0400 Received: from mail-pf1-f180.google.com ([209.85.210.180]:41162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1IEm-00062y-CM for 30660@debbugs.gnu.org; Fri, 23 Aug 2019 18:40:52 -0400 Received: by mail-pf1-f180.google.com with SMTP id 196so7412220pfz.8 for <30660@debbugs.gnu.org>; Fri, 23 Aug 2019 15:40:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3ciAnNhOIkRBHqfnxAisysAtqvlhlttzwAGVoa1sOow=; b=n1ct5x4BCnmMR26QeMBM8NAHN4T7nnv7n0pxOeNzVxX3vx0KqjVQ0OwQlzvzCwIl2o xOonGBRLYeuR4ckgslJvhXqqNxd5XBo/23GaBSbZYml7lL8yePw4O+3/EQvXv+bWQ+hG nLjeUCZW3HmLExFJP0ozHWsiP1SS3WyDSWn3RSwx5eiRhnB1exfKafzHcsS0NlZEOxxx gfZ4I7VxFmmLt78BZSMdYZo7z+xfCbPayJ4iQc6egjgL3MwenTWwH0fbh7h3U3zRsyUA kZx40czRs4yKHQp4XxfLpLWAMECbsMuU2VwKVvg70Lz8iCuR8l103sPM5Ay+D65WeIKC p5WQ== X-Gm-Message-State: APjAAAUx3R/ohGreTuaqvFQ/o48IveO1Z7hDGT55/RV1gFG0MBdz60x2 Ey3HZk4b0effaHDx3QMP4CKdbPJiOyCZI0Q9BEo= X-Google-Smtp-Source: APXvYqwW6e53atPzxflvwcLVIZSyUIP4Mlyscls5yW8aVQreGTeiSEK755bVPqTS8e8M7PZnm7+ackfq1LrtzZshfs0= X-Received: by 2002:a17:90a:fa8f:: with SMTP id cu15mr7605869pjb.119.1566600046444; Fri, 23 Aug 2019 15:40:46 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Stefan Kangas Date: Sat, 24 Aug 2019 00:40:34 +0200 Message-ID: Subject: Re: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") To: Drew Adams Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 30660 Cc: 30660@debbugs.gnu.org, =?UTF-8?B?56mN5Li55bC8IERhbiBKYWNvYnNvbg==?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Drew Adams writes: > `Info-make-manuals-xref' _is_ defined in > help-fns+.el. OK, sorry about that. I must have missed it. > Bottom line, if you want to add only bare-bones > `describe-keymap' to vanilla Emacs then just > use the attached definition. Thanks. I tried it, and I personally think it's a useful addition. Maybe others disagree. I was going to pack it up as a patch for review but I have some questions about the code first. > Non-interactively: > * KEYMAP can be such a keymap variable or a keymap. > * Non-nil optional arg SEARCH-SYMBOLS-P means that if KEYMAP is not a > symbol then search all variables for one whose value is KEYMAP." Is the purpose of SEARCH-SYMBOLS-P just to allow for calling it like this: (describe-keymap 'my-keymap t) (describe-keymap my-keymap t) And have it work automatically? Or am I missing something? Also see below. > (unless (and (symbolp keymap) (boundp keymap) (keymapp (symbol-value keymap))) > (if (not (keymapp keymap)) > (error "%sot a keymap%s" > (if (symbolp keymap) (format "`%S' is n" keymap) "N") > (if (symbolp keymap) " variable" "")) > (let ((sym nil)) > (when search-symbols-p > (setq sym (catch 'describe-keymap > (mapatoms (lambda (symb) (when (and (boundp symb) > (eq (symbol-value symb) keymap) > (not (eq symb 'keymap)) > (throw 'describe-keymap symb))))) > nil))) > (unless sym > (setq sym (gentemp "KEYMAP OBJECT (no variable) ")) > (set sym keymap)) > (setq keymap sym)))) I admit that I find this code a bit hard to follow. If I understand correctly, then most of this can be removed if we don't want to support SEARCH-SYMBOLS-P, and instead just require that the KEYMAP argument is a symbol. Is that correct or am I missing something? I'm sort of leaning towards simplifying this by removing the SEARCH-SYMBOLS-P argument, but I might not understand the use case here. If I'm missing something, could you please briefly describe the use case for that and if and why it's important to keep? > (setq keymap (or (ignore-errors (indirect-variable keymap)) keymap)) ; Follow aliasing. > (let* ((name (symbol-name keymap)) > (doc (let ((raw-doc (documentation-property keymap 'variable-documentation 'RAW))) > (substitute-command-keys raw-doc))) Why not just say (documentation-property keymap 'variable-documentation) without the 'RAW argument? That should have the same effect as passing the 'RAW argument and then calling substitute-command-keys on the result, AFAICT. > (doc (and (not (equal "" doc)) doc))) Is this to allow us to simply say (when doc ...) below instead of (when (not (equal "" doc)) ...) or am I missing something? Thanks, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 23 21:46:34 2019 Received: (at 30660) by debbugs.gnu.org; 24 Aug 2019 01:46:34 +0000 Received: from localhost ([127.0.0.1]:41442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1L8U-0004Vz-89 for submit@debbugs.gnu.org; Fri, 23 Aug 2019 21:46:34 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:42638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1L8P-0004Vj-Ht for 30660@debbugs.gnu.org; Fri, 23 Aug 2019 21:46:30 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7O1ijDd041212; Sat, 24 Aug 2019 01:46:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=2kq4oGy0YT4vY4A5nOlBTQwLN3Hpnhs91W6I5wbqZF4=; b=aKTn2bls6TuixHjUxme6aZcPOLyiTZGixpT2srUa4blufk6842h1+4ZLDU9HFajhwvEI 8/wOLU8xtOTC6i56P+ZlLxfPJenA4PRh+NZY7Z/pWY2EJFJhed9PGsWk/bdJly/4yPx7 6rkOz/FnucYS6HbPIfdUPEnaVTGsSdDSf/q1h4SUnRDjfbnzBp68ZsqakLChcbsqpbju u0HB9WFT/UhMud0ABsYdxvchR8E0+PAawobo4s3HzU80PeSuGyXBdZSWznQfO2w8BM3Z SlYcQs27lPORuLZX4im/A5/YnJ+OK3Xq3qb8DGP+7oIrsLPZorSYaePe2zQNpqCokT6S 3w== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 2uea7rfqfy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 24 Aug 2019 01:46:22 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7O1gOVo083856; Sat, 24 Aug 2019 01:46:22 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3020.oracle.com with ESMTP id 2ujca8qpv5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 24 Aug 2019 01:46:22 +0000 Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x7O1kKWD011452; Sat, 24 Aug 2019 01:46:20 GMT MIME-Version: 1.0 Message-ID: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> Date: Fri, 23 Aug 2019 18:46:19 -0700 (PDT) From: Drew Adams To: Stefan Kangas Subject: RE: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") References: In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4873.0 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9358 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908240017 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9358 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908240017 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 30660 Cc: 30660@debbugs.gnu.org, =?utf-8?B?56mN5Li55bC8IERhbiBKYWNvYnNvbg==?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > Non-interactively: > > * KEYMAP can be such a keymap variable or a keymap. > > * Non-nil optional arg SEARCH-SYMBOLS-P means that if KEYMAP is not a > > symbol then search all variables for one whose value is KEYMAP." >=20 > Is the purpose of SEARCH-SYMBOLS-P just to allow for calling it like > this: > (describe-keymap 'my-keymap t) > (describe-keymap my-keymap t) >=20 > And have it work automatically? Or am I missing something? Also see > below. KEYMAP can be a keymap, instead of a symbol. (This was not the case originally. I added handling this case later, as it was requested and turned out to be useful. It's not rare to have a keymap object ready-to-hand and without its variable. This lets you not only see the bindings but also identify the keymap.) If it's not a symbol there might still be a symbol that has it as value. Non-nil SEARCH-SYMBOLS-P means try to find such a symbol. If such a symbol is found then the help is better - it tells you more about the keymap and its context, by (1) providing its doc (in addition to listing the key bindings) and even just (2) providing its name, letting you know (typically) what mode or other context defines it. If the search finds no symbol with KEYMAP as its value then the behavior is the same as if no search was made (except for the time wasted on a failed search): a symbol is generated for the map (just to use the same code path). The other difference is that because you provided SEARCH-SYMBOLS-P you know that a search turned up no symbol - more information. > I admit that I find this code a bit hard to follow. If I understand > correctly, then most of this can be removed if we don't want to > support SEARCH-SYMBOLS-P, and instead just require that the KEYMAP > argument is a symbol. Is that correct or am I missing something? Who's "we"? If a _user_ or calling code doesn't want to search existing symbols then SEARCH-SYMBOLS-P is supplied. Nothing is lost by having it as a behavior option, and something (quite a lot, actually) is gained by making it available. Putting a name on a keymap object can be quite helpful. The case where a user (or calling code) has a keymap but no variable for it is not uncommon, even if it is not the most common case. Being able to find the variable and see its doc is helpful. > I'm sort of leaning towards simplifying this by removing the > SEARCH-SYMBOLS-P argument, but I might not understand the use case > here. If I'm missing something, could you please briefly describe the > use case for that and if and why it's important to keep? See above. > > (let* ((name (symbol-name keymap)) > > (doc (let ((raw-doc (documentation-property keymap > 'variable-documentation 'RAW))) > > (substitute-command-keys raw-doc))) >=20 > Why not just say (documentation-property keymap 'variable- > documentation) > without the 'RAW argument? That should have the same effect as > passing the 'RAW argument and then calling substitute-command-keys on > the result, AFAICT. Yes; sorry. My code uses `help-documentation-property' and `help-substitute-command-keys'. I too quickly substituted the body of `help-documentation-property', changing its occurrence of `help-substitute-command-keys' to just `substitute-command-keys'. None of `h-d-p' is needed here if you don't have `h-s-c-k'. IOW, if neither of those is available then yes, all you need is (documentation-property keymap 'variable-documentation). Sorry about that mistake. You might want to take a look at the full code, in help-fns+.el, to see what the differences are. Some are to support older Emacs versions too, others are to provide additional features. > > (doc (and (not (equal "" doc)) doc))) >=20 > Is this to allow us to simply say (when doc ...) below Yes. It makes DOC be either nil or real doc. > instead of (when (not (equal "" doc)) ...) [aka (unless (equal "" doc)...)] No. That's not the same. That does `...' when doc is nil. The code should do `...' only when doc is non-nil and not "". From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 23 23:01:48 2019 Received: (at 30660) by debbugs.gnu.org; 24 Aug 2019 03:01:48 +0000 Received: from localhost ([127.0.0.1]:41458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1MJI-0006Fr-5v for submit@debbugs.gnu.org; Fri, 23 Aug 2019 23:01:48 -0400 Received: from mail-pf1-f173.google.com ([209.85.210.173]:41809) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1MJF-0006Fc-Rm for 30660@debbugs.gnu.org; Fri, 23 Aug 2019 23:01:47 -0400 Received: by mail-pf1-f173.google.com with SMTP id 196so7794297pfz.8 for <30660@debbugs.gnu.org>; Fri, 23 Aug 2019 20:01:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=B8q/41aAzhTeO3wsNZgESYjn/pQMQfaDtqzFckBmFIU=; b=HkPjeI3sSkITRcGXjQ/lJS4tp4ptG7Dg2rfC0fPJg/9RqRCCnKoY57jKLsNQfmcdfk SfA8AykDNzkRGQFQytMJq2ngsjxD1k1+mdhvednD2nrwhist6jzuaFBCtmaxndGxD/a3 weI4yccpAYEotaYKvQwqc/YF4mp13Aqo9w/ZNOpjEcw/dHduOlAPBp9+yaU+k1OdnDaC z8UNt3vq4qVQX9RhONnai5bZ4n+v1hE3X11G9u4XrMQ2iQdJhqwOuwJwxGhBIt0vNvCY ohFM/5RcCQoZyKKHb14AttHPHGUiklLVBMbwZStrmNyEKiX9iY2zHQLvRizJcRdP4V5g 7VWA== X-Gm-Message-State: APjAAAXnATbps7XInYOoNw0Rh2aZ6ok/xIQ/BbnS2sr2EZZaHij6ENN4 IQ+3cjQlhoPUR9ZQ/YEwuiewekFKP9ElLrwn+LY= X-Google-Smtp-Source: APXvYqxHMr8HUWzEEY80jSfH//2+t7Ree4jwzMKD2a6zmQ/sVYhXvynRw2gTyeWX8RKJHe1r5/yS+dCtwk8wFdEi1Q4= X-Received: by 2002:a63:69c1:: with SMTP id e184mr6336635pgc.198.1566615699948; Fri, 23 Aug 2019 20:01:39 -0700 (PDT) MIME-Version: 1.0 References: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> In-Reply-To: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> From: Stefan Kangas Date: Sat, 24 Aug 2019 05:01:28 +0200 Message-ID: Subject: Re: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") To: Drew Adams Content-Type: multipart/mixed; boundary="0000000000004bb8a00590d424a6" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 30660 Cc: 30660@debbugs.gnu.org, =?UTF-8?B?56mN5Li55bC8IERhbiBKYWNvYnNvbg==?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --0000000000004bb8a00590d424a6 Content-Type: text/plain; charset="UTF-8" Drew Adams writes: > KEYMAP can be a keymap, instead of a symbol. Thanks for the clarifications. I've now packaged up a proposed patch with some cleanups and adaptions. It would be great if someone could review this. Best regards, Stefan Kangas --0000000000004bb8a00590d424a6 Content-Type: application/octet-stream; name="0001-Add-new-help-function-describe-keymap.patch" Content-Disposition: attachment; filename="0001-Add-new-help-function-describe-keymap.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jzoyizw50 RnJvbSA5MWY0YThmMTBlMmFhMGRmOWNlZWUxYzhjODIzZWY4MmI4NTZjMTIyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBTYXQsIDI0IEF1ZyAyMDE5IDAxOjAyOjA0ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g QWRkIG5ldyBoZWxwIGZ1bmN0aW9uIGRlc2NyaWJlLWtleW1hcAoKVGhpcyBjb2RlIHdhcyB3cml0 dGVuIGJ5IERyZXcgQWRhbXMgd2l0aCBtaW5vciBjbGVhbnVwcyBhbmQgc3R5bGlzdGljCmNoYW5n ZXMgYnkgU3RlZmFuIEthbmdhcy4KUmVmOiBodHRwczovL2RlYmJ1Z3MuZ251Lm9yZy9jZ2kvYnVn cmVwb3J0LmNnaT9idWc9MzA2NjAKCiogbGlzcC9oZWxwLWZucy5lbCAoZGVzY3JpYmUta2V5bWFw KTogTmV3IGZ1bmN0aW9uIHRvIHNob3cga2V5CmJpbmRpbmdzIGZvciBhIGdpdmVuIGtleW1hcC4g IChCdWcjMzA2NjApCiogbGlzcC9oZWxwLmVsIChoZWxwLW1hcCk6IEJpbmQgdGhlIG5ldyBmdW5j dGlvbiB0byAiQy1oIE0iLgoqIGxpc3AvaGVscC5lbCAoaGVscC1mb3ItaGVscC1pbnRlcm5hbCk6 IERvY3VtZW50IHdoYXQgIkMtaCBNIiBkb2VzCndoZW4gdXNlciB0eXBlcyAiQy1oIEMtaCIuCi0t LQogbGlzcC9oZWxwLWZucy5lbCB8IDY2ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKwogbGlzcC9oZWxwLmVsICAgICB8ICAyICsrCiAyIGZpbGVzIGNoYW5n ZWQsIDY4IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9saXNwL2hlbHAtZm5zLmVsIGIvbGlz cC9oZWxwLWZucy5lbAppbmRleCA5MGEzNTcxNTIwLi5iNjRiYmJlNGM2IDEwMDY0NAotLS0gYS9s aXNwL2hlbHAtZm5zLmVsCisrKyBiL2xpc3AvaGVscC1mbnMuZWwKQEAgLTEzOTAsNiArMTM5MCw3 MiBAQCBkZXNjcmliZS1jYXRlZ29yaWVzCiAJICAoaW5zZXJ0ICJcblRoZSBwYXJlbnQgY2F0ZWdv cnkgdGFibGUgaXM6IikKIAkgIChkZXNjcmliZS12ZWN0b3IgdGFibGUgJ2hlbHAtZGVzY3JpYmUt Y2F0ZWdvcnktc2V0KSkpKSkpCiAKKzs7OyMjI2F1dG9sb2FkCisoZGVmdW4gZGVzY3JpYmUta2V5 bWFwIChrZXltYXAgJm9wdGlvbmFsIHNlYXJjaC1zeW1ib2xzLXApCisgICJEZXNjcmliZSBrZXkg YmluZGluZ3MgaW4gS0VZTUFQLgorV2hlbiBjYWxsZWQgaW50ZXJhY3RpdmVseSwgcHJvbXB0IGZv ciBhIHZhcmlhYmxlIHRoYXQgaGFzIGEKK2tleW1hcCB2YWx1ZS4gIENvbXBsZXRpb24gaXMgYXZh aWxhYmxlIGZvciB0aGUgdmFyaWFibGUgbmFtZS4KKworSWYgb3B0aW9uYWwgYXJndW1lbnQgU0VB UkNILVNZTUJPTFMtUCBpcyBub24tbmlsLCBhbmQgS0VZTUFQIGlzCitub3QgYSBzeW1ib2wsIHNl YXJjaCBhbGwgdmFyaWFibGVzIGZvciBvbmUgd2hvc2UgdmFsdWUgaXMgS0VZTUFQCithbmQgdXNl IHRoYXQgdG8gZGVzY3JpYmUgdGhlIGtleSBiaW5kaW5ncy4gIFRoaXMgbWFrZXMgaXQKK3Bvc3Np YmxlIHRvIG5vdCBvbmx5IHNlZSB0aGUgYmluZGluZ3MgYnV0IGFsc28gdG8gaWRlbnRpZnkgdGhl CituYW1lIG9mIHRoZSBrZXltYXAgaW4gcXVlc3Rpb24uIgorICAoaW50ZXJhY3RpdmUgKGxpc3QK KyAgICAgICAgICAgICAgICAoaW50ZXJuIChjb21wbGV0aW5nLXJlYWQgIktleW1hcDogIiBvYmFy cmF5CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChsYW1iZGEgKG0p CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGFuZCAoYm91bmRw IG0pCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoa2V5 bWFwcCAoc3ltYm9sLXZhbHVlIG0pKSkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHQgbmlsICd2YXJpYWJsZS1uYW1lLWhpc3RvcnkpKSkpCisgICh1bmxlc3MgKGFu ZCAoc3ltYm9scCBrZXltYXApCisgICAgICAgICAgICAgICAoYm91bmRwIGtleW1hcCkKKyAgICAg ICAgICAgICAgIChrZXltYXBwIChzeW1ib2wtdmFsdWUga2V5bWFwKSkpCisgICAgKGlmIChub3Qg KGtleW1hcHAga2V5bWFwKSkKKyAgICAgICAgKGlmIChzeW1ib2xwIGtleW1hcCkKKyAgICAgICAg ICAgIChlcnJvciAiTm90IGEga2V5bWFwIHZhcmlhYmxlOiAlUyIga2V5bWFwKQorICAgICAgICAg IChlcnJvciAiTm90IGEga2V5bWFwIikpCisgICAgICAobGV0ICgoc3ltIG5pbCkpCisgICAgICAg ICh3aGVuIHNlYXJjaC1zeW1ib2xzLXAKKyAgICAgICAgICAoc2V0cSBzeW0gKGNhdGNoICdkZXNj cmliZS1rZXltYXAKKyAgICAgICAgICAgICAgICAgICAgICAobWFwYXRvbXMgKGxhbWJkYSAoc3lt YikKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAod2hlbiAoYW5kIChib3VuZHAg c3ltYikKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChlcSAo c3ltYm9sLXZhbHVlIHN5bWIpIGtleW1hcCkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIChub3QgKGVxIHN5bWIgJ2tleW1hcCkpCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAodGhyb3cgJ2Rlc2NyaWJlLWtleW1hcCBzeW1i KSkpKSkKKyAgICAgICAgICAgICAgICAgICAgICBuaWwpKSkKKyAgICAgICAgKHVubGVzcyBzeW0K KyAgICAgICAgICAoc2V0cSBzeW0gKGNsLWdlbnRlbXAgIktFWU1BUCBPQkpFQ1QgKG5vIHZhcmlh YmxlKSAiKSkKKyAgICAgICAgICAoc2V0IHN5bSBrZXltYXApKQorICAgICAgICAoc2V0cSBrZXlt YXAgc3ltKSkpKQorICA7OyBGb2xsb3cgYWxpYXNpbmcuCisgIChzZXRxIGtleW1hcCAob3IgKGln bm9yZS1lcnJvcnMgKGluZGlyZWN0LXZhcmlhYmxlIGtleW1hcCkpIGtleW1hcCkpCisgIChsZXQq ICgobmFtZSAoc3ltYm9sLW5hbWUga2V5bWFwKSkKKyAgICAgICAgIChkb2MgKGRvY3VtZW50YXRp b24tcHJvcGVydHkga2V5bWFwICd2YXJpYWJsZS1kb2N1bWVudGF0aW9uKSkKKyAgICAgICAgIChm aWxlLW5hbWUgKGZpbmQtbGlzcC1vYmplY3QtZmlsZS1uYW1lIGtleW1hcCAnZGVmdmFyKSkpCisg ICAgKGhlbHAtc2V0dXAteHJlZiAobGlzdCAjJ2Rlc2NyaWJlLWtleW1hcCBrZXltYXApCisgICAg ICAgICAgICAgICAgICAgICAoY2FsbGVkLWludGVyYWN0aXZlbHktcCAnaW50ZXJhY3RpdmUpKQor ICAgICh3aXRoLWhlbHAtd2luZG93IChoZWxwLWJ1ZmZlcikKKyAgICAgIChwcmluYyAoZm9ybWF0 LW1lc3NhZ2UgIiVTIiBrZXltYXApKQorICAgICAgKHByaW5jIChmb3JtYXQtbWVzc2FnZQorICAg ICAgICAgICAgICAiIGlzIGEga2V5bWFwIHZhcmlhYmxlIGRlZmluZWQgaW4gYCVzJy5cblxuIgor ICAgICAgICAgICAgICAoaWYgKGVxIGZpbGUtbmFtZSAnQy1zb3VyY2UpCisgICAgICAgICAgICAg ICAgICAiQyBzb3VyY2UgY29kZSIKKyAgICAgICAgICAgICAgICAoZmlsZS1uYW1lLW5vbmRpcmVj dG9yeSBmaWxlLW5hbWUpKSkpCisgICAgICAod2l0aC1jdXJyZW50LWJ1ZmZlciBzdGFuZGFyZC1v dXRwdXQKKyAgICAgICAgKHNhdmUtZXhjdXJzaW9uCisgICAgICAgICAgKHJlLXNlYXJjaC1iYWNr d2FyZCAoc3Vic3RpdHV0ZS1jb21tYW5kLWtleXMKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAiYFxcKFteYCddK1xcKSciKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbmls IHQpCisgICAgICAgICAgKGhlbHAteHJlZi1idXR0b24gMSAnaGVscC12YXJpYWJsZS1kZWYKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICBrZXltYXAgZmlsZS1uYW1lKSkpCisgICAgICAod2hl biAoYW5kIChub3QgKGVxdWFsICIiIGRvYykpIGRvYykKKyAgICAgICAgKHByaW5jICJEb2N1bWVu dGF0aW9uOlxuIikKKyAgICAgICAgKHByaW5jIChmb3JtYXQtbWVzc2FnZSAiJXNcblxuIiBkb2Mp KSkKKyAgICAgIDs7IFVzZSBgaW5zZXJ0JyBpbnN0ZWFkIG9mIGBwcmluYycsIHNvIGNvbnRyb2wg Y2hhcnMgKGUuZy4gXDM3NykKKyAgICAgIDs7IGluc2VydCBjb3JyZWN0bHkuCisgICAgICAod2l0 aC1jdXJyZW50LWJ1ZmZlciAiKkhlbHAqIgorICAgICAgICAoaW5zZXJ0IChzdWJzdGl0dXRlLWNv bW1hbmQta2V5cyAoY29uY2F0ICJcXHsiIG5hbWUgIn0iKSkpKSkpKQorCiAMCiA7OzsgUmVwbGFj ZW1lbnRzIGZvciBvbGQgbGliLXNyYy8gcHJvZ3JhbXMuICBEb24ndCBzZWVtIGVzcGVjaWFsbHkg dXNlZnVsLgogCmRpZmYgLS1naXQgYS9saXNwL2hlbHAuZWwgYi9saXNwL2hlbHAuZWwKaW5kZXgg ZTQwMTc4ZGU5Ni4uMThmMTIxOWNhMCAxMDA2NDQKLS0tIGEvbGlzcC9oZWxwLmVsCisrKyBiL2xp c3AvaGVscC5lbApAQCAtOTYsNiArOTYsNyBAQCBoZWxwLW1hcAogICAgIChkZWZpbmUta2V5IG1h cCAiayIgJ2Rlc2NyaWJlLWtleSkKICAgICAoZGVmaW5lLWtleSBtYXAgImwiICd2aWV3LWxvc3Nh Z2UpCiAgICAgKGRlZmluZS1rZXkgbWFwICJtIiAnZGVzY3JpYmUtbW9kZSkKKyAgICAoZGVmaW5l LWtleSBtYXAgIk0iICdkZXNjcmliZS1rZXltYXApCiAgICAgKGRlZmluZS1rZXkgbWFwICJvIiAn ZGVzY3JpYmUtc3ltYm9sKQogICAgIChkZWZpbmUta2V5IG1hcCAibiIgJ3ZpZXctZW1hY3MtbmV3 cykKICAgICAoZGVmaW5lLWtleSBtYXAgInAiICdmaW5kZXItYnkta2V5d29yZCkKQEAgLTIxOSw2 ICsyMjAsNyBAQCAnaGVscC1mb3ItaGVscAogTCBMQU5HLUVOViAgRGVzY3JpYmVzIGEgc3BlY2lm aWMgbGFuZ3VhZ2UgZW52aXJvbm1lbnQsIG9yIFJFVCBmb3IgY3VycmVudC4KIG0gICAgICAgICAg IERpc3BsYXkgZG9jdW1lbnRhdGlvbiBvZiBjdXJyZW50IG1pbm9yIG1vZGVzIGFuZCBjdXJyZW50 IG1ham9yIG1vZGUsCiAgICAgICAgICAgICAgIGluY2x1ZGluZyB0aGVpciBzcGVjaWFsIGNvbW1h bmRzLgorTSBLRVlNQVAgICAgRGVzY3JpYmUgdGhlIGdpdmVuIGtleW1hcCBhbmQgaXRzIGJpbmRp bmdzLgogbiAgICAgICAgICAgRGlzcGxheSBuZXdzIG9mIHJlY2VudCBFbWFjcyBjaGFuZ2VzLgog byBTWU1CT0wgICAgRGlzcGxheSB0aGUgZ2l2ZW4gZnVuY3Rpb24gb3IgdmFyaWFibGUncyBkb2N1 bWVudGF0aW9uIGFuZCB2YWx1ZS4KIHAgVE9QSUMgICAgIEZpbmQgcGFja2FnZXMgbWF0Y2hpbmcg YSBnaXZlbiB0b3BpYyBrZXl3b3JkLgotLSAKMi4yMi4wCgo= --0000000000004bb8a00590d424a6-- From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 24 11:06:30 2019 Received: (at 30660) by debbugs.gnu.org; 24 Aug 2019 15:06:30 +0000 Received: from localhost ([127.0.0.1]:43212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1Xcb-0005Wa-Uf for submit@debbugs.gnu.org; Sat, 24 Aug 2019 11:06:30 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:49978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1XcZ-0005WK-IK for 30660@debbugs.gnu.org; Sat, 24 Aug 2019 11:06:28 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7OF3eXh153814; Sat, 24 Aug 2019 15:06:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=BZaS4ZYFfewSekwaYCyYPcVgud2bidSfHQgxAoZJ/l4=; b=FBhtsSqGm361EW2Ce9JoxolqjEUtnhU0BEVtuYpmBpaEy5J66/eZncc4atfaQHsV366O 2m+aDzWfbanLfSjc9X3o6iLGTIaymPjNfz8Kp45jqPVLaKmXwO0zjdSPzM5u6khl6DFe D3dx/OrlrsJ+rbpeTVAA901/zVyNxEAz8WRpEccbX+FIDtBgmv9bTzBJOjjT9PMQEmq+ WrFX8Mf7Karx5XwvDppg78guyesP7B9lnki19Mi5YlKu0PJshzYgVzFNe0eemiJlZ8o8 ZtL7JdLuhQAamIbKrheL2UqROTCYsE9R/6PhJdloMJWwf42Vw6GrAmDdXwRqmxujPBF+ uQ== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 2ujwvq18fk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 24 Aug 2019 15:06:21 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7OF2frO140343; Sat, 24 Aug 2019 15:06:21 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 2ujw6g3bsh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 24 Aug 2019 15:06:21 +0000 Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x7OF6J3I017813; Sat, 24 Aug 2019 15:06:20 GMT MIME-Version: 1.0 Message-ID: <13355700-914e-477e-99b6-c278b55e5563@default> Date: Sat, 24 Aug 2019 08:06:19 -0700 (PDT) From: Drew Adams To: Stefan Kangas Subject: RE: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") References: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4873.0 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9359 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908240166 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9359 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908240166 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 30660 Cc: 30660@debbugs.gnu.org, =?utf-8?B?56mN5Li55bC8IERhbiBKYWNvYnNvbg==?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > I've now packaged up a proposed patch Thanks for working on this. Looks mostly OK to me. However: 1. I object to the use of `C-h M' as the key binding. Please use `C-h M-k'. The letter `M/m' has other, and more useful, associations (mode, mail, . And `M' currently is translated to the often used `C-h m'. `K' is often associated in Emacs with "key" or "kill". And it's as easy to use Meta as it is to use Shift. [And users of `help-fns+.el', which has the same command but with additional features, are used to `C-h M-k'. Because the vanilla version will lack those additional features I'll continue to maintain `describe-keymap' in `help-fns+.el'. If those features are also added to vanilla Emacs someday then I won't need to maintain it.] 2. When testing with `emacs -Q' (but perhaps because I ran into the error of #3?), and also using `C-h f' etc., I somehow ended up with two [back] links at the bottom of *Help*, like this: [back] [back] Please check that what you end up with doesn't lead to this. 3. The code raises this error when KEYMAP is not a symbol and SEARCH-SYMBOLS-P is nil, because FILE-NAME is nil. (describe-keymap isearch-mode-map) =3D>=20 Debugger entered--Lisp error: (wrong-type-argument stringp nil) file-name-nondirectory(nil) (if (eq file-name (quote C-source)) "C source code" (file-name-nondirecto= ry file-name)) ... 4. When fixing that bug, please be sure not to print a generated name ("KEYMAP OBJECT (no variable)") for a non-existent or not found variable. 5. When fixing that bug, if the keymap is fine, and it has a variable that is not defined in a file, don't try to print a file for it. Don't try to print a file for the non-variable case either. Wrt 3-5: It's not right to blindly print a variable name and a file for it. The code needs to handle cases such as variable not given, no variable at all, and variable not defined in a file. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 14 16:28:34 2019 Received: (at 30660) by debbugs.gnu.org; 14 Oct 2019 20:28:34 +0000 Received: from localhost ([127.0.0.1]:41858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iK6xG-0004E9-BX for submit@debbugs.gnu.org; Mon, 14 Oct 2019 16:28:34 -0400 Received: from [80.91.231.51] (port=39390 helo=quimby.gnus.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iK6xF-0004E1-30 for 30660@debbugs.gnu.org; Mon, 14 Oct 2019 16:28:33 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iK6xA-0003l1-1Y; Mon, 14 Oct 2019 22:28:30 +0200 From: Lars Ingebrigtsen To: Stefan Kangas Subject: Re: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") References: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> Date: Mon, 14 Oct 2019 22:28:27 +0200 In-Reply-To: (Stefan Kangas's message of "Sat, 24 Aug 2019 05:01:28 +0200") Message-ID: <87tv8bul5g.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Kangas writes: > I've now packaged up a proposed patch with some cleanups and > adaptions. It would be great if someone could review this. [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Stefan Kangas writes: > I've now packaged up a proposed patch with some cleanups and > adaptions. It would be great if someone could review this. [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: ingebrigtsen.no] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Debbugs-Envelope-To: 30660 Cc: 30660@debbugs.gnu.org, Drew Adams , =?utf-8?B?56mN5Li55bC8?= Dan Jacobson X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Stefan Kangas writes: > I've now packaged up a proposed patch with some cleanups and > adaptions. It would be great if someone could review this. [...] > This code was written by Drew Adams with minor cleanups and stylistic > changes by Stefan Kangas. > Ref: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=30660 > > * lisp/help-fns.el (describe-keymap): New function to show key > bindings for a given keymap. (Bug#30660) This looks like a useful addition... > * lisp/help.el (help-map): Bind the new function to "C-h M". > * lisp/help.el (help-for-help-internal): Document what "C-h M" does > when user types "C-h C-h". `C-h m' is already used and `C-h M' auto-maps to it currently, so I'm not sure that's the best binding. But perhaps that's not a problem in practice. Other than that, I have no comments, and I think it should be applied to Emacs 27. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 14 16:33:45 2019 Received: (at 30660) by debbugs.gnu.org; 14 Oct 2019 20:33:45 +0000 Received: from localhost ([127.0.0.1]:41863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iK72H-0006Qu-2t for submit@debbugs.gnu.org; Mon, 14 Oct 2019 16:33:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44193) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iK72F-0006Qg-7v for 30660@debbugs.gnu.org; Mon, 14 Oct 2019 16:33:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33209) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iK729-0000ST-5m; Mon, 14 Oct 2019 16:33:37 -0400 Received: from [176.228.60.248] (port=1629 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iK728-0000Tp-9C; Mon, 14 Oct 2019 16:33:36 -0400 Date: Mon, 14 Oct 2019 23:33:31 +0300 Message-Id: <8336fvhxt0.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-reply-to: <87tv8bul5g.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 14 Oct 2019 22:28:27 +0200) Subject: Re: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") References: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> <87tv8bul5g.fsf@gnus.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 30660 Cc: 30660@debbugs.gnu.org, stefan@marxist.se, jidanni@jidanni.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Date: Mon, 14 Oct 2019 22:28:27 +0200 > Cc: 30660@debbugs.gnu.org, > 積丹尼 Dan Jacobson > > This looks like a useful addition... > > > * lisp/help.el (help-map): Bind the new function to "C-h M". > > * lisp/help.el (help-for-help-internal): Document what "C-h M" does > > when user types "C-h C-h". > > `C-h m' is already used and `C-h M' auto-maps to it currently, so I'm > not sure that's the best binding. But perhaps that's not a problem in > practice. > > Other than that, I have no comments, and I think it should be applied to > Emacs 27. Fine with me, but let's not give it any key binding yet, and please mention this command in NEWS. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 14 16:50:17 2019 Received: (at 30660) by debbugs.gnu.org; 14 Oct 2019 20:50:17 +0000 Received: from localhost ([127.0.0.1]:41917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iK7IH-0000aw-DF for submit@debbugs.gnu.org; Mon, 14 Oct 2019 16:50:17 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:57244) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iK7IF-0000ac-G1 for 30660@debbugs.gnu.org; Mon, 14 Oct 2019 16:50:15 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x9EKn5YF026735; Mon, 14 Oct 2019 20:50:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=McEHQOENjrqId4OdlPdCBMpubY1+KiwZG+hdMr/NGnc=; b=dgmJnxZ7IDQBSIMVEGG7XT8czxWIW/amDGXoVeTBa8GJaybOuMpaTGGTuMucfOC/WtuQ XNvN8odcWs2BOSaDFYC0m7bsx+fltPcsYdOU+mMycxxRumcdG2/qZYkz3G0tcmNZrfCK j7kJUssI9PVrlFNnxQhbEUdZKeG+2muVjwXND6L03J38BfhekOy0DmL+UIKTFa8TO1tm x1kRUiplGlEF5wQBvtY3p2g6up7GeWAWOLq55EpW1NlyXfUElMD0yBwEhzWV984gKmDr rTv5efstZQ4dY/vXLHLxOZUYuKgysG14IxEEUqg75Uw62A/vYQf4jgJv/gh+jmPt9Yk/ jg== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 2vk7fr3bya-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 14 Oct 2019 20:50:09 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x9EKh4Ao100684; Mon, 14 Oct 2019 20:50:09 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3030.oracle.com with ESMTP id 2vkr9xs45q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 14 Oct 2019 20:50:09 +0000 Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x9EKo6NU028239; Mon, 14 Oct 2019 20:50:06 GMT MIME-Version: 1.0 Message-ID: <37fa8265-0900-47e7-ba11-6ba40937e2a5@default> Date: Mon, 14 Oct 2019 20:50:05 +0000 (UTC) From: Drew Adams To: Lars Ingebrigtsen , Stefan Kangas Subject: RE: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") References: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> <87tv8bul5g.fsf@gnus.org> In-Reply-To: <87tv8bul5g.fsf@gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4900.0 (x86)] Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9410 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910140171 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9410 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910140172 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 30660 Cc: 30660@debbugs.gnu.org, =?iso-2022-jp?B?GyRCQFFDMEZ0GyhCIERhbiBKYWNvYnNvbg==?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > * lisp/help.el (help-map): Bind the new function to "C-h M". > > * lisp/help.el (help-for-help-internal): Document what "C-h M" does > > when user types "C-h C-h". >=20 > `C-h m' is already used and `C-h M' auto-maps to it currently, so I'm > not sure that's the best binding. But perhaps that's not a problem in > practice. I wrote the code for this command and have been using it since 2007. I already objected here two months ago to Emacs using `C-h M' for this - in the message just after the one you chose to reply to. I requested that `C-h M-k' be used. That's the key I and others have been using for years. And it's mnemonic with "keymap" and "key". Is there a good reason my input is just ignored? For more info, including other problems with the patch provided: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D30660#26 And I do suggest that the other features provided in the original code be included in the vanilla version as well. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 16 18:42:40 2019 Received: (at 30660) by debbugs.gnu.org; 16 Oct 2019 22:42:40 +0000 Received: from localhost ([127.0.0.1]:46734 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKs08-0005ei-4H for submit@debbugs.gnu.org; Wed, 16 Oct 2019 18:42:40 -0400 Received: from mail-pf1-f169.google.com ([209.85.210.169]:47008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKs07-0005eY-0A for 30660@debbugs.gnu.org; Wed, 16 Oct 2019 18:42:39 -0400 Received: by mail-pf1-f169.google.com with SMTP id q5so279373pfg.13 for <30660@debbugs.gnu.org>; Wed, 16 Oct 2019 15:42:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HWfCPooTsKb0el3SWU8GBTiiqAlPwahYcrMtdZ+j8qk=; b=fGApxzLRMRk2zFmj1/l5oDwqxNq8u+6DDEKQbHFg1iCfySZGlDArzkJioSvGC7vx2Y pNsE04s4o4WCGjERxqULeckZEPJbWIuOknOOZ1Rpz/BxEsc2zsTzYFTaV1Ls/n18En+A N3459STI61FPQ53tR+enmIQhqhQr8xIaJ9b+ZID9uKc0582Z1vDjTPTGLbIF71XZWlWK mbJLo4IRXo2XRF8j+WZd1HDeXi7ZLyzXTSoaax0+uCBIaRnSAiK2g2R4yhJ5fr2/j5oj 0OiNFxElFjURHjbw+9Vsl9gEEiuiJ9ITph4joV/5PmIqiXlsJOfg643oENI6VuxEsaxh P3Fw== X-Gm-Message-State: APjAAAWUe4edb0s+37FCtWD6T8tMYIzEOk0c6xU7kTpJXvIIXBnmcJzx a5rFgJhDRBFD46dXdkAMw1dTZ69AVYMDjntHTbI= X-Google-Smtp-Source: APXvYqzBkjbgnS9yEIxflGiMwOv3zOHfHC2KnQbz0sLI63uQEuGenaiqBV4KOK4r0ffU7k8K6Dw07UMoXzWeiLwl2Ws= X-Received: by 2002:aa7:8652:: with SMTP id a18mr89237pfo.190.1571265753102; Wed, 16 Oct 2019 15:42:33 -0700 (PDT) MIME-Version: 1.0 References: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> <13355700-914e-477e-99b6-c278b55e5563@default> In-Reply-To: <13355700-914e-477e-99b6-c278b55e5563@default> From: Stefan Kangas Date: Thu, 17 Oct 2019 00:42:20 +0200 Message-ID: Subject: Re: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") To: Drew Adams Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 30660 Cc: 30660@debbugs.gnu.org, =?UTF-8?B?56mN5Li55bC8IERhbiBKYWNvYnNvbg==?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Drew Adams writes: > > I've now packaged up a proposed patch > > Thanks for working on this. Looks mostly OK to me. > However: Thanks for the review. I've fixed all your comments in a patch I'll send soon. Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 16 18:48:52 2019 Received: (at 30660) by debbugs.gnu.org; 16 Oct 2019 22:48:52 +0000 Received: from localhost ([127.0.0.1]:46743 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKs68-0005pD-3z for submit@debbugs.gnu.org; Wed, 16 Oct 2019 18:48:52 -0400 Received: from mail-pf1-f176.google.com ([209.85.210.176]:36703) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKs66-0005oz-Ow for 30660@debbugs.gnu.org; Wed, 16 Oct 2019 18:48:51 -0400 Received: by mail-pf1-f176.google.com with SMTP id y22so315808pfr.3 for <30660@debbugs.gnu.org>; Wed, 16 Oct 2019 15:48:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ol0dNfxKudGzbIEWVAe+bFYTHTeHKsMuIjDqYaf36jQ=; b=Hrh0RlbLuzxW7Ag4cvzZsMlpn97ZMxeWreC7SLL8HAWd0mlEuxy42dSDBUTdwLcZMh FDTBWSIpSzkqeyRGplOG6DX6qnrwFXuuyGQOISD9+hEUEbt3lCt/hVHsguKRpcHB9yDT SNWktxlH6ln/cIFUFY/w5K8IYYntbiq9kh/aJy9VbGvN+aqQ9nrGKa4ZpJcknQmzAbqY /hOJvPd00bJpvyy0bwFnGle9ipxCNVb4+tDLKCexnl29YUJSCqyS8lEXo+AYi5AAdFR8 t50GnN6stZvEEQAtn2urePXXZp2i2RbD+NMYgtrHR6eRjvNRYFHutmVYzWV9cFWyR6sD YSZQ== X-Gm-Message-State: APjAAAVANvHMTUt71NbweUW6oqtwysWUHqErv1SB9T/C5aG+MeQQSX/r dRWVORk8jY5s8dOYk5F6B26Uq6ZxNnzcUeMVOSo= X-Google-Smtp-Source: APXvYqx3yBH3WCc7PstAXNuard7vbr6oEfq3Himko3mN+4ZRhqcwMSPYQonGi//rsfg/VU3OWbjZzNNKpRREzEjBlao= X-Received: by 2002:a17:90a:fb92:: with SMTP id cp18mr478452pjb.2.1571266124781; Wed, 16 Oct 2019 15:48:44 -0700 (PDT) MIME-Version: 1.0 References: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> <87tv8bul5g.fsf@gnus.org> <37fa8265-0900-47e7-ba11-6ba40937e2a5@default> In-Reply-To: <37fa8265-0900-47e7-ba11-6ba40937e2a5@default> From: Stefan Kangas Date: Thu, 17 Oct 2019 00:48:32 +0200 Message-ID: Subject: Re: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") To: Drew Adams Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 30660 Cc: Lars Ingebrigtsen , 30660@debbugs.gnu.org, =?UTF-8?B?56mN5Li55bC8IERhbiBKYWNvYnNvbg==?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Drew Adams writes: > I requested that `C-h M-k' be used. I'll add no keybinding at all, as Eli requested. > Is there a good reason my input is just ignored? I'm sorry if it looked like your input was being ignored. I was busy working on other things. > And I do suggest that the other features provided > in the original code be included in the vanilla > version as well. I'm not sure which features this refers to, but perhaps you could take a look when I send the new patch and give your feedback. Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 17 05:39:51 2019 Received: (at 30660) by debbugs.gnu.org; 17 Oct 2019 09:39:51 +0000 Received: from localhost ([127.0.0.1]:47145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iL2G7-0004sI-DL for submit@debbugs.gnu.org; Thu, 17 Oct 2019 05:39:51 -0400 Received: from mail-pg1-f177.google.com ([209.85.215.177]:35930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iL2G4-0004s5-VP for 30660@debbugs.gnu.org; Thu, 17 Oct 2019 05:39:49 -0400 Received: by mail-pg1-f177.google.com with SMTP id 23so1027555pgk.3 for <30660@debbugs.gnu.org>; Thu, 17 Oct 2019 02:39:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=o8OKa0E9GEzRYE31MfZg3SJ1R9khk4eKBT0F8giJCf8=; b=X8SXpdXaLI32KVHlQiNzpwo2/MlTCFU3x1gRXns9hmNGSalgv0NZEETg4Ua/Xyw0qi FkeZyfWWoaku0ZXdVVAXziSahM32YLr0ILaHjOE1uapve4duQD+VHDGNi8Q8d1UHZKoG yTJOnMY+tMxeB5wJyCRLdc7m52wQ6t0int7SH+jwsCMbr+vEv50GWHth8UVG35JuPuin Nf/y+/4F9tmehL6Sis41qXF/aLpeufoVmtejiw191GdLA2IdKQYcpD2iDarR0YAIW6bF o+rKbYC8pMno0USBbm741fzCvs7uxzVLZzwsE+gI/cvrDSsfdg8LWaFY7TRXh6HtnKY2 Gwow== X-Gm-Message-State: APjAAAXs6Fa/IQmfJwTWM/D0u4LnSxu5JTQOT8MOY5QMNhRVUZRAqHPL /Bimc/oB9pu9bzIHXa9FexCqJ0rxZaTNzQrU7f0= X-Google-Smtp-Source: APXvYqzVoe2uP6L5mJs5isYIQRVvFafMlN5B8OXgkCnLpN+3bRq8qEDynGcRDK4hHXDvoy198xop96iqQZofzuqQTn0= X-Received: by 2002:a17:90a:fb92:: with SMTP id cp18mr3291053pjb.2.1571305182953; Thu, 17 Oct 2019 02:39:42 -0700 (PDT) MIME-Version: 1.0 References: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> <87tv8bul5g.fsf@gnus.org> <8336fvhxt0.fsf@gnu.org> In-Reply-To: <8336fvhxt0.fsf@gnu.org> From: Stefan Kangas Date: Thu, 17 Oct 2019 11:39:31 +0200 Message-ID: Subject: Re: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") To: Eli Zaretskii Content-Type: multipart/mixed; boundary="00000000000043a0a6059517ffdb" X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 30660 Cc: Lars Ingebrigtsen , 30660@debbugs.gnu.org, =?UTF-8?B?56mN5Li55bC8IERhbiBKYWNvYnNvbg==?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) --00000000000043a0a6059517ffdb Content-Type: text/plain; charset="UTF-8" Eli Zaretskii writes: > Fine with me, but let's not give it any key binding yet, and please > mention this command in NEWS. Please find attached an updated patch fixing your comments as well as earlier comments by Drew Adams. In addition to adding this to NEWS, I've also updated the elisp manual. Best regards, Stefan Kangas --00000000000043a0a6059517ffdb Content-Type: application/octet-stream; name="0001-Add-new-help-function-describe-keymap.patch" Content-Disposition: attachment; filename="0001-Add-new-help-function-describe-keymap.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k1uigfrc0 RnJvbSAzMjNmN2VlYjdlZWUzZjBkM2E3ZTlkMzhjMTg5ZGI0MGQ0MGViYTQyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBTYXQsIDI0IEF1ZyAyMDE5IDAxOjAyOjA0ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g QWRkIG5ldyBoZWxwIGZ1bmN0aW9uIGRlc2NyaWJlLWtleW1hcAoKVGhpcyBjb2RlIHdhcyB3cml0 dGVuIGJ5IERyZXcgQWRhbXMuICBTdGVmYW4gS2FuZ2FzIGFkYXB0ZWQgaXQgZm9yCmluY2x1c2lv biBpbiBFbWFjcywgYWRkZWQgdW5pdCB0ZXN0cyBhbmQgZG9jdW1lbnRhdGlvbi4KCiogbGlzcC9o ZWxwLWZucy5lbCAoZGVzY3JpYmUta2V5bWFwKTogTmV3IGZ1bmN0aW9uIHRvIHNob3cga2V5CmJp bmRpbmdzIGZvciBhIGdpdmVuIGtleW1hcC4gIChCdWcjMzA2NjApCiogZG9jL2xpc3ByZWYva2V5 bWFwcy50ZXhpIChTY2FubmluZyBLZXltYXBzKTogRG9jdW1lbnQgaXQuCiogZXRjL05FV1M6IEFu bm91bmNlIGl0LgoKKiB0ZXN0L2xpc3AvaGVscC1mbnMtdGVzdHMuZWwgKGhlbHAtZm5zLXRlc3Qt ZGVzY3JpYmUta2V5bWFwL3N5bWJvbCkKKGhlbHAtZm5zLXRlc3QtZGVzY3JpYmUta2V5bWFwL3Zh bHVlKQooaGVscC1mbnMtdGVzdC1kZXNjcmliZS1rZXltYXAvdmFsdWUrc2VhcmNoLXN5bWJvbHMp CihoZWxwLWZucy10ZXN0LWRlc2NyaWJlLWtleW1hcC9zeW1ib2wrc2VhcmNoLXN5bWJvbHMpCiho ZWxwLWZucy10ZXN0LWRlc2NyaWJlLWtleW1hcC9ub3Qta2V5bWFwKQooaGVscC1mbnMtdGVzdC1k ZXNjcmliZS1rZXltYXAvbGV0LWJvdW5kKQooaGVscC1mbnMtdGVzdC1kZXNjcmliZS1rZXltYXAv ZHluYW1pY2FsbHktYm91bmQtbm8tZmlsZSk6IE5ldyB0ZXN0cy4KLS0tCiBkb2MvbGlzcHJlZi9r ZXltYXBzLnRleGkgICAgfCAxMiArKysrKysKIGV0Yy9ORVdTICAgICAgICAgICAgICAgICAgICB8 ICAzICsrCiBsaXNwL2hlbHAtZm5zLmVsICAgICAgICAgICAgfCA3MyArKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrCiB0ZXN0L2xpc3AvaGVscC1mbnMtdGVzdHMuZWwgfCA0NSAr KysrKysrKysrKysrKysrKysrKysrKwogNCBmaWxlcyBjaGFuZ2VkLCAxMzMgaW5zZXJ0aW9ucygr KQoKZGlmZiAtLWdpdCBhL2RvYy9saXNwcmVmL2tleW1hcHMudGV4aSBiL2RvYy9saXNwcmVmL2tl eW1hcHMudGV4aQppbmRleCA1MzJlNTM3MDI2Li41NjllNjEzN2U2IDEwMDY0NAotLS0gYS9kb2Mv bGlzcHJlZi9rZXltYXBzLnRleGkKKysrIGIvZG9jL2xpc3ByZWYva2V5bWFwcy50ZXhpCkBAIC0y MDA0LDYgKzIwMDQsMTggQEAgU2Nhbm5pbmcgS2V5bWFwcwogaW5zdGVhZCBvZiB0aGUgY3VycmVu dCBidWZmZXIncy4KIEBlbmQgZGVmZm4KIAorQGRlZmZuIENvbW1hbmQgZGVzY3JpYmUta2V5bWFw IGtleW1hcCAmb3B0aW9uYWwgc2VhcmNoLXN5bWJvbHMKK1RoaXMgZnVuY3Rpb24gY3JlYXRlcyBh IGxpc3Rpbmcgb2YgYWxsIGtleSBiaW5kaW5ncyBpbiB2YXJpYWJsZQorQHZhcntrZXltYXB9LCBh bmQgZGlzcGxheXMgaXQgaW4gYSBidWZmZXIgbmFtZWQgQGZpbGV7KkhlbHAqfS4gIFdoZW4KK2Nh bGxlZCBpbnRlcmFjdGl2ZWx5LCBwcm9tcHQgZm9yIGEgdmFyaWFibGUgdGhhdCBoYXMgYSBrZXlt YXAgdmFsdWUuCisKK0lmIG9wdGlvbmFsIGFyZ3VtZW50IEB2YXJ7c2VhcmNoLXN5bWJvbHN9IGlz IG5vbi1uaWwsIGFuZCBAdmFye2tleW1hcH0KK2lzIG5vdCBhIHN5bWJvbCwgc2VhcmNoIGFsbCB2 YXJpYWJsZXMgZm9yIG9uZSB3aG9zZSB2YWx1ZSBpcyBLRVlNQVAKK2FuZCB1c2UgdGhhdCB0byBk ZXNjcmliZSB0aGUga2V5IGJpbmRpbmdzLiAgVGhpcyBtYWtlcyBpdCBwb3NzaWJsZSB0bworbm90 IG9ubHkgc2VlIHRoZSBiaW5kaW5ncyBidXQgYWxzbyB0byBpZGVudGlmeSB0aGUgbmFtZSBvZiBh IGtleW1hcAord2hlbiB5b3UgaGF2ZSBpdHMgdmFsdWUuCitAZW5kIGRlZmZuCisKIEBub2RlIE1l bnUgS2V5bWFwcwogQHNlY3Rpb24gTWVudSBLZXltYXBzCiBAY2luZGV4IG1lbnUga2V5bWFwcwpk aWZmIC0tZ2l0IGEvZXRjL05FV1MgYi9ldGMvTkVXUwppbmRleCBlMWViNzRmODZlLi4wNWMyOTQw YTkyIDEwMDY0NAotLS0gYS9ldGMvTkVXUworKysgYi9ldGMvTkVXUwpAQCAtMTMzNyw2ICsxMzM3 LDkgQEAgZGlyZWN0b3JpZXMgaW4gdGhlIGRlc3RpbmF0aW9uLgogCiAqKiBIZWxwCiAKKysrKwor KioqIE5ldyBjb21tYW5kICdkZXNjcmliZS1rZXltYXAnIGRlc2NyaWJlcyBrZXliaW5kaW5ncyBp biBhIGtleW1hcC4KKwogLS0tCiAqKiogRGVzY3JpcHRpb24gb2YgdmFyaWFibGVzIGFuZCBmdW5j dGlvbnMgZ2l2ZSBhbiBlc3RpbWF0ZWQgZmlyc3QgcmVsZWFzZS4KIApkaWZmIC0tZ2l0IGEvbGlz cC9oZWxwLWZucy5lbCBiL2xpc3AvaGVscC1mbnMuZWwKaW5kZXggMjM1YWE5YTZlMS4uMjc2ZDQ0 OTU4YiAxMDA2NDQKLS0tIGEvbGlzcC9oZWxwLWZucy5lbAorKysgYi9saXNwL2hlbHAtZm5zLmVs CkBAIC0xNTU3LDYgKzE1NTcsNzkgQEAgZGVzY3JpYmUtY2F0ZWdvcmllcwogCSAgKGluc2VydCAi XG5UaGUgcGFyZW50IGNhdGVnb3J5IHRhYmxlIGlzOiIpCiAJICAoZGVzY3JpYmUtdmVjdG9yIHRh YmxlICdoZWxwLWRlc2NyaWJlLWNhdGVnb3J5LXNldCkpKSkpKQogCis7OzsjIyNhdXRvbG9hZAor KGRlZnVuIGRlc2NyaWJlLWtleW1hcCAoa2V5bWFwICZvcHRpb25hbCBzZWFyY2gtc3ltYm9scykK KyAgIkRlc2NyaWJlIGtleSBiaW5kaW5ncyBpbiBLRVlNQVAuCitXaGVuIGNhbGxlZCBpbnRlcmFj dGl2ZWx5LCBwcm9tcHQgZm9yIGEgdmFyaWFibGUgdGhhdCBoYXMgYQora2V5bWFwIHZhbHVlLiAg Q29tcGxldGlvbiBpcyBhdmFpbGFibGUgZm9yIHRoZSB2YXJpYWJsZSBuYW1lLgorCitJZiBvcHRp b25hbCBhcmd1bWVudCBTRUFSQ0gtU1lNQk9MUyBpcyBub24tbmlsLCBhbmQgS0VZTUFQIGlzCitu b3QgYSBzeW1ib2wsIHNlYXJjaCBhbGwgdmFyaWFibGVzIGZvciBvbmUgd2hvc2UgdmFsdWUgaXMg S0VZTUFQCithbmQgdXNlIHRoYXQgdG8gZGVzY3JpYmUgdGhlIGtleSBiaW5kaW5ncy4gIFRoaXMg bWFrZXMgaXQKK3Bvc3NpYmxlIHRvIG5vdCBvbmx5IHNlZSB0aGUgYmluZGluZ3MgYnV0IGFsc28g dG8gaWRlbnRpZnkgdGhlCituYW1lIG9mIHRoZSBrZXltYXAgaW4gcXVlc3Rpb24uIgorICAoaW50 ZXJhY3RpdmUgKGxpc3QKKyAgICAgICAgICAgICAgICAoaW50ZXJuIChjb21wbGV0aW5nLXJlYWQg IktleW1hcDogIiBvYmFycmF5CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIChsYW1iZGEgKG0pCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgKGFuZCAoYm91bmRwIG0pCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAoa2V5bWFwcCAoc3ltYm9sLXZhbHVlIG0pKSkpCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHQgbmlsICd2YXJpYWJsZS1uYW1lLWhpc3RvcnkpKSkp CisgIChsZXQgKHVzZWQtZ2VudGVtcCkKKyAgICAodW5sZXNzIChhbmQgKHN5bWJvbHAga2V5bWFw KQorICAgICAgICAgICAgICAgICAoYm91bmRwIGtleW1hcCkKKyAgICAgICAgICAgICAgICAgKGtl eW1hcHAgKHN5bWJvbC12YWx1ZSBrZXltYXApKSkKKyAgICAgICh3aGVuIChub3QgKGtleW1hcHAg a2V5bWFwKSkKKyAgICAgICAgKGlmIChzeW1ib2xwIGtleW1hcCkKKyAgICAgICAgICAgIChlcnJv ciAiTm90IGEga2V5bWFwIHZhcmlhYmxlOiAlUyIga2V5bWFwKQorICAgICAgICAgIChlcnJvciAi Tm90IGEga2V5bWFwIikpKQorICAgICAgKGxldCAoKHN5bSBuaWwpKQorICAgICAgICAod2hlbiBz ZWFyY2gtc3ltYm9scworICAgICAgICAgIChzZXRxIHN5bSAoY2F0Y2ggJ2Rlc2NyaWJlLWtleW1h cAorICAgICAgICAgICAgICAgICAgICAgIChtYXBhdG9tcyAobGFtYmRhIChzeW1iKQorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICh3aGVuIChhbmQgKGJvdW5kcCBzeW1iKQorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGVxIChzeW1ib2wtdmFs dWUgc3ltYikga2V5bWFwKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgKG5vdCAoZXEgc3ltYiAna2V5bWFwKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICh0aHJvdyAnZGVzY3JpYmUta2V5bWFwIHN5bWIpKSkpKQorICAg ICAgICAgICAgICAgICAgICAgIG5pbCkpKQorICAgICAgICAodW5sZXNzIHN5bQorICAgICAgICAg IChzZXRxIHN5bSAoY2wtZ2VudGVtcCAiS0VZTUFQIE9CSkVDVCAobm8gdmFyaWFibGUpICIpKQor ICAgICAgICAgIChzZXRxIHVzZWQtZ2VudGVtcCB0KQorICAgICAgICAgIChzZXQgc3ltIGtleW1h cCkpCisgICAgICAgIChzZXRxIGtleW1hcCBzeW0pKSkKKyAgICA7OyBGb2xsb3cgYWxpYXNpbmcu CisgICAgKHNldHEga2V5bWFwIChvciAoaWdub3JlLWVycm9ycyAoaW5kaXJlY3QtdmFyaWFibGUg a2V5bWFwKSkga2V5bWFwKSkKKyAgICAoaGVscC1zZXR1cC14cmVmIChsaXN0ICMnZGVzY3JpYmUt a2V5bWFwIGtleW1hcCkKKyAgICAgICAgICAgICAgICAgICAgIChjYWxsZWQtaW50ZXJhY3RpdmVs eS1wICdpbnRlcmFjdGl2ZSkpCisgICAgKGxldCogKChuYW1lIChzeW1ib2wtbmFtZSBrZXltYXAp KQorICAgICAgICAgICAoZG9jIChkb2N1bWVudGF0aW9uLXByb3BlcnR5IGtleW1hcCAndmFyaWFi bGUtZG9jdW1lbnRhdGlvbikpCisgICAgICAgICAgIChmaWxlLW5hbWUgKGZpbmQtbGlzcC1vYmpl Y3QtZmlsZS1uYW1lIGtleW1hcCAnZGVmdmFyKSkpCisgICAgICAod2l0aC1oZWxwLXdpbmRvdyAo aGVscC1idWZmZXIpCisgICAgICAgICh3aXRoLWN1cnJlbnQtYnVmZmVyIHN0YW5kYXJkLW91dHB1 dAorICAgICAgICAgICh1bmxlc3MgdXNlZC1nZW50ZW1wCisgICAgICAgICAgICAocHJpbmMgKGZv cm1hdC1tZXNzYWdlICIlUyBpcyBhIGtleW1hcCB2YXJpYWJsZSIga2V5bWFwKSkKKyAgICAgICAg ICAgIChpZiAobm90IGZpbGUtbmFtZSkKKyAgICAgICAgICAgICAgICAocHJpbmMgIi5cblxuIikK KyAgICAgICAgICAgICAgKHByaW5jIChmb3JtYXQtbWVzc2FnZQorICAgICAgICAgICAgICAgICAg ICAgICIgZGVmaW5lZCBpbiBgJXMnLlxuXG4iCisgICAgICAgICAgICAgICAgICAgICAgKGlmIChl cSBmaWxlLW5hbWUgJ0Mtc291cmNlKQorICAgICAgICAgICAgICAgICAgICAgICAgICAiQyBzb3Vy Y2UgY29kZSIKKyAgICAgICAgICAgICAgICAgICAgICAgIChmaWxlLW5hbWUtbm9uZGlyZWN0b3J5 IGZpbGUtbmFtZSkpKSkKKyAgICAgICAgICAgICAgKHNhdmUtZXhjdXJzaW9uCisgICAgICAgICAg ICAgICAgKHJlLXNlYXJjaC1iYWNrd2FyZCAoc3Vic3RpdHV0ZS1jb21tYW5kLWtleXMKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiYFxcKFteYCddK1xcKSciKQorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbmlsIHQpCisgICAgICAgICAgICAgICAgKGhl bHAteHJlZi1idXR0b24gMSAnaGVscC12YXJpYWJsZS1kZWYKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBrZXltYXAgZmlsZS1uYW1lKSkpKQorICAgICAgICAgICh3aGVuIChhbmQg KG5vdCAoZXF1YWwgIiIgZG9jKSkgZG9jKQorICAgICAgICAgICAgKHByaW5jICJEb2N1bWVudGF0 aW9uOlxuIikKKyAgICAgICAgICAgIChwcmluYyAoZm9ybWF0LW1lc3NhZ2UgIiVzXG5cbiIgZG9j KSkpCisgICAgICAgICAgOzsgVXNlIGBpbnNlcnQnIGluc3RlYWQgb2YgYHByaW5jJywgc28gY29u dHJvbCBjaGFycyAoZS5nLiBcMzc3KQorICAgICAgICAgIDs7IGluc2VydCBjb3JyZWN0bHkuCisg ICAgICAgICAgKGluc2VydCAoc3Vic3RpdHV0ZS1jb21tYW5kLWtleXMgKGNvbmNhdCAiXFx7IiBu YW1lICJ9IikpKSkpKQorICAgIDs7IENsZWFudXAuCisgICAgKHdoZW4gdXNlZC1nZW50ZW1wCisg ICAgICAobWFrdW5ib3VuZCBrZXltYXApKSkpCisKIAwKIDs7OyBSZXBsYWNlbWVudHMgZm9yIG9s ZCBsaWItc3JjLyBwcm9ncmFtcy4gIERvbid0IHNlZW0gZXNwZWNpYWxseSB1c2VmdWwuCiAKZGlm ZiAtLWdpdCBhL3Rlc3QvbGlzcC9oZWxwLWZucy10ZXN0cy5lbCBiL3Rlc3QvbGlzcC9oZWxwLWZu cy10ZXN0cy5lbAppbmRleCBkYTRkMjVkMGE2Li4zMGM4ZmFhOGE4IDEwMDY0NAotLS0gYS90ZXN0 L2xpc3AvaGVscC1mbnMtdGVzdHMuZWwKKysrIGIvdGVzdC9saXNwL2hlbHAtZm5zLXRlc3RzLmVs CkBAIC0xMjMsNCArMTIzLDQ5IEBAIGhlbHAtZm5zLXRlc3QtZGVzY3JpYmUtc3ltYm9sCiAgICAg KGdvdG8tY2hhciAocG9pbnQtbWluKSkKICAgICAoc2hvdWxkIChsb29raW5nLWF0ICJeZm9udC1s b2NrLWNvbW1lbnQtZmFjZSBpcyAiKSkpKQogCisMCisKKzs7OyBUZXN0cyBmb3IgZGVzY3JpYmUt a2V5bWFwCisoZXJ0LWRlZnRlc3QgaGVscC1mbnMtdGVzdC1kZXNjcmliZS1rZXltYXAvc3ltYm9s ICgpCisgIChkZXNjcmliZS1rZXltYXAgJ21pbmlidWZmZXItbG9jYWwtbXVzdC1tYXRjaC1tYXAp CisgICh3aXRoLWN1cnJlbnQtYnVmZmVyICIqSGVscCoiCisgICAgKHNob3VsZCAobG9va2luZy1h dCAiXm1pbmlidWZmZXItbG9jYWwtbXVzdC1tYXRjaC1tYXAgaXMiKSkpKQorCisoZXJ0LWRlZnRl c3QgaGVscC1mbnMtdGVzdC1kZXNjcmliZS1rZXltYXAvdmFsdWUgKCkKKyAgKGRlc2NyaWJlLWtl eW1hcCBtaW5pYnVmZmVyLWxvY2FsLW11c3QtbWF0Y2gtbWFwKQorICAod2l0aC1jdXJyZW50LWJ1 ZmZlciAiKkhlbHAqIgorICAgIChzaG91bGQgKGxvb2tpbmctYXQgIl5rZXkiKSkpKQorCisoZXJ0 LWRlZnRlc3QgaGVscC1mbnMtdGVzdC1kZXNjcmliZS1rZXltYXAvdmFsdWUrc2VhcmNoLXN5bWJv bHMgKCkKKyAgKGRlc2NyaWJlLWtleW1hcCBtaW5pYnVmZmVyLWxvY2FsLW11c3QtbWF0Y2gtbWFw IHQpCisgICh3aXRoLWN1cnJlbnQtYnVmZmVyICIqSGVscCoiCisgICAgKG1lc3NhZ2UgIiMjIyMj IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyIpCisgICAgOzsgKG1lc3NhZ2UgIiVTIiBtaW5pYnVm ZmVyLWxvY2FsLW11c3QtbWF0Y2gtbWFwKQorICAgIChtZXNzYWdlIChidWZmZXItc3RyaW5nKSkK KyAgICAobWVzc2FnZSAiIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIikKKyAgICAoc2hv dWxkIChsb29raW5nLWF0ICJebWluaWJ1ZmZlci1sb2NhbC1tdXN0LW1hdGNoLW1hcCBpcyIpKSkp CisKKyhlcnQtZGVmdGVzdCBoZWxwLWZucy10ZXN0LWRlc2NyaWJlLWtleW1hcC9zeW1ib2wrc2Vh cmNoLXN5bWJvbHMgKCkKKyAgKGRlc2NyaWJlLWtleW1hcCAnbWluaWJ1ZmZlci1sb2NhbC1tdXN0 LW1hdGNoLW1hcCB0KQorICAod2l0aC1jdXJyZW50LWJ1ZmZlciAiKkhlbHAqIgorICAgIChzaG91 bGQgKGxvb2tpbmctYXQgIl5taW5pYnVmZmVyLWxvY2FsLW11c3QtbWF0Y2gtbWFwIGlzIikpKSkK KworKGVydC1kZWZ0ZXN0IGhlbHAtZm5zLXRlc3QtZGVzY3JpYmUta2V5bWFwL25vdC1rZXltYXAg KCkKKyAgKHNob3VsZC1lcnJvciAoZGVzY3JpYmUta2V5bWFwIG5pbCkpCisgIChzaG91bGQtZXJy b3IgKGRlc2NyaWJlLWtleW1hcCBlbWFjcy12ZXJzaW9uKSkKKyAgKHNob3VsZC1lcnJvciAoZGVz Y3JpYmUta2V5bWFwIG5pbCB0KSkKKyAgKHNob3VsZC1lcnJvciAoZGVzY3JpYmUta2V5bWFwIGVt YWNzLXZlcnNpb24gdCkpKQorCisoZXJ0LWRlZnRlc3QgaGVscC1mbnMtdGVzdC1kZXNjcmliZS1r ZXltYXAvbGV0LWJvdW5kICgpCisgIChsZXQgKChmb29iYXIgbWluaWJ1ZmZlci1sb2NhbC1tdXN0 LW1hdGNoLW1hcCkpCisgICAgKGRlc2NyaWJlLWtleW1hcCBmb29iYXIpCisgICAgKHdpdGgtY3Vy cmVudC1idWZmZXIgIipIZWxwKiIKKyAgICAgIChzaG91bGQgKGxvb2tpbmctYXQgIl5rZXkiKSkp KSkKKworKGVydC1kZWZ0ZXN0IGhlbHAtZm5zLXRlc3QtZGVzY3JpYmUta2V5bWFwL2R5bmFtaWNh bGx5LWJvdW5kLW5vLWZpbGUgKCkKKyAgKHNldHEgaGVscC1mbnMtdGVzdC0tZGVzY3JpYmUta2V5 bWFwLWZvbyBtaW5pYnVmZmVyLWxvY2FsLW11c3QtbWF0Y2gtbWFwKQorICAoZGVzY3JpYmUta2V5 bWFwICdoZWxwLWZucy10ZXN0LS1kZXNjcmliZS1rZXltYXAtZm9vKQorICAod2l0aC1jdXJyZW50 LWJ1ZmZlciAiKkhlbHAqIgorICAgIChzaG91bGQgKGxvb2tpbmctYXQgIl5oZWxwLWZucy10ZXN0 LS1kZXNjcmliZS1rZXltYXAtZm9vIGlzIikpKSkKKwogOzs7IGhlbHAtZm5zLXRlc3RzLmVsIGVu ZHMgaGVyZQotLSAKMi4yMy4wCgo= --00000000000043a0a6059517ffdb-- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 17 05:42:45 2019 Received: (at 30660) by debbugs.gnu.org; 17 Oct 2019 09:42:45 +0000 Received: from localhost ([127.0.0.1]:47150 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iL2Iu-0004wt-Rk for submit@debbugs.gnu.org; Thu, 17 Oct 2019 05:42:45 -0400 Received: from mail-pf1-f181.google.com ([209.85.210.181]:33769) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iL2It-0004we-86 for 30660@debbugs.gnu.org; Thu, 17 Oct 2019 05:42:43 -0400 Received: by mail-pf1-f181.google.com with SMTP id q10so1304714pfl.0 for <30660@debbugs.gnu.org>; Thu, 17 Oct 2019 02:42:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OEsfIigSOIUsbTFtjigEXmQ4yAAyJGnbfKQpepipeZ4=; b=KJdF1Bchu3JFOKuCivxpJfuYzAHAE1/kpJ1bbD52W9EJZ2AxC8bl/Urm29hjX+ea2o 7v3pcGUGWn0a515WM0h8kNxFXOT2vfM2aFqcog9j5C84++awBJWSFQbsEXGCGqCFNI32 fxDrNURPvj+yjEcHtfqpt1kj7BI2vf56Ah355gi2dCkBMpboVAPfecNE65RJ4+JyDkoq 9UhO9RmapUagx5ENnuaTX69OsNboedm3TCf5edwBUijYUDJM7XVq4YzQ2z/y12Who+di 48kJz9ZOvZCGw5QapTYRLzo7G7Xy5g9o7+eqLs4i7E6iNQWpDnaASMT1c8rQ4zfaC3Zz +Pcw== X-Gm-Message-State: APjAAAVhU284Vb+Il4xCdzBtdwnMXgLNUmj5h4FU7S+DxNA0aOGSQYHV nZoYz4K0WbCJ7ttOBavnaJOCYcdII7GL7qYHPJC11Q== X-Google-Smtp-Source: APXvYqzpUsAbQDOp654GyLbf65AdianwEIQByCUm9/ZjW9Q4HrmvxK5lNT/QKN18SgJWD6u+sWj52U2GfLlJw4oKWQo= X-Received: by 2002:a63:4046:: with SMTP id n67mr2912877pga.200.1571305357168; Thu, 17 Oct 2019 02:42:37 -0700 (PDT) MIME-Version: 1.0 References: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> <87tv8bul5g.fsf@gnus.org> <8336fvhxt0.fsf@gnu.org> In-Reply-To: From: Stefan Kangas Date: Thu, 17 Oct 2019 11:42:25 +0200 Message-ID: Subject: Re: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") To: Eli Zaretskii Content-Type: multipart/mixed; boundary="000000000000a9899605951809bc" X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 30660 Cc: Lars Ingebrigtsen , 30660@debbugs.gnu.org, Drew Adams , =?UTF-8?B?56mN5Li55bC8IERhbiBKYWNvYnNvbg==?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) --000000000000a9899605951809bc Content-Type: text/plain; charset="UTF-8" Stefan Kangas writes: > Please find attached an updated patch fixing your comments as well as > earlier comments by Drew Adams. > > In addition to adding this to NEWS, I've also updated the elisp manual. Second try; I'd forgotten to remove some debug printouts from the tests. Best regards, Stefan Kangas --000000000000a9899605951809bc Content-Type: application/octet-stream; name="0001-Add-new-help-function-describe-keymap.patch" Content-Disposition: attachment; filename="0001-Add-new-help-function-describe-keymap.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k1uilh1p0 RnJvbSAxMGY0YzA3MDMwMmEyYjJiYzBjYjIxMTVhMGRkOTE5MjEyMDhiOWFjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBTYXQsIDI0IEF1ZyAyMDE5IDAxOjAyOjA0ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g QWRkIG5ldyBoZWxwIGZ1bmN0aW9uIGRlc2NyaWJlLWtleW1hcAoKVGhpcyBjb2RlIHdhcyB3cml0 dGVuIGJ5IERyZXcgQWRhbXMuICBTdGVmYW4gS2FuZ2FzIGFkYXB0ZWQgaXQgZm9yCmluY2x1c2lv biBpbiBFbWFjcywgYWRkZWQgdW5pdCB0ZXN0cyBhbmQgZG9jdW1lbnRhdGlvbi4KCiogbGlzcC9o ZWxwLWZucy5lbCAoZGVzY3JpYmUta2V5bWFwKTogTmV3IGZ1bmN0aW9uIHRvIHNob3cga2V5CmJp bmRpbmdzIGZvciBhIGdpdmVuIGtleW1hcC4gIChCdWcjMzA2NjApCiogZG9jL2xpc3ByZWYva2V5 bWFwcy50ZXhpIChTY2FubmluZyBLZXltYXBzKTogRG9jdW1lbnQgaXQuCiogZXRjL05FV1M6IEFu bm91bmNlIGl0LgoKKiB0ZXN0L2xpc3AvaGVscC1mbnMtdGVzdHMuZWwgKGhlbHAtZm5zLXRlc3Qt ZGVzY3JpYmUta2V5bWFwL3N5bWJvbCkKKGhlbHAtZm5zLXRlc3QtZGVzY3JpYmUta2V5bWFwL3Zh bHVlKQooaGVscC1mbnMtdGVzdC1kZXNjcmliZS1rZXltYXAvdmFsdWUrc2VhcmNoLXN5bWJvbHMp CihoZWxwLWZucy10ZXN0LWRlc2NyaWJlLWtleW1hcC9zeW1ib2wrc2VhcmNoLXN5bWJvbHMpCiho ZWxwLWZucy10ZXN0LWRlc2NyaWJlLWtleW1hcC9ub3Qta2V5bWFwKQooaGVscC1mbnMtdGVzdC1k ZXNjcmliZS1rZXltYXAvbGV0LWJvdW5kKQooaGVscC1mbnMtdGVzdC1kZXNjcmliZS1rZXltYXAv ZHluYW1pY2FsbHktYm91bmQtbm8tZmlsZSk6IE5ldyB0ZXN0cy4KLS0tCiBkb2MvbGlzcHJlZi9r ZXltYXBzLnRleGkgICAgfCAxMiArKysrKysKIGV0Yy9ORVdTICAgICAgICAgICAgICAgICAgICB8 ICAzICsrCiBsaXNwL2hlbHAtZm5zLmVsICAgICAgICAgICAgfCA3MyArKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrCiB0ZXN0L2xpc3AvaGVscC1mbnMtdGVzdHMuZWwgfCA0MSAr KysrKysrKysrKysrKysrKysrKysKIDQgZmlsZXMgY2hhbmdlZCwgMTI5IGluc2VydGlvbnMoKykK CmRpZmYgLS1naXQgYS9kb2MvbGlzcHJlZi9rZXltYXBzLnRleGkgYi9kb2MvbGlzcHJlZi9rZXlt YXBzLnRleGkKaW5kZXggNTMyZTUzNzAyNi4uNTY5ZTYxMzdlNiAxMDA2NDQKLS0tIGEvZG9jL2xp c3ByZWYva2V5bWFwcy50ZXhpCisrKyBiL2RvYy9saXNwcmVmL2tleW1hcHMudGV4aQpAQCAtMjAw NCw2ICsyMDA0LDE4IEBAIFNjYW5uaW5nIEtleW1hcHMKIGluc3RlYWQgb2YgdGhlIGN1cnJlbnQg YnVmZmVyJ3MuCiBAZW5kIGRlZmZuCiAKK0BkZWZmbiBDb21tYW5kIGRlc2NyaWJlLWtleW1hcCBr ZXltYXAgJm9wdGlvbmFsIHNlYXJjaC1zeW1ib2xzCitUaGlzIGZ1bmN0aW9uIGNyZWF0ZXMgYSBs aXN0aW5nIG9mIGFsbCBrZXkgYmluZGluZ3MgaW4gdmFyaWFibGUKK0B2YXJ7a2V5bWFwfSwgYW5k IGRpc3BsYXlzIGl0IGluIGEgYnVmZmVyIG5hbWVkIEBmaWxleypIZWxwKn0uICBXaGVuCitjYWxs ZWQgaW50ZXJhY3RpdmVseSwgcHJvbXB0IGZvciBhIHZhcmlhYmxlIHRoYXQgaGFzIGEga2V5bWFw IHZhbHVlLgorCitJZiBvcHRpb25hbCBhcmd1bWVudCBAdmFye3NlYXJjaC1zeW1ib2xzfSBpcyBu b24tbmlsLCBhbmQgQHZhcntrZXltYXB9CitpcyBub3QgYSBzeW1ib2wsIHNlYXJjaCBhbGwgdmFy aWFibGVzIGZvciBvbmUgd2hvc2UgdmFsdWUgaXMgS0VZTUFQCithbmQgdXNlIHRoYXQgdG8gZGVz Y3JpYmUgdGhlIGtleSBiaW5kaW5ncy4gIFRoaXMgbWFrZXMgaXQgcG9zc2libGUgdG8KK25vdCBv bmx5IHNlZSB0aGUgYmluZGluZ3MgYnV0IGFsc28gdG8gaWRlbnRpZnkgdGhlIG5hbWUgb2YgYSBr ZXltYXAKK3doZW4geW91IGhhdmUgaXRzIHZhbHVlLgorQGVuZCBkZWZmbgorCiBAbm9kZSBNZW51 IEtleW1hcHMKIEBzZWN0aW9uIE1lbnUgS2V5bWFwcwogQGNpbmRleCBtZW51IGtleW1hcHMKZGlm ZiAtLWdpdCBhL2V0Yy9ORVdTIGIvZXRjL05FV1MKaW5kZXggZTFlYjc0Zjg2ZS4uMDVjMjk0MGE5 MiAxMDA2NDQKLS0tIGEvZXRjL05FV1MKKysrIGIvZXRjL05FV1MKQEAgLTEzMzcsNiArMTMzNyw5 IEBAIGRpcmVjdG9yaWVzIGluIHRoZSBkZXN0aW5hdGlvbi4KIAogKiogSGVscAogCisrKysKKyoq KiBOZXcgY29tbWFuZCAnZGVzY3JpYmUta2V5bWFwJyBkZXNjcmliZXMga2V5YmluZGluZ3MgaW4g YSBrZXltYXAuCisKIC0tLQogKioqIERlc2NyaXB0aW9uIG9mIHZhcmlhYmxlcyBhbmQgZnVuY3Rp b25zIGdpdmUgYW4gZXN0aW1hdGVkIGZpcnN0IHJlbGVhc2UuCiAKZGlmZiAtLWdpdCBhL2xpc3Av aGVscC1mbnMuZWwgYi9saXNwL2hlbHAtZm5zLmVsCmluZGV4IDIzNWFhOWE2ZTEuLjI3NmQ0NDk1 OGIgMTAwNjQ0Ci0tLSBhL2xpc3AvaGVscC1mbnMuZWwKKysrIGIvbGlzcC9oZWxwLWZucy5lbApA QCAtMTU1Nyw2ICsxNTU3LDc5IEBAIGRlc2NyaWJlLWNhdGVnb3JpZXMKIAkgIChpbnNlcnQgIlxu VGhlIHBhcmVudCBjYXRlZ29yeSB0YWJsZSBpczoiKQogCSAgKGRlc2NyaWJlLXZlY3RvciB0YWJs ZSAnaGVscC1kZXNjcmliZS1jYXRlZ29yeS1zZXQpKSkpKSkKIAorOzs7IyMjYXV0b2xvYWQKKyhk ZWZ1biBkZXNjcmliZS1rZXltYXAgKGtleW1hcCAmb3B0aW9uYWwgc2VhcmNoLXN5bWJvbHMpCisg ICJEZXNjcmliZSBrZXkgYmluZGluZ3MgaW4gS0VZTUFQLgorV2hlbiBjYWxsZWQgaW50ZXJhY3Rp dmVseSwgcHJvbXB0IGZvciBhIHZhcmlhYmxlIHRoYXQgaGFzIGEKK2tleW1hcCB2YWx1ZS4gIENv bXBsZXRpb24gaXMgYXZhaWxhYmxlIGZvciB0aGUgdmFyaWFibGUgbmFtZS4KKworSWYgb3B0aW9u YWwgYXJndW1lbnQgU0VBUkNILVNZTUJPTFMgaXMgbm9uLW5pbCwgYW5kIEtFWU1BUCBpcworbm90 IGEgc3ltYm9sLCBzZWFyY2ggYWxsIHZhcmlhYmxlcyBmb3Igb25lIHdob3NlIHZhbHVlIGlzIEtF WU1BUAorYW5kIHVzZSB0aGF0IHRvIGRlc2NyaWJlIHRoZSBrZXkgYmluZGluZ3MuICBUaGlzIG1h a2VzIGl0Citwb3NzaWJsZSB0byBub3Qgb25seSBzZWUgdGhlIGJpbmRpbmdzIGJ1dCBhbHNvIHRv IGlkZW50aWZ5IHRoZQorbmFtZSBvZiB0aGUga2V5bWFwIGluIHF1ZXN0aW9uLiIKKyAgKGludGVy YWN0aXZlIChsaXN0CisgICAgICAgICAgICAgICAgKGludGVybiAoY29tcGxldGluZy1yZWFkICJL ZXltYXA6ICIgb2JhcnJheQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAobGFtYmRhIChtKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IChhbmQgKGJvdW5kcCBtKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgKGtleW1hcHAgKHN5bWJvbC12YWx1ZSBtKSkpKQorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICB0IG5pbCAndmFyaWFibGUtbmFtZS1oaXN0b3J5KSkpKQor ICAobGV0ICh1c2VkLWdlbnRlbXApCisgICAgKHVubGVzcyAoYW5kIChzeW1ib2xwIGtleW1hcCkK KyAgICAgICAgICAgICAgICAgKGJvdW5kcCBrZXltYXApCisgICAgICAgICAgICAgICAgIChrZXlt YXBwIChzeW1ib2wtdmFsdWUga2V5bWFwKSkpCisgICAgICAod2hlbiAobm90IChrZXltYXBwIGtl eW1hcCkpCisgICAgICAgIChpZiAoc3ltYm9scCBrZXltYXApCisgICAgICAgICAgICAoZXJyb3Ig Ik5vdCBhIGtleW1hcCB2YXJpYWJsZTogJVMiIGtleW1hcCkKKyAgICAgICAgICAoZXJyb3IgIk5v dCBhIGtleW1hcCIpKSkKKyAgICAgIChsZXQgKChzeW0gbmlsKSkKKyAgICAgICAgKHdoZW4gc2Vh cmNoLXN5bWJvbHMKKyAgICAgICAgICAoc2V0cSBzeW0gKGNhdGNoICdkZXNjcmliZS1rZXltYXAK KyAgICAgICAgICAgICAgICAgICAgICAobWFwYXRvbXMgKGxhbWJkYSAoc3ltYikKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAod2hlbiAoYW5kIChib3VuZHAgc3ltYikKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChlcSAoc3ltYm9sLXZhbHVl IHN5bWIpIGtleW1hcCkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIChub3QgKGVxIHN5bWIgJ2tleW1hcCkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAodGhyb3cgJ2Rlc2NyaWJlLWtleW1hcCBzeW1iKSkpKSkKKyAgICAg ICAgICAgICAgICAgICAgICBuaWwpKSkKKyAgICAgICAgKHVubGVzcyBzeW0KKyAgICAgICAgICAo c2V0cSBzeW0gKGNsLWdlbnRlbXAgIktFWU1BUCBPQkpFQ1QgKG5vIHZhcmlhYmxlKSAiKSkKKyAg ICAgICAgICAoc2V0cSB1c2VkLWdlbnRlbXAgdCkKKyAgICAgICAgICAoc2V0IHN5bSBrZXltYXAp KQorICAgICAgICAoc2V0cSBrZXltYXAgc3ltKSkpCisgICAgOzsgRm9sbG93IGFsaWFzaW5nLgor ICAgIChzZXRxIGtleW1hcCAob3IgKGlnbm9yZS1lcnJvcnMgKGluZGlyZWN0LXZhcmlhYmxlIGtl eW1hcCkpIGtleW1hcCkpCisgICAgKGhlbHAtc2V0dXAteHJlZiAobGlzdCAjJ2Rlc2NyaWJlLWtl eW1hcCBrZXltYXApCisgICAgICAgICAgICAgICAgICAgICAoY2FsbGVkLWludGVyYWN0aXZlbHkt cCAnaW50ZXJhY3RpdmUpKQorICAgIChsZXQqICgobmFtZSAoc3ltYm9sLW5hbWUga2V5bWFwKSkK KyAgICAgICAgICAgKGRvYyAoZG9jdW1lbnRhdGlvbi1wcm9wZXJ0eSBrZXltYXAgJ3ZhcmlhYmxl LWRvY3VtZW50YXRpb24pKQorICAgICAgICAgICAoZmlsZS1uYW1lIChmaW5kLWxpc3Atb2JqZWN0 LWZpbGUtbmFtZSBrZXltYXAgJ2RlZnZhcikpKQorICAgICAgKHdpdGgtaGVscC13aW5kb3cgKGhl bHAtYnVmZmVyKQorICAgICAgICAod2l0aC1jdXJyZW50LWJ1ZmZlciBzdGFuZGFyZC1vdXRwdXQK KyAgICAgICAgICAodW5sZXNzIHVzZWQtZ2VudGVtcAorICAgICAgICAgICAgKHByaW5jIChmb3Jt YXQtbWVzc2FnZSAiJVMgaXMgYSBrZXltYXAgdmFyaWFibGUiIGtleW1hcCkpCisgICAgICAgICAg ICAoaWYgKG5vdCBmaWxlLW5hbWUpCisgICAgICAgICAgICAgICAgKHByaW5jICIuXG5cbiIpCisg ICAgICAgICAgICAgIChwcmluYyAoZm9ybWF0LW1lc3NhZ2UKKyAgICAgICAgICAgICAgICAgICAg ICAiIGRlZmluZWQgaW4gYCVzJy5cblxuIgorICAgICAgICAgICAgICAgICAgICAgIChpZiAoZXEg ZmlsZS1uYW1lICdDLXNvdXJjZSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgIkMgc291cmNl IGNvZGUiCisgICAgICAgICAgICAgICAgICAgICAgICAoZmlsZS1uYW1lLW5vbmRpcmVjdG9yeSBm aWxlLW5hbWUpKSkpCisgICAgICAgICAgICAgIChzYXZlLWV4Y3Vyc2lvbgorICAgICAgICAgICAg ICAgIChyZS1zZWFyY2gtYmFja3dhcmQgKHN1YnN0aXR1dGUtY29tbWFuZC1rZXlzCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgImBcXChbXmAnXStcXCknIikKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIG5pbCB0KQorICAgICAgICAgICAgICAgIChoZWxw LXhyZWYtYnV0dG9uIDEgJ2hlbHAtdmFyaWFibGUtZGVmCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAga2V5bWFwIGZpbGUtbmFtZSkpKSkKKyAgICAgICAgICAod2hlbiAoYW5kIChu b3QgKGVxdWFsICIiIGRvYykpIGRvYykKKyAgICAgICAgICAgIChwcmluYyAiRG9jdW1lbnRhdGlv bjpcbiIpCisgICAgICAgICAgICAocHJpbmMgKGZvcm1hdC1tZXNzYWdlICIlc1xuXG4iIGRvYykp KQorICAgICAgICAgIDs7IFVzZSBgaW5zZXJ0JyBpbnN0ZWFkIG9mIGBwcmluYycsIHNvIGNvbnRy b2wgY2hhcnMgKGUuZy4gXDM3NykKKyAgICAgICAgICA7OyBpbnNlcnQgY29ycmVjdGx5LgorICAg ICAgICAgIChpbnNlcnQgKHN1YnN0aXR1dGUtY29tbWFuZC1rZXlzIChjb25jYXQgIlxceyIgbmFt ZSAifSIpKSkpKSkKKyAgICA7OyBDbGVhbnVwLgorICAgICh3aGVuIHVzZWQtZ2VudGVtcAorICAg ICAgKG1ha3VuYm91bmQga2V5bWFwKSkpKQorCiAMCiA7OzsgUmVwbGFjZW1lbnRzIGZvciBvbGQg bGliLXNyYy8gcHJvZ3JhbXMuICBEb24ndCBzZWVtIGVzcGVjaWFsbHkgdXNlZnVsLgogCmRpZmYg LS1naXQgYS90ZXN0L2xpc3AvaGVscC1mbnMtdGVzdHMuZWwgYi90ZXN0L2xpc3AvaGVscC1mbnMt dGVzdHMuZWwKaW5kZXggZGE0ZDI1ZDBhNi4uMGJkZmQ4YzM5YyAxMDA2NDQKLS0tIGEvdGVzdC9s aXNwL2hlbHAtZm5zLXRlc3RzLmVsCisrKyBiL3Rlc3QvbGlzcC9oZWxwLWZucy10ZXN0cy5lbApA QCAtMTIzLDQgKzEyMyw0NSBAQCBoZWxwLWZucy10ZXN0LWRlc2NyaWJlLXN5bWJvbAogICAgIChn b3RvLWNoYXIgKHBvaW50LW1pbikpCiAgICAgKHNob3VsZCAobG9va2luZy1hdCAiXmZvbnQtbG9j ay1jb21tZW50LWZhY2UgaXMgIikpKSkKIAorDAorCis7OzsgVGVzdHMgZm9yIGRlc2NyaWJlLWtl eW1hcAorKGVydC1kZWZ0ZXN0IGhlbHAtZm5zLXRlc3QtZGVzY3JpYmUta2V5bWFwL3N5bWJvbCAo KQorICAoZGVzY3JpYmUta2V5bWFwICdtaW5pYnVmZmVyLWxvY2FsLW11c3QtbWF0Y2gtbWFwKQor ICAod2l0aC1jdXJyZW50LWJ1ZmZlciAiKkhlbHAqIgorICAgIChzaG91bGQgKGxvb2tpbmctYXQg Il5taW5pYnVmZmVyLWxvY2FsLW11c3QtbWF0Y2gtbWFwIGlzIikpKSkKKworKGVydC1kZWZ0ZXN0 IGhlbHAtZm5zLXRlc3QtZGVzY3JpYmUta2V5bWFwL3ZhbHVlICgpCisgIChkZXNjcmliZS1rZXlt YXAgbWluaWJ1ZmZlci1sb2NhbC1tdXN0LW1hdGNoLW1hcCkKKyAgKHdpdGgtY3VycmVudC1idWZm ZXIgIipIZWxwKiIKKyAgICAoc2hvdWxkIChsb29raW5nLWF0ICJea2V5IikpKSkKKworKGVydC1k ZWZ0ZXN0IGhlbHAtZm5zLXRlc3QtZGVzY3JpYmUta2V5bWFwL3ZhbHVlK3NlYXJjaC1zeW1ib2xz ICgpCisgIChkZXNjcmliZS1rZXltYXAgbWluaWJ1ZmZlci1sb2NhbC1tdXN0LW1hdGNoLW1hcCB0 KQorICAod2l0aC1jdXJyZW50LWJ1ZmZlciAiKkhlbHAqIgorICAgIChzaG91bGQgKGxvb2tpbmct YXQgIl5taW5pYnVmZmVyLWxvY2FsLW11c3QtbWF0Y2gtbWFwIGlzIikpKSkKKworKGVydC1kZWZ0 ZXN0IGhlbHAtZm5zLXRlc3QtZGVzY3JpYmUta2V5bWFwL3N5bWJvbCtzZWFyY2gtc3ltYm9scyAo KQorICAoZGVzY3JpYmUta2V5bWFwICdtaW5pYnVmZmVyLWxvY2FsLW11c3QtbWF0Y2gtbWFwIHQp CisgICh3aXRoLWN1cnJlbnQtYnVmZmVyICIqSGVscCoiCisgICAgKHNob3VsZCAobG9va2luZy1h dCAiXm1pbmlidWZmZXItbG9jYWwtbXVzdC1tYXRjaC1tYXAgaXMiKSkpKQorCisoZXJ0LWRlZnRl c3QgaGVscC1mbnMtdGVzdC1kZXNjcmliZS1rZXltYXAvbm90LWtleW1hcCAoKQorICAoc2hvdWxk LWVycm9yIChkZXNjcmliZS1rZXltYXAgbmlsKSkKKyAgKHNob3VsZC1lcnJvciAoZGVzY3JpYmUt a2V5bWFwIGVtYWNzLXZlcnNpb24pKQorICAoc2hvdWxkLWVycm9yIChkZXNjcmliZS1rZXltYXAg bmlsIHQpKQorICAoc2hvdWxkLWVycm9yIChkZXNjcmliZS1rZXltYXAgZW1hY3MtdmVyc2lvbiB0 KSkpCisKKyhlcnQtZGVmdGVzdCBoZWxwLWZucy10ZXN0LWRlc2NyaWJlLWtleW1hcC9sZXQtYm91 bmQgKCkKKyAgKGxldCAoKGZvb2JhciBtaW5pYnVmZmVyLWxvY2FsLW11c3QtbWF0Y2gtbWFwKSkK KyAgICAoZGVzY3JpYmUta2V5bWFwIGZvb2JhcikKKyAgICAod2l0aC1jdXJyZW50LWJ1ZmZlciAi KkhlbHAqIgorICAgICAgKHNob3VsZCAobG9va2luZy1hdCAiXmtleSIpKSkpKQorCisoZXJ0LWRl ZnRlc3QgaGVscC1mbnMtdGVzdC1kZXNjcmliZS1rZXltYXAvZHluYW1pY2FsbHktYm91bmQtbm8t ZmlsZSAoKQorICAoc2V0cSBoZWxwLWZucy10ZXN0LS1kZXNjcmliZS1rZXltYXAtZm9vIG1pbmli dWZmZXItbG9jYWwtbXVzdC1tYXRjaC1tYXApCisgIChkZXNjcmliZS1rZXltYXAgJ2hlbHAtZm5z LXRlc3QtLWRlc2NyaWJlLWtleW1hcC1mb28pCisgICh3aXRoLWN1cnJlbnQtYnVmZmVyICIqSGVs cCoiCisgICAgKHNob3VsZCAobG9va2luZy1hdCAiXmhlbHAtZm5zLXRlc3QtLWRlc2NyaWJlLWtl eW1hcC1mb28gaXMiKSkpKQorCiA7OzsgaGVscC1mbnMtdGVzdHMuZWwgZW5kcyBoZXJlCi0tIAoy LjIzLjAKCg== --000000000000a9899605951809bc-- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 17 08:07:21 2019 Received: (at 30660) by debbugs.gnu.org; 17 Oct 2019 12:07:21 +0000 Received: from localhost ([127.0.0.1]:47293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iL4Yq-0002N0-Qt for submit@debbugs.gnu.org; Thu, 17 Oct 2019 08:07:21 -0400 Received: from mail-wr1-f52.google.com ([209.85.221.52]:36936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iL4Yo-0002Mn-Ad for 30660@debbugs.gnu.org; Thu, 17 Oct 2019 08:07:18 -0400 Received: by mail-wr1-f52.google.com with SMTP id p14so2063474wro.4 for <30660@debbugs.gnu.org>; Thu, 17 Oct 2019 05:07:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version:content-transfer-encoding; bh=DcKjzrlEvFX0xl5puZvN9ZKzRfmku4tCciwIFjw7zSs=; b=HuWmoNvjnVnvRPhvspXvUxj6VYW9e9RCu5XSu9mpayTwgFEUl98ZOhbfdwJrBUi2BI dpxIHMPusg/NB6RroaXJX5YeuoZOZ/ozHhuVSY2HnH4cfAJ6ygz3NuWazlnFEQYSEEhm gdC2UIMCsDLwk1592AHwNInhUnNUEdsEGK0SP6yKgfvR48j6XhlRWJdybMXhq70g3oxI fvyRbkY8t2Sq0a9UQSrK41a41/epxYlLz5wWs4Bfe/aXy/B2PIXbmXJ6K900EWCm8DkD prf1lp+Y56HipA84ZzjNIpSbsb8D5wxDa6Tfqo95Z6qYV+aV90wNjx2X9LPEbdQxpPwt C3lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=DcKjzrlEvFX0xl5puZvN9ZKzRfmku4tCciwIFjw7zSs=; b=n10l+kX7Md88tDPge9RexaHX/7DM6ZhtnF9+apkt5KmiuxKKA27nF58r+rpzJ0Ryq3 EXd4mEPaICopqFfUNhdUtbmIz4Gdmsay3QJcweg2A0jgAk9uNnOsH0e9xTbhQjmivkYi /xzdF7NIN+K+4JfB2+42sekkzKTxV3/+u4okscDL6iSNU8qAOO9/uA9L+M5ht2vX3yFX HpT+iWQ75YzgPdrn/N+oaU7oPOryM141d9q5arsKUDrgc4r5Hpr9o/JR4itHAOWfkfV/ t68yZKuAGcJEkm4tbTBQ1Sxzy+d+KoqwP6I1Yrzxzde9q2uF695FgOnCkCNEOgK9xscT 9XCw== X-Gm-Message-State: APjAAAUPhQCsW+EWWJduga3QC1UeXknjKQ+48oWujC7mIG4zqcUbl06g 07nwgrYsBpyrAtxfypp8Kj8= X-Google-Smtp-Source: APXvYqw0xkbwgN6uf3W7Ri2pTzLCmM0X3PiAF0m2SctMwHQkCThXqhzJhfO+SjeecvB2b1hsHnrUgA== X-Received: by 2002:adf:f78f:: with SMTP id q15mr2665395wrp.282.1571314032257; Thu, 17 Oct 2019 05:07:12 -0700 (PDT) Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id d4sm2328839wrc.54.2019.10.17.05.07.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2019 05:07:11 -0700 (PDT) From: Robert Pluim To: Stefan Kangas Subject: Re: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") References: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> <87tv8bul5g.fsf@gnus.org> <8336fvhxt0.fsf@gnu.org> X-Debbugs-No-Ack: yes Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Thu, 17 Oct 2019 14:07:10 +0200 In-Reply-To: (Stefan Kangas's message of "Thu, 17 Oct 2019 11:42:25 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30660 Cc: Eli Zaretskii , 30660@debbugs.gnu.org, Lars Ingebrigtsen , =?utf-8?B?56mN5Li55bC8?= Dan Jacobson X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 17 Oct 2019 11:42:25 +0200, Stefan Kangas = said: Stefan> * lisp/help-fns.el (describe-keymap): New function to show key Stefan> bindings for a given keymap. (Bug#30660) Stefan> * doc/lispref/keymaps.texi (Scanning Keymaps): Document it. Stefan> * etc/NEWS: Announce it. Stefan> * test/lisp/help-fns-tests.el (help-fns-test-describe-keymap/sy= mbol) Stefan> (help-fns-test-describe-keymap/value) Stefan> (help-fns-test-describe-keymap/value+search-symbols) Stefan> (help-fns-test-describe-keymap/symbol+search-symbols) Stefan> (help-fns-test-describe-keymap/not-keymap) Stefan> (help-fns-test-describe-keymap/let-bound) Stefan> (help-fns-test-describe-keymap/dynamically-bound-no-file): New = tests. Stefan> --- Stefan> doc/lispref/keymaps.texi | 12 ++++++ Stefan> etc/NEWS | 3 ++ Stefan> lisp/help-fns.el | 73 +++++++++++++++++++++++++++++= ++++++++ Stefan> test/lisp/help-fns-tests.el | 41 +++++++++++++++++++++ Stefan> 4 files changed, 129 insertions(+) Stefan> diff --git a/doc/lispref/keymaps.texi b/doc/lispref/keymaps.texi Stefan> index 532e537026..569e6137e6 100644 Stefan> --- a/doc/lispref/keymaps.texi Stefan> +++ b/doc/lispref/keymaps.texi Stefan> @@ -2004,6 +2004,18 @@ Scanning Keymaps Stefan> instead of the current buffer's. Stefan> @end deffn =20 Stefan> +@deffn Command describe-keymap keymap &optional search-symbols Stefan> +This function creates a listing of all key bindings in variable s/variable// Stefan> +@var{keymap}, and displays it in a buffer named @file{*Help*}.= When Stefan> +called interactively, prompt for a variable that has a keymap = value. Stefan> + Stefan> +If optional argument @var{search-symbols} is non-nil, and @var= {keymap} Stefan> +is not a symbol, search all variables for one whose value is K= EYMAP @var{keymap} I=CA=BCm not clear on why it needs such a convoluted API, but I guess it=CA= =BCs useful to someone. Could the searching not be split into a 'find-keymap' function? Robert From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 17 09:01:08 2019 Received: (at 30660) by debbugs.gnu.org; 17 Oct 2019 13:01:09 +0000 Received: from localhost ([127.0.0.1]:47358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iL5Ou-0003oP-Jq for submit@debbugs.gnu.org; Thu, 17 Oct 2019 09:01:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50232) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iL5Os-0003o2-Lf for 30660@debbugs.gnu.org; Thu, 17 Oct 2019 09:01:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36892) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iL5On-00079J-7d; Thu, 17 Oct 2019 09:01:01 -0400 Received: from [176.228.60.248] (port=3235 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iL5Ok-00055z-TJ; Thu, 17 Oct 2019 09:00:59 -0400 Date: Thu, 17 Oct 2019 16:00:42 +0300 Message-Id: <83o8yfbk79.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-reply-to: (message from Stefan Kangas on Thu, 17 Oct 2019 11:39:31 +0200) Subject: Re: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") References: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> <87tv8bul5g.fsf@gnus.org> <8336fvhxt0.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 30660 Cc: larsi@gnus.org, 30660@debbugs.gnu.org, jidanni@jidanni.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Thu, 17 Oct 2019 11:39:31 +0200 > Cc: Lars Ingebrigtsen , 30660@debbugs.gnu.org, > 積丹尼 Dan Jacobson > > > Fine with me, but let's not give it any key binding yet, and please > > mention this command in NEWS. > > Please find attached an updated patch fixing your comments as well as > earlier comments by Drew Adams. > > In addition to adding this to NEWS, I've also updated the elisp manual. Thanks. However, I think that the right manual for this is the user manual, not the ELisp manual. It is, after all, a command whose purpose is to show documentation to the user, right? > Subject: [PATCH] Add new help function describe-keymap > > This code was written by Drew Adams. Stefan Kangas adapted it for > inclusion in Emacs, added unit tests and documentation. I think CONTRIBUTE advises to use Co-authored-by for these situations. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 17 09:10:42 2019 Received: (at 30660) by debbugs.gnu.org; 17 Oct 2019 13:10:42 +0000 Received: from localhost ([127.0.0.1]:47380 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iL5Y9-00046X-Nf for submit@debbugs.gnu.org; Thu, 17 Oct 2019 09:10:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iL5Y7-00046H-N2 for 30660@debbugs.gnu.org; Thu, 17 Oct 2019 09:10:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36987) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iL5Y1-0002qP-Mz; Thu, 17 Oct 2019 09:10:33 -0400 Received: from [176.228.60.248] (port=3829 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iL5Y1-0006cE-9Q; Thu, 17 Oct 2019 09:10:33 -0400 Date: Thu, 17 Oct 2019 16:10:17 +0300 Message-Id: <83k193bjra.fsf@gnu.org> From: Eli Zaretskii To: Robert Pluim In-reply-to: (message from Robert Pluim on Thu, 17 Oct 2019 14:07:10 +0200) Subject: Re: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") References: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> <87tv8bul5g.fsf@gnus.org> <8336fvhxt0.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 30660 Cc: 30660@debbugs.gnu.org, larsi@gnus.org, stefan@marxist.se, jidanni@jidanni.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Robert Pluim > Cc: Eli Zaretskii , Lars Ingebrigtsen , > 30660@debbugs.gnu.org, 積丹尼 Dan Jacobson > > Date: Thu, 17 Oct 2019 14:07:10 +0200 > > Iʼm not clear on why it needs such a convoluted API Yes, I was wondering about that as well. It looks somewhat artificial to me. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 17 09:31:10 2019 Received: (at 30660) by debbugs.gnu.org; 17 Oct 2019 13:31:10 +0000 Received: from localhost ([127.0.0.1]:47408 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iL5ry-0004hV-9P for submit@debbugs.gnu.org; Thu, 17 Oct 2019 09:31:10 -0400 Received: from mail-pf1-f178.google.com ([209.85.210.178]:43862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iL5ru-0004gz-Kt for 30660@debbugs.gnu.org; Thu, 17 Oct 2019 09:31:09 -0400 Received: by mail-pf1-f178.google.com with SMTP id a2so1666224pfo.10 for <30660@debbugs.gnu.org>; Thu, 17 Oct 2019 06:31:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=xfmsG6ZwCuC30qVz/oQ9I/Jt59yaH77LuWNzGtYivyg=; b=DCYMrY16qxfTsH3twHAfQodC4ehOvimEkQw+4DqY54RV1o9eb98ODJeQ7XYKs1f84P 8kKJ1sjBgwGmoUQNvXtuUI75nEImJBXBFoNWLerFJwU50aAwSDPOvdfpAH3Bv1W0YzKu z4zVVcCTDPhrcyL1jE6fE8Uh/0hgE8HMojoV+injF8vcJX/8V8g+jQyEbqYeehYPUNK3 ZWqayY/QHXv8Qf6GaSo8jlwCVblsVryjbucZ/xSOAjbQGM93F68tuih8pL2n8x3jtlkh ExQ6HLfq981DmV2yFixcr8GAhKzBt7p07mBKNsvtDm2BBUNsU30jCyQUrBkgtui+Qj2S wNgA== X-Gm-Message-State: APjAAAVDuka/wEgguIH8v4PYU3a5uGDFfaOqUv9Vm0XgDU+QT9gnx7hR f6sICOht8XSA6Ifw3El8UY4DeET+Xv1F79O13Sw= X-Google-Smtp-Source: APXvYqxS1AMFAUDyEVQBz+ZaridmFMgsSghAb2Cqnbg3j/vMau/wmaF9D4gacSTHabh4tdtGZgCszSmlZ0Ksqc3v2lE= X-Received: by 2002:a63:c10:: with SMTP id b16mr4357620pgl.333.1571319060638; Thu, 17 Oct 2019 06:31:00 -0700 (PDT) MIME-Version: 1.0 References: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> <87tv8bul5g.fsf@gnus.org> <8336fvhxt0.fsf@gnu.org> <83k193bjra.fsf@gnu.org> In-Reply-To: <83k193bjra.fsf@gnu.org> From: Stefan Kangas Date: Thu, 17 Oct 2019 15:30:48 +0200 Message-ID: Subject: Re: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 30660 Cc: Robert Pluim , 30660@debbugs.gnu.org, Lars Ingebrigtsen , Drew Adams , =?UTF-8?B?56mN5Li55bC8IERhbiBKYWNvYnNvbg==?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Zaretskii writes: > > I=CA=BCm not clear on why it needs such a convoluted API > > Yes, I was wondering about that as well. It looks somewhat artificial > to me. I'd be happy to simplify it, but Drew felt that this was an important use case. Perhaps that could be covered by Robert Pluim's suggestion to add a separate function 'find-keymap' instead. Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 06 19:19:33 2019 Received: (at 30660) by debbugs.gnu.org; 7 Nov 2019 00:19:33 +0000 Received: from localhost ([127.0.0.1]:41434 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iSVWO-0007PE-L6 for submit@debbugs.gnu.org; Wed, 06 Nov 2019 19:19:33 -0500 Received: from host.gofardesign.uk ([208.79.239.190]:59869) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iSVVr-0007Ny-Mz for 30660@debbugs.gnu.org; Wed, 06 Nov 2019 19:19:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LYasSKnLjBdD9KTZINdKHJuA7bZugIHTApFxC9qBQmY=; b=mTOUn8iz6UqIl0EWwQLtCNN+Nn SibGcCEieaeLIehNTTudNyS4KeqRdlmBEmeCKqNSB0OwfM97kDNOp7ivW9msrBgVm3zy6tkxHfarr 6tErkDS7EAQDPPxcAdc5RD/BN3oeF7q5wHzaZ7yX5DaOqWkmrHHpYyj6ABs5qtC/iaaw=; Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:53054 helo=localhost) by host.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iSVVf-0001Hm-Ki; Wed, 06 Nov 2019 18:18:48 -0600 From: Stefan Kangas To: Eli Zaretskii Subject: Re: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") In-Reply-To: (Stefan Kangas's message of "Thu, 17 Oct 2019 15:30:48 +0200") References: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> <87tv8bul5g.fsf@gnus.org> <8336fvhxt0.fsf@gnu.org> <83k193bjra.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Date: Thu, 07 Nov 2019 01:18:45 +0100 Message-ID: <87y2wswnbu.fsf@marxist.se> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: host.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: host.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30660 Cc: Robert Pluim , 30660@debbugs.gnu.org, Lars Ingebrigtsen , Drew Adams , =?utf-8?B?56mN5Li55bC8?= Dan Jacobson X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Stefan Kangas writes: > Eli Zaretskii writes: > >> > I=CA=BCm not clear on why it needs such a convoluted API >> >> Yes, I was wondering about that as well. It looks somewhat artificial >> to me. > > I'd be happy to simplify it, but Drew felt that this was an important > use case. Perhaps that could be covered by Robert Pluim's suggestion > to add a separate function 'find-keymap' instead. I've thought about this some more, and I think it's better to simplify the API of 'describe-keymap'. We could consider adding a separate function 'find-keymap' later. Please find attached a patch without the optional argument, and let me know if there are any further comments. Best regards, Stefan Kangas --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Add-new-help-command-describe-keymap.patch >From 63952f2062d981c49d16e8643e287de00b19ffe3 Mon Sep 17 00:00:00 2001 From: Stefan Kangas Date: Sat, 24 Aug 2019 01:02:04 +0200 Subject: [PATCH] Add new help command describe-keymap * lisp/help-fns.el (describe-keymap): New command to show key bindings for a given keymap. (Bug#30660) * doc/lispref/keymaps.texi (Scanning Keymaps): Document it. * etc/NEWS: Announce it. * test/lisp/help-fns-tests.el (help-fns-test-describe-keymap/symbol) (help-fns-test-describe-keymap/value) (help-fns-test-describe-keymap/not-keymap) (help-fns-test-describe-keymap/let-bound) (help-fns-test-describe-keymap/dynamically-bound-no-file): New tests. Co-authored-by: Drew Adams --- doc/lispref/keymaps.texi | 6 ++++ etc/NEWS | 3 ++ lisp/help-fns.el | 59 +++++++++++++++++++++++++++++++++++++ test/lisp/help-fns-tests.el | 29 ++++++++++++++++++ 4 files changed, 97 insertions(+) diff --git a/doc/lispref/keymaps.texi b/doc/lispref/keymaps.texi index 8ff329bdac..9fc0420b7e 100644 --- a/doc/lispref/keymaps.texi +++ b/doc/lispref/keymaps.texi @@ -2010,6 +2010,12 @@ Scanning Keymaps instead of the current buffer's. @end deffn +@deffn Command describe-keymap keymap &optional search-symbols +This function creates a listing of all key bindings in variable +@var{keymap}, and displays it in a buffer named @file{*Help*}. When +called interactively, prompt for a variable that has a keymap value. +@end deffn + @node Menu Keymaps @section Menu Keymaps @cindex menu keymaps diff --git a/etc/NEWS b/etc/NEWS index 737053a099..cc98705cd3 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1443,6 +1443,9 @@ The maximum level is used by default; customize ** Help ++++ +*** New command 'describe-keymap' describes keybindings in a keymap. + --- *** Description of variables and functions give an estimated first release. diff --git a/lisp/help-fns.el b/lisp/help-fns.el index 14dea7de9b..333eda0aac 100644 --- a/lisp/help-fns.el +++ b/lisp/help-fns.el @@ -1561,6 +1561,65 @@ describe-categories (insert "\nThe parent category table is:") (describe-vector table 'help-describe-category-set)))))) +;;;###autoload +(defun describe-keymap (keymap) + "Describe key bindings in KEYMAP. +When called interactively, prompt for a variable that has a +keymap value." + (interactive (list + (intern (completing-read "Keymap: " obarray + (lambda (m) + (and (boundp m) + (keymapp (symbol-value m)))) + t nil 'variable-name-history)))) + (let (used-gentemp) + (unless (and (symbolp keymap) + (boundp keymap) + (keymapp (symbol-value keymap))) + (when (not (keymapp keymap)) + (if (symbolp keymap) + (error "Not a keymap variable: %S" keymap) + (error "Not a keymap"))) + (let ((sym nil)) + (unless sym + (setq sym (cl-gentemp "KEYMAP OBJECT (no variable) ")) + (setq used-gentemp t) + (set sym keymap)) + (setq keymap sym))) + ;; Follow aliasing. + (setq keymap (or (ignore-errors (indirect-variable keymap)) keymap)) + (help-setup-xref (list #'describe-keymap keymap) + (called-interactively-p 'interactive)) + (let* ((name (symbol-name keymap)) + (doc (documentation-property keymap 'variable-documentation)) + (file-name (find-lisp-object-file-name keymap 'defvar))) + (with-help-window (help-buffer) + (with-current-buffer standard-output + (unless used-gentemp + (princ (format-message "%S is a keymap variable" keymap)) + (if (not file-name) + (princ ".\n\n") + (princ (format-message + " defined in `%s'.\n\n" + (if (eq file-name 'C-source) + "C source code" + (file-name-nondirectory file-name)))) + (save-excursion + (re-search-backward (substitute-command-keys + "`\\([^`']+\\)'") + nil t) + (help-xref-button 1 'help-variable-def + keymap file-name)))) + (when (and (not (equal "" doc)) doc) + (princ "Documentation:\n") + (princ (format-message "%s\n\n" doc))) + ;; Use `insert' instead of `princ', so control chars (e.g. \377) + ;; insert correctly. + (insert (substitute-command-keys (concat "\\{" name "}")))))) + ;; Cleanup. + (when used-gentemp + (makunbound keymap)))) + ;;; Replacements for old lib-src/ programs. Don't seem especially useful. diff --git a/test/lisp/help-fns-tests.el b/test/lisp/help-fns-tests.el index da4d25d0a6..3921b59f2c 100644 --- a/test/lisp/help-fns-tests.el +++ b/test/lisp/help-fns-tests.el @@ -123,4 +123,33 @@ help-fns-test-describe-symbol (goto-char (point-min)) (should (looking-at "^font-lock-comment-face is ")))) + + +;;; Tests for describe-keymap +(ert-deftest help-fns-test-describe-keymap/symbol () + (describe-keymap 'minibuffer-local-must-match-map) + (with-current-buffer "*Help*" + (should (looking-at "^minibuffer-local-must-match-map is")))) + +(ert-deftest help-fns-test-describe-keymap/value () + (describe-keymap minibuffer-local-must-match-map) + (with-current-buffer "*Help*" + (should (looking-at "^key")))) + +(ert-deftest help-fns-test-describe-keymap/not-keymap () + (should-error (describe-keymap nil)) + (should-error (describe-keymap emacs-version))) + +(ert-deftest help-fns-test-describe-keymap/let-bound () + (let ((foobar minibuffer-local-must-match-map)) + (describe-keymap foobar) + (with-current-buffer "*Help*" + (should (looking-at "^key"))))) + +(ert-deftest help-fns-test-describe-keymap/dynamically-bound-no-file () + (setq help-fns-test--describe-keymap-foo minibuffer-local-must-match-map) + (describe-keymap 'help-fns-test--describe-keymap-foo) + (with-current-buffer "*Help*" + (should (looking-at "^help-fns-test--describe-keymap-foo is")))) + ;;; help-fns-tests.el ends here -- 2.20.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 06 19:41:20 2019 Received: (at 30660) by debbugs.gnu.org; 7 Nov 2019 00:41:20 +0000 Received: from localhost ([127.0.0.1]:41462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iSVrS-00084W-R5 for submit@debbugs.gnu.org; Wed, 06 Nov 2019 19:41:20 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:51994) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iSVrQ-00084F-Bv for 30660@debbugs.gnu.org; Wed, 06 Nov 2019 19:41:17 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xA70d2DH135147; Thu, 7 Nov 2019 00:41:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=XwrWQ7CU7ADuBSd6UKke6AuniJh6uTlr8rwc/hivr7A=; b=pL0CHnHE3tmKB2lqpEqaq/qFT/bgMsir6cX1s8w5Fm4yVXt3pDeM+sxIcpEBMBVgupPc 789jAm3Nr+FRBMCL/ntgWWDGSnaHN8iKtljkYbKzee8F5OGxLZ3PRqBYoryQ53Fbn5Pv 3qXV4bwhgO4u2R4aKQDrko4PZ41WzUWCCG2SLzMcuCp4rPhPt8i2mcgXVWlzmlDD6T5/ wvTTVHi8dra8J8bp1RuUvw3so4MtFnnBV8RH47ZOnV4qpG+MGVfaBJGElxBOv60tJvCf ZRo2yEeRc+l4PH2Q2wbMRR3c37DBG9vEJ4bBsiHSZCKkfAcFSrLww/TDJwdI6YmzRm8K Xw== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 2w41w0tj8d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 07 Nov 2019 00:41:07 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xA70d1Ri077190; Thu, 7 Nov 2019 00:41:07 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 2w41w8cda2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 07 Nov 2019 00:41:06 +0000 Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id xA70ex8D014452; Thu, 7 Nov 2019 00:40:59 GMT MIME-Version: 1.0 Message-ID: Date: Wed, 6 Nov 2019 16:40:58 -0800 (PST) From: Drew Adams To: Stefan Kangas , Eli Zaretskii Subject: RE: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") References: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> <87tv8bul5g.fsf@gnus.org> <8336fvhxt0.fsf@gnu.org> <83k193bjra.fsf@gnu.org> <87y2wswnbu.fsf@marxist.se> In-Reply-To: <87y2wswnbu.fsf@marxist.se> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4900.0 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9433 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1910280000 definitions=main-1911070005 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9433 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1910280000 definitions=main-1911070005 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 30660 Cc: Robert Pluim , 30660@debbugs.gnu.org, Lars Ingebrigtsen , =?utf-8?B?56mN5Li55bC8IERhbiBKYWNvYnNvbg==?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Well, I obviously disagree. Another reason I'll have to keep maintaining the version in `help-fns+.el', I guess. Oh well. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 06 20:00:29 2019 Received: (at 30660) by debbugs.gnu.org; 7 Nov 2019 01:00:29 +0000 Received: from localhost ([127.0.0.1]:41475 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iSWA0-0000DY-RJ for submit@debbugs.gnu.org; Wed, 06 Nov 2019 20:00:29 -0500 Received: from host.gofardesign.uk ([208.79.239.190]:40825) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iSW9z-0000DK-K0 for 30660@debbugs.gnu.org; Wed, 06 Nov 2019 20:00:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=mohUetACGijuEWQrTul1GVHBxf/gmAbAAFFvwA9I74Q=; b=HH+zMk61vIn8xcLCJl3Add0axG /lOLC2vUt/QYwTzaxurR9iCebBB4T9PQBB4HFCOGzh2nYCIEnUQlYuzCMnPFxSmv7FPLWGwzu9Hos bB+3Ytf6x9tskvsmH4m77zJjR3+d08+n1m9Hbnp+XV3Xb1dIdsDBST82rargpTToentU=; Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:52720 helo=localhost) by host.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iSW9s-0001hM-Kn; Wed, 06 Nov 2019 19:00:21 -0600 From: Stefan Kangas To: Eli Zaretskii Subject: Re: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") In-Reply-To: <83o8yfbk79.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 17 Oct 2019 16:00:42 +0300") References: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> <87tv8bul5g.fsf@gnus.org> <8336fvhxt0.fsf@gnu.org> <83o8yfbk79.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Date: Thu, 07 Nov 2019 02:00:18 +0100 Message-ID: <87ftj0wlel.fsf@marxist.se> MIME-Version: 1.0 Content-Type: text/plain X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: host.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: host.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30660 Cc: larsi@gnus.org, 30660@debbugs.gnu.org, jidanni@jidanni.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> In addition to adding this to NEWS, I've also updated the elisp manual. > > Thanks. However, I think that the right manual for this is the user > manual, not the ELisp manual. It is, after all, a command whose > purpose is to show documentation to the user, right? I had missed fixing this before sending my recent updated patch. I think what you say here makes sense, so I'll move documentation to the user manual and send a new patch. Thanks. Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 11 10:04:23 2019 Received: (at 30660) by debbugs.gnu.org; 11 Nov 2019 15:04:23 +0000 Received: from localhost ([127.0.0.1]:55890 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iUBEs-0005At-PW for submit@debbugs.gnu.org; Mon, 11 Nov 2019 10:04:23 -0500 Received: from host.gofardesign.uk ([208.79.239.190]:58129) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iUBEo-0005Ad-I3 for 30660@debbugs.gnu.org; Mon, 11 Nov 2019 10:04:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ieokrfaAxFDtfdVnFHJTQ2Jm/mVT42DIK/I1FtxUtFI=; b=sKgeOYlg6gUyQw7/hJbCaS/htG 6UD2zfDk3i1oN6OYmmA6wE0bTF1mjIBzRIee9DXgfpq5kYnXF3LME2mR11v3AFQJ+4v4qDKiMiNfd +OEJthCEXfHXMPlUwdwPnEq9Slxf+rgkCdvrSYivJA98Zh8yPLvbtK6PRxx9UUW7MwQ4=; Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:43158 helo=localhost) by host.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iUBEi-000876-8p; Mon, 11 Nov 2019 09:04:12 -0600 From: Stefan Kangas To: Eli Zaretskii Subject: Re: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") In-Reply-To: <87ftj0wlel.fsf@marxist.se> (Stefan Kangas's message of "Thu, 07 Nov 2019 02:00:18 +0100") References: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> <87tv8bul5g.fsf@gnus.org> <8336fvhxt0.fsf@gnu.org> <83o8yfbk79.fsf@gnu.org> <87ftj0wlel.fsf@marxist.se> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Date: Mon, 11 Nov 2019 16:04:10 +0100 Message-ID: <87k186pi8l.fsf@marxist.se> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: host.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: host.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30660 Cc: larsi@gnus.org, 30660@debbugs.gnu.org, jidanni@jidanni.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Stefan Kangas writes: > Eli Zaretskii writes: > >>> In addition to adding this to NEWS, I've also updated the elisp manual. >> >> Thanks. However, I think that the right manual for this is the user >> manual, not the ELisp manual. It is, after all, a command whose >> purpose is to show documentation to the user, right? > > I had missed fixing this before sending my recent updated patch. I > think what you say here makes sense, so I'll move documentation to the > user manual and send a new patch. Thanks. In the attached patch, I've added it to the user manual in addition to the elisp manual. I followed the example of describe-bindings which is documented in both. WDYT? Best regards, Stefan Kangas --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Add-new-help-command-describe-keymap.patch >From 3a24ecd11256014e53c464bf8c181239b443c7cd Mon Sep 17 00:00:00 2001 From: Stefan Kangas Date: Sat, 24 Aug 2019 01:02:04 +0200 Subject: [PATCH] Add new help command describe-keymap * lisp/help-fns.el (describe-keymap): New command to show key bindings for a given keymap. (Bug#30660) * doc/emacs/help.texi (Misc Help): * doc/lispref/keymaps.texi (Scanning Keymaps): Document it. * etc/NEWS: Announce it. * test/lisp/help-fns-tests.el (help-fns-test-describe-keymap/symbol) (help-fns-test-describe-keymap/value) (help-fns-test-describe-keymap/not-keymap) (help-fns-test-describe-keymap/let-bound) (help-fns-test-describe-keymap/dynamically-bound-no-file): New tests. Co-authored-by: Drew Adams --- doc/emacs/help.texi | 5 +++- doc/lispref/keymaps.texi | 6 ++++ etc/NEWS | 3 ++ lisp/help-fns.el | 59 +++++++++++++++++++++++++++++++++++++ test/lisp/help-fns-tests.el | 29 ++++++++++++++++++ 5 files changed, 101 insertions(+), 1 deletion(-) diff --git a/doc/emacs/help.texi b/doc/emacs/help.texi index 4851659b8b..ce40a15abe 100644 --- a/doc/emacs/help.texi +++ b/doc/emacs/help.texi @@ -581,6 +581,7 @@ Misc Help @findex describe-bindings @kindex C-h s @findex describe-syntax +@findex describe-keymap @kbd{C-h b} (@code{describe-bindings}) and @kbd{C-h s} (@code{describe-syntax}) show other information about the current environment within Emacs. @kbd{C-h b} displays a list of all the key @@ -589,7 +590,9 @@ Misc Help finally the global bindings (@pxref{Key Bindings}). @kbd{C-h s} displays the contents of the syntax table, with explanations of each character's syntax (@pxref{Syntax Tables,, Syntax Tables, elisp, The -Emacs Lisp Reference Manual}). +Emacs Lisp Reference Manual}). Finally, @kbd{M-x describe-keymap} +prompts for the name of a keymap variable and displays a listing of +all key bindings in that keymap. @findex describe-prefix-bindings You can get a list of subcommands for a particular prefix key by diff --git a/doc/lispref/keymaps.texi b/doc/lispref/keymaps.texi index 8ff329bdac..9fc0420b7e 100644 --- a/doc/lispref/keymaps.texi +++ b/doc/lispref/keymaps.texi @@ -2010,6 +2010,12 @@ Scanning Keymaps instead of the current buffer's. @end deffn +@deffn Command describe-keymap keymap &optional search-symbols +This function creates a listing of all key bindings in variable +@var{keymap}, and displays it in a buffer named @file{*Help*}. When +called interactively, prompt for a variable that has a keymap value. +@end deffn + @node Menu Keymaps @section Menu Keymaps @cindex menu keymaps diff --git a/etc/NEWS b/etc/NEWS index 4134f7bb5f..6609bd3111 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1461,6 +1461,9 @@ killed when pdbtracking session is finished. ** Help ++++ +*** New command 'describe-keymap' describes keybindings in a keymap. + --- *** Description of variables and functions give an estimated first release. diff --git a/lisp/help-fns.el b/lisp/help-fns.el index 14dea7de9b..333eda0aac 100644 --- a/lisp/help-fns.el +++ b/lisp/help-fns.el @@ -1561,6 +1561,65 @@ describe-categories (insert "\nThe parent category table is:") (describe-vector table 'help-describe-category-set)))))) +;;;###autoload +(defun describe-keymap (keymap) + "Describe key bindings in KEYMAP. +When called interactively, prompt for a variable that has a +keymap value." + (interactive (list + (intern (completing-read "Keymap: " obarray + (lambda (m) + (and (boundp m) + (keymapp (symbol-value m)))) + t nil 'variable-name-history)))) + (let (used-gentemp) + (unless (and (symbolp keymap) + (boundp keymap) + (keymapp (symbol-value keymap))) + (when (not (keymapp keymap)) + (if (symbolp keymap) + (error "Not a keymap variable: %S" keymap) + (error "Not a keymap"))) + (let ((sym nil)) + (unless sym + (setq sym (cl-gentemp "KEYMAP OBJECT (no variable) ")) + (setq used-gentemp t) + (set sym keymap)) + (setq keymap sym))) + ;; Follow aliasing. + (setq keymap (or (ignore-errors (indirect-variable keymap)) keymap)) + (help-setup-xref (list #'describe-keymap keymap) + (called-interactively-p 'interactive)) + (let* ((name (symbol-name keymap)) + (doc (documentation-property keymap 'variable-documentation)) + (file-name (find-lisp-object-file-name keymap 'defvar))) + (with-help-window (help-buffer) + (with-current-buffer standard-output + (unless used-gentemp + (princ (format-message "%S is a keymap variable" keymap)) + (if (not file-name) + (princ ".\n\n") + (princ (format-message + " defined in `%s'.\n\n" + (if (eq file-name 'C-source) + "C source code" + (file-name-nondirectory file-name)))) + (save-excursion + (re-search-backward (substitute-command-keys + "`\\([^`']+\\)'") + nil t) + (help-xref-button 1 'help-variable-def + keymap file-name)))) + (when (and (not (equal "" doc)) doc) + (princ "Documentation:\n") + (princ (format-message "%s\n\n" doc))) + ;; Use `insert' instead of `princ', so control chars (e.g. \377) + ;; insert correctly. + (insert (substitute-command-keys (concat "\\{" name "}")))))) + ;; Cleanup. + (when used-gentemp + (makunbound keymap)))) + ;;; Replacements for old lib-src/ programs. Don't seem especially useful. diff --git a/test/lisp/help-fns-tests.el b/test/lisp/help-fns-tests.el index da4d25d0a6..3921b59f2c 100644 --- a/test/lisp/help-fns-tests.el +++ b/test/lisp/help-fns-tests.el @@ -123,4 +123,33 @@ help-fns-test-describe-symbol (goto-char (point-min)) (should (looking-at "^font-lock-comment-face is ")))) + + +;;; Tests for describe-keymap +(ert-deftest help-fns-test-describe-keymap/symbol () + (describe-keymap 'minibuffer-local-must-match-map) + (with-current-buffer "*Help*" + (should (looking-at "^minibuffer-local-must-match-map is")))) + +(ert-deftest help-fns-test-describe-keymap/value () + (describe-keymap minibuffer-local-must-match-map) + (with-current-buffer "*Help*" + (should (looking-at "^key")))) + +(ert-deftest help-fns-test-describe-keymap/not-keymap () + (should-error (describe-keymap nil)) + (should-error (describe-keymap emacs-version))) + +(ert-deftest help-fns-test-describe-keymap/let-bound () + (let ((foobar minibuffer-local-must-match-map)) + (describe-keymap foobar) + (with-current-buffer "*Help*" + (should (looking-at "^key"))))) + +(ert-deftest help-fns-test-describe-keymap/dynamically-bound-no-file () + (setq help-fns-test--describe-keymap-foo minibuffer-local-must-match-map) + (describe-keymap 'help-fns-test--describe-keymap-foo) + (with-current-buffer "*Help*" + (should (looking-at "^help-fns-test--describe-keymap-foo is")))) + ;;; help-fns-tests.el ends here -- 2.20.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 14 06:13:02 2019 Received: (at 30660) by debbugs.gnu.org; 14 Nov 2019 11:13:02 +0000 Received: from localhost ([127.0.0.1]:32779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVD3e-0001jR-4a for submit@debbugs.gnu.org; Thu, 14 Nov 2019 06:13:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49372) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVD3b-0001iw-Qb for 30660@debbugs.gnu.org; Thu, 14 Nov 2019 06:13:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48484) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iVD3V-0004rh-Ru; Thu, 14 Nov 2019 06:12:53 -0500 Received: from [176.228.60.248] (port=1703 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iVD3U-0004Ax-T4; Thu, 14 Nov 2019 06:12:53 -0500 Date: Thu, 14 Nov 2019 13:12:36 +0200 Message-Id: <83h8367luj.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-reply-to: <87k186pi8l.fsf@marxist.se> (message from Stefan Kangas on Mon, 11 Nov 2019 16:04:10 +0100) Subject: Re: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") References: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> <87tv8bul5g.fsf@gnus.org> <8336fvhxt0.fsf@gnu.org> <83o8yfbk79.fsf@gnu.org> <87ftj0wlel.fsf@marxist.se> <87k186pi8l.fsf@marxist.se> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 30660 Cc: larsi@gnus.org, 30660@debbugs.gnu.org, jidanni@jidanni.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Cc: larsi@gnus.org, 30660@debbugs.gnu.org, jidanni@jidanni.org > Date: Mon, 11 Nov 2019 16:04:10 +0100 > > In the attached patch, I've added it to the user manual in addition to > the elisp manual. I followed the example of describe-bindings which > is documented in both. I'd prefer to have just one description in the user manual, and have a cross-reference in the ELisp manual which points to that. I don't know why describe-bindings was documented in both manuals, and see no reason to continue doing so (the ELisp manual prints in 2 large volumes, so avoiding any unnecessary bloat there is generally a good idea). Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 17 15:37:07 2019 Received: (at 30660) by debbugs.gnu.org; 17 Nov 2019 20:37:07 +0000 Received: from localhost ([127.0.0.1]:42725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWRIB-0007XJ-E5 for submit@debbugs.gnu.org; Sun, 17 Nov 2019 15:37:07 -0500 Received: from ted.gofardesign.uk ([67.225.143.91]:56668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWRI9-0007Wp-Lj for 30660@debbugs.gnu.org; Sun, 17 Nov 2019 15:37:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rIvLQFnAP9vna+HX1LeopHhXZTKTaCiBUWn9ec+Odo8=; b=heMetOxrYAH21Z9MF4n5sH9cQX lThZFHo+CikyMSQJ+x3RUZ7XT4/zbJOT3fBs0fXlp5iKqBVGb65vBGWXjsjsv8i7gpEDY0Yf2kY3K TbVn2upWlaHxX+lNtdzg7wvk4v4aTLw7TPzwaLrf8wQLVbHgD230rIb8lZXgVQYp+JCDA4hqwWSus PhQtCW24elB2nlT6tPVAcTzOPiqhj+PeK7fB3JQYL5MVWQFVGjacrrHMo2Jf/XcqQOKanPqnlewAW bc/EhERNGXnNwcRzhuk+8uSTgGelu1Z//PGWkwhRg3o+oF9k2EORiVrVIK3upEW/EPhajV+80GA7U bork5fmA==; Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:60580 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iWRI2-000iLC-3Q; Sun, 17 Nov 2019 15:36:58 -0500 From: Stefan Kangas To: Eli Zaretskii Subject: Re: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") In-Reply-To: <83h8367luj.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 14 Nov 2019 13:12:36 +0200") References: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> <87tv8bul5g.fsf@gnus.org> <8336fvhxt0.fsf@gnu.org> <83o8yfbk79.fsf@gnu.org> <87ftj0wlel.fsf@marxist.se> <87k186pi8l.fsf@marxist.se> <83h8367luj.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Date: Sun, 17 Nov 2019 21:36:53 +0100 Message-ID: <87wobyme8q.fsf@marxist.se> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30660 Cc: larsi@gnus.org, 30660@debbugs.gnu.org, jidanni@jidanni.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: > I don't know why describe-bindings was documented in both manuals, > and see no reason to continue doing so (the ELisp manual prints in 2 > large volumes, so avoiding any unnecessary bloat there is generally > a good idea). Here's a separate patch to remove it, while preserving the information by moving it to the doc string of 'describe-bindings'. WDYT? Best regards, Stefan Kangas --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Remove-describe-bindings-from-elisp-manual.patch >From 872d71f8667d68ac449d89993f9f85138eb3c1bb Mon Sep 17 00:00:00 2001 From: Stefan Kangas Date: Fri, 15 Nov 2019 05:05:00 +0100 Subject: [PATCH] Remove describe-bindings from elisp manual Ref: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=30660#74 * doc/lispref/keymaps.texi (Scanning Keymaps): Remove 'describe-bindings'. * lisp/help.el (describe-bindings): Add some information removed from the elisp manual to the doc string instead. --- doc/lispref/keymaps.texi | 23 ----------------------- lisp/help.el | 28 +++++++++++++++++++++------- 2 files changed, 21 insertions(+), 30 deletions(-) diff --git a/doc/lispref/keymaps.texi b/doc/lispref/keymaps.texi index 8ff329bdac..1162abfc2b 100644 --- a/doc/lispref/keymaps.texi +++ b/doc/lispref/keymaps.texi @@ -1987,29 +1987,6 @@ Scanning Keymaps @end table @end defun -@deffn Command describe-bindings &optional prefix buffer-or-name -This function creates a listing of all current key bindings, and -displays it in a buffer named @file{*Help*}. The text is grouped by -modes---minor modes first, then the major mode, then global bindings. - -If @var{prefix} is non-@code{nil}, it should be a prefix key; then the -listing includes only keys that start with @var{prefix}. - -When several characters with consecutive @acronym{ASCII} codes have the -same definition, they are shown together, as -@samp{@var{firstchar}..@var{lastchar}}. In this instance, you need to -know the @acronym{ASCII} codes to understand which characters this means. -For example, in the default global map, the characters @samp{@key{SPC} -..@: ~} are described by a single line. @key{SPC} is @acronym{ASCII} 32, -@kbd{~} is @acronym{ASCII} 126, and the characters between them include all -the normal printing characters, (e.g., letters, digits, punctuation, -etc.@:); all these characters are bound to @code{self-insert-command}. - -If @var{buffer-or-name} is non-@code{nil}, it should be a buffer or a -buffer name. Then @code{describe-bindings} lists that buffer's bindings, -instead of the current buffer's. -@end deffn - @node Menu Keymaps @section Menu Keymaps @cindex menu keymaps diff --git a/lisp/help.el b/lisp/help.el index 3b3d1f977e..7b5f4b4b31 100644 --- a/lisp/help.el +++ b/lisp/help.el @@ -492,13 +492,27 @@ view-lossage (defun describe-bindings (&optional prefix buffer) "Display a buffer showing a list of all defined keys, and their definitions. -The keys are displayed in order of precedence. - -The optional argument PREFIX, if non-nil, should be a key sequence; -then we display only bindings that start with that prefix. -The optional argument BUFFER specifies which buffer's bindings -to display (default, the current buffer). BUFFER can be a buffer -or a buffer name." +The keys are displayed in order of precedence: first local +bindings of minor modes, then local bindings defined by the +current major mode, and finally global bindings. + +If optional argument PREFIX is non-nil, it should be a key +sequence and means to display only bindings starting with that +prefix. + +If optional argument BUFFER is non-nil, it specifies which +buffer's bindings to display (by default, the current buffer). +BUFFER can be a buffer or a buffer name. + +When several characters with consecutive ASCII codes have the same +definition, they are shown together, as `FIRSTCHAR..LASTCHAR'. In +this instance, you need to know the ASCII codes to understand which +characters this means. For example, in the default global map, the +characters ` .. ~' are described by a single line. is +ASCII 32, `~' is ASCII 126, and the characters between them include +all the normal printing characters, (e.g., letters, digits, +punctuation, etc.); all these characters are bound to +`self-insert-command'." (interactive) (or buffer (setq buffer (current-buffer))) (help-setup-xref (list #'describe-bindings prefix buffer) -- 2.20.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 17 15:51:16 2019 Received: (at 30660) by debbugs.gnu.org; 17 Nov 2019 20:51:16 +0000 Received: from localhost ([127.0.0.1]:42765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWRVs-0007uX-30 for submit@debbugs.gnu.org; Sun, 17 Nov 2019 15:51:16 -0500 Received: from ted.gofardesign.uk ([67.225.143.91]:60324) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWRVo-0007uK-P6 for 30660@debbugs.gnu.org; Sun, 17 Nov 2019 15:51:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QSorOeo7uqPBfjnopNp4skVwjSZ/dmBEZBTxQJmy+ds=; b=UAFtfhs0ZPYUy9YpRYf31D/xqW wMZw6/lflIcPXAk561qGHOlI6Tkt7quqlnoIg1aDEtdsw2ePk5HkJZDG/G7nB6Oq5PQRLiIYaYu0L zkVUJn1XsHlOphkbmr4bshC3wxFuuJv/ducnhHX0eETHF3q7t+AthNhthW0cjqKEQzxrRJLpFGjgM iP670cdBfFq7f/CJeyy/3/jRDHKv5b30nabkShPizv6zv2PlZUtJF4WGwTojs/a1idvbHAXQddEvp nWFEKT4Tepc4jSpVP28TN18x3FANN7BTpI+mKo0KH+aNrkctQDp1fQkumXvouK95bwAY/nAPPh3jk he4ByeXg==; Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:41416 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iWRVi-000lQd-SG; Sun, 17 Nov 2019 15:51:07 -0500 From: Stefan Kangas To: Eli Zaretskii Subject: Re: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") In-Reply-To: <83h8367luj.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 14 Nov 2019 13:12:36 +0200") References: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> <87tv8bul5g.fsf@gnus.org> <8336fvhxt0.fsf@gnu.org> <83o8yfbk79.fsf@gnu.org> <87ftj0wlel.fsf@marxist.se> <87k186pi8l.fsf@marxist.se> <83h8367luj.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Date: Sun, 17 Nov 2019 21:51:04 +0100 Message-ID: <87h832mdl3.fsf@marxist.se> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30660 Cc: larsi@gnus.org, 30660@debbugs.gnu.org, jidanni@jidanni.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> In the attached patch, I've added it to the user manual in addition to >> the elisp manual. I followed the example of describe-bindings which >> is documented in both. > > I'd prefer to have just one description in the user manual, and have a > cross-reference in the ELisp manual which points to that. I don't > know why describe-bindings was documented in both manuals, and see no > reason to continue doing so (the ELisp manual prints in 2 large > volumes, so avoiding any unnecessary bloat there is generally a good > idea). OK, I've removed it in the attached patch. Best regards, Stefan Kangas --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Add-new-help-command-describe-keymap.patch >From 94a94c833fd75225fb96e0de17000fa604945c97 Mon Sep 17 00:00:00 2001 From: Stefan Kangas Date: Sat, 24 Aug 2019 01:02:04 +0200 Subject: [PATCH] Add new help command describe-keymap * lisp/help-fns.el (describe-keymap): New command to show key bindings for a given keymap. (Bug#30660) * doc/emacs/help.texi (Misc Help): Document it. * etc/NEWS: Announce it. * test/lisp/help-fns-tests.el (help-fns-test-describe-keymap/symbol) (help-fns-test-describe-keymap/value) (help-fns-test-describe-keymap/not-keymap) (help-fns-test-describe-keymap/let-bound) (help-fns-test-describe-keymap/dynamically-bound-no-file): New tests. Co-authored-by: Drew Adams --- doc/emacs/help.texi | 5 +++- etc/NEWS | 3 ++ lisp/help-fns.el | 59 +++++++++++++++++++++++++++++++++++++ test/lisp/help-fns-tests.el | 29 ++++++++++++++++++ 4 files changed, 95 insertions(+), 1 deletion(-) diff --git a/doc/emacs/help.texi b/doc/emacs/help.texi index 4851659b8b..ce40a15abe 100644 --- a/doc/emacs/help.texi +++ b/doc/emacs/help.texi @@ -581,6 +581,7 @@ Misc Help @findex describe-bindings @kindex C-h s @findex describe-syntax +@findex describe-keymap @kbd{C-h b} (@code{describe-bindings}) and @kbd{C-h s} (@code{describe-syntax}) show other information about the current environment within Emacs. @kbd{C-h b} displays a list of all the key @@ -589,7 +590,9 @@ Misc Help finally the global bindings (@pxref{Key Bindings}). @kbd{C-h s} displays the contents of the syntax table, with explanations of each character's syntax (@pxref{Syntax Tables,, Syntax Tables, elisp, The -Emacs Lisp Reference Manual}). +Emacs Lisp Reference Manual}). Finally, @kbd{M-x describe-keymap} +prompts for the name of a keymap variable and displays a listing of +all key bindings in that keymap. @findex describe-prefix-bindings You can get a list of subcommands for a particular prefix key by diff --git a/etc/NEWS b/etc/NEWS index 485d2b1fdf..83d6b0f416 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1461,6 +1461,9 @@ killed when pdbtracking session is finished. ** Help ++++ +*** New command 'describe-keymap' describes keybindings in a keymap. + --- *** Description of variables and functions give an estimated first release. diff --git a/lisp/help-fns.el b/lisp/help-fns.el index 14dea7de9b..333eda0aac 100644 --- a/lisp/help-fns.el +++ b/lisp/help-fns.el @@ -1561,6 +1561,65 @@ describe-categories (insert "\nThe parent category table is:") (describe-vector table 'help-describe-category-set)))))) +;;;###autoload +(defun describe-keymap (keymap) + "Describe key bindings in KEYMAP. +When called interactively, prompt for a variable that has a +keymap value." + (interactive (list + (intern (completing-read "Keymap: " obarray + (lambda (m) + (and (boundp m) + (keymapp (symbol-value m)))) + t nil 'variable-name-history)))) + (let (used-gentemp) + (unless (and (symbolp keymap) + (boundp keymap) + (keymapp (symbol-value keymap))) + (when (not (keymapp keymap)) + (if (symbolp keymap) + (error "Not a keymap variable: %S" keymap) + (error "Not a keymap"))) + (let ((sym nil)) + (unless sym + (setq sym (cl-gentemp "KEYMAP OBJECT (no variable) ")) + (setq used-gentemp t) + (set sym keymap)) + (setq keymap sym))) + ;; Follow aliasing. + (setq keymap (or (ignore-errors (indirect-variable keymap)) keymap)) + (help-setup-xref (list #'describe-keymap keymap) + (called-interactively-p 'interactive)) + (let* ((name (symbol-name keymap)) + (doc (documentation-property keymap 'variable-documentation)) + (file-name (find-lisp-object-file-name keymap 'defvar))) + (with-help-window (help-buffer) + (with-current-buffer standard-output + (unless used-gentemp + (princ (format-message "%S is a keymap variable" keymap)) + (if (not file-name) + (princ ".\n\n") + (princ (format-message + " defined in `%s'.\n\n" + (if (eq file-name 'C-source) + "C source code" + (file-name-nondirectory file-name)))) + (save-excursion + (re-search-backward (substitute-command-keys + "`\\([^`']+\\)'") + nil t) + (help-xref-button 1 'help-variable-def + keymap file-name)))) + (when (and (not (equal "" doc)) doc) + (princ "Documentation:\n") + (princ (format-message "%s\n\n" doc))) + ;; Use `insert' instead of `princ', so control chars (e.g. \377) + ;; insert correctly. + (insert (substitute-command-keys (concat "\\{" name "}")))))) + ;; Cleanup. + (when used-gentemp + (makunbound keymap)))) + ;;; Replacements for old lib-src/ programs. Don't seem especially useful. diff --git a/test/lisp/help-fns-tests.el b/test/lisp/help-fns-tests.el index da4d25d0a6..3921b59f2c 100644 --- a/test/lisp/help-fns-tests.el +++ b/test/lisp/help-fns-tests.el @@ -123,4 +123,33 @@ help-fns-test-describe-symbol (goto-char (point-min)) (should (looking-at "^font-lock-comment-face is ")))) + + +;;; Tests for describe-keymap +(ert-deftest help-fns-test-describe-keymap/symbol () + (describe-keymap 'minibuffer-local-must-match-map) + (with-current-buffer "*Help*" + (should (looking-at "^minibuffer-local-must-match-map is")))) + +(ert-deftest help-fns-test-describe-keymap/value () + (describe-keymap minibuffer-local-must-match-map) + (with-current-buffer "*Help*" + (should (looking-at "^key")))) + +(ert-deftest help-fns-test-describe-keymap/not-keymap () + (should-error (describe-keymap nil)) + (should-error (describe-keymap emacs-version))) + +(ert-deftest help-fns-test-describe-keymap/let-bound () + (let ((foobar minibuffer-local-must-match-map)) + (describe-keymap foobar) + (with-current-buffer "*Help*" + (should (looking-at "^key"))))) + +(ert-deftest help-fns-test-describe-keymap/dynamically-bound-no-file () + (setq help-fns-test--describe-keymap-foo minibuffer-local-must-match-map) + (describe-keymap 'help-fns-test--describe-keymap-foo) + (with-current-buffer "*Help*" + (should (looking-at "^help-fns-test--describe-keymap-foo is")))) + ;;; help-fns-tests.el ends here -- 2.20.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 18 11:20:48 2019 Received: (at 30660) by debbugs.gnu.org; 18 Nov 2019 16:20:48 +0000 Received: from localhost ([127.0.0.1]:46128 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWjlg-0004X1-0P for submit@debbugs.gnu.org; Mon, 18 Nov 2019 11:20:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWjle-0004Wp-EK for 30660@debbugs.gnu.org; Mon, 18 Nov 2019 11:20:46 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56989) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iWjlY-0007Aa-SP; Mon, 18 Nov 2019 11:20:40 -0500 Received: from [176.228.60.248] (port=4834 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iWjlY-0003a9-Bz; Mon, 18 Nov 2019 11:20:40 -0500 Date: Mon, 18 Nov 2019 18:20:45 +0200 Message-Id: <83wobx2m1u.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-reply-to: <87h832mdl3.fsf@marxist.se> (message from Stefan Kangas on Sun, 17 Nov 2019 21:51:04 +0100) Subject: Re: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") References: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> <87tv8bul5g.fsf@gnus.org> <8336fvhxt0.fsf@gnu.org> <83o8yfbk79.fsf@gnu.org> <87ftj0wlel.fsf@marxist.se> <87k186pi8l.fsf@marxist.se> <83h8367luj.fsf@gnu.org> <87h832mdl3.fsf@marxist.se> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 30660 Cc: larsi@gnus.org, 30660@debbugs.gnu.org, jidanni@jidanni.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Cc: larsi@gnus.org, 30660@debbugs.gnu.org, jidanni@jidanni.org > Date: Sun, 17 Nov 2019 21:51:04 +0100 > > Eli Zaretskii writes: > > >> In the attached patch, I've added it to the user manual in addition to > >> the elisp manual. I followed the example of describe-bindings which > >> is documented in both. > > > > I'd prefer to have just one description in the user manual, and have a > > cross-reference in the ELisp manual which points to that. I don't > > know why describe-bindings was documented in both manuals, and see no > > reason to continue doing so (the ELisp manual prints in 2 large > > volumes, so avoiding any unnecessary bloat there is generally a good > > idea). > > OK, I've removed it in the attached patch. This seems to do the opposite of what I've been talking about, no? What am I missing? From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 18 11:23:31 2019 Received: (at 30660) by debbugs.gnu.org; 18 Nov 2019 16:23:31 +0000 Received: from localhost ([127.0.0.1]:46136 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWjoI-0004cB-UO for submit@debbugs.gnu.org; Mon, 18 Nov 2019 11:23:31 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37770) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWjoH-0004by-Bn for 30660@debbugs.gnu.org; Mon, 18 Nov 2019 11:23:29 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57055) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iWjoC-0008N9-7y; Mon, 18 Nov 2019 11:23:24 -0500 Received: from [176.228.60.248] (port=4998 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iWjoB-0003la-HX; Mon, 18 Nov 2019 11:23:24 -0500 Date: Mon, 18 Nov 2019 18:23:27 +0200 Message-Id: <83v9rh2lxc.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-reply-to: <87wobyme8q.fsf@marxist.se> (message from Stefan Kangas on Sun, 17 Nov 2019 21:36:53 +0100) Subject: Re: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") References: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> <87tv8bul5g.fsf@gnus.org> <8336fvhxt0.fsf@gnu.org> <83o8yfbk79.fsf@gnu.org> <87ftj0wlel.fsf@marxist.se> <87k186pi8l.fsf@marxist.se> <83h8367luj.fsf@gnu.org> <87wobyme8q.fsf@marxist.se> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 30660 Cc: larsi@gnus.org, 30660@debbugs.gnu.org, jidanni@jidanni.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Cc: larsi@gnus.org, 30660@debbugs.gnu.org, jidanni@jidanni.org > Date: Sun, 17 Nov 2019 21:36:53 +0100 > > > I don't know why describe-bindings was documented in both manuals, > > and see no reason to continue doing so (the ELisp manual prints in 2 > > large volumes, so avoiding any unnecessary bloat there is generally > > a good idea). > > Here's a separate patch to remove it, while preserving the information > by moving it to the doc string of 'describe-bindings'. Why move that to the doc string? why not to the user manual? From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 19 01:08:06 2019 Received: (at 30660) by debbugs.gnu.org; 19 Nov 2019 06:08:06 +0000 Received: from localhost ([127.0.0.1]:46513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWwgD-0000B2-Uw for submit@debbugs.gnu.org; Tue, 19 Nov 2019 01:08:06 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48508) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWwg6-0000AZ-DT for 30660@debbugs.gnu.org; Tue, 19 Nov 2019 01:08:00 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41085) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iWwg0-00034n-KO; Tue, 19 Nov 2019 01:07:48 -0500 Received: from rms by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1iWwfy-00022n-Ru; Tue, 19 Nov 2019 01:07:47 -0500 Content-Type: text/plain; charset=Utf-8 From: Richard Stallman To: Stefan Kangas In-Reply-To: <87wobyme8q.fsf@marxist.se> (message from Stefan Kangas on Sun, 17 Nov 2019 21:36:53 +0100) Subject: Re: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") References: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> <87tv8bul5g.fsf@gnus.org> <8336fvhxt0.fsf@gnu.org> <83o8yfbk79.fsf@gnu.org> <87ftj0wlel.fsf@marxist.se> <87k186pi8l.fsf@marxist.se> <83h8367luj.fsf@gnu.org> <87wobyme8q.fsf@marxist.se> Message-Id: Date: Tue, 19 Nov 2019 01:07:46 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 30660 Cc: eliz@gnu.org, 30660@debbugs.gnu.org, larsi@gnus.org, jidanni@jidanni.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rms@gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > > I don't know why describe-bindings was documented in both manuals, > > and see no reason to continue doing so (the ELisp manual prints in 2 > > large volumes, so avoiding any unnecessary bloat there is generally > > a good idea). I think I included it in the Lisp Manual because it is useful for debugging the bindings of a mode you are working on. -- Dr Richard Stallman Founder, Free Software Foundation (https://gnu.org, https://fsf.org) Internet Hall-of-Famer (https://internethalloffame.org) From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 19 09:15:17 2019 Received: (at 30660) by debbugs.gnu.org; 19 Nov 2019 14:15:17 +0000 Received: from localhost ([127.0.0.1]:46808 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iX4Hl-0003Bb-JA for submit@debbugs.gnu.org; Tue, 19 Nov 2019 09:15:17 -0500 Received: from mail-pl1-f171.google.com ([209.85.214.171]:37114) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iX4HX-0003AX-Be for 30660@debbugs.gnu.org; Tue, 19 Nov 2019 09:15:16 -0500 Received: by mail-pl1-f171.google.com with SMTP id bb5so11831014plb.4 for <30660@debbugs.gnu.org>; Tue, 19 Nov 2019 06:15:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rk6xR2zoHkLuKiKPR2AmQgIZA/M+nnZdDjRQIMuygRk=; b=kv007RPac9bAxm5CwYenrh5ZBn2uUxF9mTtbZmJzJUMM65aurLfEbM1Acqft1px7wY JcxF4BzKWJyLfG29/xHc5j2s4jHbJ+jzhCmV95Y3eCTVSjl9mKd9igvJTPTmz2JvuNmC tzsJvol2mWBIswRYcFRhIF9IlNPHHUXcfAXcqz5WwUd3GdLoa21KHC35gdwiSD3X188A EQFPoffCYJdTSKhD4cOQjC9egQESvKWsN6MRmgQsy+iOUfn032qSTU1gCwbKqIKDvtzh 7J/IlcE9slS/rDK8TzoRS16ivi92nYmaULUMdAxWm4po6ksnrGvDEyTh/I0janlpuLia XsFA== X-Gm-Message-State: APjAAAV44VcPKIl/phoo2hmwsjs1cRlWAfzokJJFrfK9YgXTKNft8QwT XUti8GQyEHJv38xphLu2W2QqKMMPQN5fWI4wdeo= X-Google-Smtp-Source: APXvYqwuq7LuElhwgEGOeN7LRutR2vnRtB+MYPvWMf+Macdkn9InlpuGGYFgeI2s5B6SDgSPhf3obfC9lpAds0Y/a1w= X-Received: by 2002:a17:90a:1424:: with SMTP id j33mr7047584pja.2.1574172897501; Tue, 19 Nov 2019 06:14:57 -0800 (PST) MIME-Version: 1.0 References: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> <87tv8bul5g.fsf@gnus.org> <8336fvhxt0.fsf@gnu.org> <83o8yfbk79.fsf@gnu.org> <87ftj0wlel.fsf@marxist.se> <87k186pi8l.fsf@marxist.se> <83h8367luj.fsf@gnu.org> <87h832mdl3.fsf@marxist.se> <83wobx2m1u.fsf@gnu.org> In-Reply-To: <83wobx2m1u.fsf@gnu.org> From: Stefan Kangas Date: Tue, 19 Nov 2019 15:14:45 +0100 Message-ID: Subject: Re: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 30660 Cc: Lars Ingebrigtsen , 30660@debbugs.gnu.org, =?UTF-8?B?56mN5Li55bC8IERhbiBKYWNvYnNvbg==?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Eli Zaretskii writes: >> > I'd prefer to have just one description in the user manual, and have a >> > cross-reference in the ELisp manual which points to that. >> >> OK, I've removed it in the attached patch. > > This seems to do the opposite of what I've been talking about, no? > What am I missing? I'm not sure; I might have misunderstood you. In the quote above, you write "I'd prefer to have just one description in the user manual". In the patch, I therefore removed the addition to the elisp manual, while keeping the addition to the user manual. Re-reading your message, I see that you also asked for a "cross-reference in the elisp manual which points to that". My patch did not add such a reference. That was an oversight on my part. Perhaps we could add the reference in the separate patch that removes describe-bindings from the elisp manual instead. I think that logically makes more sense, since these commands are related and could be better explained if they're kept together in one brief paragraph. Please clarify if any of the above is incorrect. Thanks in advance and sorry for any confusion. Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 19 11:04:33 2019 Received: (at 30660) by debbugs.gnu.org; 19 Nov 2019 16:04:33 +0000 Received: from localhost ([127.0.0.1]:48302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iX5zU-00089O-UQ for submit@debbugs.gnu.org; Tue, 19 Nov 2019 11:04:33 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48176) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iX5zT-00089B-Kz for 30660@debbugs.gnu.org; Tue, 19 Nov 2019 11:04:32 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49868) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iX5zI-0002WH-V2; Tue, 19 Nov 2019 11:04:22 -0500 Received: from [176.228.60.248] (port=4536 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iX5zA-0007u8-3i; Tue, 19 Nov 2019 11:04:12 -0500 Date: Tue, 19 Nov 2019 18:04:19 +0200 Message-Id: <834kyz3la4.fsf@gnu.org> From: Eli Zaretskii To: rms@gnu.org In-reply-to: (message from Richard Stallman on Tue, 19 Nov 2019 01:07:46 -0500) Subject: Re: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") References: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> <87tv8bul5g.fsf@gnus.org> <8336fvhxt0.fsf@gnu.org> <83o8yfbk79.fsf@gnu.org> <87ftj0wlel.fsf@marxist.se> <87k186pi8l.fsf@marxist.se> <83h8367luj.fsf@gnu.org> <87wobyme8q.fsf@marxist.se> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 30660 Cc: 30660@debbugs.gnu.org, larsi@gnus.org, stefan@marxist.se, jidanni@jidanni.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Richard Stallman > Cc: eliz@gnu.org, larsi@gnus.org, 30660@debbugs.gnu.org, > jidanni@jidanni.org > Date: Tue, 19 Nov 2019 01:07:46 -0500 > > > > I don't know why describe-bindings was documented in both manuals, > > > and see no reason to continue doing so (the ELisp manual prints in 2 > > > large volumes, so avoiding any unnecessary bloat there is generally > > > a good idea). > > I think I included it in the Lisp Manual because it is useful for debugging > the bindings of a mode you are working on. I didn't suggest to remove any mention of it, I suggested to mention it, but send the reader to the Emacs manual to read about the details. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 19 12:03:56 2019 Received: (at 30660) by debbugs.gnu.org; 19 Nov 2019 17:03:56 +0000 Received: from localhost ([127.0.0.1]:48429 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iX6ux-0003B0-Vj for submit@debbugs.gnu.org; Tue, 19 Nov 2019 12:03:56 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37175) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iX6uw-0003An-GR for 30660@debbugs.gnu.org; Tue, 19 Nov 2019 12:03:54 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51523) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iX6uo-0000x6-Ty; Tue, 19 Nov 2019 12:03:47 -0500 Received: from [176.228.60.248] (port=4567 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iX6uk-0000e5-HU; Tue, 19 Nov 2019 12:03:46 -0500 Date: Tue, 19 Nov 2019 19:03:48 +0200 Message-Id: <83r22323yj.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-reply-to: (message from Stefan Kangas on Tue, 19 Nov 2019 15:14:45 +0100) Subject: Re: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") References: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> <87tv8bul5g.fsf@gnus.org> <8336fvhxt0.fsf@gnu.org> <83o8yfbk79.fsf@gnu.org> <87ftj0wlel.fsf@marxist.se> <87k186pi8l.fsf@marxist.se> <83h8367luj.fsf@gnu.org> <87h832mdl3.fsf@marxist.se> <83wobx2m1u.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 30660 Cc: larsi@gnus.org, 30660@debbugs.gnu.org, jidanni@jidanni.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Tue, 19 Nov 2019 15:14:45 +0100 > Cc: Lars Ingebrigtsen , 30660@debbugs.gnu.org, > 積丹尼 Dan Jacobson > > Re-reading your message, I see that you also asked for a > "cross-reference in the elisp manual which points to that". My patch > did not add such a reference. That was an oversight on my part. Yes, that's what I was missing. Also, the log message says * lisp/help-fns.el (describe-keymap): New command to show key bindings for a given keymap. (Bug#30660) * doc/emacs/help.texi (Misc Help): Document it. but I see no patch part that describes describe-keymap in help.texi... > Perhaps we could add the reference in the separate patch that removes > describe-bindings from the elisp manual instead. I meant to have a reference to the description of describe-keymap. What to do with describe-bindings is a separate issue. I'm okay with removing it as well, leaving its only description in the user manual, and having a cross-reference to that in the ELisp manual. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 16 17:02:04 2020 Received: (at 30660) by debbugs.gnu.org; 16 Jan 2020 22:02:04 +0000 Received: from localhost ([127.0.0.1]:38492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isDDI-00019J-6m for submit@debbugs.gnu.org; Thu, 16 Jan 2020 17:02:04 -0500 Received: from ted.gofardesign.uk ([67.225.143.91]:60838) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isDDC-00018l-Jk for 30660@debbugs.gnu.org; Thu, 16 Jan 2020 17:02:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=M+sd3RK9CD2IrLI0PI+FD/6uE8DoADtEOHF0OeCUNeA=; b=qac2xZ677NKuD/uMbK6n+lgIKh tlTPeS5kjtoGT9+aauzRGHPi2By9H1Fc1QZ7Qd8GvXpsq4xfggImSLqCKO4udkxd/A+LvLd3xOSQA waN24YxREqYr/cQkYrMT2qs58kLK69kA0FOsp/AtHwvskIPg84KzTQF1CKW7gvE3VVpGgr5HBo9Yv kts88QYoO41YAhpXgKf95AYX8kgSKH44oeLUngjuZevY6o9gk6CICh2Fz3NjVHSWG8gFHQDWbKXqD 2oyU+jur/585O38oHmoYWEhP4dl1y3JZbRpy1/7EVUOekK3SEwkjJ1+V1NU8vdr3S9bhJF8wCd2Xq CVh5RNcA==; Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:48524 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1isDD6-0003qM-FC; Thu, 16 Jan 2020 17:01:52 -0500 From: Stefan Kangas To: Eli Zaretskii Subject: Re: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") In-Reply-To: <83r22323yj.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 19 Nov 2019 19:03:48 +0200") References: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> <87tv8bul5g.fsf@gnus.org> <8336fvhxt0.fsf@gnu.org> <83o8yfbk79.fsf@gnu.org> <87ftj0wlel.fsf@marxist.se> <87k186pi8l.fsf@marxist.se> <83h8367luj.fsf@gnu.org> <87h832mdl3.fsf@marxist.se> <83wobx2m1u.fsf@gnu.org> <83r22323yj.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Date: Thu, 16 Jan 2020 23:01:50 +0100 Message-ID: <87zhen2h81.fsf@marxist.se> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30660 Cc: larsi@gnus.org, 30660@debbugs.gnu.org, jidanni@jidanni.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Eli Zaretskii writes: >> From: Stefan Kangas >> Date: Tue, 19 Nov 2019 15:14:45 +0100 >> Cc: Lars Ingebrigtsen , 30660@debbugs.gnu.org,=20 >> =E7=A9=8D=E4=B8=B9=E5=B0=BC Dan Jacobson >>=20 >> Re-reading your message, I see that you also asked for a >> "cross-reference in the elisp manual which points to that". My patch >> did not add such a reference. That was an oversight on my part. > > Yes, that's what I was missing. Also, the log message says > > * lisp/help-fns.el (describe-keymap): New command to show key bindings > for a given keymap. (Bug#30660) > * doc/emacs/help.texi (Misc Help): Document it. > > but I see no patch part that describes describe-keymap in help.texi... Please find attached an updated patch below. Best regards, Stefan Kangas --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Add-new-help-command-describe-keymap.patch >From eb60c6a6c018f9e4c35c162a67f476858c7c3fd0 Mon Sep 17 00:00:00 2001 From: Stefan Kangas Date: Sat, 24 Aug 2019 01:02:04 +0200 Subject: [PATCH] Add new help command describe-keymap * lisp/help-fns.el (describe-keymap): New command to show key bindings for a given keymap. (Bug#30660) * doc/emacs/help.texi (Misc Help): Document the new command. * doc/lispref/keymaps.texi (Scanning Keymaps): Add a cross-reference to the above documentation. * etc/NEWS: Announce the new command. * test/lisp/help-fns-tests.el (help-fns-test-describe-keymap/symbol) (help-fns-test-describe-keymap/value) (help-fns-test-describe-keymap/not-keymap) (help-fns-test-describe-keymap/let-bound) (help-fns-test-describe-keymap/dynamically-bound-no-file): New tests. Co-authored-by: Drew Adams --- doc/emacs/help.texi | 4 +++ doc/lispref/keymaps.texi | 7 +++-- etc/NEWS | 5 ++++ lisp/help-fns.el | 59 +++++++++++++++++++++++++++++++++++++ test/lisp/help-fns-tests.el | 28 ++++++++++++++++++ 5 files changed, 101 insertions(+), 2 deletions(-) diff --git a/doc/emacs/help.texi b/doc/emacs/help.texi index fce6720b93..3250c12364 100644 --- a/doc/emacs/help.texi +++ b/doc/emacs/help.texi @@ -601,6 +601,10 @@ Misc Help which marks a defun. However, @w{@kbd{@key{ESC} @key{F1}}} and @w{@kbd{@key{ESC} ?}} work fine.) +@findex describe-keymap +Finally, @kbd{M-x describe-keymap} prompts for the name of a keymap +variable and displays a listing of all key bindings in that keymap. + @node Help Files @section Help Files diff --git a/doc/lispref/keymaps.texi b/doc/lispref/keymaps.texi index 259efea324..4d513132e9 100644 --- a/doc/lispref/keymaps.texi +++ b/doc/lispref/keymaps.texi @@ -1846,8 +1846,11 @@ Scanning Keymaps @cindex scanning keymaps @cindex keymaps, scanning - This section describes functions used to scan all the current keymaps -for the sake of printing help information. + This section describes functions used to scan all the current +keymaps for the sake of printing help information. To display the +bindings in a particular keymap, you can use the +@code{describe-keymap} command (@pxref{Misc Help, , Other Help +Commands, emacs, The GNU Emacs Manual}) @defun accessible-keymaps keymap &optional prefix This function returns a list of all the keymaps that can be reached (via diff --git a/etc/NEWS b/etc/NEWS index 7ea4bba9cd..1033da8102 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -44,6 +44,11 @@ It was declared obsolete in Emacs 27.1. * Changes in Specialized Modes and Packages in Emacs 28.1 +** Help + ++++ +*** New command 'describe-keymap' describes keybindings in a keymap. + * New Modes and Packages in Emacs 28.1 diff --git a/lisp/help-fns.el b/lisp/help-fns.el index 0e2ae6b3c3..017bb3ae74 100644 --- a/lisp/help-fns.el +++ b/lisp/help-fns.el @@ -1562,6 +1562,65 @@ describe-categories (insert "\nThe parent category table is:") (describe-vector table 'help-describe-category-set)))))) +;;;###autoload +(defun describe-keymap (keymap) + "Describe key bindings in KEYMAP. +When called interactively, prompt for a variable that has a +keymap value." + (interactive (list + (intern (completing-read "Keymap: " obarray + (lambda (m) + (and (boundp m) + (keymapp (symbol-value m)))) + t nil 'variable-name-history)))) + (let (used-gentemp) + (unless (and (symbolp keymap) + (boundp keymap) + (keymapp (symbol-value keymap))) + (when (not (keymapp keymap)) + (if (symbolp keymap) + (error "Not a keymap variable: %S" keymap) + (error "Not a keymap"))) + (let ((sym nil)) + (unless sym + (setq sym (cl-gentemp "KEYMAP OBJECT (no variable) ")) + (setq used-gentemp t) + (set sym keymap)) + (setq keymap sym))) + ;; Follow aliasing. + (setq keymap (or (ignore-errors (indirect-variable keymap)) keymap)) + (help-setup-xref (list #'describe-keymap keymap) + (called-interactively-p 'interactive)) + (let* ((name (symbol-name keymap)) + (doc (documentation-property keymap 'variable-documentation)) + (file-name (find-lisp-object-file-name keymap 'defvar))) + (with-help-window (help-buffer) + (with-current-buffer standard-output + (unless used-gentemp + (princ (format-message "%S is a keymap variable" keymap)) + (if (not file-name) + (princ ".\n\n") + (princ (format-message + " defined in `%s'.\n\n" + (if (eq file-name 'C-source) + "C source code" + (file-name-nondirectory file-name)))) + (save-excursion + (re-search-backward (substitute-command-keys + "`\\([^`']+\\)'") + nil t) + (help-xref-button 1 'help-variable-def + keymap file-name)))) + (when (and (not (equal "" doc)) doc) + (princ "Documentation:\n") + (princ (format-message "%s\n\n" doc))) + ;; Use `insert' instead of `princ', so control chars (e.g. \377) + ;; insert correctly. + (insert (substitute-command-keys (concat "\\{" name "}")))))) + ;; Cleanup. + (when used-gentemp + (makunbound keymap)))) + ;;; Replacements for old lib-src/ programs. Don't seem especially useful. diff --git a/test/lisp/help-fns-tests.el b/test/lisp/help-fns-tests.el index 4c808d8372..1ac27fef3a 100644 --- a/test/lisp/help-fns-tests.el +++ b/test/lisp/help-fns-tests.el @@ -123,4 +123,32 @@ help-fns-test-describe-symbol (goto-char (point-min)) (should (looking-at "^font-lock-comment-face is ")))) + +;;; Tests for describe-keymap +(ert-deftest help-fns-test-describe-keymap/symbol () + (describe-keymap 'minibuffer-local-must-match-map) + (with-current-buffer "*Help*" + (should (looking-at "^minibuffer-local-must-match-map is")))) + +(ert-deftest help-fns-test-describe-keymap/value () + (describe-keymap minibuffer-local-must-match-map) + (with-current-buffer "*Help*" + (should (looking-at "^key")))) + +(ert-deftest help-fns-test-describe-keymap/not-keymap () + (should-error (describe-keymap nil)) + (should-error (describe-keymap emacs-version))) + +(ert-deftest help-fns-test-describe-keymap/let-bound () + (let ((foobar minibuffer-local-must-match-map)) + (describe-keymap foobar) + (with-current-buffer "*Help*" + (should (looking-at "^key"))))) + +(ert-deftest help-fns-test-describe-keymap/dynamically-bound-no-file () + (setq help-fns-test--describe-keymap-foo minibuffer-local-must-match-map) + (describe-keymap 'help-fns-test--describe-keymap-foo) + (with-current-buffer "*Help*" + (should (looking-at "^help-fns-test--describe-keymap-foo is")))) + ;;; help-fns-tests.el ends here -- 2.20.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 17 03:08:05 2020 Received: (at 30660) by debbugs.gnu.org; 17 Jan 2020 08:08:06 +0000 Received: from localhost ([127.0.0.1]:38815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isMfl-0000nn-Nn for submit@debbugs.gnu.org; Fri, 17 Jan 2020 03:08:05 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57481) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isMfk-0000nJ-Sh for 30660@debbugs.gnu.org; Fri, 17 Jan 2020 03:08:05 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43823) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1isMff-0006Fc-7G; Fri, 17 Jan 2020 03:07:59 -0500 Received: from [176.228.60.248] (port=1554 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1isMfe-00055u-99; Fri, 17 Jan 2020 03:07:58 -0500 Date: Fri, 17 Jan 2020 10:07:56 +0200 Message-Id: <83a76m33qb.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-reply-to: <87zhen2h81.fsf@marxist.se> (message from Stefan Kangas on Thu, 16 Jan 2020 23:01:50 +0100) Subject: Re: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") References: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> <87tv8bul5g.fsf@gnus.org> <8336fvhxt0.fsf@gnu.org> <83o8yfbk79.fsf@gnu.org> <87ftj0wlel.fsf@marxist.se> <87k186pi8l.fsf@marxist.se> <83h8367luj.fsf@gnu.org> <87h832mdl3.fsf@marxist.se> <83wobx2m1u.fsf@gnu.org> <83r22323yj.fsf@gnu.org> <87zhen2h81.fsf@marxist.se> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 30660 Cc: larsi@gnus.org, 30660@debbugs.gnu.org, jidanni@jidanni.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Cc: larsi@gnus.org, 30660@debbugs.gnu.org, jidanni@jidanni.org > Date: Thu, 16 Jan 2020 23:01:50 +0100 > > >> Re-reading your message, I see that you also asked for a > >> "cross-reference in the elisp manual which points to that". My patch > >> did not add such a reference. That was an oversight on my part. > > > > Yes, that's what I was missing. Also, the log message says > > > > * lisp/help-fns.el (describe-keymap): New command to show key bindings > > for a given keymap. (Bug#30660) > > * doc/emacs/help.texi (Misc Help): Document it. > > > > but I see no patch part that describes describe-keymap in help.texi... > > Please find attached an updated patch below. Thanks. > +@findex describe-keymap > +Finally, @kbd{M-x describe-keymap} prompts for the name of a keymap > +variable and displays a listing of all key bindings in that keymap. This should mention the completion on keymaps: "...prompts for the name of a keymap, with completion, and displays the listing of all the key bindings in that keymap." Also, do we want to have some reasonable default value for this prompt? Otherwise, LGTM. From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 17 21:16:41 2020 Received: (at 30660) by debbugs.gnu.org; 18 Jan 2020 02:16:41 +0000 Received: from localhost ([127.0.0.1]:40357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isdfE-0005mv-US for submit@debbugs.gnu.org; Fri, 17 Jan 2020 21:16:41 -0500 Received: from ted.gofardesign.uk ([67.225.143.91]:60890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isdfD-0005mj-Fh for 30660@debbugs.gnu.org; Fri, 17 Jan 2020 21:16:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=mgWaMChts0mxEJ/X9ZsFES7ze3ZQSSNXtkccigbTi4I=; b=Gc4teqyQ3A0x315ssx9JK4uUqq 5qfcumU2y+nwWrN86PCi4tUxTW9vDuIS6zOnK4R7W9tZAw8CLeeMUkwg2P2p/gq5Jhd8BdmIVZmxg Qk2agMGbZiV5zNgiRpcve314q700kt4SHx9tZoWGQFNzuGoH6Uk7XzlyakxD3pKK4NEZOELsP1z6R NaaKI0Fl7MRPYfaQyeuiAPS3EmBzuHlbuV+V4EgltFvLg+p3CiT9aauVUtZgz4bqp6H51AR1xHMpw j6zQEMILyrFc03KumB3g67diXCC2PzunH3ch+l/YcAPTtAo3K+Epzl9p9BNNnPtI/ha1qG5YYCnm+ E+ihtQDw==; Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:47564 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1isdf7-000LWb-Ga; Fri, 17 Jan 2020 21:16:33 -0500 From: Stefan Kangas To: Eli Zaretskii Subject: Re: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") In-Reply-To: <83a76m33qb.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 17 Jan 2020 10:07:56 +0200") References: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> <87tv8bul5g.fsf@gnus.org> <8336fvhxt0.fsf@gnu.org> <83o8yfbk79.fsf@gnu.org> <87ftj0wlel.fsf@marxist.se> <87k186pi8l.fsf@marxist.se> <83h8367luj.fsf@gnu.org> <87h832mdl3.fsf@marxist.se> <83wobx2m1u.fsf@gnu.org> <83r22323yj.fsf@gnu.org> <87zhen2h81.fsf@marxist.se> <83a76m33qb.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Date: Sat, 18 Jan 2020 03:16:30 +0100 Message-ID: <875zh9y0e9.fsf@marxist.se> MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30660 Cc: larsi@gnus.org, 30660@debbugs.gnu.org, jidanni@jidanni.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> +@findex describe-keymap >> +Finally, @kbd{M-x describe-keymap} prompts for the name of a keymap >> +variable and displays a listing of all key bindings in that keymap. > > This should mention the completion on keymaps: > > "...prompts for the name of a keymap, with completion, and displays > the listing of all the key bindings in that keymap." Fixed, thanks. I now have: @findex describe-keymap Finally, @kbd{M-x describe-keymap} prompts for the name of a keymap, with completion, and displays a listing of all key bindings in that keymap. > Also, do we want to have some reasonable default value for this > prompt? I'm not sure, what would be a reasonable default? The keymap of the current major mode? Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 18 03:31:38 2020 Received: (at 30660) by debbugs.gnu.org; 18 Jan 2020 08:31:38 +0000 Received: from localhost ([127.0.0.1]:40435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isjW6-0007gd-8d for submit@debbugs.gnu.org; Sat, 18 Jan 2020 03:31:38 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59013) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isjW2-0007aQ-MM for 30660@debbugs.gnu.org; Sat, 18 Jan 2020 03:31:36 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49223) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1isjVx-0006Rd-08; Sat, 18 Jan 2020 03:31:29 -0500 Received: from [176.228.60.248] (port=3053 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1isjVu-0003pM-Qw; Sat, 18 Jan 2020 03:31:27 -0500 Date: Sat, 18 Jan 2020 10:31:28 +0200 Message-Id: <83mual17z3.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-reply-to: <875zh9y0e9.fsf@marxist.se> (message from Stefan Kangas on Sat, 18 Jan 2020 03:16:30 +0100) Subject: Re: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") References: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> <87tv8bul5g.fsf@gnus.org> <8336fvhxt0.fsf@gnu.org> <83o8yfbk79.fsf@gnu.org> <87ftj0wlel.fsf@marxist.se> <87k186pi8l.fsf@marxist.se> <83h8367luj.fsf@gnu.org> <87h832mdl3.fsf@marxist.se> <83wobx2m1u.fsf@gnu.org> <83r22323yj.fsf@gnu.org> <87zhen2h81.fsf@marxist.se> <83a76m33qb.fsf@gnu.org> <875zh9y0e9.fsf@marxist.se> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 30660 Cc: larsi@gnus.org, 30660@debbugs.gnu.org, jidanni@jidanni.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Cc: larsi@gnus.org, 30660@debbugs.gnu.org, jidanni@jidanni.org > Date: Sat, 18 Jan 2020 03:16:30 +0100 > > > Also, do we want to have some reasonable default value for this > > prompt? > > I'm not sure, what would be a reasonable default? The keymap of the > current major mode? I thought about the description in "Active Keymaps". From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 18 04:12:25 2020 Received: (at 30660) by debbugs.gnu.org; 18 Jan 2020 09:12:25 +0000 Received: from localhost ([127.0.0.1]:40455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isk9W-0000sf-Sw for submit@debbugs.gnu.org; Sat, 18 Jan 2020 04:12:25 -0500 Received: from ted.gofardesign.uk ([67.225.143.91]:33322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isk9S-0000sQ-V2 for 30660@debbugs.gnu.org; Sat, 18 Jan 2020 04:12:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=aMlSO7byWfcAJU/dahHPkaqaRrKKR0Nfnony+1zeoog=; b=Ufa6EKlz06Y2h/d6sCREhQ+miq Ghvc9sIP4SsaZL1l33DGA8WZoRNdXEYZ5e4C9nfEcXcwJfL+AI6UJJ1WKlCQC4F8mpTVnpqhtdwfX FdKsgntMTdeVMdWX2dDEwf/XKxkM8D2Kw6+NXD+vKzAjLMqOiTvqKKXkVpqhIOow7c7Odbtq5jugD baO5eXfDhVbl8uHX0XQPTU3M63pAJ086BdlC+JQngzQFcsqGCuNqCVwCeenI3G9iTwa0gl3zX7le3 b+eoOyXOKbG+cDd7x77O25tnFJqWWoqJpck6PIz+0GQtm5G6bGHHpJEcdAxB3NbwvWAQ998yR7LL8 /VzAm++A==; Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:60040 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1isk9J-001jKx-Ry; Sat, 18 Jan 2020 04:12:10 -0500 From: Stefan Kangas To: Eli Zaretskii Subject: Re: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") In-Reply-To: <83mual17z3.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 18 Jan 2020 10:31:28 +0200") References: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> <87tv8bul5g.fsf@gnus.org> <8336fvhxt0.fsf@gnu.org> <83o8yfbk79.fsf@gnu.org> <87ftj0wlel.fsf@marxist.se> <87k186pi8l.fsf@marxist.se> <83h8367luj.fsf@gnu.org> <87h832mdl3.fsf@marxist.se> <83wobx2m1u.fsf@gnu.org> <83r22323yj.fsf@gnu.org> <87zhen2h81.fsf@marxist.se> <83a76m33qb.fsf@gnu.org> <875zh9y0e9.fsf@marxist.se> <83mual17z3.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Date: Sat, 18 Jan 2020 10:12:08 +0100 Message-ID: <87iml95dsn.fsf@marxist.se> MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30660 Cc: larsi@gnus.org, 30660@debbugs.gnu.org, jidanni@jidanni.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> > Also, do we want to have some reasonable default value for this >> > prompt? >> >> I'm not sure, what would be a reasonable default? The keymap of the >> current major mode? > > I thought about the description in "Active Keymaps". Do you mean to use the first active keymap? I can see how that make sense, and would probably be intuitive when trying to figure out what keymap is active in different parts of a buffer (for example over a button). If that's what you're thinking of, I wonder if there's any way to get the name of the highest precedent keymap among the active keymaps? This was the first thing I tried, but it didn't work: (car (current-active-maps t (point))) Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 18 04:41:48 2020 Received: (at 30660) by debbugs.gnu.org; 18 Jan 2020 09:41:48 +0000 Received: from localhost ([127.0.0.1]:40474 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iskc0-0001Zh-3H for submit@debbugs.gnu.org; Sat, 18 Jan 2020 04:41:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iskbx-0001ZQ-Vz for 30660@debbugs.gnu.org; Sat, 18 Jan 2020 04:41:47 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49864) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iskbs-0006Qd-CP; Sat, 18 Jan 2020 04:41:40 -0500 Received: from [176.228.60.248] (port=3334 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iskbr-0006iR-SA; Sat, 18 Jan 2020 04:41:40 -0500 Date: Sat, 18 Jan 2020 11:41:41 +0200 Message-Id: <83iml914q2.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-reply-to: <87iml95dsn.fsf@marxist.se> (message from Stefan Kangas on Sat, 18 Jan 2020 10:12:08 +0100) Subject: Re: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") References: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> <87tv8bul5g.fsf@gnus.org> <8336fvhxt0.fsf@gnu.org> <83o8yfbk79.fsf@gnu.org> <87ftj0wlel.fsf@marxist.se> <87k186pi8l.fsf@marxist.se> <83h8367luj.fsf@gnu.org> <87h832mdl3.fsf@marxist.se> <83wobx2m1u.fsf@gnu.org> <83r22323yj.fsf@gnu.org> <87zhen2h81.fsf@marxist.se> <83a76m33qb.fsf@gnu.org> <875zh9y0e9.fsf@marxist.se> <83mual17z3.fsf@gnu.org> <87iml95dsn.fsf@marxist.se> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 30660 Cc: larsi@gnus.org, 30660@debbugs.gnu.org, jidanni@jidanni.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Cc: larsi@gnus.org, 30660@debbugs.gnu.org, jidanni@jidanni.org > Date: Sat, 18 Jan 2020 10:12:08 +0100 > > >> I'm not sure, what would be a reasonable default? The keymap of the > >> current major mode? > > > > I thought about the description in "Active Keymaps". > > Do you mean to use the first active keymap? > > I can see how that make sense, and would probably be intuitive when > trying to figure out what keymap is active in different parts of a > buffer (for example over a button). > > If that's what you're thinking of, I wonder if there's any way to get > the name of the highest precedent keymap among the active keymaps? > > This was the first thing I tried, but it didn't work: > > (car (current-active-maps t (point))) Does the pseudo-code at the beginning of "Searching Keymaps" give any ideas? From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 18 18:42:15 2020 Received: (at 30660) by debbugs.gnu.org; 18 Jan 2020 23:42:16 +0000 Received: from localhost ([127.0.0.1]:42463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isxjL-0007OF-3q for submit@debbugs.gnu.org; Sat, 18 Jan 2020 18:42:15 -0500 Received: from ted.gofardesign.uk ([67.225.143.91]:44522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isxjJ-0007O2-Fk for 30660@debbugs.gnu.org; Sat, 18 Jan 2020 18:42:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kqw5i+rZEqygbzSjOqzoc9veDfYknL6+vMWWNxJ/e1M=; b=ZQICvSA42ZU66EK8oDAza+gAta U/hfgicwRD55z1bUH1R4ugoaRDZQvnKb73PesdBimM1OjIDK8DKn1Qnb7gSSzC+nlo40joOLKhs8G VVhZ7iYb9vtDBB1AXPYe6bNpKXrxbH68smsWVbjq5zsjFTeIbnm63Cym4i3eCB3EJ5uvU2MMyF7/P 7hYaLUPUluF+o+HYAB4SDKg1DKC1eILy0f956eOUZcbmWicKeRw/VD+K/ACPBpOcUzLKxAXy6mNuo J+P6XtTx796WpxbBm4IKaZ9zOx2sOjuoQnBzJh+20bruCHu7OUZ2gClCOtBzpPtEz0LBypNaC8loQ luUanlEw==; Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:53288 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1isxjD-000oeY-8o; Sat, 18 Jan 2020 18:42:07 -0500 From: Stefan Kangas To: Eli Zaretskii Subject: Re: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") In-Reply-To: <83iml914q2.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 18 Jan 2020 11:41:41 +0200") References: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> <87tv8bul5g.fsf@gnus.org> <8336fvhxt0.fsf@gnu.org> <83o8yfbk79.fsf@gnu.org> <87ftj0wlel.fsf@marxist.se> <87k186pi8l.fsf@marxist.se> <83h8367luj.fsf@gnu.org> <87h832mdl3.fsf@marxist.se> <83wobx2m1u.fsf@gnu.org> <83r22323yj.fsf@gnu.org> <87zhen2h81.fsf@marxist.se> <83a76m33qb.fsf@gnu.org> <875zh9y0e9.fsf@marxist.se> <83mual17z3.fsf@gnu.org> <87iml95dsn.fsf@marxist.se> <83iml914q2.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Date: Sun, 19 Jan 2020 00:42:05 +0100 Message-ID: <871rrwwcvm.fsf@marxist.se> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30660 Cc: larsi@gnus.org, 30660@debbugs.gnu.org, jidanni@jidanni.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: > Does the pseudo-code at the beginning of "Searching Keymaps" give any > ideas? It does, yes. The pseudo-code only gives us the *value* of the keymap. This is probably part of the reason why Drew wanted us to be able to find keymap *symbols* from values. I have added a separate function help-fns-find-keymap-name to get the symbol from the value based on his code. I'm not sure exactly where the new functions in the second patch should go, so I just kept them in help-fns.el. I suspect people might want to use at least help-fns-find-keymap-name outside of help-fns.el, so maybe we could find a better place to add them (and better names?). Attached is an updated patchset. The first patch is as before, updated with the above doc fix, and the second patch adds the reasonable default you asked for. WDYT? Best regards, Stefan Kangas --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Add-new-help-command-describe-keymap.patch >From be09c3a807239804284430cd316530235b48da19 Mon Sep 17 00:00:00 2001 From: Stefan Kangas Date: Sat, 24 Aug 2019 01:02:04 +0200 Subject: [PATCH 1/2] Add new help command describe-keymap * lisp/help-fns.el (describe-keymap): New command to show key bindings for a given keymap. (Bug#30660) * doc/emacs/help.texi (Misc Help): Document the new command. * doc/lispref/keymaps.texi (Scanning Keymaps): Add a cross-reference to the above documentation. * etc/NEWS: Announce the new command. * test/lisp/help-fns-tests.el (help-fns-test-describe-keymap/symbol) (help-fns-test-describe-keymap/value) (help-fns-test-describe-keymap/not-keymap) (help-fns-test-describe-keymap/let-bound) (help-fns-test-describe-keymap/dynamically-bound-no-file): New tests. Co-authored-by: Drew Adams --- doc/emacs/help.texi | 5 ++++ doc/lispref/keymaps.texi | 7 +++-- etc/NEWS | 5 ++++ lisp/help-fns.el | 59 +++++++++++++++++++++++++++++++++++++ test/lisp/help-fns-tests.el | 28 ++++++++++++++++++ 5 files changed, 102 insertions(+), 2 deletions(-) diff --git a/doc/emacs/help.texi b/doc/emacs/help.texi index fce6720b93..49c53c5cbc 100644 --- a/doc/emacs/help.texi +++ b/doc/emacs/help.texi @@ -601,6 +601,11 @@ Misc Help which marks a defun. However, @w{@kbd{@key{ESC} @key{F1}}} and @w{@kbd{@key{ESC} ?}} work fine.) +@findex describe-keymap +Finally, @kbd{M-x describe-keymap} prompts for the name of a keymap, +with completion, and displays a listing of all key bindings in that +keymap. + @node Help Files @section Help Files diff --git a/doc/lispref/keymaps.texi b/doc/lispref/keymaps.texi index 259efea324..4d513132e9 100644 --- a/doc/lispref/keymaps.texi +++ b/doc/lispref/keymaps.texi @@ -1846,8 +1846,11 @@ Scanning Keymaps @cindex scanning keymaps @cindex keymaps, scanning - This section describes functions used to scan all the current keymaps -for the sake of printing help information. + This section describes functions used to scan all the current +keymaps for the sake of printing help information. To display the +bindings in a particular keymap, you can use the +@code{describe-keymap} command (@pxref{Misc Help, , Other Help +Commands, emacs, The GNU Emacs Manual}) @defun accessible-keymaps keymap &optional prefix This function returns a list of all the keymaps that can be reached (via diff --git a/etc/NEWS b/etc/NEWS index 73ed3d739e..e4ed0e0bf6 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -44,6 +44,11 @@ It was declared obsolete in Emacs 27.1. * Changes in Specialized Modes and Packages in Emacs 28.1 +** Help + ++++ +*** New command 'describe-keymap' describes keybindings in a keymap. + --- ** The sb-image.el library is now marked obsolete. This file was a compatibility kludge which is no longer needed. diff --git a/lisp/help-fns.el b/lisp/help-fns.el index 0e2ae6b3c3..017bb3ae74 100644 --- a/lisp/help-fns.el +++ b/lisp/help-fns.el @@ -1562,6 +1562,65 @@ describe-categories (insert "\nThe parent category table is:") (describe-vector table 'help-describe-category-set)))))) +;;;###autoload +(defun describe-keymap (keymap) + "Describe key bindings in KEYMAP. +When called interactively, prompt for a variable that has a +keymap value." + (interactive (list + (intern (completing-read "Keymap: " obarray + (lambda (m) + (and (boundp m) + (keymapp (symbol-value m)))) + t nil 'variable-name-history)))) + (let (used-gentemp) + (unless (and (symbolp keymap) + (boundp keymap) + (keymapp (symbol-value keymap))) + (when (not (keymapp keymap)) + (if (symbolp keymap) + (error "Not a keymap variable: %S" keymap) + (error "Not a keymap"))) + (let ((sym nil)) + (unless sym + (setq sym (cl-gentemp "KEYMAP OBJECT (no variable) ")) + (setq used-gentemp t) + (set sym keymap)) + (setq keymap sym))) + ;; Follow aliasing. + (setq keymap (or (ignore-errors (indirect-variable keymap)) keymap)) + (help-setup-xref (list #'describe-keymap keymap) + (called-interactively-p 'interactive)) + (let* ((name (symbol-name keymap)) + (doc (documentation-property keymap 'variable-documentation)) + (file-name (find-lisp-object-file-name keymap 'defvar))) + (with-help-window (help-buffer) + (with-current-buffer standard-output + (unless used-gentemp + (princ (format-message "%S is a keymap variable" keymap)) + (if (not file-name) + (princ ".\n\n") + (princ (format-message + " defined in `%s'.\n\n" + (if (eq file-name 'C-source) + "C source code" + (file-name-nondirectory file-name)))) + (save-excursion + (re-search-backward (substitute-command-keys + "`\\([^`']+\\)'") + nil t) + (help-xref-button 1 'help-variable-def + keymap file-name)))) + (when (and (not (equal "" doc)) doc) + (princ "Documentation:\n") + (princ (format-message "%s\n\n" doc))) + ;; Use `insert' instead of `princ', so control chars (e.g. \377) + ;; insert correctly. + (insert (substitute-command-keys (concat "\\{" name "}")))))) + ;; Cleanup. + (when used-gentemp + (makunbound keymap)))) + ;;; Replacements for old lib-src/ programs. Don't seem especially useful. diff --git a/test/lisp/help-fns-tests.el b/test/lisp/help-fns-tests.el index 4c808d8372..1ac27fef3a 100644 --- a/test/lisp/help-fns-tests.el +++ b/test/lisp/help-fns-tests.el @@ -123,4 +123,32 @@ help-fns-test-describe-symbol (goto-char (point-min)) (should (looking-at "^font-lock-comment-face is ")))) + +;;; Tests for describe-keymap +(ert-deftest help-fns-test-describe-keymap/symbol () + (describe-keymap 'minibuffer-local-must-match-map) + (with-current-buffer "*Help*" + (should (looking-at "^minibuffer-local-must-match-map is")))) + +(ert-deftest help-fns-test-describe-keymap/value () + (describe-keymap minibuffer-local-must-match-map) + (with-current-buffer "*Help*" + (should (looking-at "^key")))) + +(ert-deftest help-fns-test-describe-keymap/not-keymap () + (should-error (describe-keymap nil)) + (should-error (describe-keymap emacs-version))) + +(ert-deftest help-fns-test-describe-keymap/let-bound () + (let ((foobar minibuffer-local-must-match-map)) + (describe-keymap foobar) + (with-current-buffer "*Help*" + (should (looking-at "^key"))))) + +(ert-deftest help-fns-test-describe-keymap/dynamically-bound-no-file () + (setq help-fns-test--describe-keymap-foo minibuffer-local-must-match-map) + (describe-keymap 'help-fns-test--describe-keymap-foo) + (with-current-buffer "*Help*" + (should (looking-at "^help-fns-test--describe-keymap-foo is")))) + ;;; help-fns-tests.el ends here -- 2.20.1 --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0002-Provide-default-for-describe-keymap-prompt.patch >From 3a7a39f241dcb1988abd47dff0070b2abca20c02 Mon Sep 17 00:00:00 2001 From: Stefan Kangas Date: Sun, 19 Jan 2020 00:17:42 +0100 Subject: [PATCH 2/2] Provide default for describe-keymap prompt * lisp/help-fns.el (describe-keymap): Provide a reasonable default for prompt. (Bug#30660) (help-fns-find-keymap-name) (help-fns--most-relevant-active-keymap): New functions. * test/lisp/help-fns-tests.el (help-fns-test-find-keymap-name): New test. --- lisp/help-fns.el | 50 ++++++++++++++++++++++++++++++++----- test/lisp/help-fns-tests.el | 9 +++++++ 2 files changed, 53 insertions(+), 6 deletions(-) diff --git a/lisp/help-fns.el b/lisp/help-fns.el index 017bb3ae74..36c2a8b186 100644 --- a/lisp/help-fns.el +++ b/lisp/help-fns.el @@ -1562,17 +1562,55 @@ describe-categories (insert "\nThe parent category table is:") (describe-vector table 'help-describe-category-set)))))) +(defun help-fns-find-keymap-name (keymap) + "Find the name of the variable with value KEYMAP. +Return nil if KEYMAP is not a valid keymap, or if there is no +variable with value KEYMAP." + (when (keymapp keymap) + (let ((name (catch 'found-keymap + (mapatoms (lambda (symb) + (when (and (boundp symb) + (eq (symbol-value symb) keymap) + (not (eq symb 'keymap)) + (throw 'found-keymap symb))))) + nil))) + ;; Follow aliasing. + (or (ignore-errors (indirect-variable name)) name)))) + +(defun help-fns--most-relevant-active-keymap () + "Return the name of the most relevant active keymap. +The heuristic to determine which keymap is most likely to be +relevant to a user follows this order: + +1. 'keymap' text property at point +2. 'local-map' text property at point +3. the `current-local-map' + +This is used to set the default value for the interactive prompt +in `describe-keymap'. See also `Searching the Active Keymaps'." + (help-fns-find-keymap-name (or (get-char-property (point) 'keymap) + (if (get-text-property (point) 'local-map) + (get-char-property (point) 'local-map) + (current-local-map))))) + ;;;###autoload (defun describe-keymap (keymap) "Describe key bindings in KEYMAP. When called interactively, prompt for a variable that has a keymap value." - (interactive (list - (intern (completing-read "Keymap: " obarray - (lambda (m) - (and (boundp m) - (keymapp (symbol-value m)))) - t nil 'variable-name-history)))) + (interactive + (let* ((km (help-fns--most-relevant-active-keymap)) + (val (completing-read + (format "Keymap (default %s): " km) + obarray + (lambda (m) (and (boundp m) (keymapp (symbol-value m)))) + t nil 'keymap-name-history + (symbol-name km)))) + (unless (equal val "") + (setq km (intern val))) + (unless (and km (keymapp (symbol-value km))) + (user-error "Not a keymap: %s" km)) + (list km))) (let (used-gentemp) (unless (and (symbolp keymap) (boundp keymap) diff --git a/test/lisp/help-fns-tests.el b/test/lisp/help-fns-tests.el index 1ac27fef3a..89f732d244 100644 --- a/test/lisp/help-fns-tests.el +++ b/test/lisp/help-fns-tests.el @@ -125,6 +125,15 @@ help-fns-test-describe-symbol ;;; Tests for describe-keymap +(ert-deftest help-fns-test-find-keymap-name () + (should (equal (help-fns-find-keymap-name lisp-mode-map) 'lisp-mode-map)) + ;; Follow aliasing. + (unwind-protect + (progn + (defvaralias 'foo-test-map 'lisp-mode-map) + (should (equal (help-fns-find-keymap-name foo-test-map) 'lisp-mode-map))) + (makunbound 'foo-test-map))) + (ert-deftest help-fns-test-describe-keymap/symbol () (describe-keymap 'minibuffer-local-must-match-map) (with-current-buffer "*Help*" -- 2.20.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 18 21:09:40 2020 Received: (at 30660) by debbugs.gnu.org; 19 Jan 2020 02:09:40 +0000 Received: from localhost ([127.0.0.1]:42542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1it01z-0004U2-Si for submit@debbugs.gnu.org; Sat, 18 Jan 2020 21:09:40 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:58428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1it01x-0004To-GZ for 30660@debbugs.gnu.org; Sat, 18 Jan 2020 21:09:38 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 00J29VnB192535; Sun, 19 Jan 2020 02:09:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=xXQyVPQk7XCVZgVaZmKLVd/TRgTnJHYoViJbMTH76t8=; b=KiTHVop0Zi8oDzSsvCp7Pk5N9iUKLpbvsjzpLuxe7a7RtYiM4IY+L0Ul90/cwM4lSfXo zJT4tRXTPsR5AWaIB2hgLBXISLLGmnVv5zXfeL4dqOnLY2JIeZlkElMoc28nfxaP1N30 CNl7XEKTjTt/lNqSYTuYd3OswR8RMwrjff/XujYlHbSmbEmEWwCBq9VekaWyY+YW6ag4 tGwwTK93whrO4CI+UvwwOuvJYfgCX8XsWpqyWP1s8d6YpLdpVn+pLTI99ebHMHWhMik+ C5UEFAZRBiK1UeLtlHxpxHL0mr6FJFeGTu+KzLROSzGq+lcsmnyrd1broaLrsaT8aY/h VA== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 2xktnqt50w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 19 Jan 2020 02:09:31 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 00J290WG187318; Sun, 19 Jan 2020 02:09:30 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3030.oracle.com with ESMTP id 2xmc62b688-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 19 Jan 2020 02:09:30 +0000 Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 00J29Qrj028257; Sun, 19 Jan 2020 02:09:27 GMT MIME-Version: 1.0 Message-ID: Date: Sat, 18 Jan 2020 18:09:25 -0800 (PST) From: Drew Adams To: Stefan Kangas , Eli Zaretskii Subject: RE: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") References: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> <87tv8bul5g.fsf@gnus.org> <8336fvhxt0.fsf@gnu.org> <83o8yfbk79.fsf@gnu.org> <87ftj0wlel.fsf@marxist.se> <87k186pi8l.fsf@marxist.se> <83h8367luj.fsf@gnu.org> <87h832mdl3.fsf@marxist.se> <83wobx2m1u.fsf@gnu.org> <83r22323yj.fsf@gnu.org> <87zhen2h81.fsf@marxist.se> <83a76m33qb.fsf@gnu.org> <875zh9y0e9.fsf@marxist.se> <83mual17z3.fsf@gnu.org> <87iml95dsn.fsf@marxist.se> <83iml914q2.fsf@gnu.org> <871rrwwcvm.fsf@marxist.se> In-Reply-To: <871rrwwcvm.fsf@marxist.se> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4954.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9504 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001190015 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9504 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001190015 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 30660 Cc: larsi@gnus.org, 30660@debbugs.gnu.org, jidanni@jidanni.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > The pseudo-code only gives us the *value* of the keymap. This is > probably part of the reason why Drew wanted us to be able to find > keymap *symbols* from values. Yes, part of the reason. And my version doesn't just try to find keymap symbols from values. It also handles real keymap args (non-interactively), that is, keymaps for which no symbol is found (and perhaps not even sought). As I said, users reported the use case of having a keymap without any symbol (in 2015, whereas I added `describe-keymap' in 2007 - 8 years earlier). And a keymap can be composed, or it can be modified without updating any associated symbol name(s). Keymaps are not necessarily always with variables, and a user can want to see, in human terms, what the keys are in a given map. This represents real, non-interactive use cases. And as I also said, as long as the version you add to vanilla Emacs doesn't offer at least what my version provides I'll feel obliged to continue to offer my version, even for the most recent Emacs versions - something I'd prefer not to have to do. That is apparently still not so - the proposed `describe-keymap' code still doesn't allow for a non-symbol keymap argument. I don't recall ever seeing a good argument as to why you refuse to provide this feature. I hope you might reconsider this continuing lack. From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 31 05:15:53 2020 Received: (at 30660) by debbugs.gnu.org; 31 Jan 2020 10:15:53 +0000 Received: from localhost ([127.0.0.1]:36603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixTL7-0002Qp-1q for submit@debbugs.gnu.org; Fri, 31 Jan 2020 05:15:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40634) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixTL5-0002Qc-Fu for 30660@debbugs.gnu.org; Fri, 31 Jan 2020 05:15:51 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60794) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ixTKz-0003BC-SF; Fri, 31 Jan 2020 05:15:45 -0500 Received: from [176.228.60.248] (port=2774 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ixTKz-0001h9-2p; Fri, 31 Jan 2020 05:15:45 -0500 Date: Fri, 31 Jan 2020 12:15:26 +0200 Message-Id: <83h80ckk3l.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-reply-to: <871rrwwcvm.fsf@marxist.se> (message from Stefan Kangas on Sun, 19 Jan 2020 00:42:05 +0100) Subject: Re: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") References: <831b5f34-28c7-4753-bed9-0a28de484aa8@default> <87tv8bul5g.fsf@gnus.org> <8336fvhxt0.fsf@gnu.org> <83o8yfbk79.fsf@gnu.org> <87ftj0wlel.fsf@marxist.se> <87k186pi8l.fsf@marxist.se> <83h8367luj.fsf@gnu.org> <87h832mdl3.fsf@marxist.se> <83wobx2m1u.fsf@gnu.org> <83r22323yj.fsf@gnu.org> <87zhen2h81.fsf@marxist.se> <83a76m33qb.fsf@gnu.org> <875zh9y0e9.fsf@marxist.se> <83mual17z3.fsf@gnu.org> <87iml95dsn.fsf@marxist.se> <83iml914q2.fsf@gnu.org> <871rrwwcvm.fsf@marxist.se> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 30660 Cc: larsi@gnus.org, 30660@debbugs.gnu.org, jidanni@jidanni.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Stefan Kangas > Cc: larsi@gnus.org, 30660@debbugs.gnu.org, jidanni@jidanni.org > Date: Sun, 19 Jan 2020 00:42:05 +0100 > > Attached is an updated patchset. The first patch is as before, > updated with the above doc fix, and the second patch adds the > reasonable default you asked for. WDYT? Fine with me, thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 03 20:32:13 2020 Received: (at 30660) by debbugs.gnu.org; 4 Feb 2020 01:32:13 +0000 Received: from localhost ([127.0.0.1]:42347 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iyn4W-0007gA-W2 for submit@debbugs.gnu.org; Mon, 03 Feb 2020 20:32:13 -0500 Received: from ted.gofardesign.uk ([67.225.143.91]:60842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iyn4V-0007fw-V6; Mon, 03 Feb 2020 20:32:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=EGVnhCrvNiZlzg1QTSdRPvgPfpA5Jry1HFCtczIdqSk=; b=K9YyV7x1gaHgVvHnVnRHYQiqSS smcquUeyqLOh0HAE87z1dBdkZ5c86hayrQETAFzAhGjZ/3RwsXAf3wnPhED0ctjMYkXvR8WK6PQUQ S9CISa7b0/3BVDNmszn/NYhpXQ33aSnnv9wDg2iiPI067ON6catOqUhFlAY6uLNMweiCtg3KG2CvA VWpYgNJSEOyHqkvsN33E6B5oawuioROG+Y2ylu+cb0jaW4imsY+fGZgAst5y0QjpyrAzny2KZZR0+ UN/6EywBOaYeXP2LJ7QX88d1SqbiMIMg2m49dy9kuOYnS0zZPTSP9QcSZy/Jks2h4SFoLyNFntp6d pohF1ScQ==; Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:40156 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iyn4P-001Gkl-Si; Mon, 03 Feb 2020 20:32:06 -0500 From: Stefan Kangas To: Eli Zaretskii Subject: Re: bug#30660: mention describe-bindings on (info "(emacs) Keymaps") In-Reply-To: <83h80ckk3l.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 31 Jan 2020 12:15:26 +0200") References: <87tv8bul5g.fsf@gnus.org> <8336fvhxt0.fsf@gnu.org> <83o8yfbk79.fsf@gnu.org> <87ftj0wlel.fsf@marxist.se> <87k186pi8l.fsf@marxist.se> <83h8367luj.fsf@gnu.org> <87h832mdl3.fsf@marxist.se> <83wobx2m1u.fsf@gnu.org> <83r22323yj.fsf@gnu.org> <87zhen2h81.fsf@marxist.se> <83a76m33qb.fsf@gnu.org> <875zh9y0e9.fsf@marxist.se> <83mual17z3.fsf@gnu.org> <87iml95dsn.fsf@marxist.se> <83iml914q2.fsf@gnu.org> <871rrwwcvm.fsf@marxist.se> <83h80ckk3l.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Date: Tue, 04 Feb 2020 02:32:03 +0100 Message-ID: <87pnev6sto.fsf@marxist.se> MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: close 30660 28.1 thanks Eli Zaretskii writes: > Fine with me, thanks. Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: gnu.org] 1.3 RCVD_IN_RP_RNBL RBL: Relay in RNBL, https://senderscore.org/blacklistlookup/ [67.225.143.91 listed in bl.score.senderscore.com] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-Debbugs-Envelope-To: 30660 Cc: larsi@gnus.org, 30660@debbugs.gnu.org, jidanni@jidanni.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) close 30660 28.1 thanks Eli Zaretskii writes: > Fine with me, thanks. Pushed to master as commit 557b790e0a and 330228d5c7. Best regards, Stefan Kangas From unknown Sat Sep 13 02:34:35 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 03 Mar 2020 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator