From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 27 13:46:05 2018 Received: (at submit) by debbugs.gnu.org; 27 Feb 2018 18:46:05 +0000 Received: from localhost ([127.0.0.1]:35961 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqkGK-0005gR-Vy for submit@debbugs.gnu.org; Tue, 27 Feb 2018 13:46:05 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60070) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqkGK-0005fj-3k for submit@debbugs.gnu.org; Tue, 27 Feb 2018 13:46:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqkGE-00024j-0X for submit@debbugs.gnu.org; Tue, 27 Feb 2018 13:45:58 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43591) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqkGD-00024d-TB for submit@debbugs.gnu.org; Tue, 27 Feb 2018 13:45:57 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1eqkGD-0006Gt-Hw; Tue, 27 Feb 2018 13:45:57 -0500 From: Glenn Morris To: submit@debbugs.gnu.org Subject: No compiler warning if code forgets to require cl-lib X-Spook: Janet Reno Waco, Texas Ft. Bragg keyhole bootleg X-Ran: F#;Zq$#C!Z:>Ug'Z][myDPz(+Z']lC%_%G7%uFvKWx|!uaW9zvIhuhFi=h_3+X,~k@8/0X X-Hue: black X-Debbugs-No-Ack: yes X-Attribution: GM Date: Tue, 27 Feb 2018 13:45:57 -0500 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Package: emacs Version: 26.0.91 There's no compiler warning if a library uses cl-lib without requiring it. I assume this is because bytecomp.el requires cl-lib. Perhaps bytecomp can track cl-lib specially to work around this. (I was wondering how the problem shown in 6288c3d went unspotted.) Example: foo.el: (defun foo () (cl-member-if 'cl-evenp '(1 2 3))) emacs -Q -batch -f batch-byte-compile foo.el -> silently succeeds emacs -Q -l foo.elc M-: (foo) -> void-function cl-member-if From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 19 15:58:50 2018 Received: (at 30635) by debbugs.gnu.org; 19 Mar 2018 19:58:50 +0000 Received: from localhost ([127.0.0.1]:42207 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ey0vi-0001sT-As for submit@debbugs.gnu.org; Mon, 19 Mar 2018 15:58:50 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:42415) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ey0vh-0001sM-8w for 30635@debbugs.gnu.org; Mon, 19 Mar 2018 15:58:49 -0400 Received: from lechazo.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w2JJwmM5023403; Mon, 19 Mar 2018 15:58:48 -0400 Received: by lechazo.home (Postfix, from userid 20848) id 3E4AF632A7; Mon, 19 Mar 2018 15:58:48 -0400 (EDT) From: Stefan Monnier To: Glenn Morris Subject: Re: bug#30635: No compiler warning if code forgets to require cl-lib Message-ID: References: Date: Mon, 19 Mar 2018 15:58:48 -0400 In-Reply-To: (Glenn Morris's message of "Tue, 27 Feb 2018 13:45:57 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6245=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6245> : inlines <6504> : streams <1781677> : uri <2611215> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 30635 Cc: 30635@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) > There's no compiler warning if a library uses cl-lib without requiring it. > I assume this is because bytecomp.el requires cl-lib. Should we apply the patch below? Stefan diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el index b3ea9300b0..e75403d80d 100644 --- a/lisp/emacs-lisp/bytecomp.el +++ b/lisp/emacs-lisp/bytecomp.el @@ -124,17 +124,11 @@ (require 'backquote) (require 'macroexp) (require 'cconv) -(require 'cl-lib) - -;; During bootstrap, cl-loaddefs.el is not created yet, so loading cl-lib -;; doesn't setup autoloads for things like cl-every, which is why we have to -;; require cl-extra as well (bug#18804). -(or (fboundp 'cl-every) - (require 'cl-extra)) - -(or (fboundp 'defsubst) - ;; This really ought to be loaded already! - (load "byte-run")) +(eval-when-compile + ;; We should refrain from loading cl-lib at run-time within the compiler + ;; code, otherwise we can't detect if a file forgets to (require 'cl-lib), + ;; as mentioned in bug#30635. + (require 'cl-lib)) ;; The feature of compiling in a specific target Emacs version ;; has been turned off because compile time options are a bad idea. @@ -3582,7 +3576,10 @@ byte-compile-and-folded (cond ((< l 3) (byte-compile-form `(progn ,(nth 1 form) t))) ((= l 3) (byte-compile-two-args form)) - ((cl-every #'macroexp-copyable-p (nthcdr 2 form)) + ;; This used to use `cl-every' but we need to avoid cl-lib at run-time as + ;; mentioned at the beginning of this file. + ((null (delq nil (mapcar (lambda (e) (not (macroexp-copyable-p e))) + (nthcdr 2 form)))) (byte-compile-form `(and (,(car form) ,(nth 1 form) ,(nth 2 form)) (,(car form) ,@(nthcdr 2 form))))) (t (byte-compile-normal-call form))))) From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 19 16:12:38 2018 Received: (at 30635) by debbugs.gnu.org; 19 Mar 2018 20:12:38 +0000 Received: from localhost ([127.0.0.1]:42224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ey194-0002FQ-Fk for submit@debbugs.gnu.org; Mon, 19 Mar 2018 16:12:38 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51953) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ey193-0002FB-TQ for 30635@debbugs.gnu.org; Mon, 19 Mar 2018 16:12:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ey18x-0006GY-RA for 30635@debbugs.gnu.org; Mon, 19 Mar 2018 16:12:32 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35742) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ey18v-0006Dv-CW; Mon, 19 Mar 2018 16:12:29 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ey18u-0008O0-Hp; Mon, 19 Mar 2018 16:12:28 -0400 From: Glenn Morris To: Stefan Monnier Subject: Re: bug#30635: No compiler warning if code forgets to require cl-lib References: X-Spook: MDA Beltran-Leyva AQIM Plot AQAP smuggle La Familia Recall X-Ran: 1!50kf>zq2W<:9P4I`)S|f#zW'f\'=o_!?E!;C-&TY([4!w>r#rxY3s'%z/KuW'n`O1zxT X-Hue: green X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 19 Mar 2018 16:12:28 -0400 In-Reply-To: (Stefan Monnier's message of "Mon, 19 Mar 2018 15:58:48 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30635 Cc: 30635@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Stefan Monnier wrote: >> There's no compiler warning if a library uses cl-lib without requiring it. >> I assume this is because bytecomp.el requires cl-lib. > > Should we apply the patch below? Works for me, thanks. It reveals a problem in isearch.el since 6bc78d5: emacs -Q --eval "(setq search-exit-option 'append)" C-s -> Error in pre-command-hook (isearch-pre-command-hook): (void-function cl-every) From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 22 17:53:05 2018 Received: (at 30635) by debbugs.gnu.org; 22 Mar 2018 21:53:06 +0000 Received: from localhost ([127.0.0.1]:48185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ez88v-0006wc-MA for submit@debbugs.gnu.org; Thu, 22 Mar 2018 17:53:05 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:34444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ez88t-0006wU-De for 30635@debbugs.gnu.org; Thu, 22 Mar 2018 17:53:04 -0400 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w2MLr1L9006733; Thu, 22 Mar 2018 17:53:02 -0400 Received: by pastel.home (Postfix, from userid 20848) id 6EA3E604C8; Thu, 22 Mar 2018 17:53:01 -0400 (EDT) From: Stefan Monnier To: Glenn Morris Subject: Re: bug#30635: No compiler warning if code forgets to require cl-lib Message-ID: References: Date: Thu, 22 Mar 2018 17:53:01 -0400 In-Reply-To: (Glenn Morris's message of "Mon, 19 Mar 2018 16:12:28 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6248=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6248> : inlines <6514> : streams <1781970> : uri <2613021> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 30635 Cc: 30635@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) >>> There's no compiler warning if a library uses cl-lib without requiring it. >>> I assume this is because bytecomp.el requires cl-lib. >> Should we apply the patch below? > Works for me, thanks. Doesn't work for me, OTOH: % src/emacs --batch --eval "(eval-after-load 'cl-lib '(debug t))" -f batch-byte-compile lisp/emacs-lisp/bytecomp.el Debugger entered--beginning evaluation of function call form: (lambda nil (debug t))() eval-after-load-helper("/home/monnier/src/emacs/trunk/lisp/emacs-lisp/cl-lib.elc") run-hook-with-args(eval-after-load-helper "/home/monnier/src/emacs/trunk/lisp/emacs-lisp/cl-lib.elc") do-after-load-evaluation("/home/monnier/src/emacs/trunk/lisp/emacs-lisp/cl-lib.elc") require(cl-lib) require(seq) require(map) dir-locals-read-from-dir("/home/monnier/src/emacs/trunk/") hack-dir-local-variables() hack-local-variables(no-mode) normal-mode(t) byte-compile-file("lisp/emacs-lisp/bytecomp.el") batch-byte-compile-file("lisp/emacs-lisp/bytecomp.el") batch-byte-compile() command-line-1(("--eval" "(eval-after-load 'cl-lib '(debug t))" "-f" "batch-byte-compile" "lisp/emacs-lisp/bytecomp.el")) command-line() normal-top-level() and if you look at `dir-locals-read-from-dir`, you'll see that it does (require 'map) and then uses its `map-merge(-with)`. Stefan "the pressure to preload cl-lib is definitely mounting" From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 22 18:19:33 2018 Received: (at 30635) by debbugs.gnu.org; 22 Mar 2018 22:19:33 +0000 Received: from localhost ([127.0.0.1]:48206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ez8YX-00014e-Kp for submit@debbugs.gnu.org; Thu, 22 Mar 2018 18:19:33 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:41097) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ez8YV-00014V-4J for 30635@debbugs.gnu.org; Thu, 22 Mar 2018 18:19:31 -0400 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w2MMJTcv005730; Thu, 22 Mar 2018 18:19:30 -0400 Received: by pastel.home (Postfix, from userid 20848) id 99DD0604C8; Thu, 22 Mar 2018 18:19:29 -0400 (EDT) From: Stefan Monnier To: Glenn Morris Subject: Re: bug#30635: No compiler warning if code forgets to require cl-lib Message-ID: References: Date: Thu, 22 Mar 2018 18:19:29 -0400 In-Reply-To: (Stefan Monnier's message of "Thu, 22 Mar 2018 17:53:01 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6248=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6248> : inlines <6514> : streams <1781972> : uri <2613033> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 30635 Cc: 30635@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) >>>> There's no compiler warning if a library uses cl-lib without requiring= it. >>>> I assume this is because bytecomp.el requires cl-lib. >>> Should we apply the patch below? >> Works for me, thanks. > Doesn't work for me, OTOH: [...] > and if you look at `dir-locals-read-from-dir`, you'll see that it does > (require 'map) and then uses its `map-merge(-with)`. And if I tweak dir-locals-read-from-dir so it doesn't require `map`, and then try to compile a file like gnus-cloud.el where I removed all the `require`s, I still get: % src/emacs --batch --eval "(eval-after-load 'cl-lib '(debug t))" -f b= atch-byte-compile lisp/gnus/gnus-cloud.el=20=20 Debugger entered--beginning evaluation of function call form: (lambda nil (debug t))() [...] require(cl-lib) byte-code("\300\301!\210\300\302!\210\300\303!\207" [require cl-lib m= acroexp gv] 2) cl--defsubst-expand((cl-x) (cl-block epg-context-armor (or (cl--struc= t-epg-context-p cl-x) (signal 'wrong-type-argument (list 'epg-context cl-x)= )) (aref cl-x 4)) nil nil nil context) epg-context-armor--cmacro((epg-context-armor context) context) apply(epg-context-armor--cmacro (epg-context-armor context) context) gv-get((epg-context-armor context) #f(compiled-function (getter sette= r) #)) [...] macroexpand-all((defalias 'gnus-cloud-encode-data ...) ...) [...] byte-compile-recurse-toplevel((defun gnus-cloud-encode-data ...) ...) The end result is better tho; if I then add a call to `cl-every` into that file, I do get a warning of the form: gnus/gnus-cloud.el:512:1:Warning: the function =E2=80=98cl-every=E2=80= =99 might not be defined at runtime. So I pushed the previous two patches to master, since I think they at least partly fix this bug. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 22 20:56:44 2018 Received: (at 30635) by debbugs.gnu.org; 23 Mar 2018 00:56:44 +0000 Received: from localhost ([127.0.0.1]:48285 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezB0e-0006hC-1x for submit@debbugs.gnu.org; Thu, 22 Mar 2018 20:56:44 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35411) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezB0c-0006gt-Fo for 30635@debbugs.gnu.org; Thu, 22 Mar 2018 20:56:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ezB0W-0003ME-JK for 30635@debbugs.gnu.org; Thu, 22 Mar 2018 20:56:37 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60232) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezB0T-0003Kt-9a; Thu, 22 Mar 2018 20:56:33 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ezB0R-00035u-ER; Thu, 22 Mar 2018 20:56:31 -0400 From: Glenn Morris To: Stefan Monnier Subject: Re: bug#30635: No compiler warning if code forgets to require cl-lib References: X-Spook: Ortega dictionary CDC Blackout codes Mafia TTP Flu X-Ran: KjEx;fAO3zuscJ"7XfAip-l<3,1Dd!H8LiLS}ohT3ayMg7/A5.94F=,s;Qi^wP3/A;@kb6 X-Hue: red X-Debbugs-No-Ack: yes X-Attribution: GM Date: Thu, 22 Mar 2018 20:56:31 -0400 In-Reply-To: (Stefan Monnier's message of "Thu, 22 Mar 2018 18:19:29 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30635 Cc: 30635@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Stefan Monnier wrote: > And if I tweak dir-locals-read-from-dir so it doesn't require `map`, and Nice; this provides a measurable build speed-up by finally getting rid of some of the slowdown introduced by support for multiple dir-locals. (bug#22307) From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 23 18:48:47 2018 Received: (at control) by debbugs.gnu.org; 23 Mar 2018 22:48:47 +0000 Received: from localhost ([127.0.0.1]:50139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezVUM-0004Hf-QD for submit@debbugs.gnu.org; Fri, 23 Mar 2018 18:48:47 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezVUK-0004HO-Nx for control@debbugs.gnu.org; Fri, 23 Mar 2018 18:48:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ezVUE-0002ao-Sr for control@debbugs.gnu.org; Fri, 23 Mar 2018 18:48:39 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40286) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezVUE-0002ai-PO for control@debbugs.gnu.org; Fri, 23 Mar 2018 18:48:38 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ezVUE-0000fx-Gg for control@debbugs.gnu.org; Fri, 23 Mar 2018 18:48:38 -0400 Subject: control message for bug 30635 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Fri, 23 Mar 2018 18:48:38 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) # 97b7e58 close 30635 27.1 From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 25 20:51:36 2018 Received: (at 30635) by debbugs.gnu.org; 26 Mar 2018 00:51:36 +0000 Received: from localhost ([127.0.0.1]:53313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f0GMJ-0007G8-St for submit@debbugs.gnu.org; Sun, 25 Mar 2018 20:51:36 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:32803) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f0GMI-0007Ft-1D for 30635@debbugs.gnu.org; Sun, 25 Mar 2018 20:51:34 -0400 Received: by mail-wm0-f51.google.com with SMTP id o23so2773343wmf.0 for <30635@debbugs.gnu.org>; Sun, 25 Mar 2018 17:51:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-transfer-encoding; bh=Y5f0ap3TSN1DcZFtmkG3QC+qfdMIR7nbo0q8Eww4SHY=; b=i6Eq6XwBwrzPAZiYAqnQiHwOWO/hQKcLQ37zgYYaGYrlz3xXfNyc/TwSH0ftyY8dsI cgyj+sQagwuVvCPZyZ1wslI0iXXBXcn8BG1j4RA7NAyyH+U/9QM/eYWN3x8MNkFPWxez lnUNqiz0asK50byfPFEPqhm+gcX8Ai9oOndd4wSRIbCk5VgJWr7Xx+hNKUiPwdaR8ovt zAb4eQddV6J7zcqfIDcP3RuUnqNoErnjcMm/rO6WSI7fKFXLuqpsyeoH40C5Qd3uJR7J REQ0tPAhawt1nnVoZYNo3bVcY1h/l7cv9yd34KT7w7VmlMGTQg94FqToGhXylBV/E8yt +ZnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-transfer-encoding; bh=Y5f0ap3TSN1DcZFtmkG3QC+qfdMIR7nbo0q8Eww4SHY=; b=qPriMxMBiIAQetM7vzxsolEHSP2O1dncTBX3d86u2pOpZkrsqj6s/wf35G2yyIx1BN nMPjvjLGdpkXZ9Coy75VLod0Sj40vx8TNOzjGyoAs+YsusGQrgBcBSMG7Y2N/nUosVPS aKXWSKNIUwR5uvd8mkDcnUKRCFE/lYJN3efkZDVMqk31ZTJaOOYINgGd4nZL3AN+3nBw VgLcXA7izxHZXaqAOFG71KgsklT8FsYABC5fnIrbJbyyM1Kkf+yYkfk8s86dPpF8hAGo hBkth0mxbIa+78PXR4cc02Hi5jbG3bUnpKnD8vOMwSBM8ZGImx4ESS0m+KIFXff9brpf ik1g== X-Gm-Message-State: AElRT7FPfRslFxrVpxuVPvnKj+1cmkvXQ5bWS4zA12YeoKtH4iaZ1rQS yHyIbzOErVmGSIA8xfv7UIp9vQ== X-Google-Smtp-Source: AG47ELtzU3q+EPPe8qoeuvS2XmqrWklnWkPLaOPRpMtKlxoAD0ZR6Rp5sOI/nlA1ZIezC9Z4pkgG5Q== X-Received: by 10.80.208.221 with SMTP id g29mr39295329edf.295.1522025488162; Sun, 25 Mar 2018 17:51:28 -0700 (PDT) Received: from localhost ([2a02:8084:4f41:8c80:9c34:da08:a010:edfc]) by smtp.gmail.com with ESMTPSA id c9sm9354301edl.23.2018.03.25.17.51.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 25 Mar 2018 17:51:27 -0700 (PDT) From: "Basil L. Contovounesios" To: Stefan Monnier Subject: Re: bug#30635: No compiler warning if code forgets to require cl-lib In-Reply-To: (Stefan Monnier's message of "Thu, 22 Mar 2018 18:19:29 -0400") References: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) Date: Mon, 26 Mar 2018 01:51:22 +0100 Message-ID: <87sh8nd5h1.fsf@tcd.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30635 Cc: Glenn Morris , 30635@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Stefan Monnier writes: > So I pushed the previous two patches to master, since I think they at > least partly fix this bug. I've bisected the following build error to your commit 97b7e58c4d "Try and fix the more obvious sources of bug#30635" of 2018-03-22: [...] Dumping under the name emacs 13102432 of 33554432 static heap bytes used 99255 pure bytes used mv -f emacs bootstrap-emacs make -C ../lisp compile-first EMACS=3D"../src/bootstrap-emacs" make[2]: Entering directory '/home/blc/.local/src/emacs/lisp' ELC emacs-lisp/bytecomp.elc Error reading dir-locals: (invalid-read-syntax "#") =20=20=20=20 In toplevel form: emacs-lisp/bytecomp.el:124:1:Error: Symbol=E2=80=99s value as variable = is void: =3D Makefile:301: recipe for target 'emacs-lisp/bytecomp.elc' failed make[2]: *** [emacs-lisp/bytecomp.elc] Error 1 make[2]: Leaving directory '/home/blc/.local/src/emacs/lisp' Makefile:745: recipe for target 'bootstrap-emacs' failed make[1]: *** [bootstrap-emacs] Error 2 make[1]: Leaving directory '/home/blc/.local/src/emacs/src' Makefile:418: recipe for target 'src' failed make: *** [src] Error 2 The immediately preceding incantation on my part is: make clean && ./configure [...] && make where the configuration used follows my signature. Subsequently invoking 'make boostrap' similarly barfs with: Dumping under the name emacs 11966048 of 33554432 static heap bytes used 2450001 pure bytes used Adding name emacs-27.0.50.1 ln -f emacs bootstrap-emacs make[2]: Leaving directory '/home/blc/.local/src/emacs/src' make -C lisp all make[2]: Entering directory '/home/blc/.local/src/emacs/lisp' make -C ../leim all EMACS=3D"../src/emacs" make[3]: Entering directory '/home/blc/.local/src/emacs/leim' make[3]: Nothing to be done for 'all'. make[3]: Leaving directory '/home/blc/.local/src/emacs/leim' make -C ../admin/grammars all EMACS=3D"../../src/emacs" make[3]: Entering directory '/home/blc/.local/src/emacs/admin/grammars' make[3]: Nothing to be done for 'all'. make[3]: Leaving directory '/home/blc/.local/src/emacs/admin/grammars' make[3]: Entering directory '/home/blc/.local/src/emacs/lisp' ELC emacs-lisp/eieio.elc =20=20=20=20 In toplevel form: emacs-lisp/eieio.el:Error: Invalid read syntax: "#" Error reading dir-locals: (invalid-function " In toplevel form: emacs-lisp/eieio.el:Error: Invalid read syntax: \"#\"") emacs-lisp/eieio.el:52:4:Error: Symbol=E2=80=99s value as variable is v= oid: =3D Makefile:301: recipe for target 'emacs-lisp/eieio.elc' failed make[3]: *** [emacs-lisp/eieio.elc] Error 1 make[3]: Leaving directory '/home/blc/.local/src/emacs/lisp' Makefile:324: recipe for target 'compile-main' failed make[2]: *** [compile-main] Error 2 make[2]: Leaving directory '/home/blc/.local/src/emacs/lisp' Makefile:405: recipe for target 'lisp' failed make[1]: *** [lisp] Error 2 make[1]: Leaving directory '/home/blc/.local/src/emacs' Makefile:1099: recipe for target 'bootstrap' failed make: *** [bootstrap] Error 2 Any ideas on where I am or what is going wrong and how I can further troubleshoot this? TIA, --=20 Basil Configured using: 'configure --prefix=3D/home/blc/.local --with-mailutils --with-x-toolkit=3Dlucid --with-modules --with-file-notification=3Dyes --with-x 'CFLAGS=3D-march=3Dnative -O2 -pipe' Configured features: XAW3D XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS LUCID X11 MODULES THREADS LIBSYSTEMD LCMS2 From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 25 21:30:38 2018 Received: (at 30635) by debbugs.gnu.org; 26 Mar 2018 01:30:38 +0000 Received: from localhost ([127.0.0.1]:53324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f0Gy6-0008BX-AZ for submit@debbugs.gnu.org; Sun, 25 Mar 2018 21:30:38 -0400 Received: from mail-wm0-f54.google.com ([74.125.82.54]:54408) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f0Gy5-0008BL-1S for 30635@debbugs.gnu.org; Sun, 25 Mar 2018 21:30:37 -0400 Received: by mail-wm0-f54.google.com with SMTP id h76so12372843wme.4 for <30635@debbugs.gnu.org>; Sun, 25 Mar 2018 18:30:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=CnFuvCBys1nH9hRvYYJVmYOUnJOcyCKoj791lrdHr34=; b=GxK/RPMKKnDML+uF9V2b/fU4ha7FAEQHWpM08oR1g4u7LxkbaXDeu5twSe5xdC4u32 +T8z4N/qV7Xhs2/ifINU5rYHses7/Z3KPi1rR4tJ+nYfilyY3dAu4Sx4+gRS+EtwLibu Y2RbI5n/j2RJXDe3FxmEju2nuWb+FCGvDARR1nLYUFWPQ3C9WtesdNp2lZn8L64Ps632 xN0jR/M17kB4oqoLkssBIgjMZMHFhn98SCbKhqeGwdtoL2e4JtZIex/BcwG9YfnppI+/ rTVB4Ty2ah2TR2yzyVoWibyLJjN9Ze8qbBiejK7zODFq7I+dYXTj5pyswzNTUFryRsbv jdVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=CnFuvCBys1nH9hRvYYJVmYOUnJOcyCKoj791lrdHr34=; b=fmAJZ8ZC7U0cFQ02GZF+vPHjvk628lFVxHaIFmvUj49QgmKaP2WCk0dXDpbrzT4E0e VtFs+MN0IkLepzL81wrwFh2VycX7XKV5RbZMki0uL8ULxsmebUEeNQHsshlGbuVsq45B 9LxIwQ3tsTjqfVP1fn3ueTSijaKZWfYFldR1GLY6dz28ffJNOdYzoDg8l1wo+4DBgern Vl1rnDhQhyA4QbKVFVnN0eR3JriXpOfLiHXrTPeOhHHTM3zkwVCZSYSFj4Cbm7YwzJZJ z/+afVjfiipg2WcB13NZ6VnBbC+q/kyDs74AEQjNkuPVk0/9hicTNCE44LkRqQjLpSvX Wtpg== X-Gm-Message-State: AElRT7HgJSfW3vOHTLCe7rB9WBGt8TLsbTBTZH/gm1W7ysXvNMlNR36J GKyKhxB7ybxPPDSnWRJii7CjoA== X-Google-Smtp-Source: AG47ELusmpKEgetkPVdAguR8GJfoZqvAT2uLT0dYZ9IMepPfXhCycI8VoBceRpwSMu5LK9N6yoDVQw== X-Received: by 10.80.133.205 with SMTP id q13mr11239109edh.123.1522027831402; Sun, 25 Mar 2018 18:30:31 -0700 (PDT) Received: from localhost ([2a02:8084:4f41:8c80:9c34:da08:a010:edfc]) by smtp.gmail.com with ESMTPSA id e56sm6174873edb.84.2018.03.25.18.30.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 25 Mar 2018 18:30:30 -0700 (PDT) From: "Basil L. Contovounesios" To: Stefan Monnier Subject: Re: bug#30635: No compiler warning if code forgets to require cl-lib References: <87sh8nd5h1.fsf@tcd.ie> Date: Mon, 26 Mar 2018 02:30:29 +0100 In-Reply-To: <87sh8nd5h1.fsf@tcd.ie> (Basil L. Contovounesios's message of "Mon, 26 Mar 2018 01:51:22 +0100") Message-ID: <87vadjtyh6.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30635 Cc: Glenn Morris , 30635@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) "Basil L. Contovounesios" writes: > Any ideas on where I am or what is going wrong and how I can further > troubleshoot this? I ultimately nuked everything via 'git clean -fdx', as per INSTALL.REPO, and the errors no longer appear. Sorry about the noise. -- Basil From unknown Sun Jun 15 08:27:37 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 23 Apr 2018 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator