From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 27 13:04:38 2018 Received: (at submit) by debbugs.gnu.org; 27 Feb 2018 18:04:38 +0000 Received: from localhost ([127.0.0.1]:35904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqjcE-0002jG-DY for submit@debbugs.gnu.org; Tue, 27 Feb 2018 13:04:38 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqjcC-0002j3-Qp for submit@debbugs.gnu.org; Tue, 27 Feb 2018 13:04:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqjc7-0001Az-0C for submit@debbugs.gnu.org; Tue, 27 Feb 2018 13:04:31 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51785) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eqjc6-0001Av-Sa for submit@debbugs.gnu.org; Tue, 27 Feb 2018 13:04:30 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39449) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqjc5-0006zd-Q4 for bug-automake@gnu.org; Tue, 27 Feb 2018 13:04:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqjc0-00017Z-TF for bug-automake@gnu.org; Tue, 27 Feb 2018 13:04:29 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:53746) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eqjc0-000156-Mf for bug-automake@gnu.org; Tue, 27 Feb 2018 13:04:24 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3zrRRB6XZsz1qvBw for ; Tue, 27 Feb 2018 19:04:22 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3zrRRB56LJz1qqkT for ; Tue, 27 Feb 2018 19:04:22 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 3IGw48ZvglcJ for ; Tue, 27 Feb 2018 19:04:21 +0100 (CET) X-Auth-Info: yyB61x39FeSywDvLl7hG5Wm7fZCzoEzDMM9FefqckBJF+6E3uFgQMzp4bZjZfK8Q Received: from localhost (ppp-188-174-145-207.dynamic.mnet-online.de [188.174.145.207]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA for ; Tue, 27 Feb 2018 19:04:21 +0100 (CET) Received: by localhost (Postfix, from userid 1000) id 226522C1975; Tue, 27 Feb 2018 19:04:19 +0100 (CET) From: Andreas Schwab To: bug-automake@gnu.org Subject: Automake 1.6 fails to build with perl 5.18.2 X-Yow: Yes, Private DOBERMAN!! Date: Tue, 27 Feb 2018 19:04:19 +0100 Message-ID: <87fu5ml36k.fsf@linux-m68k.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.8 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.8 (----) I get this build failure when building automake 1.6 with perl 5.18.2: $ make -j4 GEN bin/automake GEN bin/aclocal GEN t/ax/shell-no-trail-bslash GEN t/ax/cc-no-c-o GEN runtest GEN doc/aclocal.1 GEN doc/automake.1 GEN lib/Automake/Config.pm GEN t/ax/test-defs.sh GEN bin/aclocal-1.16 GEN bin/automake-1.16 GEN doc/aclocal-1.16.1 GEN doc/automake-1.16.1 help2man: can't get `--help' info from automake-1.16 Try `--no-discard-stderr' if option outputs to stderr Makefile:3694: recipe for target 'doc/automake-1.16.1' failed make: *** [doc/automake-1.16.1] Error 255 make: *** Waiting for unfinished jobs.... $ ./pre-inst-env automake-1.16 --help "none" is not exported by the List::Util module Can't continue after import errors at /home/abuild/rpmbuild/BUILD/automake-1.16/bin/automake-1.16 line 76. BEGIN failed--compilation aborted at /home/abuild/rpmbuild/BUILD/automake-1.16/bin/automake-1.16 line 76. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 03 10:05:13 2018 Received: (at 30631) by debbugs.gnu.org; 3 Mar 2018 15:05:13 +0000 Received: from localhost ([127.0.0.1]:42942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1es8im-0008At-7q for submit@debbugs.gnu.org; Sat, 03 Mar 2018 10:05:13 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:40256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1es6cv-0004qP-JO for 30631@debbugs.gnu.org; Sat, 03 Mar 2018 07:51:03 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3ztmHm3Ghvz1qxKP for <30631@debbugs.gnu.org>; Sat, 3 Mar 2018 13:51:00 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3ztmHm1pDYz1qql2 for <30631@debbugs.gnu.org>; Sat, 3 Mar 2018 13:51:00 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id dXbU5Fjkx5X8 for <30631@debbugs.gnu.org>; Sat, 3 Mar 2018 13:50:58 +0100 (CET) X-Auth-Info: fm5GaVdV/S30jd9TleQIXR2R2UncavChxE8mYka56c9r7OMbTnW6B8mGmgsnn9lG Received: from localhost (ppp-188-174-147-167.dynamic.mnet-online.de [188.174.147.167]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA for <30631@debbugs.gnu.org>; Sat, 3 Mar 2018 13:50:58 +0100 (CET) Received: by localhost (Postfix, from userid 1000) id D7BA22C157D; Sat, 3 Mar 2018 13:50:57 +0100 (CET) Resent-To: 30631@debbugs.gnu.org Resent-From: Andreas Schwab Resent-Date: Sat, 03 Mar 2018 13:50:57 +0100 Resent-Message-ID: <87a7vpjpam.fsf@linux-m68k.org> X-From-Line: imap Sat Mar 3 13:42:51 2018 Received: from frontend02 ([127.0.0.1]) by backend01-a.mail.m-online.net (Dovecot) with LMTP id mx1UGdJ7mloiJwAA/TEooA for ; Sat, 03 Mar 2018 11:41:22 +0100 Received: from mail.m-online.net ([127.0.0.1]) by frontend02 (Dovecot) with LMTP id 0XAUGdJ7mlomYQAAz6fncw ; Sat, 03 Mar 2018 11:41:22 +0100 Received: from scanner-3.m-online.net (unknown [192.168.6.82]) by mail.m-online.net (Postfix) with ESMTP id 3ztjQB2lqYz1qqkK for ; Sat, 3 Mar 2018 11:41:22 +0100 (CET) X-Virus-Scanned: by amavisd-new at mnet-online.de Authentication-Results: scanner-3.mail.m-online.net (amavisd-new); dkim=pass (1024-bit key) header.d=unimelb.edu.au Received: from mxin-4.m-online.net ([192.168.8.170]) by scanner-3.m-online.net (scanner-3.mail.m-online.net [192.168.6.82]) (amavisd-new, port 10026) with ESMTP id 4FzcfUy2CADO for ; Sat, 3 Mar 2018 11:41:19 +0100 (CET) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [IPv6:2001:4b98:c:538::195]) by mxin-4.m-online.net (Postfix) with ESMTPS id 3ztjQ70ZhMzvPsN for ; Sat, 3 Mar 2018 11:41:19 +0100 (CET) Received: from spool.mail.gandi.net (mspool1-d.mgt.gandi.net [10.0.21.131]) by relay3-d.mail.gandi.net (Postfix) with ESMTP id BE36FA80D1 for ; Sat, 3 Mar 2018 11:41:16 +0100 (CET) Received: from mail-gw6.its.unimelb.edu.au (mail-gw6.its.unimelb.edu.au [128.250.5.155]) by spool.mail.gandi.net (Postfix) with ESMTP id 1B7DF22604B for ; Sat, 3 Mar 2018 11:41:12 +0100 (CET) Received: from mail-vk0-f52.google.com (mail-vk0-f52.google.com [209.85.213.52]) (Authenticated sender: tseemann) by mail-gw6.its.unimelb.edu.au (Postfix) with ESMTPSA id 3A82A801908B for ; Sat, 3 Mar 2018 21:41:07 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unimelb.edu.au; s=smtp; t=1520073668; bh=FN3nIO/fflwdS58k4Dk/+umOrTjmWB6tnRRIbwOQ1rI=; h=From:Date:Subject:To:From; b=FunYpo0YdQ/AoO9pSj9NW3+xtOLEi6U1QCGSiOeFUy5SN6yYkx/AE3Eye2NI0czbz TmM4BuOvssE+0F/W6mwnN9Kjs7/zR41KKrAZKlg5MvyWFYHYZ88KMnn+XEagT/B6xk qqA9DT0gkAi4FWdx5hQ10ouRHGW4nk2aFl/4jxWI= Received: by mail-vk0-f52.google.com with SMTP id k187so7178163vke.12 for ; Sat, 03 Mar 2018 02:41:07 -0800 (PST) X-Gm-Message-State: APf1xPB4Z/HnsLWPOm4Ux/xfol46U8pbn2zY72LY3DpXM8VT4f2lsf1U ocRQd+iQ5Kyk2JDGKL5y6x2b7bkVceHM89/C7tg= X-Google-Smtp-Source: AG47ELvRqHCNEASybNhnYGZ9TYEZRmz0zmNtYEzfd2Fcb4TgJpThOE8TMtweZqcaH+EJpQpSgVd/bTI9xGl7v5OjYiI= X-Received: by 10.31.13.143 with SMTP id 137mr5702964vkn.159.1520073665658; Sat, 03 Mar 2018 02:41:05 -0800 (PST) MIME-Version: 1.0 Received: by 10.176.66.66 with HTTP; Sat, 3 Mar 2018 02:40:35 -0800 (PST) From: Torsten Seemann Date: Sat, 3 Mar 2018 21:40:35 +1100 X-Gmail-Original-Message-ID: Message-ID: Subject: bug#30631: Automake 1.6 fails to build with perl 5.18.2 To: schwab@linux-m68k.org Content-Type: multipart/alternative; boundary="001a11459fc8dfc59a05667fba17" Lines: 82 X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 30631 X-Mailman-Approved-At: Sat, 03 Mar 2018 10:05:11 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) --001a11459fc8dfc59a05667fba17 Content-Type: text/plain; charset="UTF-8" Hello, I have found the same bug as you (and have a solution) The problem is that automake 1.16 is importing the function "none" from perl List::Util module. Unfortunately, "none" was only added to that module in v 1.33 and Perl 5.18 has an older version. This only occurs in "bin/automake.in" The simplest patch is for the authors to change use List::Util 'none' => use List::Util 'any' And replace their use of the function (only one case) as so: && none { => && ! any { I can't seem to find an online bug tracker for automake so I am guessing the mailing list I found your message on is all there is? If so, could you please pass this on to the maintainers? Best, Torsten A/Prof. Torsten Seemann *Lead Bioinformatician* *Melbourne Bioinformatics: melbournebioinformatics.org.au * *Microbiological Diagnostic Unit Public Health Laboratory: mduphl.unimelb.edu.au * *University of Melbourne, Parkville, AUSTRALIA.* --001a11459fc8dfc59a05667fba17 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Hello,

I have foun= d the same bug as you (and have a solution)

The problem = is that automake 1.16 is importing the function "none" from perl = List::Util module.
Unfortunately,=C2=A0 "none" was only= added to that module in v 1.33 and Perl 5.18 has an older version.
This only occurs in "bin/automake.in= "

The simplest patch is for the authors t= o change=C2=A0

use List::Util 'none'
=
=3D>
use List::Util 'any'

And replace their use of the function (only one case) as so:
&& none {=C2=A0
=3D>
&&= ! any {

I can't seem to find an online bug tr= acker for automake so I am guessing the mailing list I
found your= message on is all there is?

If so, could you plea= se pass this on to the maintainers?

Best,

Torsten



A/Prof. Torst= en Seemann
Lead Bioinfo= rmatician
Melbourne Bioinformatics= : melbo= urnebioinformatics.org.au
Micr= obiological Diagnostic Unit Public Health Laboratory: mduphl.unimelb.edu.au<= /div>
University of Melbourne, Parkville, AUSTRALIA= .

<= /div>
--001a11459fc8dfc59a05667fba17-- From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 03 19:14:05 2018 Received: (at 30631) by debbugs.gnu.org; 4 Mar 2018 00:14:05 +0000 Received: from localhost ([127.0.0.1]:43329 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1esHHl-0001LV-Q8 for submit@debbugs.gnu.org; Sat, 03 Mar 2018 19:14:04 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48976) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1esHHe-0001LD-GF for 30631@debbugs.gnu.org; Sat, 03 Mar 2018 19:13:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1esHHX-0000KR-Li for 30631@debbugs.gnu.org; Sat, 03 Mar 2018 19:13:41 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58663) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1esHHX-0000K8-FX; Sat, 03 Mar 2018 19:13:39 -0500 Received: from [2a01:e35:2ec2:e580:7d5f:f616:fc6f:3970] (port=34872 helo=godel) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1esGuH-0005UP-28; Sat, 03 Mar 2018 18:49:37 -0500 From: Mathieu Lirzin To: Torsten Seemann Subject: Re: bug#30631: Automake 1.6 fails to build with perl 5.18.2 References: <87fu5ml36k.fsf@linux-m68k.org> Date: Sun, 04 Mar 2018 00:49:34 +0100 Message-ID: <87371gzpm9.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30631 Cc: 30631@debbugs.gnu.org, schwab@linux-m68k.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain Hello, Torsten Seemann writes: > The problem is that automake 1.16 is importing the function "none" > from perl List::Util module. Unfortunately, "none" was only added to > that module in v 1.33 and Perl 5.18 has an older version. This only > occurs in "bin/automake.in" > > The simplest patch is for the authors to change > > use List::Util 'none' > => > use List::Util 'any' > > And replace their use of the function (only one case) as so: > > && none { > => > && ! any { According to [1] both 'none' and 'any' were added in List::Util 1.33. There is indeed a portability bug on the Automake side since 'configure.ac' claims to be compatible with Perl 5.6 and Looking at the perl distributions [2] it seems that 5.6.2 does not have List::Util. This requirement could probably be relaxed since Perl 5.6 is 18 years old, however this can't be done in the micro (bugfix) release I intend to make after fixing this bug. So let's reimplement it ourselves for now. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-automake-Don-t-rely-on-List-Util-to-provide-none.patch >From 666b787749b5986f7a30453741ca206b6b6ff164 Mon Sep 17 00:00:00 2001 From: Mathieu Lirzin Date: Sat, 3 Mar 2018 23:50:10 +0100 Subject: [PATCH] automake: Don't rely on List::Util to provide 'none' This change fixes automake bug#30631. This removes the use of List::Util which is not supported by Perl 5.6, by reimplementing the 'none' subroutine. * lib/Automake/General.pm (none): New subroutine. * bin/automake.in (handle_single_transform): Use it. * t/pm/General.pl: New test. * t/list-of-tests.mk (perl_TESTS): Add it. --- bin/automake.in | 3 +-- lib/Automake/General.pm | 20 +++++++++++++++++++- t/list-of-tests.mk | 1 + t/pm/General.pl | 27 +++++++++++++++++++++++++++ 4 files changed, 48 insertions(+), 3 deletions(-) create mode 100644 t/pm/General.pl diff --git a/bin/automake.in b/bin/automake.in index 16fb45182..a52a48951 100644 --- a/bin/automake.in +++ b/bin/automake.in @@ -73,7 +73,6 @@ use Automake::Wrap 'makefile_wrap'; use Automake::Language; use File::Basename; use File::Spec; -use List::Util 'none'; use Carp; ## ----------------------- ## @@ -1793,7 +1792,7 @@ sub handle_single_transform my $dname = $derived; if ($directory ne '' && option 'subdir-objects' - && none { $dname =~ /$_$/ } @dup_shortnames) + && none { $dname =~ /$_[0]$/ } @dup_shortnames) { # At this point, we don't clear information about what # parts of $derived are truly file name components. We can diff --git a/lib/Automake/General.pm b/lib/Automake/General.pm index 32f5c8db7..aa2de38b8 100644 --- a/lib/Automake/General.pm +++ b/lib/Automake/General.pm @@ -23,7 +23,7 @@ use File::Basename; use vars qw (@ISA @EXPORT); @ISA = qw (Exporter); -@EXPORT = qw (&uniq $me); +@EXPORT = qw (&uniq &none $me); # Variable we share with the main package. Be sure to have a single # copy of them: using 'my' together with multiple inclusion of this @@ -66,5 +66,23 @@ sub uniq (@) return wantarray ? @res : "@res"; } +# $RES +# none (&PRED, @LIST) +# ------------ +# Return 1 when no element in LIST satisfies predicate PRED otherwise 0. +sub none (&@) +{ + my ($pred, @list) = @_; + my $res = 1; + foreach my $item (@list) + { + if ($pred->($item)) + { + $res = 0; + last; + } + } + return $res; +} 1; # for require diff --git a/t/list-of-tests.mk b/t/list-of-tests.mk index 271bfb573..84dd29af0 100644 --- a/t/list-of-tests.mk +++ b/t/list-of-tests.mk @@ -54,6 +54,7 @@ t/pm/DisjCon2.pl \ t/pm/DisjCon3.pl \ t/pm/DisjConditions.pl \ t/pm/DisjConditions-t.pl \ +t/pm/General.pl \ t/pm/Version.pl \ t/pm/Version2.pl \ t/pm/Version3.pl \ diff --git a/t/pm/General.pl b/t/pm/General.pl new file mode 100644 index 000000000..0caefe7cf --- /dev/null +++ b/t/pm/General.pl @@ -0,0 +1,27 @@ +# Copyright (C) 2018 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2, or (at your option) +# any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +use Automake::General; + +my $failed = 0; + +# Check 'none'. +my $none_positive = none { $_[0] < 0 } (1, 7, 3, 8, 9); +$failed = 1 if ($none_positive == 0); + +my $none_gt_8 = none { $_[0] >= 8 } (1, 7, 3, 8, 9); +$failed = 1 if ($none_gt_8 == 1); + +exit $failed; -- 2.16.2 --=-=-= Content-Type: text/plain How does it sound? [1] https://metacpan.org/changes/distribution/Scalar-List-Utils#L156 [2] https://www.cpan.org/src/README.html -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 03 23:40:03 2018 Received: (at 30631) by debbugs.gnu.org; 4 Mar 2018 04:40:03 +0000 Received: from localhost ([127.0.0.1]:43433 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1esLRE-0000vH-6c for submit@debbugs.gnu.org; Sat, 03 Mar 2018 23:40:02 -0500 Received: from mail-gw6.its.unimelb.edu.au ([128.250.5.155]:53902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1esLR9-0000uy-UD for 30631@debbugs.gnu.org; Sat, 03 Mar 2018 23:39:54 -0500 Received: from mail-ua0-f169.google.com (mail-ua0-f169.google.com [209.85.217.169]) (Authenticated sender: tseemann) by mail-gw6.its.unimelb.edu.au (Postfix) with ESMTPSA id 9F4D1801908B for <30631@debbugs.gnu.org>; Sun, 4 Mar 2018 15:39:43 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unimelb.edu.au; s=smtp; t=1520138384; bh=xospk6StnAw7mJ99KJoq68suxyuNoXcLZn8rT62v5F8=; h=In-Reply-To:References:From:Date:Subject:To:Cc:From; b=fGYFyNQqzX1WRd8/JsKpgwa3PNG8zrVpJ7GDxpBsQMLgxV0P/PJUfeXpmlm4RJ67/ A7gP/kCtSOp3FESuxHGwldMxrF7zzG/Age0ql342yvPYTLtxHnDTpqip7MmkEtHPue KgnRTsMijgyb4MBH10saWLy5Yoo1F1GbHCJ+31HY= Received: by mail-ua0-f169.google.com with SMTP id n24so1143472ual.12 for <30631@debbugs.gnu.org>; Sat, 03 Mar 2018 20:39:43 -0800 (PST) X-Gm-Message-State: APf1xPCsis9lYasSqWvcxkmjZaTV4hOKydHIVlRe8+5pDb8raex3ple8 bkMZH4wipOwJcm+9RVUcT61HqLSfZC6wbqW4Oyw= X-Google-Smtp-Source: AG47ELsMLwDUbOYovdvZFJ9pwi6oTX1BVB2TebCihlZGSKQ16O4Y/yWKrLL0nuIGO49XdOrl3LnvkYHkeMfxs9GokCc= X-Received: by 10.159.33.144 with SMTP id 16mr7353306uac.182.1520138380777; Sat, 03 Mar 2018 20:39:40 -0800 (PST) MIME-Version: 1.0 Received: by 10.176.66.66 with HTTP; Sat, 3 Mar 2018 20:39:10 -0800 (PST) In-Reply-To: <87371gzpm9.fsf@gnu.org> References: <87fu5ml36k.fsf@linux-m68k.org> <87371gzpm9.fsf@gnu.org> From: Torsten Seemann Date: Sun, 4 Mar 2018 15:39:10 +1100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: bug#30631: Automake 1.6 fails to build with perl 5.18.2 To: Mathieu Lirzin Content-Type: multipart/alternative; boundary="001a113e878832205005668eccb0" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30631 Cc: 30631@debbugs.gnu.org, schwab@linux-m68k.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --001a113e878832205005668eccb0 Content-Type: text/plain; charset="UTF-8" Mathieu, That patch looks good - removing List::Util altogether is probably the right thing. And tests too. For linuxbrew, this is the patch I proposed - it uses `reduce` which has been part of List::Util from the start (I think). https://github.com/Linuxbrew/homebrew-core/pull/6352/files +-use List::Util 'none'; ++use List::Util 'reduce'; ++sub none (&@) { my $code=shift; reduce { $a && !$code->(local $_ = $b) } 1, @_; } We appreciate the fast response, as there is lots of infrastructure still on Ubuntu 14 LTS which uses old Perl 5.18. Thank you, Torsten. A/Prof. Torsten Seemann *Lead Bioinformatician* *Melbourne Bioinformatics: melbournebioinformatics.org.au * *Microbiological Diagnostic Unit Public Health Laboratory: mduphl.unimelb.edu.au * *University of Melbourne, Parkville, AUSTRALIA.* On 4 March 2018 at 10:49, Mathieu Lirzin wrote: > Hello, > > Torsten Seemann writes: > > > The problem is that automake 1.16 is importing the function "none" > > from perl List::Util module. Unfortunately, "none" was only added to > > that module in v 1.33 and Perl 5.18 has an older version. This only > > occurs in "bin/automake.in" > > > > The simplest patch is for the authors to change > > > > use List::Util 'none' > > => > > use List::Util 'any' > > > > And replace their use of the function (only one case) as so: > > > > && none { > > => > > && ! any { > > According to [1] both 'none' and 'any' were added in List::Util 1.33. > > There is indeed a portability bug on the Automake side since > 'http://configure.ac' claims to be compatible with Perl 5.6 and Looking > at the > perl distributions [2] it seems that 5.6.2 does not have List::Util. > > This requirement could probably be relaxed since Perl 5.6 is 18 years > old, however this can't be done in the micro (bugfix) release I intend > to make after fixing this bug. So let's reimplement it ourselves for > now. > > > > How does it sound? > > [1] https://metacpan.org/changes/distribution/Scalar-List-Utils#L156 > [2] https://www.cpan.org/src/README.html > > -- > Mathieu Lirzin > GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37 > > --001a113e878832205005668eccb0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Mathieu,

That patch looks good - removi= ng List::Util altogether is probably the right thing. And tests too.
<= div>
For linuxbrew, this is the patch I proposed - it uses `r= educe` which has been part of List::Util from the start (I think).
ht= tps://github.com/Linuxbrew/homebrew-core/pull/6352/files
=
+-use List::Util &= #39;none';

++use List::Util 'reduce';
++sub none (&am= p;@) { my $code=3Dshift; reduce { $a && !$code->(local $_ =3D $b= ) } 1, @_; }

We apprecia= te the fast response, as there is lots of infrastructure still on Ubuntu 14= LTS which uses old Perl 5.18.

Thank you,

Torsten.



<= div>A/Prof. Torsten Seemann
Lead Bioinformatician
Melbourne Bioinformatics: melbournebioinformatics.org.au
Microbiological Diagnostic Unit Public Heal= th Laboratory: m= duphl.unimelb.edu.au
Universit= y of Melbourne, Parkville, AUSTRALIA.


On 4 March 2018 at 10:49, Mathieu Lirzin <mthl@g= nu.org> wrote:
Hello,

Torsten Seemann <tseemann@uni= melb.edu.au> writes:

> The problem is that automake 1.16 is importing the function "none= "
> from perl List::Util module.=C2=A0 Unfortunately, "none" was= only added to
> that module in v 1.33 and Perl 5.18 has an older version.=C2=A0 This o= nly
> occurs in "bin/automake.in"
>
> The simplest patch is for the authors to change
>
> use List::Util 'none'
> =3D>
> use List::Util 'any'
>
> And replace their use of the function (only one case) as so:
>
> && none {
> =3D>
> && ! any {

According to [1] both 'none' and 'any' were added in= List::Util 1.33.

There is indeed a portability bug on the Automake side since
'h= ttp://configure.ac' claims to be compatible with Perl 5.6 and Looki= ng at the
perl distributions [2] it seems that 5.6.2 does not have List::Util.

This requirement could probably be relaxed since Perl 5.6 is 18 years
old, however this can't be done in the micro (bugfix) release I intend<= br> to make after fixing this bug.=C2=A0 So let's reimplement it ourselves = for
now.



How does it sound?

[1] https://metacpan.org/changes/distribution/Scalar-List-Utils#L156
[2] https://www.cpan.org/src/README.html

--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761=C2=A0 070D 0ADE E100 9460 4D37


--001a113e878832205005668eccb0-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 08 15:40:10 2018 Received: (at 30631-done) by debbugs.gnu.org; 8 Mar 2018 20:40:10 +0000 Received: from localhost ([127.0.0.1]:51504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eu2Kf-0003xX-QD for submit@debbugs.gnu.org; Thu, 08 Mar 2018 15:40:09 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42265) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eu2Ke-0003xF-Bc for 30631-done@debbugs.gnu.org; Thu, 08 Mar 2018 15:40:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eu2KY-00071R-Ja for 30631-done@debbugs.gnu.org; Thu, 08 Mar 2018 15:40:03 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39015) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eu2KW-00070x-KZ; Thu, 08 Mar 2018 15:40:00 -0500 Received: from [2a01:e35:2ec2:e580:7d5f:f616:fc6f:3970] (port=60610 helo=godel) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eu2KW-0005Er-3T; Thu, 08 Mar 2018 15:40:00 -0500 From: Mathieu Lirzin To: Torsten Seemann Subject: Re: bug#30631: Automake 1.6 fails to build with perl 5.18.2 References: <87fu5ml36k.fsf@linux-m68k.org> <87371gzpm9.fsf@gnu.org> Date: Thu, 08 Mar 2018 21:39:56 +0100 In-Reply-To: (Torsten Seemann's message of "Sun, 4 Mar 2018 15:39:10 +1100") Message-ID: <87ina65mjn.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30631-done Cc: 30631-done@debbugs.gnu.org, schwab@linux-m68k.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Torsten Seemann writes: > That patch looks good - removing List::Util altogether is probably the right thing. And tests too. Pushed as commit 74902aa24d4c313ab51fa684142d9240f636971a. Thanks for the review. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37 From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 08 16:41:25 2018 Received: (at control) by debbugs.gnu.org; 8 Mar 2018 21:41:25 +0000 Received: from localhost ([127.0.0.1]:51552 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eu3Hx-0005bZ-61 for submit@debbugs.gnu.org; Thu, 08 Mar 2018 16:41:25 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54176) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eu3Hw-0005bN-90 for control@debbugs.gnu.org; Thu, 08 Mar 2018 16:41:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eu3Hq-0004Lk-K7 for control@debbugs.gnu.org; Thu, 08 Mar 2018 16:41:19 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40482) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eu3Hq-0004Lg-G8 for control@debbugs.gnu.org; Thu, 08 Mar 2018 16:41:18 -0500 Received: from [2a01:e35:2ec2:e580:7d5f:f616:fc6f:3970] (port=32800 helo=godel) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eu3Hn-0005qv-PU for control@debbugs.gnu.org; Thu, 08 Mar 2018 16:41:18 -0500 Date: Thu, 08 Mar 2018 22:41:11 +0100 Message-Id: <87a7vi5jpk.fsf@gnu.org> To: control@debbugs.gnu.org From: Mathieu Lirzin Subject: control message for bug #30631 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) tags 30631 fixed From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 08 18:08:07 2018 Received: (at 30631-done) by debbugs.gnu.org; 8 Mar 2018 23:08:07 +0000 Received: from localhost ([127.0.0.1]:51585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eu4dq-0001Kt-SG for submit@debbugs.gnu.org; Thu, 08 Mar 2018 18:08:07 -0500 Received: from mail-gw6.its.unimelb.edu.au ([128.250.5.155]:51130) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eu4do-0001KL-K3 for 30631-done@debbugs.gnu.org; Thu, 08 Mar 2018 18:08:05 -0500 Received: from mail-vk0-f44.google.com (mail-vk0-f44.google.com [209.85.213.44]) (Authenticated sender: tseemann) by mail-gw6.its.unimelb.edu.au (Postfix) with ESMTPSA id AB2B1801908B for <30631-done@debbugs.gnu.org>; Fri, 9 Mar 2018 10:07:56 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unimelb.edu.au; s=smtp; t=1520550476; bh=Hv290VDRVGJMwEP5a5gNxt+XjY09h7ssmafG1BZdp1c=; h=In-Reply-To:References:From:Date:Subject:To:Cc:From; b=hFHXMexdpOC0I6/gp9jpa7yi5UpUdAddqKvGkB753cpYXC4CvLcv8MJk1v2x6zfoR +IDizN/mAuz3PY+1iuC7NOYbDa1Bi/ze2KwecQgO9ekd/Mt+tx3gsTtNjwxvrYqrYD 7hIKlMfO3lPlQ3P5+14G4Sxi9pBtEQ+oVFiycjnQ= Received: by mail-vk0-f44.google.com with SMTP id y127so992105vky.9 for <30631-done@debbugs.gnu.org>; Thu, 08 Mar 2018 15:07:56 -0800 (PST) X-Gm-Message-State: AElRT7Fjg2nZAm4YWY/hTFBiveQY+KcyuoBdhB2x6CmQe2HSBgvleEmB ZUDzrhexHKCvCr9KR1aWGRAGICdaC5fCJWB5S/I= X-Google-Smtp-Source: AG47ELu9PNEj1HLEadvhhGXJGa683+t+YO00sLeDUc3ydLkW4jRem4Mr28sWziItRmM/KG0ubIVGJkNx8ZIE+8As5yA= X-Received: by 10.31.244.13 with SMTP id s13mr14564506vkh.148.1520550474240; Thu, 08 Mar 2018 15:07:54 -0800 (PST) MIME-Version: 1.0 Received: by 10.176.66.66 with HTTP; Thu, 8 Mar 2018 15:07:53 -0800 (PST) Received: by 10.176.66.66 with HTTP; Thu, 8 Mar 2018 15:07:53 -0800 (PST) In-Reply-To: <87ina65mjn.fsf@gnu.org> References: <87fu5ml36k.fsf@linux-m68k.org> <87371gzpm9.fsf@gnu.org> <87ina65mjn.fsf@gnu.org> From: Torsten Seemann Date: Fri, 9 Mar 2018 10:07:53 +1100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: bug#30631: Automake 1.6 fails to build with perl 5.18.2 To: Mathieu Lirzin Content-Type: multipart/alternative; boundary="94eb2c149f8ee15b2d0566eebe7f" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30631-done Cc: 30631-done@debbugs.gnu.org, schwab@linux-m68k.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --94eb2c149f8ee15b2d0566eebe7f Content-Type: text/plain; charset="UTF-8" Awesome, thanks! On 9 Mar. 2018 07:40, "Mathieu Lirzin" wrote: > Torsten Seemann writes: > > > That patch looks good - removing List::Util altogether is probably the > right thing. And tests too. > > Pushed as commit 74902aa24d4c313ab51fa684142d9240f636971a. > > Thanks for the review. > > -- > Mathieu Lirzin > GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37 > > --94eb2c149f8ee15b2d0566eebe7f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Awesome, thanks!=C2=A0
On 9 Mar. 2018 07:40, "Mathieu Lirzin&quo= t; <mthl@gnu.org> wrote:
Torsten Seemann <tseemann@unimelb.edu.au> writes:=

> That patch looks good - removing List::Util altogether is probably the= right thing. And tests too.

Pushed as commit 74902aa24d4c313ab51fa684142d9240f636971a.

Thanks for the review.

--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761=C2=A0 070D 0ADE E100 9460 4D37

--94eb2c149f8ee15b2d0566eebe7f-- From unknown Sat Jun 14 04:52:56 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 06 Apr 2018 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator