From unknown Sat Aug 16 11:40:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30624: 27.0.50; dired-create-destination-dirs doesn't work when renaming more than one file Resent-From: Amos Bird Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Feb 2018 02:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 30624 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 30624@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.151969857329152 (code B ref -1); Tue, 27 Feb 2018 02:30:03 +0000 Received: (at submit) by debbugs.gnu.org; 27 Feb 2018 02:29:33 +0000 Received: from localhost ([127.0.0.1]:34193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqV1J-0007a7-Ar for submit@debbugs.gnu.org; Mon, 26 Feb 2018 21:29:33 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57743) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqV1H-0007Zu-82 for submit@debbugs.gnu.org; Mon, 26 Feb 2018 21:29:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqV19-0000w7-SR for submit@debbugs.gnu.org; Mon, 26 Feb 2018 21:29:25 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:52520) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eqV19-0000w0-Oe for submit@debbugs.gnu.org; Mon, 26 Feb 2018 21:29:23 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48683) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqV17-0001mu-SR for bug-gnu-emacs@gnu.org; Mon, 26 Feb 2018 21:29:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqV12-0000pl-4n for bug-gnu-emacs@gnu.org; Mon, 26 Feb 2018 21:29:21 -0500 Received: from mail-pf0-x230.google.com ([2607:f8b0:400e:c00::230]:33112) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eqV11-0000pb-SO for bug-gnu-emacs@gnu.org; Mon, 26 Feb 2018 21:29:16 -0500 Received: by mail-pf0-x230.google.com with SMTP id q13so7363419pff.0 for ; Mon, 26 Feb 2018 18:29:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:subject:date:message-id:mime-version; bh=+GEdLSUyyARWDxXT/3L/TLE9E9PpEtk+Xp+Ri6pY4v0=; b=iIgu2SJvcj3omJuPq1vRxthZC5FzgybYfWXMb/1g5fKpGKyZPzC8CEykujIqKnd6Of CgFXmUIbTwadCBwdldggZW3xY+BwMWuNUlv62GF1hIpVh9vz+Jf/1qZslv+cIcxIKljw Kq4aON9GMSafGswdmYoblgX1IwMAlgS/Zbf/KvBASHDdG2rKVcwDy8sCDWMtTSGS0Nj0 bMZ+0xa/13nzfZRuyRomEHfO57lNYlFhtYo7/Q3K3GYRB05jh2vt7d20+4ecXRbLXqzs eVP3HtL7IKPwAj7M0U8NvLfLkUycIEHiYO0WWgHYTHkMcOfaHxgm6iVhvgwKXxn7KufV 3myQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version; bh=+GEdLSUyyARWDxXT/3L/TLE9E9PpEtk+Xp+Ri6pY4v0=; b=VJFfOQZ9xsmnoF0k6Gpyu8gTHtEwZqiv8jJwENhDm38qT2la5mTS5PiMMf6wAdR93e qnAZtuvTD11wXH0n7RS95NbKL1sT4B3e/5cc/XkdaKkNoOiY84E+gZqBGNElxmCYQQUC /SVDYBIgbA4OU12cJlr6BdWHQ6NRMbobPOSBu7VkVPsv+y7atbzVQjML0UIwIQgA1JDX ntHqoCJHIe40BE21wmRff6l86k0b83kaNKGiriHjB0lO2kPOjgoeTQMwN1fNVBEGaAff 0iCzVn4nSWdB6LPqLgiDygn9z25iL+7FQoqbv+QgDBX0yaE0YjAnZQzVLKsW3Hhjg121 G+bA== X-Gm-Message-State: APf1xPAwAKqe9TCtBI0ZIBWD6qty6D91zyyLQoeDzKDWmdNPrHNhytMe ZCQ5ATJrtunky773mS4B0qNnag== X-Google-Smtp-Source: AH8x224bd8+HxY/QjuYHsLNRtp+II7z+c9Gwqqy5xk5tRhAVFttDNEoAKnwxL9TDiZmuwdALRZQmpQ== X-Received: by 10.99.110.199 with SMTP id j190mr10042582pgc.404.1519698554256; Mon, 26 Feb 2018 18:29:14 -0800 (PST) Received: from localhost ([168.235.77.108]) by smtp.gmail.com with ESMTPSA id 186sm18605822pfe.2.2018.02.26.18.29.12 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Feb 2018 18:29:13 -0800 (PST) User-agent: mu4e 1.0-alpha3; emacs 27.0.50 From: Amos Bird Date: Tue, 27 Feb 2018 10:29:09 +0800 Message-ID: <87muzv413e.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Hi, I'm using emacs 27.0.50 and have dired-create-destination-dirs set to 'always. When renaming more than one files to a new directory, dired throws an error at /usr/local/share/emacs/27.0.50/lisp/dired-aux.el.gz:1891 . It fails early before it has time to check whether a new directory should be created. regards, In GNU Emacs 27.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.22.27) of 2018-02-14 built on t450s Repository revision: 298275c595f6ca9e77f8131d34dda2b58fe1faa5 Windowing system distributor 'The X.Org Foundation', version 11.0.11906000 System Description: Arch Linux Recent messages: Checking 4 files in /home/amos/.emacs.d/.local/packages/elpa/vimish-fold-20171231.2212... Checking 4 files in /home/amos/.emacs.d/.local/packages/elpa/yapfify-20180105.1447... Checking 4 files in /home/amos/.emacs.d/.local/packages/elpa/fcitx-20170913.1900... Checking 20 files in /home/amos/.emacs.d/.local/packages/elpa/multiple-cursors-20170908.1452... Checking 4 files in /home/amos/.emacs.d/.local/packages/elpa/opencl-mode-20170816.549... Checking for load-path shadows...done Error during redisplay: (eval (doom-modeline-format--main)) signaled (wrong-type-argument stringp nil) [4 times] Auto-saving... Error during redisplay: (eval (doom-modeline-format--main)) signaled (wrong-type-argument stringp nil) [2 times] Buffer *unsent mail to bug-gnu-emacs* modified; kill anyway? (y or n) y dired-do-create-files: Marked Move: target must be a directory: /home/amos/git/ccutils/ffffff/ Configured features: XPM JPEG TIFF GIF PNG RSVG SOUND GPM DBUS GSETTINGS NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 THREADS LIBSYSTEMD JSON LCMS2 Important settings: value of $LC_CTYPE: zh_CN.UTF-8 value of $LANG: C value of $XMODIFIERS: @im=fcitx locale-coding-system: utf-8 Major mode: Dired by name Minor modes in effect: company-quickhelp-mode: t company-quickhelp-local-mode: t company-statistics-mode: t global-company-mode: t company-mode: t TeX-PDF-mode: t auto-compile-on-save-mode: t global-git-commit-mode: t async-bytecomp-package-mode: t diff-auto-refine-mode: t winner-mode: t show-paren-mode: t evil-escape-mode: t evil-snipe-override-mode: t evil-snipe-mode: t evil-snipe-override-local-mode: t evil-snipe-local-mode: t realign-mode: t save-place-mode: t recentf-mode: t smartparens-global-mode: t evilified-leader-override-mode: t global-evilified-leader-override-mode: t auto-insert-mode: t global-page-break-lines-mode: t global-hl-line-mode: t dired-omit-mode: t savehist-mode: t ws-butler-global-mode: t ws-butler-mode: t xterm-mouse-mode: t global-git-gutter-mode: t global-narrow-reindent-mode: t narrow-reindent-mode: t eldoc-in-minibuffer-mode: t projectile-mode: t ivy-mode: t persp-mode: t shell-dirtrack-mode: t evil-mode: t evil-local-mode: t which-key-mode: t global-undo-tree-mode: t editorconfig-mode: t global-auto-revert-mode: t override-global-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t window-divider-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (pp shadow mail-extr emacsbug sendmail cc-playground time-stamp modern-cpp-font-lock url-http url-gw gravatar url-cache bug-reference texmathp unfill preview prv-emacs tex-buf company-auctex company-lua company-lsp company-quickhelp company-statistics company-yasnippet company-ispell company-dabbrev company-capf company reftex-dcr reftex-auc reftex reftex-loaddefs reftex-vars font-latex smartparens-latex latex tex-ispell tex-style tex latexenc view dired-aux sort tramp trampver tramp-compat tramp-loaddefs ucs-normalize parse-time auto-compile packed rainbow-delimiters highlight-quoted highlight-numbers parent-mode ace-link avy disp-table eieio-opt speedbar sb-image ezimage dframe help-fns radix-tree magit-svn evil-magit magit-obsolete magit-blame magit-stash magit-bisect magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-collab ghub url-auth url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf mailcap magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log magit-diff smerge-mode magit-core magit-autorevert magit-process magit-margin magit-mode git-commit magit-git magit-section magit-utils crm magit-popup log-edit message format-spec rfc822 mml mml-sec epa epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log with-editor async-bytecomp smex ido shrink-path vc-git diff-mode yasnippet elec-pair hl-todo smartparens-lua lua-mode editorconfig-core editorconfig-core-handle editorconfig-fnmatch colir all-the-icons all-the-icons-faces data-material data-weathericons data-octicons data-fileicons data-faicons data-alltheicons memoize persistent-soft list-utils pcache eieio-base font-utils evil-vimish-fold vimish-fold f winner paren doom-themes-org doom-themes-neotree doom-one-theme evil-escape evil-snipe nav-flash pulse warnings realign-mode face-remap saveplace recentf tree-widget wid-edit smartparens-config smartparens-text smartparens-markdown smartparens solaire-mode cquery cquery-tree cquery-codelens cquery-semantic-highlighting cquery-common cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs lsp-ui lsp-ui-doc markdown-mode noutline outline lsp-ui-imenu lsp-ui-flycheck lsp-ui-peek lsp-ui-sideline lsp-imenu imenu lsp-mode network-stream puny nsm rmc starttls tls gnutls lsp-methods inline lsp-io lsp-notifications lsp-common url-util kurecolor rainbow-mode color dired-ranger bind-map autoinsert page-break-lines helm-make helm helm-source eieio-compat helm-multi-match helm-lib async ag vc-svn find-dired s hl-line+ hl-line ivy-rich dired-open dired-hacks-utils dired-x dired-quick-sort savehist ls-lisp ws-butler xt-mouse evil-terminal-cursor-changer evil-textobj-line git-gutter fcitx dbus xml narrow-reindent osc browse-url perl6-detect flycheck-ledger fringe-helper flycheck-pos-tip pos-tip flycheck find-func dash tex-site unicode-fonts let-alist evil-anzu anzu eldoc-eval derived doom-themes doom-themes-common counsel-projectile projectile grep ibuf-ext ibuffer ibuffer-loaddefs counsel dired dired-loaddefs compile esh-util etags ivy-xref xref project swiper ivy delsel ivy-overlay ffap persp-mode cl time-date evil evil-integration evil-maps evil-commands reveal flyspell ispell evil-jumps evil-command-window evil-types evil-search evil-ex shell pcomplete comint ansi-color evil-macros evil-repeat evil-states evil-core evil-common windmove thingatpt rect evil-digraphs evil-vars server core core-keybinds hydra ring lv which-key advice core-projects core-editor undo-tree diff editorconfig rx autorevert filenotify core-popups edmacro kmacro shackle trace core-ui cl-extra help-mode use-package use-package-ensure use-package-delight use-package-diminish use-package-bind-key bind-key use-package-core easy-mmode autoloads core-os core-lib pcase subr-x finder-inf package easymenu url-handlers url-parse auth-source cl-seq eieio eieio-core eieio-loaddefs password-cache json map url-vars seq byte-opt bytecomp byte-compile cconv core-packages cl-macs gv cl-loaddefs cl-lib mule-util china-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 1088997 459602) (symbols 48 66787 141) (miscs 40 1354 3276) (strings 32 291164 33158) (string-bytes 1 14013832) (vectors 16 101437) (vector-slots 8 2423876 103126) (floats 8 953 3028) (intervals 56 39806 7836) (buffers 992 89)) -- Amos Bird amosbird@gmail.com From unknown Sat Aug 16 11:40:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30624: 27.0.50; dired-create-destination-dirs doesn't work when renaming more than one file Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Mar 2018 09:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30624 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Amos Bird , Tino Calancha Cc: 30624@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 30624-submit@debbugs.gnu.org id=B30624.15214529227568 (code B ref 30624); Mon, 19 Mar 2018 09:49:01 +0000 Received: (at 30624) by debbugs.gnu.org; 19 Mar 2018 09:48:42 +0000 Received: from localhost ([127.0.0.1]:40772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exrPG-0001y0-Gr for submit@debbugs.gnu.org; Mon, 19 Mar 2018 05:48:42 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44675) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exrPE-0001xk-6x for 30624@debbugs.gnu.org; Mon, 19 Mar 2018 05:48:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1exrP5-0008Tl-T4 for 30624@debbugs.gnu.org; Mon, 19 Mar 2018 05:48:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52200) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1exrP5-0008Tg-Po; Mon, 19 Mar 2018 05:48:31 -0400 Received: from [176.228.60.248] (port=2614 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1exrP5-0002L1-7P; Mon, 19 Mar 2018 05:48:31 -0400 Date: Mon, 19 Mar 2018 11:48:39 +0200 Message-Id: <83in9so0p4.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87muzv413e.fsf@gmail.com> (message from Amos Bird on Tue, 27 Feb 2018 10:29:09 +0800) References: <87muzv413e.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Amos Bird > Date: Tue, 27 Feb 2018 10:29:09 +0800 > > I'm using emacs 27.0.50 and have dired-create-destination-dirs set > to 'always. > When renaming more than one files to a new directory, dired throws > an error at > /usr/local/share/emacs/27.0.50/lisp/dired-aux.el.gz:1891 . It > fails early before > it has time to check whether a new directory should be created. Sorry for the long delay in handling your report. Tino, could you please look into fixing this? It looks like your change that introduced dired-create-destination-dirs didn't support the use case where several files are marked to be moved to a single non-existent directory. From unknown Sat Aug 16 11:40:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30624: 27.0.50; dired-create-destination-dirs doesn't work when renaming more than one file Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Apr 2018 09:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30624 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: tino.calancha@gmail.com Cc: 30624@debbugs.gnu.org, amosbird@gmail.com Reply-To: Eli Zaretskii Received: via spool by 30624-submit@debbugs.gnu.org id=B30624.152257634924229 (code B ref 30624); Sun, 01 Apr 2018 09:53:01 +0000 Received: (at 30624) by debbugs.gnu.org; 1 Apr 2018 09:52:29 +0000 Received: from localhost ([127.0.0.1]:33493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f2Zf3-0006Ij-Kq for submit@debbugs.gnu.org; Sun, 01 Apr 2018 05:52:29 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51857) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f2Zf1-0006IX-SJ for 30624@debbugs.gnu.org; Sun, 01 Apr 2018 05:52:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f2Zew-0003BO-3y for 30624@debbugs.gnu.org; Sun, 01 Apr 2018 05:52:22 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42421) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f2Zev-0003BI-W7; Sun, 01 Apr 2018 05:52:22 -0400 Received: from [176.228.60.248] (port=4879 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1f2Zev-0003j0-5Z; Sun, 01 Apr 2018 05:52:21 -0400 Date: Sun, 01 Apr 2018 12:52:24 +0300 Message-Id: <83in9b6yp3.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <83in9so0p4.fsf@gnu.org> (message from Eli Zaretskii on Mon, 19 Mar 2018 11:48:39 +0200) References: <87muzv413e.fsf@gmail.com> <83in9so0p4.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Ping! > Date: Mon, 19 Mar 2018 11:48:39 +0200 > From: Eli Zaretskii > Cc: 30624@debbugs.gnu.org > > > From: Amos Bird > > Date: Tue, 27 Feb 2018 10:29:09 +0800 > > > > I'm using emacs 27.0.50 and have dired-create-destination-dirs set > > to 'always. > > When renaming more than one files to a new directory, dired throws > > an error at > > /usr/local/share/emacs/27.0.50/lisp/dired-aux.el.gz:1891 . It > > fails early before > > it has time to check whether a new directory should be created. > > Sorry for the long delay in handling your report. > > Tino, could you please look into fixing this? It looks like your > change that introduced dired-create-destination-dirs didn't support > the use case where several files are marked to be moved to a single > non-existent directory. From unknown Sat Aug 16 11:40:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30624: 27.0.50; dired-create-destination-dirs doesn't work when renaming more than one file Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Apr 2018 11:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30624 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 30624@debbugs.gnu.org, Amos Bird , Tino Calancha Received: via spool by 30624-submit@debbugs.gnu.org id=B30624.152258089931223 (code B ref 30624); Sun, 01 Apr 2018 11:09:02 +0000 Received: (at 30624) by debbugs.gnu.org; 1 Apr 2018 11:08:19 +0000 Received: from localhost ([127.0.0.1]:33528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f2aqQ-00087X-Og for submit@debbugs.gnu.org; Sun, 01 Apr 2018 07:08:18 -0400 Received: from mail-pg0-f52.google.com ([74.125.83.52]:46147) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f2aqP-00087K-Iw for 30624@debbugs.gnu.org; Sun, 01 Apr 2018 07:08:17 -0400 Received: by mail-pg0-f52.google.com with SMTP id t12so7406405pgp.13 for <30624@debbugs.gnu.org>; Sun, 01 Apr 2018 04:08:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=fSim63etigp2Tg7HNOFmddHKSnYMGzFNxbWQwPDouGs=; b=OUcZlyU2SrRNJ6vLCdE/qkiRgn6sOZkJID5VtBq22iJXFXu+JZjNtZmVAxhnXE/CyM X5JvdczQwZRjgaL3dZ5gKl6dY6uOfqLQU9u1Bta9TJ+KHmADL2JwYgvw6wxczsKW2D6f IQyvEYMH42WSydhf2AWWIlbQD7d5Ebe+Ztmh2XmcqC0P2dOjjiYmxeEDmrNW0uxHw71R Sjp5dtqtq0HNYUCUSTEB9A6+vQbCCpOop4nJT4QxLykVchWq0mpLPb26TUh5LjfF4Hfk RhTEYJZW/jqUrTfqDS7OzHrVyGQx3P2dRt/Gg1J+KjCXqCDm9v1L17ors/3khfuNiRuA 382Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=fSim63etigp2Tg7HNOFmddHKSnYMGzFNxbWQwPDouGs=; b=PS42ZdmknHThzpdN2MQ4K752+RT04zE3fdA4jVt1uq82mqR7UImLTDuPKRMwQjZMRL PIFUBIqdt6gBwtiWEXGQ2+rY+OXkeM1fsVtQZkXRb49zrW2yqiVAZfbNENRcPJPgsTLo mjX5yOo0XzVRp9z+JTk57wEWy5i8iwIAR16nKOo8pdP/0Llj/376pzTdaeOjnBgLq5Fu jOPGB5hp7Uk1fl5rNq8aNjPxs03nr1GvzGsH//z8zndwrAtciVocFgFDbkfvJRdiDgNu F6L6v5OKUEQKApIuxhIgTNP3UrqKyPq0A0Mo152JwnoA8FnFBKBghargVmOY9OS5CNct C3kQ== X-Gm-Message-State: AElRT7EqOmG1jVOBEee4CD+8/RwKgRpLCbhWdiBL3rzsqZNbQsW1sKTM P941uEuCwrhtC1PxxZYf/nk= X-Google-Smtp-Source: AIpwx4+Qn23JCy39dTtyRKCKVQsSvAGzHcffLV4GSkySEB933jFCYW76A/0DpzxsTM5uy6SnGujzVQ== X-Received: by 10.99.182.6 with SMTP id j6mr3747966pgf.122.1522580891795; Sun, 01 Apr 2018 04:08:11 -0700 (PDT) Received: from calancha-pc ([240f:6e:ee9a:1:adc4:139f:709c:10b]) by smtp.gmail.com with ESMTPSA id q15sm19644818pgv.49.2018.04.01.04.08.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Apr 2018 04:08:10 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Sun, 1 Apr 2018 20:08:07 +0900 (JST) X-X-Sender: calancha@calancha-pc In-Reply-To: <83in9so0p4.fsf@gnu.org> Message-ID: References: <87muzv413e.fsf@gmail.com> <83in9so0p4.fsf@gnu.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Mon, 19 Mar 2018, Eli Zaretskii wrote: >> From: Amos Bird >> Date: Tue, 27 Feb 2018 10:29:09 +0800 >> >> I'm using emacs 27.0.50 and have dired-create-destination-dirs set >> to 'always. >> When renaming more than one files to a new directory, dired throws >> an error at >> /usr/local/share/emacs/27.0.50/lisp/dired-aux.el.gz:1891 . It >> fails early before >> it has time to check whether a new directory should be created. Thank you very much for your report Amos! I would be enough to call `dired-maybe-create-dirs' right before binding `into-dir', as follows: --8<-----------------------------cut here---------------start------------->8--- commit a89518cfb2f57509d3f0e31ddfe097f56e95c484 Author: Tino Calancha Date: Sun Apr 1 19:54:23 2018 +0900 Honor dired-create-destination-dirs if copying/renaming >1 files Check `dired-create-destination-dirs' when the user wants to copy/rename several files. * lisp/dired-aux.el (dired-do-create-files): Call `dired-maybe-create-dirs' right before bind `into-dir' (Bug#30624). diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el index e8b5e6755e..821b7d7975 100644 --- a/lisp/dired-aux.el +++ b/lisp/dired-aux.el @@ -1864,29 +1864,31 @@ dired-do-create-files (dired-mark-read-file-name (concat (if dired-one-file op1 operation) " %s to: ") target-dir op-symbol arg rfn-list default)))) - (into-dir (cond ((null how-to) - ;; Allow users to change the letter case of - ;; a directory on a case-insensitive - ;; filesystem. If we don't test these - ;; conditions up front, file-directory-p - ;; below will return t on a case-insensitive - ;; filesystem, and Emacs will try to move - ;; foo -> foo/foo, which fails. - (if (and (file-name-case-insensitive-p (car fn-list)) - (eq op-symbol 'move) - dired-one-file - (string= (downcase - (expand-file-name (car fn-list))) - (downcase - (expand-file-name target))) - (not (string= - (file-name-nondirectory (car fn-list)) - (file-name-nondirectory target)))) - nil - (file-directory-p target))) - ((eq how-to t) nil) - (t (funcall how-to target))))) + (into-dir + (progn + (unless dired-one-file (dired-maybe-create-dirs target)) + (cond ((null how-to) + ;; Allow users to change the letter case of + ;; a directory on a case-insensitive + ;; filesystem. If we don't test these + ;; conditions up front, file-directory-p + ;; below will return t on a case-insensitive + ;; filesystem, and Emacs will try to move + ;; foo -> foo/foo, which fails. + (if (and (file-name-case-insensitive-p (car fn-list)) + (eq op-symbol 'move) + dired-one-file + (string= (downcase + (expand-file-name (car fn-list))) + (downcase + (expand-file-name target))) + (not (string= + (file-name-nondirectory (car fn-list)) + (file-name-nondirectory target)))) + nil + (file-directory-p target))) + ((eq how-to t) nil) + (t (funcall how-to target)))))) (if (and (consp into-dir) (functionp (car into-dir))) (apply (car into-dir) operation rfn-list fn-list target (cdr into-dir)) (if (not (or dired-one-file into-dir)) --8<-----------------------------cut here---------------end--------------->8--- In GNU Emacs 27.0.50 (build 10, x86_64-pc-linux-gnu, GTK+ Version 3.22.11) of 2018-03-30 built on calancha-pc Repository revision: f759c5cfe4651af5f64fac2492fa362f8d383bd5 From unknown Sat Aug 16 11:40:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30624: 27.0.50; dired-create-destination-dirs doesn't work when renaming more than one file Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Apr 2018 02:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30624 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: Amos Bird , 30624@debbugs.gnu.org Received: via spool by 30624-submit@debbugs.gnu.org id=B30624.152263791924490 (code B ref 30624); Mon, 02 Apr 2018 02:59:01 +0000 Received: (at 30624) by debbugs.gnu.org; 2 Apr 2018 02:58:39 +0000 Received: from localhost ([127.0.0.1]:34578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f2pg7-0006Mv-4v for submit@debbugs.gnu.org; Sun, 01 Apr 2018 22:58:39 -0400 Received: from mail-pf0-f176.google.com ([209.85.192.176]:38591) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f2pg5-0006Mi-JP for 30624@debbugs.gnu.org; Sun, 01 Apr 2018 22:58:38 -0400 Received: by mail-pf0-f176.google.com with SMTP id y69so8617818pfb.5 for <30624@debbugs.gnu.org>; Sun, 01 Apr 2018 19:58:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=lNaWXpM4B8+MihLd5kg+/kxoTiwJFag9IV348YkItl4=; b=J5rS9u6sQyuULkMgrwMkSiMvuhRb9esACoroulvYsYnaWgPjN5LdxHr3FmExjyfKR/ 7+Iwlb+I85kYSjLjw14z+IhBpA52D3AH4dILEk6LUPiX9CvwgyuMdIScdDboNJuBQ0yf zXqRFgd+s5wsxqYRFRGCgrxyypJWEK4K1gcakBDX90E1WMx+r7x3NeUQZoHLkzQcnEIm K/lZsc4Stxmg9M7wJIsSh1tCCfxDXRcSqzFZcqckcnvGpXLTvMqq+jp0WbQ7eThLSZ0z ciQ5L95dlnMtckskiPW4O2Me+tsXP1ZALRTda4d8CXSD30YAmp8PIMAKKu4PjoQnyPoy 5syw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=lNaWXpM4B8+MihLd5kg+/kxoTiwJFag9IV348YkItl4=; b=ndT4pJtBpmvu8GT7Wytvs4Din5grXCebr3PkbG4V2fBAPZRUlh8+yUWOKmqh55PIhB /UtyeTqaay3dWSu0fPUimgrH1FjMfpT29XITRuGBdbgOFdU//AuJG8ZfDW3NVaNH+gic A4bW5tVExPAx3WiQOl0qX9kvkxAHtbiGHyeGLq7l45T6of0rYwdluW2CeM4RfqbCRUJh 1ETvgvKAkf8uWrZGj8JLLcc1S9dvMeAx0ChcpoUEh/Yv9jnvkQCDZ4eDg+AQj2yYf/XU +xjrgdsZsZaihD7OMA93LSYT6b4O9CUiRQ83pI5KRFMBktCh7E2KsFx5gJCcjIenzBym jXVg== X-Gm-Message-State: AElRT7EoY28tBAZ7KG0i8bmx+iIVOR0Auu766IgToQWLqoOLuJpOnFZq XMnmJxoz+g/Fs1VLZUHehQo= X-Google-Smtp-Source: AIpwx4/Zvo+w+HCGJ+Qm+Va3X+Sm2KJfh9z98hPMDbBLiujvxPz2yQlE0sfnvkMbU6Un1YjRSPfVbA== X-Received: by 10.101.89.6 with SMTP id f6mr5090378pgu.178.1522637911601; Sun, 01 Apr 2018 19:58:31 -0700 (PDT) Received: from calancha-pc ([210.160.37.26]) by smtp.gmail.com with ESMTPSA id p89sm28626414pfk.63.2018.04.01.19.58.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 01 Apr 2018 19:58:30 -0700 (PDT) From: Tino Calancha References: <87muzv413e.fsf@gmail.com> <83in9so0p4.fsf@gnu.org> Date: Mon, 02 Apr 2018 11:58:22 +0900 In-Reply-To: (Tino Calancha's message of "Sun, 1 Apr 2018 20:08:07 +0900 (JST)") Message-ID: <87woxqxqk1.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Tino Calancha writes: > I would be enough to call `dired-maybe-create-dirs' right before > binding `into-dir', as follows: Added a test for this bug (dired-test-bug30624): --8<-----------------------------cut here---------------start------------->8--- commit f7560f9bbbb2470378a1b31b52f6c3ff4cd6a7d7 Author: Tino Calancha Date: Mon Apr 2 11:54:58 2018 +0900 Honor dired-create-destination-dirs if copying/renaming >1 files Check `dired-create-destination-dirs' when the user wants to copy/rename several files. * lisp/dired-aux.el (dired-do-create-files): Call `dired-maybe-create-dirs' right before bind `into-dir' (Bug#30624). * test/lisp/dired-aux-tests.el (dired-test-bug30624): Add test. diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el index e8b5e6755e..821b7d7975 100644 --- a/lisp/dired-aux.el +++ b/lisp/dired-aux.el @@ -1864,28 +1864,31 @@ dired-do-create-files (dired-mark-read-file-name (concat (if dired-one-file op1 operation) " %s to: ") target-dir op-symbol arg rfn-list default)))) - (into-dir (cond ((null how-to) - ;; Allow users to change the letter case of - ;; a directory on a case-insensitive - ;; filesystem. If we don't test these - ;; conditions up front, file-directory-p - ;; below will return t on a case-insensitive - ;; filesystem, and Emacs will try to move - ;; foo -> foo/foo, which fails. - (if (and (file-name-case-insensitive-p (car fn-list)) - (eq op-symbol 'move) - dired-one-file - (string= (downcase - (expand-file-name (car fn-list))) - (downcase - (expand-file-name target))) - (not (string= - (file-name-nondirectory (car fn-list)) - (file-name-nondirectory target)))) - nil - (file-directory-p target))) - ((eq how-to t) nil) - (t (funcall how-to target))))) + (into-dir + (progn + (unless dired-one-file (dired-maybe-create-dirs target)) + (cond ((null how-to) + ;; Allow users to change the letter case of + ;; a directory on a case-insensitive + ;; filesystem. If we don't test these + ;; conditions up front, file-directory-p + ;; below will return t on a case-insensitive + ;; filesystem, and Emacs will try to move + ;; foo -> foo/foo, which fails. + (if (and (file-name-case-insensitive-p (car fn-list)) + (eq op-symbol 'move) + dired-one-file + (string= (downcase + (expand-file-name (car fn-list))) + (downcase + (expand-file-name target))) + (not (string= + (file-name-nondirectory (car fn-list)) + (file-name-nondirectory target)))) + nil + (file-directory-p target))) + ((eq how-to t) nil) + (t (funcall how-to target)))))) (if (and (consp into-dir) (functionp (car into-dir))) (apply (car into-dir) operation rfn-list fn-list target (cdr into-dir)) (if (not (or dired-one-file into-dir)) diff --git a/test/lisp/dired-aux-tests.el b/test/lisp/dired-aux-tests.el index ab6d1cb056..daf60f760e 100644 --- a/test/lisp/dired-aux-tests.el +++ b/test/lisp/dired-aux-tests.el @@ -93,6 +93,27 @@ with-dired-bug28834-test (should-error (dired-copy-file-recursive from to-cp nil)) (should-error (dired-rename-file from to-mv nil))))) +(ert-deftest dired-test-bug30624 () + "test for https://debbugs.gnu.org/30624 ." + (cl-letf* ((target-dir (make-temp-file "target" 'dir)) + ((symbol-function 'dired-mark-read-file-name) + (lambda (&rest _) target-dir)) + (inhibit-message t)) + ;; Delete target-dir: `dired-do-create-files' must recreate it. + (delete-directory target-dir) + (let ((file1 (make-temp-file "bug30624_file1")) + (file2 (make-temp-file "bug30624_file2")) + (dired-create-destination-dirs 'always) + (buf (dired temporary-file-directory))) + (unwind-protect + (progn + (dired-revert) + (dired-mark-files-regexp "bug30624_file") + (should (dired-do-create-files 'copy 'dired-copy-file "Copy" nil))) + (delete-directory target-dir 'recursive) + (mapc #'delete-file `(,file1 ,file2)) + (kill-buffer buf))))) + (provide 'dired-aux-tests) ;; dired-aux-tests.el ends here --8<-----------------------------cut here---------------end--------------->8--- In GNU Emacs 27.0.50 (build 10, x86_64-pc-linux-gnu, GTK+ Version 3.22.11) of 2018-04-02 built on calancha-pc Repository revision: 7bedc8812bd7ca1d9cf36636322068b28b690a85 From unknown Sat Aug 16 11:40:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30624: 27.0.50; dired-create-destination-dirs doesn't work when renaming more than one file Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Apr 2018 06:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30624 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Tino Calancha Cc: amosbird@gmail.com, 30624@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 30624-submit@debbugs.gnu.org id=B30624.15226496809711 (code B ref 30624); Mon, 02 Apr 2018 06:15:01 +0000 Received: (at 30624) by debbugs.gnu.org; 2 Apr 2018 06:14:40 +0000 Received: from localhost ([127.0.0.1]:34642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f2sjo-0002WZ-70 for submit@debbugs.gnu.org; Mon, 02 Apr 2018 02:14:40 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49718) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f2sjm-0002WN-Cp for 30624@debbugs.gnu.org; Mon, 02 Apr 2018 02:14:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f2sjg-0004HM-6N for 30624@debbugs.gnu.org; Mon, 02 Apr 2018 02:14:33 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34793) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f2sjc-0004Be-FL; Mon, 02 Apr 2018 02:14:28 -0400 Received: from [176.228.60.248] (port=3133 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1f2sjb-0004q8-PE; Mon, 02 Apr 2018 02:14:28 -0400 Date: Mon, 02 Apr 2018 09:14:32 +0300 Message-Id: <834lku6son.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87woxqxqk1.fsf@gmail.com> (message from Tino Calancha on Mon, 02 Apr 2018 11:58:22 +0900) References: <87muzv413e.fsf@gmail.com> <83in9so0p4.fsf@gnu.org> <87woxqxqk1.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Tino Calancha > Cc: 30624@debbugs.gnu.org, Amos Bird > Date: Mon, 02 Apr 2018 11:58:22 +0900 > > Tino Calancha writes: > > > I would be enough to call `dired-maybe-create-dirs' right before > > binding `into-dir', as follows: > > Added a test for this bug (dired-test-bug30624): Thanks, Tino. Please wait a few days, and if there are no comments, please push to master. From unknown Sat Aug 16 11:40:40 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Amos Bird Subject: bug#30624: closed (Re: bug#30624: 27.0.50; dired-create-destination-dirs doesn't work when renaming more than one file) Message-ID: References: <87d0zeuykz.fsf@gmail.com> <87muzv413e.fsf@gmail.com> X-Gnu-PR-Message: they-closed 30624 X-Gnu-PR-Package: emacs Reply-To: 30624@debbugs.gnu.org Date: Thu, 05 Apr 2018 03:23:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1522898582-12645-1" This is a multi-part message in MIME format... ------------=_1522898582-12645-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #30624: 27.0.50; dired-create-destination-dirs doesn't work when renaming m= ore than one file which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 30624@debbugs.gnu.org. --=20 30624: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D30624 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1522898582-12645-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 30624-done) by debbugs.gnu.org; 5 Apr 2018 03:22:34 +0000 Received: from localhost ([127.0.0.1]:38835 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f3vTu-0003H4-Jk for submit@debbugs.gnu.org; Wed, 04 Apr 2018 23:22:34 -0400 Received: from mail-pl0-f51.google.com ([209.85.160.51]:41754) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f3vTt-0003Gr-K9 for 30624-done@debbugs.gnu.org; Wed, 04 Apr 2018 23:22:33 -0400 Received: by mail-pl0-f51.google.com with SMTP id bj1-v6so14786649plb.8 for <30624-done@debbugs.gnu.org>; Wed, 04 Apr 2018 20:22:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=bcWci1QQ4k8qT1jeFb5bRQDb1dSN+idPhIENA2yzMk8=; b=ef0sNGamHyBCSTvp4Ttt2OnnWOvCJht6uF4VoP9h7pOpfV0/EsuvXfmhohEWFLzrX8 23d+9E2nYx0+wTG/x96xes90Y7qfTZ1euuJi7MEaO9QIqXTGUtDpSHmpJtNY/LlDVYYc AlGSEsZBonjiN7dHNJ4paJSPRUXvkFAujN1RjUBwhzYbBbk8ITg6OsYiQd1NxpYxSmcp H1URuDDCM4lrWA09GqBktmp+2sKf1rNHPqblEOZjjeDxUHRYM+8EyVk9DnhZyFMBdDHr SUlRlgcyeQ9Li6+Ij9uT7GSyIODYaVyNBg9pXjkFyTsC2t0Z1oyTHsgmdVBzwWTHOriW mtSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=bcWci1QQ4k8qT1jeFb5bRQDb1dSN+idPhIENA2yzMk8=; b=cM7h2CLIv+ol04pcEFrDKYyRfv27AIvZMEdMIWdyIUEGVPwvxVJdz3OlA0L5+QqDA4 qZYZKhDIydxzbNUwwun1FnYp/jIcmv9CcE/W/FAICt73nS5qOoRTVhwq8BetdmubcwSp gOK0M4sGumgp+GuGyjECI2VRSnWkXeQyL6MJ7SqypyLOGY23LJYghVMnIFTDqrKTJo6K 9KnGwP2YRglCZ8nF++/ezjS23QHaIQJF+UWZn2o6NHy6UDj+o1PjlsdGnlfqQsqI/Ymw +CrWcuAYoshgnix2tDUzG3gzX7USHENtnBC6WflR534CkRAmGAN1YVsJqNtmQ48zOQBg v0oA== X-Gm-Message-State: AElRT7FSqCDYgTIt4FWjtqK39n69Bs4BjxtcT2fdardj0EOcK/lxYMyR LPGM2AZ2vvFsgB8Y1UEUBac8HmL2 X-Google-Smtp-Source: AIpwx4+B2578dDhXCGPZcGGhF4+7rKpCLJpEmN13pb2Lscn5dBLBnceDtc2FkxIk2Wc0J+SYQ5AiGg== X-Received: by 2002:a17:902:b08a:: with SMTP id p10-v6mr21302964plr.60.1522898547485; Wed, 04 Apr 2018 20:22:27 -0700 (PDT) Received: from calancha-pc (121.7.236.133.dy.bbexcite.jp. [133.236.7.121]) by smtp.gmail.com with ESMTPSA id 6sm10517408pgf.9.2018.04.04.20.22.25 for <30624-done@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 04 Apr 2018 20:22:26 -0700 (PDT) From: Tino Calancha To: 30624-done@debbugs.gnu.org Subject: Re: bug#30624: 27.0.50; dired-create-destination-dirs doesn't work when renaming more than one file References: <87muzv413e.fsf@gmail.com> <83in9so0p4.fsf@gnu.org> <87woxqxqk1.fsf@gmail.com> <834lku6son.fsf@gnu.org> Date: Thu, 05 Apr 2018 12:22:20 +0900 In-Reply-To: <834lku6son.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 02 Apr 2018 09:14:32 +0300") Message-ID: <87d0zeuykz.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30624-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Eli Zaretskii writes: > Please wait a few days, and if there are no comments, > please push to master. Pushed fix into master branch as commit "Honor dired-create-destination-dirs if copying/renaming >1 files" (0b690a83f674a160ccbaa9f374226b1fcfb2d535) ------------=_1522898582-12645-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 27 Feb 2018 02:29:33 +0000 Received: from localhost ([127.0.0.1]:34193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqV1J-0007a7-Ar for submit@debbugs.gnu.org; Mon, 26 Feb 2018 21:29:33 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57743) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqV1H-0007Zu-82 for submit@debbugs.gnu.org; Mon, 26 Feb 2018 21:29:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqV19-0000w7-SR for submit@debbugs.gnu.org; Mon, 26 Feb 2018 21:29:25 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:52520) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eqV19-0000w0-Oe for submit@debbugs.gnu.org; Mon, 26 Feb 2018 21:29:23 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48683) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqV17-0001mu-SR for bug-gnu-emacs@gnu.org; Mon, 26 Feb 2018 21:29:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqV12-0000pl-4n for bug-gnu-emacs@gnu.org; Mon, 26 Feb 2018 21:29:21 -0500 Received: from mail-pf0-x230.google.com ([2607:f8b0:400e:c00::230]:33112) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eqV11-0000pb-SO for bug-gnu-emacs@gnu.org; Mon, 26 Feb 2018 21:29:16 -0500 Received: by mail-pf0-x230.google.com with SMTP id q13so7363419pff.0 for ; Mon, 26 Feb 2018 18:29:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:subject:date:message-id:mime-version; bh=+GEdLSUyyARWDxXT/3L/TLE9E9PpEtk+Xp+Ri6pY4v0=; b=iIgu2SJvcj3omJuPq1vRxthZC5FzgybYfWXMb/1g5fKpGKyZPzC8CEykujIqKnd6Of CgFXmUIbTwadCBwdldggZW3xY+BwMWuNUlv62GF1hIpVh9vz+Jf/1qZslv+cIcxIKljw Kq4aON9GMSafGswdmYoblgX1IwMAlgS/Zbf/KvBASHDdG2rKVcwDy8sCDWMtTSGS0Nj0 bMZ+0xa/13nzfZRuyRomEHfO57lNYlFhtYo7/Q3K3GYRB05jh2vt7d20+4ecXRbLXqzs eVP3HtL7IKPwAj7M0U8NvLfLkUycIEHiYO0WWgHYTHkMcOfaHxgm6iVhvgwKXxn7KufV 3myQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version; bh=+GEdLSUyyARWDxXT/3L/TLE9E9PpEtk+Xp+Ri6pY4v0=; b=VJFfOQZ9xsmnoF0k6Gpyu8gTHtEwZqiv8jJwENhDm38qT2la5mTS5PiMMf6wAdR93e qnAZtuvTD11wXH0n7RS95NbKL1sT4B3e/5cc/XkdaKkNoOiY84E+gZqBGNElxmCYQQUC /SVDYBIgbA4OU12cJlr6BdWHQ6NRMbobPOSBu7VkVPsv+y7atbzVQjML0UIwIQgA1JDX ntHqoCJHIe40BE21wmRff6l86k0b83kaNKGiriHjB0lO2kPOjgoeTQMwN1fNVBEGaAff 0iCzVn4nSWdB6LPqLgiDygn9z25iL+7FQoqbv+QgDBX0yaE0YjAnZQzVLKsW3Hhjg121 G+bA== X-Gm-Message-State: APf1xPAwAKqe9TCtBI0ZIBWD6qty6D91zyyLQoeDzKDWmdNPrHNhytMe ZCQ5ATJrtunky773mS4B0qNnag== X-Google-Smtp-Source: AH8x224bd8+HxY/QjuYHsLNRtp+II7z+c9Gwqqy5xk5tRhAVFttDNEoAKnwxL9TDiZmuwdALRZQmpQ== X-Received: by 10.99.110.199 with SMTP id j190mr10042582pgc.404.1519698554256; Mon, 26 Feb 2018 18:29:14 -0800 (PST) Received: from localhost ([168.235.77.108]) by smtp.gmail.com with ESMTPSA id 186sm18605822pfe.2.2018.02.26.18.29.12 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Feb 2018 18:29:13 -0800 (PST) User-agent: mu4e 1.0-alpha3; emacs 27.0.50 From: Amos Bird To: bug-gnu-emacs@gnu.org Subject: 27.0.50; dired-create-destination-dirs doesn't work when renaming more than one file Date: Tue, 27 Feb 2018 10:29:09 +0800 Message-ID: <87muzv413e.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Hi, I'm using emacs 27.0.50 and have dired-create-destination-dirs set to 'always. When renaming more than one files to a new directory, dired throws an error at /usr/local/share/emacs/27.0.50/lisp/dired-aux.el.gz:1891 . It fails early before it has time to check whether a new directory should be created. regards, In GNU Emacs 27.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.22.27) of 2018-02-14 built on t450s Repository revision: 298275c595f6ca9e77f8131d34dda2b58fe1faa5 Windowing system distributor 'The X.Org Foundation', version 11.0.11906000 System Description: Arch Linux Recent messages: Checking 4 files in /home/amos/.emacs.d/.local/packages/elpa/vimish-fold-20171231.2212... Checking 4 files in /home/amos/.emacs.d/.local/packages/elpa/yapfify-20180105.1447... Checking 4 files in /home/amos/.emacs.d/.local/packages/elpa/fcitx-20170913.1900... Checking 20 files in /home/amos/.emacs.d/.local/packages/elpa/multiple-cursors-20170908.1452... Checking 4 files in /home/amos/.emacs.d/.local/packages/elpa/opencl-mode-20170816.549... Checking for load-path shadows...done Error during redisplay: (eval (doom-modeline-format--main)) signaled (wrong-type-argument stringp nil) [4 times] Auto-saving... Error during redisplay: (eval (doom-modeline-format--main)) signaled (wrong-type-argument stringp nil) [2 times] Buffer *unsent mail to bug-gnu-emacs* modified; kill anyway? (y or n) y dired-do-create-files: Marked Move: target must be a directory: /home/amos/git/ccutils/ffffff/ Configured features: XPM JPEG TIFF GIF PNG RSVG SOUND GPM DBUS GSETTINGS NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 THREADS LIBSYSTEMD JSON LCMS2 Important settings: value of $LC_CTYPE: zh_CN.UTF-8 value of $LANG: C value of $XMODIFIERS: @im=fcitx locale-coding-system: utf-8 Major mode: Dired by name Minor modes in effect: company-quickhelp-mode: t company-quickhelp-local-mode: t company-statistics-mode: t global-company-mode: t company-mode: t TeX-PDF-mode: t auto-compile-on-save-mode: t global-git-commit-mode: t async-bytecomp-package-mode: t diff-auto-refine-mode: t winner-mode: t show-paren-mode: t evil-escape-mode: t evil-snipe-override-mode: t evil-snipe-mode: t evil-snipe-override-local-mode: t evil-snipe-local-mode: t realign-mode: t save-place-mode: t recentf-mode: t smartparens-global-mode: t evilified-leader-override-mode: t global-evilified-leader-override-mode: t auto-insert-mode: t global-page-break-lines-mode: t global-hl-line-mode: t dired-omit-mode: t savehist-mode: t ws-butler-global-mode: t ws-butler-mode: t xterm-mouse-mode: t global-git-gutter-mode: t global-narrow-reindent-mode: t narrow-reindent-mode: t eldoc-in-minibuffer-mode: t projectile-mode: t ivy-mode: t persp-mode: t shell-dirtrack-mode: t evil-mode: t evil-local-mode: t which-key-mode: t global-undo-tree-mode: t editorconfig-mode: t global-auto-revert-mode: t override-global-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t window-divider-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (pp shadow mail-extr emacsbug sendmail cc-playground time-stamp modern-cpp-font-lock url-http url-gw gravatar url-cache bug-reference texmathp unfill preview prv-emacs tex-buf company-auctex company-lua company-lsp company-quickhelp company-statistics company-yasnippet company-ispell company-dabbrev company-capf company reftex-dcr reftex-auc reftex reftex-loaddefs reftex-vars font-latex smartparens-latex latex tex-ispell tex-style tex latexenc view dired-aux sort tramp trampver tramp-compat tramp-loaddefs ucs-normalize parse-time auto-compile packed rainbow-delimiters highlight-quoted highlight-numbers parent-mode ace-link avy disp-table eieio-opt speedbar sb-image ezimage dframe help-fns radix-tree magit-svn evil-magit magit-obsolete magit-blame magit-stash magit-bisect magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-collab ghub url-auth url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf mailcap magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log magit-diff smerge-mode magit-core magit-autorevert magit-process magit-margin magit-mode git-commit magit-git magit-section magit-utils crm magit-popup log-edit message format-spec rfc822 mml mml-sec epa epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log with-editor async-bytecomp smex ido shrink-path vc-git diff-mode yasnippet elec-pair hl-todo smartparens-lua lua-mode editorconfig-core editorconfig-core-handle editorconfig-fnmatch colir all-the-icons all-the-icons-faces data-material data-weathericons data-octicons data-fileicons data-faicons data-alltheicons memoize persistent-soft list-utils pcache eieio-base font-utils evil-vimish-fold vimish-fold f winner paren doom-themes-org doom-themes-neotree doom-one-theme evil-escape evil-snipe nav-flash pulse warnings realign-mode face-remap saveplace recentf tree-widget wid-edit smartparens-config smartparens-text smartparens-markdown smartparens solaire-mode cquery cquery-tree cquery-codelens cquery-semantic-highlighting cquery-common cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs lsp-ui lsp-ui-doc markdown-mode noutline outline lsp-ui-imenu lsp-ui-flycheck lsp-ui-peek lsp-ui-sideline lsp-imenu imenu lsp-mode network-stream puny nsm rmc starttls tls gnutls lsp-methods inline lsp-io lsp-notifications lsp-common url-util kurecolor rainbow-mode color dired-ranger bind-map autoinsert page-break-lines helm-make helm helm-source eieio-compat helm-multi-match helm-lib async ag vc-svn find-dired s hl-line+ hl-line ivy-rich dired-open dired-hacks-utils dired-x dired-quick-sort savehist ls-lisp ws-butler xt-mouse evil-terminal-cursor-changer evil-textobj-line git-gutter fcitx dbus xml narrow-reindent osc browse-url perl6-detect flycheck-ledger fringe-helper flycheck-pos-tip pos-tip flycheck find-func dash tex-site unicode-fonts let-alist evil-anzu anzu eldoc-eval derived doom-themes doom-themes-common counsel-projectile projectile grep ibuf-ext ibuffer ibuffer-loaddefs counsel dired dired-loaddefs compile esh-util etags ivy-xref xref project swiper ivy delsel ivy-overlay ffap persp-mode cl time-date evil evil-integration evil-maps evil-commands reveal flyspell ispell evil-jumps evil-command-window evil-types evil-search evil-ex shell pcomplete comint ansi-color evil-macros evil-repeat evil-states evil-core evil-common windmove thingatpt rect evil-digraphs evil-vars server core core-keybinds hydra ring lv which-key advice core-projects core-editor undo-tree diff editorconfig rx autorevert filenotify core-popups edmacro kmacro shackle trace core-ui cl-extra help-mode use-package use-package-ensure use-package-delight use-package-diminish use-package-bind-key bind-key use-package-core easy-mmode autoloads core-os core-lib pcase subr-x finder-inf package easymenu url-handlers url-parse auth-source cl-seq eieio eieio-core eieio-loaddefs password-cache json map url-vars seq byte-opt bytecomp byte-compile cconv core-packages cl-macs gv cl-loaddefs cl-lib mule-util china-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 1088997 459602) (symbols 48 66787 141) (miscs 40 1354 3276) (strings 32 291164 33158) (string-bytes 1 14013832) (vectors 16 101437) (vector-slots 8 2423876 103126) (floats 8 953 3028) (intervals 56 39806 7836) (buffers 992 89)) -- Amos Bird amosbird@gmail.com ------------=_1522898582-12645-1--