From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 25 18:25:36 2018 Received: (at submit) by debbugs.gnu.org; 25 Feb 2018 23:25:36 +0000 Received: from localhost ([127.0.0.1]:60723 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eq5fk-0006gw-85 for submit@debbugs.gnu.org; Sun, 25 Feb 2018 18:25:36 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54351) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eq2P4-0008VU-Hw for submit@debbugs.gnu.org; Sun, 25 Feb 2018 14:56:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eq2Oy-0004Ym-Gv for submit@debbugs.gnu.org; Sun, 25 Feb 2018 14:56:05 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:59544) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eq2Oy-0004Yg-CP for submit@debbugs.gnu.org; Sun, 25 Feb 2018 14:56:04 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45313) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eq2Ox-0005E9-8t for bug-gnu-emacs@gnu.org; Sun, 25 Feb 2018 14:56:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eq2Ou-0004Uu-8p for bug-gnu-emacs@gnu.org; Sun, 25 Feb 2018 14:56:03 -0500 Received: from mail-qk0-x233.google.com ([2607:f8b0:400d:c09::233]:45120) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eq2Ou-0004Uc-2q for bug-gnu-emacs@gnu.org; Sun, 25 Feb 2018 14:56:00 -0500 Received: by mail-qk0-x233.google.com with SMTP id g2so16727647qkd.12 for ; Sun, 25 Feb 2018 11:55:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:subject:date:message-id:mime-version; bh=PcXF3GGlQ2yGQSlaNf3NsMrk1ndvxEZl7outX/FQ9MQ=; b=YWZiW0Aae08QjJWgzVOcpu9eVnR4e110EtRmm3+Y0wF3cSLpCkc+TrJ0uFCkkfn2TG mAbwYpDNXfcNjo6WfJSuMudCYoF6DbHkpwT+HU3khdDY5vO+gcSBKrpbXF233cfxj752 EA1PGqIHMmQ7IRtX9DSAVARs92ZTVtdN2b+N/aRnNFn4XGPc906RJd/DIlVbgteXsaNO /WS8IfiYIfIfTXAM6gKBLO5vwJ7ZYweztwCflGxrDhaK2g4m3wJSJDqMYyWPDCQAkifm D8YgotcYR/2KdctPgbK9ya2EUBRDA0ROF2wXbO0ZpXgaTAelKmmOQIX56Hwa6GviIypJ RAqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version; bh=PcXF3GGlQ2yGQSlaNf3NsMrk1ndvxEZl7outX/FQ9MQ=; b=OANQRnTdB/EVJnEw4eqlu4kxaQGdg4atC5aJw7CPhJoR8n2UPUhZAEQ8QT/p3z1qGA yIVBq9KK8dAYNh7bj3RAuO5V1AYcwlEsuLKalPlgVIiMOeWp+bWC4gMUY1SVtGCtxEKj tMzRWRmt6WBfbEAkcgsyM4bLZ/WAHWgN51MceJ+BFF2wVhzR0d+P6lD31jbdNJvjWLbg ocrS7r/TdzTMSJbFLnGcvBS8iEUTm/iIj5L2Tcnk95ETcTZdp/OPJ24QQtRGGXeRdWOp F5AGpKcWHQ7QVFyRq/v6FFjbU0TbnE07msJAgqPo+5U6x9ZccpcivuQQPxUGqaczyV9k Bl5w== X-Gm-Message-State: APf1xPCSHho5EDFyEG7tiGV93wV76KeM50i2LBYDTSvKVFuvtaVSMAj6 iPqwUda8eJlxIhJGi7f/OPO+zxEj X-Google-Smtp-Source: AG47ELsk5OR9eE8tYscx4uS/9IAxaHZyNw93btycGuFp+eIf/kMDa2/WO3brsO1ZqqT+391HsVxwFQ== X-Received: by 10.55.17.196 with SMTP id 65mr12804638qkr.86.1519588559092; Sun, 25 Feb 2018 11:55:59 -0800 (PST) Received: from amun (cpe-184-152-54-116.nyc.res.rr.com. [184.152.54.116]) by smtp.gmail.com with ESMTPSA id r65sm3717080qkb.38.2018.02.25.11.55.58 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 25 Feb 2018 11:55:58 -0800 (PST) User-agent: mu4e 1.0-alpha3; emacs 26.0.91 From: John Shahid To: bug-gnu-emacs@gnu.org Subject: clarify linux-mode usage from Lisp Date: Sun, 25 Feb 2018 14:55:53 -0500 Message-ID: <87d10skfna.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 25 Feb 2018 18:25:35 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-clarifies-linum-mode-usage-from-Lisp.patch >From 04d261f836e5b000e8f6ed9e343417feaa8bc273 Mon Sep 17 00:00:00 2001 From: John Shahid Date: Sun, 25 Feb 2018 14:33:00 -0500 Subject: [PATCH] clarifies linum-mode usage from Lisp --- lisp/linum.el | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lisp/linum.el b/lisp/linum.el index 9df0c5d023..fa66d62bfe 100644 --- a/lisp/linum.el +++ b/lisp/linum.el @@ -76,8 +76,12 @@ linum-delay (define-minor-mode linum-mode "Toggle display of line numbers in the left margin (Linum mode). With a prefix argument ARG, enable Linum mode if ARG is positive, -and disable it otherwise. If called from Lisp, enable the mode -if ARG is omitted or nil. +and disable it otherwise. + +When called from Lisp, toggles the mode if the argument is +`toggle', disables the mode if the argument is a non-positive +integer, and enables the mode otherwise (including if the +argument is omitted or nil or a positive integer). Linum mode is a buffer-local minor mode." :lighter "" ; for desktop.el -- 2.16.2 --=-=-= Content-Type: text/plain The attached patch fixes a bug in the docstring of linum-mode regarding calling it from Lisp. It incorrectly state that calling the function with no args or nil will enable the mode; this gives the impression that any other value disables the mode, which isn't the case. The patches copies the relevant section from define-minor-mode cheers, -js --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 25 20:51:58 2018 Received: (at submit) by debbugs.gnu.org; 26 Feb 2018 01:51:58 +0000 Received: from localhost ([127.0.0.1]:60850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eq7xN-0001c7-K9 for submit@debbugs.gnu.org; Sun, 25 Feb 2018 20:51:57 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57235) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eq2fU-0000RX-Pv for submit@debbugs.gnu.org; Sun, 25 Feb 2018 15:13:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eq2fO-0007fH-Q6 for submit@debbugs.gnu.org; Sun, 25 Feb 2018 15:13:03 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:53072) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eq2fO-0007f0-MJ for submit@debbugs.gnu.org; Sun, 25 Feb 2018 15:13:02 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48199) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eq2fN-00015x-Nv for bug-gnu-emacs@gnu.org; Sun, 25 Feb 2018 15:13:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eq2fI-0007UE-Q7 for bug-gnu-emacs@gnu.org; Sun, 25 Feb 2018 15:13:01 -0500 Received: from mail-qt0-x233.google.com ([2607:f8b0:400d:c0d::233]:38462) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eq2fI-0007Tk-LT for bug-gnu-emacs@gnu.org; Sun, 25 Feb 2018 15:12:56 -0500 Received: by mail-qt0-x233.google.com with SMTP id k13so16526175qtg.5 for ; Sun, 25 Feb 2018 12:12:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:subject:in-reply-to:date:message-id :mime-version; bh=VNKyIfckcIKt57FFrFYN3xRHJfdD501z4CCqZuaANy8=; b=qWcIOHIeQuTO6dlvFgTq+x+7Q1n2kGX7cdnrC9RwhkPwpeEI8wwRo98bRNGDUjO+Hg uGHAkOY7Ppd8c+bC0o48Hg3FUd+r9d0xwWvEMyEdMCLsHgj/jwW5eqkTI1F2ZFoV/8Xe J5ILH8fmSMJDqyHvWVTg+FF6B3hrKY3Fg/EwCTA97iDfo1Vl0tFX8pzzl1yoWwKuPdP8 bPpSzkfOgksgAAHmc4uNxmeC+SI+Vnl3UBrDL07uLc1BMR9q66UISuVca8lX8Xfb0TwW MmI/T3Z/sPxbGGKLvSm+wgktemoM1yxUc5JH+x3eS87LwNEZvJ5IOZolTVCjb00pUiHV DSjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:subject :in-reply-to:date:message-id:mime-version; bh=VNKyIfckcIKt57FFrFYN3xRHJfdD501z4CCqZuaANy8=; b=d0qoOSSkjbgAQsGVVeKjqaKqZ8Thm2uGlnRHBA6qSTmWdP6Fg0N+ezf3FzrOzeAaZZ xLOkzQjsBByXcdu7vCcQh5myZVf+XmH+q2AYL1Ylhk52lJwdtFS+Ff9dRDeuqGnTbEWG KYT06aA7QOIgymQGNcJPPYhA72bKy0itbj18m74yhy+fN+7nXjfAVlE/FZ+3J+YCyBL8 ThAAhlXGUEuhF0Vy+Q9seSePry1YVJNt4gX9pK+67wnpHJQu82v7VAb7g1vN6lOZSKcb Q/kf+z3wBqvxR3X3daSZkcOOhICZDTNBmu458yoEN5qCkT/HdwOF5VCZJxjn1b27Rnmy EYug== X-Gm-Message-State: APf1xPAqmJwIALgipvCDi/31MXJOvwaiDMd2GJb/3tlA9r8TP2nS7+hE RkNGQAiY4IhXBV7MHqSFguSfmd1f X-Google-Smtp-Source: AG47ELtnaVnYUvnEwMJ5+HlZxTWhZQkTTDL48GXXQG/z8FVUKe1oWuCw/ruhRgoAA/TbUCnqb2HBWQ== X-Received: by 10.237.34.205 with SMTP id q13mr13436930qtc.113.1519589575804; Sun, 25 Feb 2018 12:12:55 -0800 (PST) Received: from amun (cpe-184-152-54-116.nyc.res.rr.com. [184.152.54.116]) by smtp.gmail.com with ESMTPSA id h29sm4515302qtk.94.2018.02.25.12.12.55 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 25 Feb 2018 12:12:55 -0800 (PST) References: <87d10skfna.fsf@gmail.com> User-agent: mu4e 1.0-alpha3; emacs 26.0.91 From: John Shahid To: bug-gnu-emacs@gnu.org Subject: Re: clarify linux-mode usage from Lisp In-reply-to: <87d10skfna.fsf@gmail.com> Date: Sun, 25 Feb 2018 15:12:54 -0500 Message-ID: <87a7vwkeux.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 25 Feb 2018 20:51:57 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Worth noting that this is my first patch to Emacs. Let me know if there's anything wrong with the way I submitted the patch. cheers, -js John Shahid writes: > From 04d261f836e5b000e8f6ed9e343417feaa8bc273 Mon Sep 17 00:00:00 2001 > From: John Shahid > Date: Sun, 25 Feb 2018 14:33:00 -0500 > Subject: [PATCH] clarifies linum-mode usage from Lisp > > --- > lisp/linum.el | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/lisp/linum.el b/lisp/linum.el > index 9df0c5d023..fa66d62bfe 100644 > --- a/lisp/linum.el > +++ b/lisp/linum.el > @@ -76,8 +76,12 @@ linum-delay > (define-minor-mode linum-mode > "Toggle display of line numbers in the left margin (Linum mode). > With a prefix argument ARG, enable Linum mode if ARG is positive, > -and disable it otherwise. If called from Lisp, enable the mode > -if ARG is omitted or nil. > +and disable it otherwise. > + > +When called from Lisp, toggles the mode if the argument is > +`toggle', disables the mode if the argument is a non-positive > +integer, and enables the mode otherwise (including if the > +argument is omitted or nil or a positive integer). > > Linum mode is a buffer-local minor mode." > :lighter "" ; for desktop.el From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 01 22:26:11 2018 Received: (at 30610) by debbugs.gnu.org; 2 Mar 2018 03:26:11 +0000 Received: from localhost ([127.0.0.1]:39994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1erbKl-0007Pm-M2 for submit@debbugs.gnu.org; Thu, 01 Mar 2018 22:26:11 -0500 Received: from mail-it0-f53.google.com ([209.85.214.53]:34555) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1erbKj-0007PZ-Uv for 30610@debbugs.gnu.org; Thu, 01 Mar 2018 22:26:10 -0500 Received: by mail-it0-f53.google.com with SMTP id n128so918916ith.1 for <30610@debbugs.gnu.org>; Thu, 01 Mar 2018 19:26:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Wsl0Wnfi5Dj+E9Z9lu0u/aBH07NwhVa+jQfS09f0j48=; b=Dli1NuN6+gTZqVpGdj7kd6lUVWtppLui802NHmXL1RGvH8gYXVo7DMhJFvlmJctpEd 4UZb4MUil9Bj5qbuSartAM6MFGpMq3W6O7e6TOLGyBqZ9Lh5gtNPZTJA4OHrbQXUrL7B ZArI+ZHkuJoili85bHeQ1j6rVfQ+RpffuVATdG5J4JthonLRU8FPRW0/p8En9VZOvB5M mejVrlOie21fjFusZ2otr8KnVkqy4XH/WvPaiDfIIJ/HGp4Yj8e6cia0rSDqIIUQrk2S IWrBff0ZZ/asTtdBTqwBSkhKqjVWjqcnWz/YpSPUO+8mwqzG6AjbShFQ3L08Z3FOmVjp mJLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Wsl0Wnfi5Dj+E9Z9lu0u/aBH07NwhVa+jQfS09f0j48=; b=Ej8aFi1K6MynPcdhhCb2zcl6PE+HFWvpD0XoluGxafyhNUbkcYEfjMTRXeE36deFcb U/ahGt21RJYdORi8qYnIZUg7lS92UvGP+wb4C38x+hjluu18zXXZBKrSFz1HeFCjR8Ul /KbcUQZEuPwDEwsUEwSRmZ/2SEq+XK+zNvZpbTfyIbuTwAM/9lokV0sKrVSNiJaD+Lc1 KGUm4aA9xHmhiEcHHOToL5Id2fwoTCHsBt1GuAXXmRg/iYAFOveuWr7QrclFMmFKRCx/ 0g6n51x+mdD+jslynzj5QWE3eremJWOA80bwIKZtulIh9Wp45xwNNBeGeJ//5yb3xchj xCjQ== X-Gm-Message-State: AElRT7EU9T2VlIrseRCzj+X5zuoI9gHfDa4EiYj4WdTP4OYSVXb7m8Bs aPtAonmfXbzmef71Y09HrG19hQ== X-Google-Smtp-Source: AG47ELsijqpMRH1S0luyoHGbL7Z9lnIn8aKF3IdKc4eamwNV/FA95/VF0roUh0+QviTvYGOBkSMziw== X-Received: by 10.36.140.3 with SMTP id j3mr681456itd.66.1519961164306; Thu, 01 Mar 2018 19:26:04 -0800 (PST) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id v8sm310893itv.3.2018.03.01.19.26.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 01 Mar 2018 19:26:03 -0800 (PST) From: Noam Postavsky To: John Shahid Subject: Re: bug#30610: clarify linux-mode usage from Lisp References: <87d10skfna.fsf@gmail.com> <87a7vwkeux.fsf@gmail.com> Date: Thu, 01 Mar 2018 22:26:02 -0500 In-Reply-To: <87a7vwkeux.fsf@gmail.com> (John Shahid's message of "Sun, 25 Feb 2018 15:12:54 -0500") Message-ID: <87bmg740qd.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 30610 Cc: 30610@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) John Shahid writes: > Worth noting that this is my first patch to Emacs. Let me know if > there's anything wrong with the way I submitted the patch. The patch looks fine, but the commit message should have a ChangeLog style entry as described in CONTRIBUTE under "Commit messages". And if you haven't assigned copyright for Emacs, it should also have a 'Copyright-paperwork-exempt: yes' line. Note that we only accept up to 15 lines worth of unassigned patches. If you want to start the assignment process, fill out the form at [1] and send it to fsf-records@gnu.org (they will reply with further instructions). [1]: https://git.savannah.gnu.org/cgit/gnulib.git/tree/doc/Copyright/request-assign.program From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 03 18:17:38 2018 Received: (at 30610) by debbugs.gnu.org; 3 Mar 2018 23:17:38 +0000 Received: from localhost ([127.0.0.1]:43310 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1esGPJ-00005M-QR for submit@debbugs.gnu.org; Sat, 03 Mar 2018 18:17:37 -0500 Received: from mail-qk0-f182.google.com ([209.85.220.182]:45175) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1esGPI-000056-AA for 30610@debbugs.gnu.org; Sat, 03 Mar 2018 18:17:36 -0500 Received: by mail-qk0-f182.google.com with SMTP id g2so16459850qkd.12 for <30610@debbugs.gnu.org>; Sat, 03 Mar 2018 15:17:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=mTmy8ewBRAX1u2prOcf7IP21reIZW9qL0jOtdDCPV2Q=; b=nTqtraWBV3DXwaCdcsJfaffRUD8upEzqcCAQ2uEKeofCFYBPRiqHjmUxgSivuEJql5 rHHct5qCPF+Mn6hqrnpoHBvpbR+4MkisxCwZz3JhKsf7f+p8qvF0UNncbwKw155m7qyx 9E158F33QLvHrMYT7KIB8ZdPKwfFQv2G1RM458tzOUZl9jg4AN1P2gO0DbkoUAyD7tcg tUIhTZQPrf30Ui/GuBSNa43UYkKYsNLdUxKfF9x5p7uTT65TL1SvAhEI/dtTf6T89Z9O H0jR4d5HEKIqwVKngEVgkgtdZDnCvlWhpsMInZn6cCAw9TF53oALqLdkX+9jAcZYBNqO qS+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=mTmy8ewBRAX1u2prOcf7IP21reIZW9qL0jOtdDCPV2Q=; b=cg5GlqUSI6lRLFuH+4pgWUVQ6EyrNSUkt16fB322FI1Lcz7GcerqL+lTYp1U74y7+t X2l1jQISSc/nEEYwI4Zqu/NNJ378PvVO6bsgu2HLprre0yyxnBcf0nKh5JPvdNbFfRHp ATpWP0t2Z2lCk1pLagLTjmn1Mr7yG9Ju/90B49KtRUHGdg4G7Vx+7BuGT7dLWCVnn9EM n1llz+KT2MjWMxDGkZ7LQ9Bj80ZkB/6e7bKD3I+xeVBNUUgdoCl0zDpqJmp1sg82xCqN S+Okf/MA6qsDK9oFszpOC9BuvRMpxxzSz4ZdLyts0Pbntsj7WkemxybJOYAjMkOSUQPl Go/Q== X-Gm-Message-State: AElRT7E6nb21cPtMwxWQYfqaw3Hfv1M3aBV3+SzhQfVmQ/zSo2Ar86dI FdNgnzVFKxGoF8PrPMDnVbM5Mbcs X-Google-Smtp-Source: AG47ELs2oyLvMOwjpz2RGUN8AGxRa0zpHHq9Ygf9wIvV3pCvS5c8JeIOek5Ap20ZOF2G605dZLWjRw== X-Received: by 10.55.217.28 with SMTP id u28mr15067484qki.148.1520119050559; Sat, 03 Mar 2018 15:17:30 -0800 (PST) Received: from amun (cpe-184-152-54-116.nyc.res.rr.com. [184.152.54.116]) by smtp.gmail.com with ESMTPSA id s39sm7063674qth.10.2018.03.03.15.17.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 03 Mar 2018 15:17:29 -0800 (PST) References: <87d10skfna.fsf@gmail.com> <87a7vwkeux.fsf@gmail.com> <87bmg740qd.fsf@gmail.com> User-agent: mu4e 1.0-alpha3; emacs 26.0.91 From: John Shahid To: Noam Postavsky Subject: Re: bug#30610: clarify linux-mode usage from Lisp In-reply-to: <87bmg740qd.fsf@gmail.com> Date: Sat, 03 Mar 2018 18:17:19 -0500 Message-ID: <87a7vobvgg.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30610 Cc: 30610@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain Noam Postavsky writes: > John Shahid writes: > >> Worth noting that this is my first patch to Emacs. Let me know if >> there's anything wrong with the way I submitted the patch. > > The patch looks fine, but the commit message should have a ChangeLog > style entry as described in CONTRIBUTE under "Commit messages". fixed and attached a new patch > And if you haven't assigned copyright for Emacs, it should also have a > 'Copyright-paperwork-exempt: yes' line. Note that we only accept up > to 15 lines worth of unassigned patches. If you want to start the > assignment process, fill out the form at [1] and send it to > fsf-records@gnu.org (they will reply with further instructions). i filled out and sent the paper work. i also exempt this commit from the paperwork since it is a very minor change. thanks, -js --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-lisp-linum.el-clarify-linum-mode-handling-of-ARG.patch >From 113b30d8739dc8d1673a53d06b201e6c9ea1a54a Mon Sep 17 00:00:00 2001 From: John Shahid Date: Sun, 25 Feb 2018 14:33:00 -0500 Subject: [PATCH] lisp/linum.el: clarify linum-mode handling of `ARG' Copyright-paperwork-exempt: yes --- lisp/linum.el | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lisp/linum.el b/lisp/linum.el index 9df0c5d023..fa66d62bfe 100644 --- a/lisp/linum.el +++ b/lisp/linum.el @@ -76,8 +76,12 @@ linum-delay (define-minor-mode linum-mode "Toggle display of line numbers in the left margin (Linum mode). With a prefix argument ARG, enable Linum mode if ARG is positive, -and disable it otherwise. If called from Lisp, enable the mode -if ARG is omitted or nil. +and disable it otherwise. + +When called from Lisp, toggles the mode if the argument is +`toggle', disables the mode if the argument is a non-positive +integer, and enables the mode otherwise (including if the +argument is omitted or nil or a positive integer). Linum mode is a buffer-local minor mode." :lighter "" ; for desktop.el -- 2.16.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 03 18:24:14 2018 Received: (at 30610) by debbugs.gnu.org; 3 Mar 2018 23:24:14 +0000 Received: from localhost ([127.0.0.1]:43314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1esGVi-0000Em-Hy for submit@debbugs.gnu.org; Sat, 03 Mar 2018 18:24:14 -0500 Received: from mail-qk0-f173.google.com ([209.85.220.173]:41582) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1esGVg-0000EX-H9 for 30610@debbugs.gnu.org; Sat, 03 Mar 2018 18:24:12 -0500 Received: by mail-qk0-f173.google.com with SMTP id w142so16478596qkb.8 for <30610@debbugs.gnu.org>; Sat, 03 Mar 2018 15:24:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=YTx56wMmOh5PWmH+fPKNm8zK7XCPWyPNHNx0NH/9Kts=; b=Rxv/9/hrtEBKa0LjiyRWRvjZNnXyzrZtgYkNz0odPqf7tevBc7JN+baZW+BVOdf2JU rVaBTKygUlvvuJJvhtqWkrdyj9neH9OGnBaLplR8r8lTn67kN6qri5VGnT5d3sD5/YS8 pHjJd4IU1s9k/SK596vl/6bsEbMgO5+4PqAj7JaMsmMDkou8kJy8B2smzNe7MDTT6mO1 AgcqZIv4qXea7t85bBQIKtv849NF1AYQ7r0VyPjOIwmrcib5Q3CQtWyozG+f8aOA6aob 1jme+IeeTHAXcwYpRchTgY8IXjW4fQ2vmdPpXGhuff9rfK+mkUHy9KW3do1MgcYw5XST GuIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=YTx56wMmOh5PWmH+fPKNm8zK7XCPWyPNHNx0NH/9Kts=; b=atCGRnJRsBgl0+L9ZywNog1sK2/lWqn6s99ql0cny2lxuDeeO6voQRBQgT2g1WzNgQ QCBCf5eFr4Ttd3fILWd6HEYZH0UUFO+FogSQICJR4GRLFDp2bmW5J8ti7vBDAcja8ME5 5YoGxIaDjNoW1bShKc664rqpp4d57zjsTOTGjTuLsnhoir1jKChnIu/MMsZxYC+RrrVV Q8FFpEih07sLV9anhUpMO36jWlp+eYT2TWmE03WQbt2aRSnISDHxhe74YQ7/Bt6pE+JR SzwEQSF307acuyU8gkWbImMJCpfArjtXmKdRwUThUG30MF0mg0RAMTaKFATvHLu+590F MkIQ== X-Gm-Message-State: AElRT7FgWde8Q8RTfAERD1X0AAP0FVbLbQCpeTAphoyEcWTCxkTXVeba Rv7kUXZWztJTtdlOWn5UifiBL5u7 X-Google-Smtp-Source: AG47ELvOnWKWkfDR9bTUvYCuDQG6HTJZXD9Ivyb/04Gsh4mbeppRtcPGcC98qGL+hsNnh/nQvagGhQ== X-Received: by 10.55.5.6 with SMTP id 6mr15540100qkf.213.1520119446846; Sat, 03 Mar 2018 15:24:06 -0800 (PST) Received: from amun (cpe-184-152-54-116.nyc.res.rr.com. [184.152.54.116]) by smtp.gmail.com with ESMTPSA id s4sm6900456qta.34.2018.03.03.15.24.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 03 Mar 2018 15:24:05 -0800 (PST) References: <87d10skfna.fsf@gmail.com> <87a7vwkeux.fsf@gmail.com> <87bmg740qd.fsf@gmail.com> <87a7vobvgg.fsf@gmail.com> User-agent: mu4e 1.0-alpha3; emacs 26.0.91 From: John Shahid To: Noam Postavsky Subject: Re: bug#30610: clarify linux-mode usage from Lisp In-reply-to: <87a7vobvgg.fsf@gmail.com> Date: Sat, 03 Mar 2018 18:24:04 -0500 Message-ID: <878tb8bv57.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30610 Cc: 30610@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain forgot to add asterisk before the file name. attached the new patch with the asterisk John Shahid writes: > Noam Postavsky writes: > >> John Shahid writes: >> >>> Worth noting that this is my first patch to Emacs. Let me know if >>> there's anything wrong with the way I submitted the patch. >> >> The patch looks fine, but the commit message should have a ChangeLog >> style entry as described in CONTRIBUTE under "Commit messages". > > fixed and attached a new patch > >> And if you haven't assigned copyright for Emacs, it should also have a >> 'Copyright-paperwork-exempt: yes' line. Note that we only accept up >> to 15 lines worth of unassigned patches. If you want to start the >> assignment process, fill out the form at [1] and send it to >> fsf-records@gnu.org (they will reply with further instructions). > > i filled out and sent the paper work. i also exempt this commit from the > paperwork since it is a very minor change. > > thanks, > > -js > > From 113b30d8739dc8d1673a53d06b201e6c9ea1a54a Mon Sep 17 00:00:00 2001 > From: John Shahid > Date: Sun, 25 Feb 2018 14:33:00 -0500 > Subject: [PATCH] lisp/linum.el: clarify linum-mode handling of `ARG' > > Copyright-paperwork-exempt: yes > --- > lisp/linum.el | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/lisp/linum.el b/lisp/linum.el > index 9df0c5d023..fa66d62bfe 100644 > --- a/lisp/linum.el > +++ b/lisp/linum.el > @@ -76,8 +76,12 @@ linum-delay > (define-minor-mode linum-mode > "Toggle display of line numbers in the left margin (Linum mode). > With a prefix argument ARG, enable Linum mode if ARG is positive, > -and disable it otherwise. If called from Lisp, enable the mode > -if ARG is omitted or nil. > +and disable it otherwise. > + > +When called from Lisp, toggles the mode if the argument is > +`toggle', disables the mode if the argument is a non-positive > +integer, and enables the mode otherwise (including if the > +argument is omitted or nil or a positive integer). > > Linum mode is a buffer-local minor mode." > :lighter "" ; for desktop.el --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-lisp-linum.el-clarify-linum-mode-handling-of-ARG.patch >From 7024af1df6fccedbdba1ea24337f417cbb03a6a2 Mon Sep 17 00:00:00 2001 From: John Shahid Date: Sun, 25 Feb 2018 14:33:00 -0500 Subject: [PATCH] * lisp/linum.el: clarify linum-mode handling of `ARG' Copyright-paperwork-exempt: yes --- lisp/linum.el | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lisp/linum.el b/lisp/linum.el index 9df0c5d023..fa66d62bfe 100644 --- a/lisp/linum.el +++ b/lisp/linum.el @@ -76,8 +76,12 @@ linum-delay (define-minor-mode linum-mode "Toggle display of line numbers in the left margin (Linum mode). With a prefix argument ARG, enable Linum mode if ARG is positive, -and disable it otherwise. If called from Lisp, enable the mode -if ARG is omitted or nil. +and disable it otherwise. + +When called from Lisp, toggles the mode if the argument is +`toggle', disables the mode if the argument is a non-positive +integer, and enables the mode otherwise (including if the +argument is omitted or nil or a positive integer). Linum mode is a buffer-local minor mode." :lighter "" ; for desktop.el -- 2.16.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 03 20:50:04 2018 Received: (at 30610) by debbugs.gnu.org; 4 Mar 2018 01:50:04 +0000 Received: from localhost ([127.0.0.1]:43388 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1esImq-0005UQ-5T for submit@debbugs.gnu.org; Sat, 03 Mar 2018 20:50:04 -0500 Received: from eggs.gnu.org ([208.118.235.92]:36890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1esImo-0005Ts-A0 for 30610@debbugs.gnu.org; Sat, 03 Mar 2018 20:50:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1esImi-0001tf-2Z for 30610@debbugs.gnu.org; Sat, 03 Mar 2018 20:49:57 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59761) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1esIme-0001py-Mp; Sat, 03 Mar 2018 20:49:52 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1esIme-0000CC-1s; Sat, 03 Mar 2018 20:49:52 -0500 From: Glenn Morris To: John Shahid Subject: Re: bug#30610: clarify linux-mode usage from Lisp References: <87d10skfna.fsf@gmail.com> <87a7vwkeux.fsf@gmail.com> <87bmg740qd.fsf@gmail.com> <87a7vobvgg.fsf@gmail.com> <878tb8bv57.fsf@gmail.com> X-Spook: Plame Social media Failure War on Terrorism Defcon AMTRAK X-Ran: xdz[$[t@<6Ht~BQ6\{.RRIPA9$YZ>F-w#C!jt/fkwXQiHe+/gk64(P}lXiy,Tq$-H (John Shahid's message of "Sat, 03 Mar 2018 18:24:04 -0500") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30610 Cc: Noam Postavsky , 30610@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) There are loads of these "Toggle..." doc-strings, all using the same format. It doesn't make sense to change just the linum one. (https://debbugs.gnu.org/10754 would reduce the need to change multiple places in future.) From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 03 21:14:48 2018 Received: (at 30610) by debbugs.gnu.org; 4 Mar 2018 02:14:48 +0000 Received: from localhost ([127.0.0.1]:43398 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1esJAm-00062i-JV for submit@debbugs.gnu.org; Sat, 03 Mar 2018 21:14:48 -0500 Received: from mail-qk0-f181.google.com ([209.85.220.181]:44358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1esJAk-00062V-UO for 30610@debbugs.gnu.org; Sat, 03 Mar 2018 21:14:47 -0500 Received: by mail-qk0-f181.google.com with SMTP id v124so16702337qkh.11 for <30610@debbugs.gnu.org>; Sat, 03 Mar 2018 18:14:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=ZWQFMRhLIw3dkfxoQ9a01YeupWxFnxoI94R+dsS15dk=; b=rtDpnttY/Qb9L1jhewbAMYabhREflDZMIAUg/rCZ9jkW9n9NNsha66TZHPPPKHZY/t TdVqraf4ASHx0Vfi2Q1Lq8XY3Whr+khm8vCapNoklJbkRMFHwT6iW47CrKOsByXNM7G7 VemKkyroDbIYsLvSqUsIKRvviZ7E4BrKCEHJZ3iUjDrSKN4TET9dbiDqewSmjmRLYLWj tuqVpO5rSqs1EEuh6bht2yev5Pgby1U5h1OKxSQCEyIFlnnmER9du5pyLhImOx+0eUzz QurZhm2BOYGTjw0lcFr2CRm/N/w4Byy3DroXwFPJWWBl6AVtmhh2ZDlnveL1yUYhuTaA +0dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=ZWQFMRhLIw3dkfxoQ9a01YeupWxFnxoI94R+dsS15dk=; b=E/D9WlmezF6mDrAIKl3n/pavqaXDmFvoPxZGZ9TqoQEtwZSlfbpiTnEyqeMSq8JUp9 XgNm7a6d9dVKCpTikZ4whJW7ya628M9uvSUK0hKLi4OzYL8kkiIxUzVN+uTRhruxJ0ji 4aO5P4us9evQSE3rPE6ka+OFCBTQL+LC3mgk1rVCW3CpviERtgydUtARJskmXbzi3Pnc 9Xkq8aA9ZSQEmToDJ5OO7hvxgvqr58MkEDPy/6Nu8rhH/MHnvFsivJ0CQq8kwA4bovxy MfyP0aCP090QrjxBIn4o8ino5Gtz7FuDccmtTS7qPCvSn8ByUZRTCiUycNReuixMf8N1 68HQ== X-Gm-Message-State: AElRT7FkUWNGzDymAHaiAJRAETjRxR1jGgwWY8UkFYNAig88kAcUqfH9 qGRhbdULkX/GA0anX97mGWWSWZoG X-Google-Smtp-Source: AG47ELtrYTAuUycGnSfY1r2jdCK1HnYtlHWhGLuVEXWJ3Ic0n5t/5lvJfuCGxW8OtyTqBdbbuFQt6A== X-Received: by 10.55.159.3 with SMTP id i3mr15197620qke.125.1520129681051; Sat, 03 Mar 2018 18:14:41 -0800 (PST) Received: from amun (cpe-184-152-54-116.nyc.res.rr.com. [184.152.54.116]) by smtp.gmail.com with ESMTPSA id c25sm6905011qtn.9.2018.03.03.18.14.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 03 Mar 2018 18:14:40 -0800 (PST) References: <87d10skfna.fsf@gmail.com> <87a7vwkeux.fsf@gmail.com> <87bmg740qd.fsf@gmail.com> <87a7vobvgg.fsf@gmail.com> <878tb8bv57.fsf@gmail.com> User-agent: mu4e 1.0-alpha3; emacs 26.0.91 From: John Shahid To: Glenn Morris Subject: Re: bug#30610: clarify linux-mode usage from Lisp In-reply-to: Date: Sat, 03 Mar 2018 21:14:35 -0500 Message-ID: <877eqsbn90.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30610 Cc: Noam Postavsky , 30610@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Agreed. I like your proposed solution more. do you have patch or is that something I can work on ? Glenn Morris writes: > There are loads of these "Toggle..." doc-strings, all using the same > format. It doesn't make sense to change just the linum one. > > (https://debbugs.gnu.org/10754 would reduce the need to change multiple > places in future.) From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 03 21:23:09 2018 Received: (at 30610) by debbugs.gnu.org; 4 Mar 2018 02:23:09 +0000 Received: from localhost ([127.0.0.1]:43402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1esJIr-0006FH-EV for submit@debbugs.gnu.org; Sat, 03 Mar 2018 21:23:09 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39911) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1esJIq-0006F5-0S for 30610@debbugs.gnu.org; Sat, 03 Mar 2018 21:23:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1esJIk-0001d3-2L for 30610@debbugs.gnu.org; Sat, 03 Mar 2018 21:23:02 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60234) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1esJIh-0001aF-8m; Sat, 03 Mar 2018 21:22:59 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1esJIg-0007Ih-UT; Sat, 03 Mar 2018 21:22:58 -0500 From: Glenn Morris To: Noam Postavsky Subject: Re: bug#30610: clarify linux-mode usage from Lisp References: <87d10skfna.fsf@gmail.com> <87a7vwkeux.fsf@gmail.com> <87bmg740qd.fsf@gmail.com> X-Spook: Manfurov Incident Afghanistan EBS SP4 Burst underground X-Ran: f78ntlFAq8`4]v]c-a| (Noam Postavsky's message of "Thu, 01 Mar 2018 22:26:02 -0500") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30610 Cc: John Shahid , 30610@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Noam Postavsky wrote: > https://git.savannah.gnu.org/cgit/gnulib.git/tree/doc/Copyright/request-assign.program BTW, I think request-assign.future is the one to use in (al)most (all) situations. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 04 12:40:58 2018 Received: (at 30610) by debbugs.gnu.org; 4 Mar 2018 17:40:58 +0000 Received: from localhost ([127.0.0.1]:44658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1esXd4-00029K-5x for submit@debbugs.gnu.org; Sun, 04 Mar 2018 12:40:58 -0500 Received: from mail-qk0-f182.google.com ([209.85.220.182]:43679) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1esXd2-000298-7R for 30610@debbugs.gnu.org; Sun, 04 Mar 2018 12:40:56 -0500 Received: by mail-qk0-f182.google.com with SMTP id j4so17980816qke.10 for <30610@debbugs.gnu.org>; Sun, 04 Mar 2018 09:40:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=nD/qied+7pXJqGmR2Grr5yEPV/RoFQZdic0G/6L8wlo=; b=IsPNl7xVkYkAQHZ/YBJRV7UB51XC356ZNNBh8u1ONNI6t4MFzxa4dl//FdO2hwTGxx /d5mlPhhK4+0AN2Ru9fQjebKqXQUQSkgrn9KroREIj/UldBSCBa9Pu3AjpesFMXghHbj o9N43hfU7a9ozR8+1aTU9vdsKDjBJMip551dEvZ3MC75RY2tMMTpFS1eMl/yMhLkc6AK qBpuWrGxLIWNNcfsfVNiyoHzHDvMz2ZrLrXZvsufhyOKhy9RAnRfmaKOJQrjhnIifZgm 42T5aP6YMoP0NolNFy1Fuu3O6UakB9YzOU2fHrvYKexFl9400fvcPLsb7iYd+CO/ILro xNhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=nD/qied+7pXJqGmR2Grr5yEPV/RoFQZdic0G/6L8wlo=; b=KL4CQgpyoSsfkgvTIQpqAEV0u5U7rKPFm//+H52khiSR2d1OeGOZfH3oTi2D9wUUQD uKuyrm3qGmyXwYseoYQXUzTk0zcgXHza/4zuZb/vHWuvxOkXwqU3HUYqwEuLKcUHQipL Zr43XM65NZ91iaalBOafh0XLlRuTQBpcFY3WF1YpSdLWNFXC5yQ6CpDiTR1pY15Lpehx O/48BqWErSG/wICXLpNr/g0VAo5g5WvnqNrctD3plflHrHOhGPFIagWUTnCzKqLM9NPO swdvIbW0ZCWkEYyptvohq+4ex1WQBVc2xt02e+wHfLvxYbbQ85cY/YcjDgnJpezgw/Mn 5UNw== X-Gm-Message-State: AElRT7F7qrYuge1Q54H3z+fHNu9JZVglIyUyhAZYoHIpn4vPfjZiFD7H JAbaOUu+GHa49go1DtmAL2aR3Gkp X-Google-Smtp-Source: AG47ELsP2K2zZu8wBzDLpMQjdeJ3LUYSDZTV/F8WqHc0SAs94pRDGvrGNf7T4Aa1ELQ4GJxbBv0Dzg== X-Received: by 10.55.134.133 with SMTP id i127mr18657976qkd.275.1520185250558; Sun, 04 Mar 2018 09:40:50 -0800 (PST) Received: from amun (cpe-184-152-54-116.nyc.res.rr.com. [184.152.54.116]) by smtp.gmail.com with ESMTPSA id k131sm7599951qke.5.2018.03.04.09.40.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Mar 2018 09:40:50 -0800 (PST) References: <87d10skfna.fsf@gmail.com> <87a7vwkeux.fsf@gmail.com> <87bmg740qd.fsf@gmail.com> User-agent: mu4e 1.0-alpha3; emacs 26.0.91 From: John Shahid To: Glenn Morris Subject: Re: bug#30610: clarify linux-mode usage from Lisp In-reply-to: Date: Sun, 04 Mar 2018 12:40:49 -0500 Message-ID: <874llvbuxq.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30610 Cc: Noam Postavsky , 30610@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Glenn Morris writes: > Noam Postavsky wrote: > >> https://git.savannah.gnu.org/cgit/gnulib.git/tree/doc/Copyright/request-assign.program > > BTW, I think request-assign.future is the one to use in (al)most (all) > situations. I submitted both. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 20 08:22:19 2019 Received: (at 30610) by debbugs.gnu.org; 20 Aug 2019 12:22:19 +0000 Received: from localhost ([127.0.0.1]:60956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i039X-0007us-4K for submit@debbugs.gnu.org; Tue, 20 Aug 2019 08:22:19 -0400 Received: from mail-pg1-f172.google.com ([209.85.215.172]:43247) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i039V-0007ua-0T for 30610@debbugs.gnu.org; Tue, 20 Aug 2019 08:22:17 -0400 Received: by mail-pg1-f172.google.com with SMTP id k3so3154369pgb.10 for <30610@debbugs.gnu.org>; Tue, 20 Aug 2019 05:22:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=0tsEYhQj+27NkQhRZRF/qmfCJu4h956O6rIbdRzIeio=; b=O+gRVEon1S+8HtCVIt/vMYnWeuvyOevLne0V946QysqTn67yw9xNPPJqIqR0D7CLTH 20Nmr2Na12eGS7VN6lJiuwK1JzKVVGSwLIFXdXA/kFkwx7XummZnUbaDglkZGO8ZtRW3 fCeypcQ+jeTcOiZj7N5sqUPHaybn0bygdIBHjEnoUmFS/jnT2HKClfcZTK176iRcb06H To+wuyGKwI4hoP1hK61fz6sGJext/O7Tjff/wqtH3fLegXQRKZoT1awA8Cdg7Ww7U7Ww ZcAyZj2i6qf/btjZYYOIIk1nGv697N88H77fCfc2EBqQ1D3xXm8SfRz98R0WxaoL2NRu 2o+Q== X-Gm-Message-State: APjAAAXJsIAL2reydWff19EcK08qz9W5aqZ2dmb/Qxv1oVY42LDL+Gya t1+kydiAZmL4IMjj5/Msq9tmTZKYvFs6tfa6AeA= X-Google-Smtp-Source: APXvYqyaqKB5hsHxWFn8cRhpZZBJsFQeM25iEsmYmw2nqoqExjQVrJctS4pRlp56SU84l3Jw29/dB/yP5mD2FcSkY7c= X-Received: by 2002:a62:7789:: with SMTP id s131mr29613621pfc.50.1566303731201; Tue, 20 Aug 2019 05:22:11 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Tue, 20 Aug 2019 14:22:00 +0200 Message-ID: Subject: Re: bug#30610: clarify linux-mode usage from Lisp To: John Shahid Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 30610 Cc: 30610@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) close 30610 27.1 quit John Shahid writes: >>>From 04d261f836e5b000e8f6ed9e343417feaa8bc273 Mon Sep 17 00:00:00 2001 > From: John Shahid > Date: Sun, 25 Feb 2018 14:33:00 -0500 > Subject: [PATCH] clarifies linum-mode usage from Lisp > > --- > lisp/linum.el | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/lisp/linum.el b/lisp/linum.el > index 9df0c5d023..fa66d62bfe 100644 > --- a/lisp/linum.el > +++ b/lisp/linum.el > @@ -76,8 +76,12 @@ linum-delay > (define-minor-mode linum-mode > "Toggle display of line numbers in the left margin (Linum mode). > With a prefix argument ARG, enable Linum mode if ARG is positive, > -and disable it otherwise. If called from Lisp, enable the mode > -if ARG is omitted or nil. > +and disable it otherwise. > + > +When called from Lisp, toggles the mode if the argument is > +`toggle', disables the mode if the argument is a non-positive > +integer, and enables the mode otherwise (including if the > +argument is omitted or nil or a positive integer). > > Linum mode is a buffer-local minor mode." > :lighter "" ; for desktop.el > -- > 2.16.2 > > The attached patch fixes a bug in the docstring of linum-mode regarding > calling it from Lisp. It incorrectly state that calling the function > with no args or nil will enable the mode; this gives the impression that > any other value disables the mode, which isn't the case. The patches > copies the relevant section from define-minor-mode This issue seems to have been fixed on master in: commit ee3e432300054ca488896e39fca57b10d733330a Author: John Shahid Date: Sun Jul 1 23:34:53 2018 -0400 Optionally add argument description in minor mode DOC (bug#10754) I'm therefore closing this bug report. Thanks, Stefan Kangas From unknown Mon Aug 11 21:13:05 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 18 Sep 2019 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator