Subject: [bug#30604] [PATCH 3/4] linux-initrd: Add kmod.

From: Mathieu Othacehe <[email-masked]>
Date: Sun, 25 Feb 2018 15:05:24 +0100

Hi Danny,

Here are some small remarks,

> +    ;; Make modprobe available as /sbin/modprobe so the kernel finds it.
> +    (if kmod
> +        (begin

You can use "when" to avoid "begin".

> +          (define version
> +            (car

Prefer match to car/cdr use.

> +             (filter
> +              (lambda (name)
> +                (not (string-prefix? "." name)))
> +              (scandir module-dir))))
> +
> +          (display "VERSION")
> +          (display version)
> +          (newline)

(format #t "VERSION" ~a~%" version) would be shorter.

> +                  ; -E

Why is this commented ?

> +                  "-F" (string-append #$linux "/System.map")
> +                  version)
> +          #t)))
>  

Thanks,

Mathieu