GNU bug report logs - #30598
[PATCH 0/5] gnu: Add youtube-viewer.

Previous Next

Full log

View this message in rfc822 format

From: Alex Vong <alexvong1995 <at> gmail.com>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: alexvong1995 <at> gmail.com, 30598 <at> debbugs.gnu.org
Subject: [bug#30598] [PATCH 0/5] gnu: Add youtube-viewer.
Date: Tue, 27 Feb 2018 03:30:18 +0800

[Message part 1 (text/plain, inline)]

Marius Bakke <mbakke <at> fastmail.com> writes:

> Alex Vong <alexvong1995 <at> gmail.com> writes:
>
>> Tags: patch
>>
>> Hello,
>>
>> This patch series adds youtube-viewer and its dependencies. It can be
>> used for searching youtube videos without running javascript. It also
>> plays nice with tor which is a plus.
>
> Thanks for this series!  The patches LGTM, but can you move the perl
> packages to gtk.scm and glib.scm respectively?  That seems more
> appropriate, as we already have e.g. pygtk in gtk.scm, and also avoids
> some top-module cross-references.
>
> (Additionally, perl.scm is huge, so it's good to spread the load to
> appease the Guile compiler)
>
> Thanks in advance! :-)

(I messed up my mail settings, so I am re-sending.)

The next patch series should fix everything you've mentioned so far. I
don't understand why wrap-program is used before but now I do.

Thanks for your review also!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.