Subject: Re: [bug#30572] [PATCH 4/7] docker: Allow the use of a custom temporary directory.

From: Danny Milosavljevic <[email-masked]>
Date: Tue, 27 Feb 2018 00:46:58 +0100

Hi Chris,

On Mon, 26 Feb 2018 17:23:55 +0100
Chris Marusich <[email-masked]> wrote:

> Danny Milosavljevic <[email-masked]> writes:
> 
> > Hmm, I have a slight preference for not magically adding "/docker-image" here
> > but rather adding it in the caller and in the default.
> 
> Good idea.  Here's a new version of Patch 4/7 which does what you
> suggest!  What do you think?

+         (and (zero? (apply system* "tar" "-C" tmpdir "-cf" image

Apparently this works as-is, but also here, I'd write

+         (and (zero? (apply system* "tar" "-cf" image "-C" tmpdir

Otherwise LGTM!