GNU bug report logs - #30570
Patches submitted on behalf of Nextjournal

Previous Next

Full log

Message #89 received at 30570 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Leo Famulari <leo <at> famulari.name>
Cc: 30570 <at> debbugs.gnu.org
Subject: Re: [bug#30570] [PATCH 13/16] gnu: Add google-brotli.
Date: Sat, 03 Mar 2018 22:47:49 +0100

Leo Famulari <leo <at> famulari.name> skribis:

> * gnu/packages/compression.scm (google-brotli): New variable.

[...]

> +         (add-after 'install 'rename-static-libraries
> +           ;; The build tools put a 'static' suffix on the static libraries, but
> +           ;; other applications don't know how to find these.
> +           (let ((lib (string-append (assoc-ref %outputs "out") "/lib/")))
> +             (lambda _

Rather: (lambda (#:key outputs #:allow-other-keys)
          (let ((lib (string-append (assoc-ref outputs "out") "/lib/")))
            ...))

> +    (home-page "https://github.com/google/brotli")
> +    (synopsis "General-purpose lossless compression")
> +    (description "This package provides the reference implementation of Brotli,
> +a generic-purpose lossless compression algorithm that compresses data using a
> +combination of a modern variant of the LZ77 algorithm, Huffman coding and 2nd
> +order context modeling, with a compression ratio comparable to the best
> +currently available general-purpose compression methods. It is similar in speed
                                                           ^
Missing space.  :-)

Otherwise LGTM.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.