From unknown Sun Jun 15 01:08:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30568: 27.0.50; `rx' doesn't create optimal regex for (group (or ...)) Resent-From: p.stephani2@gmail.com Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Feb 2018 14:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 30568 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 30568@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15192235382891 (code B ref -1); Wed, 21 Feb 2018 14:33:01 +0000 Received: (at submit) by debbugs.gnu.org; 21 Feb 2018 14:32:18 +0000 Received: from localhost ([127.0.0.1]:53740 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eoVRR-0000kY-T2 for submit@debbugs.gnu.org; Wed, 21 Feb 2018 09:32:18 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33661) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <34IKNWgsJDfUm.pqbmeXkfzdjXfi.ZljYrd-dkr-bjXZpdkr.lod@flex--phst.bounces.google.com>) id 1eoVRQ-0000kK-UP for submit@debbugs.gnu.org; Wed, 21 Feb 2018 09:32:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <34IKNWgsJDfUm.pqbmeXkfzdjXfi.ZljYrd-dkr-bjXZpdkr.lod@flex--phst.bounces.google.com>) id 1eoVRK-0002Zc-Jk for submit@debbugs.gnu.org; Wed, 21 Feb 2018 09:32:11 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:44578) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from <34IKNWgsJDfUm.pqbmeXkfzdjXfi.ZljYrd-dkr-bjXZpdkr.lod@flex--phst.bounces.google.com>) id 1eoVRK-0002ZS-H0 for submit@debbugs.gnu.org; Wed, 21 Feb 2018 09:32:10 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52850) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <34IKNWgsJDfUm.pqbmeXkfzdjXfi.ZljYrd-dkr-bjXZpdkr.lod@flex--phst.bounces.google.com>) id 1eoVRJ-0007SX-0c for bug-gnu-emacs@gnu.org; Wed, 21 Feb 2018 09:32:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <34IKNWgsJDfUm.pqbmeXkfzdjXfi.ZljYrd-dkr-bjXZpdkr.lod@flex--phst.bounces.google.com>) id 1eoVRC-0002TX-Vt for bug-gnu-emacs@gnu.org; Wed, 21 Feb 2018 09:32:09 -0500 Received: from mail-qt0-f202.google.com ([209.85.216.202]:34188) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from <34IKNWgsJDfUm.pqbmeXkfzdjXfi.ZljYrd-dkr-bjXZpdkr.lod@flex--phst.bounces.google.com>) id 1eoVRC-0002RA-Rr for bug-gnu-emacs@gnu.org; Wed, 21 Feb 2018 09:32:02 -0500 Received: by mail-qt0-f202.google.com with SMTP id i26so1396486qtc.1 for ; Wed, 21 Feb 2018 06:32:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to; bh=SEnwMGs7Jrrcj62dCKvjU3Zn87cGJB0r8uYxFBReeYk=; b=iMywOwC8VRWYG0VxMbVkeR2TTCLvIrx4u4iFlqMKF7ROn1jFHXJh0JGYRLHBAWUGWz 1Ze3PsdLNRPwp5P+VtQiWtpcXOYdlI+9Rv1qIhkmFnnt9ACDq63vFzQT2Ll5pL2ZvB+n wDmCohzGvWcNwpu6sEu62Xc1j7dmCgnN6qj6P3Y6BiNw266jZrSFtHcQ45geOJiaFlBn 71cYxdBoAMc548KjyvBQeOdjXXAgk9loyKb3+3ZroULfvW21zfasXDrIOLU2VRkQzDc4 +uiS/Z47zeVgs4gACJGuCNakkXMn/Mr2LTr0ljZIRzWaKdKzaFC7QPspQKSyiumqHd46 nCyA== X-Gm-Message-State: APf1xPCz5TY0+bqkLk8osAoFNPBSfBO6/EhkNhJ5wpQ9g//aCdH1B+ci c/Jqdtu9IRYiu2ftORqL1xpkGQ== X-Google-Smtp-Source: AH8x227LPR8mNpTJfrgf6fUFBBeAPw2SeG0dOZHjVvrheQBYKQthYpFG1ONda0ehEOp6XWuZGj3SWcrP X-Received: by 10.233.232.139 with SMTP id a133mr2328273qkg.25.1519223520200; Wed, 21 Feb 2018 06:32:00 -0800 (PST) Date: Wed, 21 Feb 2018 15:31:56 +0100 Message-Id: Mime-Version: 1.0 From: p.stephani2@gmail.com Content-Type: text/plain; charset="UTF-8"; format=flowed; delsp=yes X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.5 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.5 (---) emacs -Q -batch --eval=3D'(progn (princ (rx (group (or "aaa" "bbb")))) (ter= pri))' =3D=3D> \(\(?:aaa\|bbb\)\) This should generate \(aaa\|bbb\) instead. Of course, these regexes are equivalent, but the second one is easier to read (and maybe faster). In GNU Emacs 27.0.50 (build 16, x86_64-pc-linux-gnu, GTK+ Version 3.22.24) of 2018-02-21 built on localhost Repository revision: d599dce1353ce59d134fcff21cde02c70025253d Windowing system distributor 'The X.Org Foundation', version 11.0.11903000 System Description: Debian GNU/Linux buster/sid Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Configured using: 'configure --without-threads --enable-gcc-warnings=3Dwarn-only --enable-gtk-deprecation-warnings --without-pop --with-mailutils --enable-checking --enable-check-lisp-object-type --with-modules 'CFLAGS=3D-O0 -ggdb3'' Configured features: XPM JPEG TIFF GIF PNG SOUND DBUS GSETTINGS NOTIFY GNUTLS FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 MODULES JSON Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils elec-pair time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 95399 9075) (symbols 48 20247 1) (miscs 40 40 121) (strings 32 28348 1815) (string-bytes 1 757412) (vectors 16 14141) (vector-slots 8 499378 12892) (floats 8 50 67) (intervals 56 223 0) (buffers 992 12)) --=20 Google Germany GmbH Erika-Mann-Stra=C3=9Fe 33 80636 M=C3=BCnchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado If you received this communication by mistake, please don=E2=80=99t forward= it to anyone else (it may contain confidential or privileged information), please erase all copies of it, including all attachments, and please let the sender know it went to the wrong person. Thanks. From unknown Sun Jun 15 01:08:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30568: 27.0.50; `rx' doesn't create optimal regex for (group (or ...)) References: In-Reply-To: Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Dec 2019 19:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30568 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 30568@debbugs.gnu.org Cc: Philipp Received: via spool by 30568-submit@debbugs.gnu.org id=B30568.15762647474304 (code B ref 30568); Fri, 13 Dec 2019 19:20:02 +0000 Received: (at 30568) by debbugs.gnu.org; 13 Dec 2019 19:19:07 +0000 Received: from localhost ([127.0.0.1]:34644 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ifqSw-00017M-Fg for submit@debbugs.gnu.org; Fri, 13 Dec 2019 14:19:06 -0500 Received: from mail222c50.megamailservers.eu ([91.136.10.232]:38244 helo=mail33c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ifqSt-00017A-MD for 30568@debbugs.gnu.org; Fri, 13 Dec 2019 14:19:05 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1576264741; bh=yUr8ui6m/zi1dhe6r9IuShKjR9p8Vr1PWcAkg8TMnpg=; h=From:Subject:Date:Cc:To:From; b=sthwAMaCjCxuBLQXKLszCHvXhL79WJK7HZ3pU0l63oV+KPnBFbZf36YxitRvMjAVl JnNEv5vdtUCHESHp7vrr3GAA/73ymVmWmJI/2n7lRBU3co+0VS6H9NfNhkxi/XePLI k4mkKiGJtptjRMHuynZunFpCuqzu5axm67ZVroHI= Feedback-ID: mattiase@acm.or Received: from stanniol.lan (c-6f4fe655.032-75-73746f71.bbcust.telenor.se [85.230.79.111]) (authenticated bits=0) by mail33c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id xBDJIxeP016479; Fri, 13 Dec 2019 19:19:01 +0000 From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Message-Id: <7A6967D6-3859-4703-9223-E3CDFD8C2AA4@acm.org> Date: Fri, 13 Dec 2019 20:18:58 +0100 X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B0213.5DF3E425.0037, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=ccisUULM c=1 sm=1 tr=0 a=fHaj9vQUQVKQ4sUldAaXuQ==:117 a=fHaj9vQUQVKQ4sUldAaXuQ==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=EgUkj9Yi6kjxZbZ2bVkA:9 a=CjuIK1q_8ugA:10 a=pHzHmUro8NiASowvMSCR:22 a=Ew2E2A-JSTLzCXPT_086:22 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) > (rx (group (or "aaa" "bbb"))) > =3D=3D> \(\(?:aaa\|bbb\)\) > > This should generate \(aaa\|bbb\) instead. Of course, these regexes = are > equivalent, but the second one is easier to read (and maybe faster). This remains unchanged, I'm afraid, despite rx being completely = rewritten. Not that it matters much: brackets do not generate any regexp = bytecode, thus matching performance isn't affected once the regexp has = been compiled. When the brackets are required, there is no waste: (rx (+ (or "aaa" "bbb")))=20 =3D> "\\(?:aaa\\|bbb\\)+" Still, it's a bit untidy, and I like that you reported it. We could add = a special value for the PAREN argument to regexp-opt to prevent = bracketing altogether, I suppose. It isn't immediately on my to-do list, = however.