GNU bug report logs - #30559
26.0.91; grep-use-null-filename-separator customization

Previous Next

Package: emacs;

Reported by: Juri Linkov <juri <at> linkov.net>

Date: Tue, 20 Feb 2018 21:37:01 UTC

Severity: normal

Tags: fixed

Found in version 26.0.91

Fixed in version 26.1

Done: Juri Linkov <juri <at> linkov.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30559 in the body.
You can then email your comments to 30559 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#30559; Package emacs. (Tue, 20 Feb 2018 21:37:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Juri Linkov <juri <at> linkov.net>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Tue, 20 Feb 2018 21:37:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.91; grep-use-null-filename-separator customization
Date: Tue, 20 Feb 2018 23:04:06 +0200
This is a request to push the patch to the emacs-26 release branch.

Recipe:
1. ‘M-x customize-variable RET grep-use-null-filename-separator RET’
2. Select a non-default value
3. ‘C-x C-s’

Customizing and saving the new defcustom ‘grep-use-null-filename-separator’
fails because ‘grep-host-defaults-alist’ is missing from the second
‘add-to-list’:

diff --git a/lisp/progmodes/grep.el b/lisp/progmodes/grep.el
index 14e251e..755c9c7 100644
--- a/lisp/progmodes/grep.el
+++ b/lisp/progmodes/grep.el
@@ -734,6 +734,8 @@ grep-compute-defaults
 	     (grep-use-null-device ,grep-use-null-device)
 	     (grep-find-command ,grep-find-command)
 	     (grep-find-template ,grep-find-template)
+	     (grep-use-null-filename-separator
+	      ,grep-use-null-filename-separator)
 	     (grep-find-use-xargs ,grep-find-use-xargs)
 	     (grep-highlight-matches ,grep-highlight-matches))))))
 




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#30559; Package emacs. (Wed, 21 Feb 2018 03:41:02 GMT) Full text and rfc822 format available.

Message #8 received at 30559 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 30559 <at> debbugs.gnu.org
Subject: Re: bug#30559: 26.0.91; grep-use-null-filename-separator customization
Date: Wed, 21 Feb 2018 05:40:58 +0200
> From: Juri Linkov <juri <at> linkov.net>
> Date: Tue, 20 Feb 2018 23:04:06 +0200
> 
> This is a request to push the patch to the emacs-26 release branch.

OK.




Added tag(s) fixed. Request was from Juri Linkov <juri <at> linkov.net> to control <at> debbugs.gnu.org. (Wed, 21 Feb 2018 20:32:04 GMT) Full text and rfc822 format available.

bug marked as fixed in version 26.1, send any further explanations to 30559 <at> debbugs.gnu.org and Juri Linkov <juri <at> linkov.net> Request was from Juri Linkov <juri <at> linkov.net> to control <at> debbugs.gnu.org. (Wed, 21 Feb 2018 20:32:04 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#30559; Package emacs. (Thu, 01 Mar 2018 22:52:01 GMT) Full text and rfc822 format available.

Message #15 received at 30559 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 30559 <at> debbugs.gnu.org
Subject: Re: bug#30559: 26.0.91; grep-use-null-filename-separator customization
Date: Fri, 02 Mar 2018 00:45:27 +0200
>> This is a request to push the patch to the emacs-26 release branch.
>
> OK.

Sorry, I forgot to do the same for zrgrep.  I already noticed earlier
that grep-use-null-filename-separator let-binding is missing here,
but forgot to test this to affirm the necessity to fix zrgrep too.
So this fix is needed for the release branch.

Eli, is it OK to push this patch to emacs-26 as well?

diff --git a/lisp/progmodes/grep.el b/lisp/progmodes/grep.el
index 755c9c7..9b6ebee 100644
--- a/lisp/progmodes/grep.el
+++ b/lisp/progmodes/grep.el
@@ -1184,6 +1184,7 @@ zrgrep
 	   ;; by `grep-compute-defaults'.
 	   (grep-find-template nil)
 	   (grep-find-command nil)
+	   (grep-use-null-filename-separator nil)
 	   (grep-host-defaults-alist nil)
 	   ;; Use for `grep-read-files'
 	   (grep-files-aliases '(("all" . "* .*")




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#30559; Package emacs. (Fri, 02 Mar 2018 08:26:01 GMT) Full text and rfc822 format available.

Message #18 received at 30559 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 30559 <at> debbugs.gnu.org
Subject: Re: bug#30559: 26.0.91; grep-use-null-filename-separator customization
Date: Fri, 02 Mar 2018 10:26:00 +0200
> From: Juri Linkov <juri <at> linkov.net>
> Cc: 30559 <at> debbugs.gnu.org
> Date: Fri, 02 Mar 2018 00:45:27 +0200
> 
> Sorry, I forgot to do the same for zrgrep.  I already noticed earlier
> that grep-use-null-filename-separator let-binding is missing here,
> but forgot to test this to affirm the necessity to fix zrgrep too.
> So this fix is needed for the release branch.
> 
> Eli, is it OK to push this patch to emacs-26 as well?
> 
> diff --git a/lisp/progmodes/grep.el b/lisp/progmodes/grep.el
> index 755c9c7..9b6ebee 100644
> --- a/lisp/progmodes/grep.el
> +++ b/lisp/progmodes/grep.el
> @@ -1184,6 +1184,7 @@ zrgrep
>  	   ;; by `grep-compute-defaults'.
>  	   (grep-find-template nil)
>  	   (grep-find-command nil)
> +	   (grep-use-null-filename-separator nil)
>  	   (grep-host-defaults-alist nil)
>  	   ;; Use for `grep-read-files'
>  	   (grep-files-aliases '(("all" . "* .*")

Yes, but please add a comment there explaining why this is done.  (And
AFAIU, our auto-detect stuff needs fixing, if it must be overridden
like that.)

Thanks.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 30 Mar 2018 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 7 years and 134 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.