GNU bug report logs - #30557
25.2; rendering of label elements in shr

Previous Next

Package: emacs;

Reported by: Alex Schroeder <kensanata <at> gmail.com>

Date: Tue, 20 Feb 2018 21:20:02 UTC

Severity: minor

Tags: fixed

Found in version 25.2

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30557 in the body.
You can then email your comments to 30557 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#30557; Package emacs. (Tue, 20 Feb 2018 21:20:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Alex Schroeder <kensanata <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Tue, 20 Feb 2018 21:20:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alex Schroeder <kensanata <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.2; rendering of label elements in shr
Date: Tue, 20 Feb 2018 22:19:19 +0100

Hi all

When using eww to browse alexschroeder.ch, I noticed the paragraph
break between the labels and the input fields at the top the page and I
think the way shr handles label elements is wrong.

This is what the master branch has:

(defun shr-tag-label (dom)
  (shr-generic dom)
  (shr-ensure-paragraph))

I think it should be:

(defun shr-tag-label (dom)
  (shr-generic dom))

What do you think?

Cheers
Alex
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#30557; Package emacs. (Thu, 12 Apr 2018 23:52:02 GMT) Full text and rfc822 format available.

Message #8 received at 30557 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Alex Schroeder <kensanata <at> gmail.com>
Cc: 30557 <at> debbugs.gnu.org
Subject: Re: bug#30557: 25.2; rendering of label elements in shr
Date: Fri, 13 Apr 2018 01:51:24 +0200

Alex Schroeder <kensanata <at> gmail.com> writes:

> This is what the master branch has:
>
> (defun shr-tag-label (dom)
>   (shr-generic dom)
>   (shr-ensure-paragraph))
>
> I think it should be:
>
> (defun shr-tag-label (dom)
>   (shr-generic dom))
>
> What do you think?

Yup.  I've now done something similar in Emacs 27.1.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Thu, 12 Apr 2018 23:52:02 GMT) Full text and rfc822 format available.
bug closed, send any further explanations to 30557 <at> debbugs.gnu.org and Alex Schroeder <kensanata <at> gmail.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Thu, 12 Apr 2018 23:52:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 11 May 2018 11:24:10 GMT) Full text and rfc822 format available.
This bug report was last modified 7 years and 44 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.