GNU bug report logs - #30554
[PATCH] gnu: mlt: Fix compilation against glibc 2.26.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30554 in the body.
You can then email your comments to 30554 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>
Subject: [PATCH] gnu: mlt: Fix compilation against glibc 2.26.
Date: Tue, 20 Feb 2018 21:45:41 +0300

* gnu/packages/video.scm (mlt)[source](snippet, modules): New fields.
---
 gnu/packages/video.scm | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 1f6a5ea33..38b762469 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1737,7 +1737,12 @@ from sites like Twitch.tv and pipes them into a video player of choice.")
               (file-name (string-append name "-" version ".tar.gz"))
               (sha256
                (base32
-                "10m3ry0b2pvqx3bk34qh5dq337nn8pkc2gzfyhsj4nv9abskln47"))))
+                "10m3ry0b2pvqx3bk34qh5dq337nn8pkc2gzfyhsj4nv9abskln47"))
+              (modules '((guix build utils)))
+              (snippet
+               ;; As of glibc 2.26, <xlocale.h> no longer is.
+               '(substitute* "src/framework/mlt_property.h"
+                  (("xlocale\\.h") "locale.h")))))
     (build-system gnu-build-system)
     (arguments
      `(#:tests? #f ; no tests
-- 
2.16.1

Message #8 received at 30554 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Oleg Pykhalov <go.wigust <at> gmail.com>, 30554 <at> debbugs.gnu.org
Subject: Re: [bug#30554] [PATCH] gnu: mlt: Fix compilation against glibc 2.26.
Date: Thu, 22 Feb 2018 15:04:40 +0100

[Message part 1 (text/plain, inline)]

Oleg Pykhalov <go.wigust <at> gmail.com> writes:

> * gnu/packages/video.scm (mlt)[source](snippet, modules): New fields.
> ---
>  gnu/packages/video.scm | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> index 1f6a5ea33..38b762469 100644
> --- a/gnu/packages/video.scm
> +++ b/gnu/packages/video.scm
> @@ -1737,7 +1737,12 @@ from sites like Twitch.tv and pipes them into a video player of choice.")
>                (file-name (string-append name "-" version ".tar.gz"))
>                (sha256
>                 (base32
> -                "10m3ry0b2pvqx3bk34qh5dq337nn8pkc2gzfyhsj4nv9abskln47"))))
> +                "10m3ry0b2pvqx3bk34qh5dq337nn8pkc2gzfyhsj4nv9abskln47"))
> +              (modules '((guix build utils)))
> +              (snippet
> +               ;; As of glibc 2.26, <xlocale.h> no longer is.
> +               '(substitute* "src/framework/mlt_property.h"
> +                  (("xlocale\\.h") "locale.h")))))

LGTM.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 30554 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 30554-done <at> debbugs.gnu.org, 30554 <at> debbugs.gnu.org
Subject: Re: [bug#30554] [PATCH] gnu: mlt: Fix compilation against glibc 2.26.
Date: Thu, 22 Feb 2018 21:46:42 +0300

[Message part 1 (text/plain, inline)]

Marius Bakke <mbakke <at> fastmail.com> writes:

> Oleg Pykhalov <go.wigust <at> gmail.com> writes:
>
>> * gnu/packages/video.scm (mlt)[source](snippet, modules): New fields.
>> ---
>>  gnu/packages/video.scm | 7 ++++++-
>>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> LGTM.

Pushed as fd7da5b9e383405d2f4655396550dd23f9ed7262

I'll close the bug report.

Thanks,
Oleg.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.