GNU bug report logs - #30547
Hurd patch for `patch` does not apply to latest release

Previous Next

Full log

View this message in rfc822 format

From: Manolis Ragkousis <manolis837 <at> gmail.com>
To: leo <at> famulari.name, 30547 <at> debbugs.gnu.org
Subject: bug#30547: Hurd patch for `patch` does not apply to latest release
Date: Tue, 20 Feb 2018 17:31:50 +0200

[Message part 1 (text/plain, inline)]

Hello Leo,

On 02/20/18 14:20, Leo Famulari wrote:
> There is a new version of GNU Patch, 2.7.6:
> 
> https://ftp.gnu.org/gnu/patch/
> 
> I noticed that our patch, 'patch-hurd-path-max.patch', doesn't apply. I
> have an idea of how to adapt the patch, but I don't really have a way to
> test it.
> 
> Manolis, are you able to adapt the patch to Patch 2.7.6?
> 

I rebased the patch on the latest patch master. The only thing I am not
sure is why the old patch was changing PATH_MAX with tost->st_size + 1.
I can't remember for the life of me. Also I can't remember why this
patch isn't part of patch upstream yet.

The old diff

-      char *buffer = xmalloc (PATH_MAX);
+      char *buffer = xmalloc (tost->st_size + 1);

while now I made it:
-      char *buffer = xmalloc (PATH_MAX + 1);
+      char *buffer = xmalloc (tost->st_size + 2);

Anyhow it should work now, can you try it?

Thank you!
Manolis

[patch-hurd-path-max.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.