From unknown Mon Jun 23 02:23:18 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#30494 <30494@debbugs.gnu.org> To: bug#30494 <30494@debbugs.gnu.org> Subject: Status: 25.2; (setting-constant nil) error in sql.el Reply-To: bug#30494 <30494@debbugs.gnu.org> Date: Mon, 23 Jun 2025 09:23:18 +0000 retitle 30494 25.2; (setting-constant nil) error in sql.el reassign 30494 emacs submitter 30494 sciamano@yandex.ru severity 30494 normal tag 30494 confirmed easy thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 16 17:01:01 2018 Received: (at submit) by debbugs.gnu.org; 16 Feb 2018 22:01:01 +0000 Received: from localhost ([127.0.0.1]:47306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emo3x-0007SR-JW for submit@debbugs.gnu.org; Fri, 16 Feb 2018 17:01:01 -0500 Received: from eggs.gnu.org ([208.118.235.92]:49122) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emnw4-0007FX-El for submit@debbugs.gnu.org; Fri, 16 Feb 2018 16:52:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emnvy-0005Nb-Gv for submit@debbugs.gnu.org; Fri, 16 Feb 2018 16:52:47 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:35203) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1emnvy-0005NT-Cb for submit@debbugs.gnu.org; Fri, 16 Feb 2018 16:52:46 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40091) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emnvx-0005MY-Cs for bug-gnu-emacs@gnu.org; Fri, 16 Feb 2018 16:52:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emnvw-0005Mu-MU for bug-gnu-emacs@gnu.org; Fri, 16 Feb 2018 16:52:45 -0500 Received: from forward104o.mail.yandex.net ([2a02:6b8:0:1a2d::607]:40887) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1emnvw-0005M8-84 for bug-gnu-emacs@gnu.org; Fri, 16 Feb 2018 16:52:44 -0500 Received: from mxback9j.mail.yandex.net (mxback9j.mail.yandex.net [IPv6:2a02:6b8:0:1619::112]) by forward104o.mail.yandex.net (Yandex) with ESMTP id 9A5B370122D for ; Sat, 17 Feb 2018 00:52:30 +0300 (MSK) Received: from smtp1p.mail.yandex.net (smtp1p.mail.yandex.net [2a02:6b8:0:1472:2741:0:8b6:6]) by mxback9j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id beyx7A2XSc-qUXa8wha; Sat, 17 Feb 2018 00:52:30 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1518817950; bh=GW5bhblz4r80Etvis+q2VrpW6Ey0VL6NoSnvNwUKpO0=; h=Date:From:To:Subject:Message-ID; b=VoXkDP+JPbaOMGIjsJ/o5od8kGp7HzSMtK3EUiZ61DB8E+C3BBhDDQ1BOfzcghtBn BvCy8PmMpg47ght9kTYvVqaXJ07M2OZ+3ogS5Us8ndyPuSyLRVf3BX3RSjmbuHxlCG PaUk+oSpxhBSweKljftm/8XFb2iGZH/opp+fQ8E4= Received: by smtp1p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id YN6uVG50GT-qTvSWtoa; Sat, 17 Feb 2018 00:52:29 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1518817949; bh=GW5bhblz4r80Etvis+q2VrpW6Ey0VL6NoSnvNwUKpO0=; h=Date:From:To:Subject:Message-ID; b=Qq5LGXioFGRv+kqicUF6A8doweKleDQFwFZbn9SG8zRJWOLwtqeodi3ktt+SXCyRh z9/bIxv7+sLsaECL0Bp4sDyUf3F2rzyVx0QBHai8u92aaBaChZRDoZlV5wXEhsQi26 j6AYiUaQM2Y0RpDq9Cp3LnZ6OY+FPPNDujLP8FSQ= Authentication-Results: smtp1p.mail.yandex.net; dkim=pass header.i=@yandex.ru Date: Fri, 16 Feb 2018 22:52:28 +0100 From: sciamano@yandex.ru To: bug-gnu-emacs@gnu.org Subject: 25.2; (setting-constant nil) error in sql.el Message-ID: <20180216214220.GA29493@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.9.3 (2018-01-21) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 16 Feb 2018 17:01:01 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Hi, i'm trying to add SQL product by following steps from the introduction section in the sql.el, but for the settings :sqli-program :sqli-login :sqli-options it fails with "attemt to set a constant symbol: nil" In 'emacs -Q' executing it step-by-step: (require 'sql) (sql-add-product 'xyz "XyzDB" '(:free-software t)) (defcustom my-sql-xyz-program "ixyz" "Command to start ixyz by XyzDB." :type 'file :group 'SQL) ;; NEXT STEP FAILS WITH: ;; Debugger entered--Lisp error: (setting-constant nil) ;; sql-set-product-feature(xyz :sqli-program my-sql-xyz-program) ;; eval((sql-set-product-feature (quote xyz) :sqli-program (quote my-sql-xyz-program)) nil) (sql-set-product-feature 'xyz :sqli-program 'my-sql-xyz-program) ;; BUT THIS TWO ARE OK (sql-set-product-feature 'xyz :prompt-regexp "^xyzdb> ") (sql-set-product-feature 'xyz :prompt-length 7) -- Denis From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 08 20:18:58 2018 Received: (at 30494) by debbugs.gnu.org; 9 Mar 2018 01:18:58 +0000 Received: from localhost ([127.0.0.1]:51633 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eu6gU-0006ax-70 for submit@debbugs.gnu.org; Thu, 08 Mar 2018 20:18:58 -0500 Received: from mail-it0-f42.google.com ([209.85.214.42]:55426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eu6gS-0006aa-8L; Thu, 08 Mar 2018 20:18:56 -0500 Received: by mail-it0-f42.google.com with SMTP id n136so873605itg.5; Thu, 08 Mar 2018 17:18:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=nKtgAteWKzOnL0HvenA0czObBGfn2gWoNJH5neJ9OmU=; b=Zx6vPzuWeAfijvTVzmRJu3BApnMvcYI/3+Ymju7yWLZobEdHepUhNy2QvUqvpPCZny uYcjVlm97K2wYXXUjvxZsNGMg5GO9uaH+ZmfFTpfYlndMadqXbXlYjUH+J25ZL5HEdmz iE5xessK8iRAgm62IoiYDGGMSB+pu85FL6t3S3ONDnviMdTIByNqlCsCFsGfN3FrfvRC 2dQGK3W+JLoBDJe912m8oXFOOOV+J/kyMyOHNdDk0YZBZcQJS8Y1t0VBxf3BArj+pFCt FExeL3QiMpl+DcGpo12mw3PD0hHH2dR+UeFPETq1uR2Q/6cBWWbwyaAzsO2+c7+/OknQ mgTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=nKtgAteWKzOnL0HvenA0czObBGfn2gWoNJH5neJ9OmU=; b=DoRzzH8sBnHYSqX6BT5rv5BkFLFezA7cF1ZhxnU+MJQ1CprnYmVKxh2RXxxpQOAFV0 gIEkB5ZyuozIavXraeUrIz8ehmXqRgJnvWoonW7AbKYJigFhpLfB5odmGOA/FC+fWTWI cqaL/X1EKFjbNyd6pWQYThWeWKRthzIEYSKXOpAU79MJCafo+x/J8C4KxxWBF5plNJX7 INF84rqmgVRLRBX6kUPuI9E6B0nXCnENOtLxX9NvcQwmXPQ9eFfYqvoYPnVSH/IG32rT 0t4TyuT0oAwI9g5DuoHVoTjOoeNUC5Kshl71D3H6//CTrw8ufFz+yPjaLYhZF3N59NVY Wetw== X-Gm-Message-State: AElRT7EUaHhNgN5TspOTM6gRsCuzJfZMDJASXwM2j5A1e4zWiOa/cn0y TR7moLqAzfm64GQLQJiW/jbe4A== X-Google-Smtp-Source: AG47ELtBZHwBN6fqvsiQ3qfkFdIo2VG+9Nuz8JBwVwlHo9z0fg3/fhaLEEb5W78LWblorfrFbd6Xkg== X-Received: by 10.36.22.200 with SMTP id a191mr1230468ita.102.1520558330807; Thu, 08 Mar 2018 17:18:50 -0800 (PST) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id 199-v6sm691208itl.1.2018.03.08.17.18.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Mar 2018 17:18:50 -0800 (PST) From: Noam Postavsky To: sciamano@yandex.ru Subject: Re: bug#30494: 25.2; (setting-constant nil) error in sql.el References: <20180216214220.GA29493@localhost> Date: Thu, 08 Mar 2018 20:18:48 -0500 In-Reply-To: <20180216214220.GA29493@localhost> (sciamano's message of "Fri, 16 Feb 2018 22:52:28 +0100") Message-ID: <87d10e11xj.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30494 Cc: 30494@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) tags 30494 + confirmed easy quit sciamano@yandex.ru writes: > In 'emacs -Q' executing it step-by-step: > > (require 'sql) > > (sql-add-product 'xyz "XyzDB" > '(:free-software t)) > > (defcustom my-sql-xyz-program "ixyz" > "Command to start ixyz by XyzDB." > :type 'file > :group 'SQL) > > ;; NEXT STEP FAILS WITH: > ;; Debugger entered--Lisp error: (setting-constant nil) > ;; sql-set-product-feature(xyz :sqli-program my-sql-xyz-program) > ;; eval((sql-set-product-feature (quote xyz) :sqli-program (quote my-sql-xyz-program)) nil) > (sql-set-product-feature 'xyz > :sqli-program 'my-sql-xyz-program) Looks like it's probably just a missing nil check in sql-set-product-feature. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 30 19:30:35 2018 Received: (at 30494) by debbugs.gnu.org; 1 Dec 2018 00:30:35 +0000 Received: from localhost ([127.0.0.1]:56700 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gStB5-00057G-4T for submit@debbugs.gnu.org; Fri, 30 Nov 2018 19:30:35 -0500 Received: from smtp3-g21.free.fr ([212.27.42.3]:47210) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gStB3-000576-PJ for 30494@debbugs.gnu.org; Fri, 30 Nov 2018 19:30:34 -0500 Received: from killashandra.ballybran.fr.free.fr (unknown [IPv6:2a01:e35:2e14:eab0:d4dc:72c5:daba:b8ca]) by smtp3-g21.free.fr (Postfix) with ESMTPS id 7BF2F13F86E; Sat, 1 Dec 2018 01:30:29 +0100 (CET) From: pierre.techoueyres@free.fr (Pierre =?utf-8?Q?T=C3=A9choueyres?=) To: Noam Postavsky Subject: Re: bug#30494: 25.2; (setting-constant nil) error in sql.el References: <20180216214220.GA29493@localhost> <87d10e11xj.fsf@gmail.com> Date: Sat, 01 Dec 2018 01:30:29 +0100 In-Reply-To: <87d10e11xj.fsf@gmail.com> (Noam Postavsky's message of "Thu, 08 Mar 2018 20:18:48 -0500") Message-ID: <87pnumccm2.fsf@killashandra.ballybran.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30494 Cc: sciamano@yandex.ru, 30494@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Noam Postavsky writes: > tags 30494 + confirmed easy > quit > > sciamano@yandex.ru writes: > >> In 'emacs -Q' executing it step-by-step: >> >> (require 'sql) >> >> (sql-add-product 'xyz "XyzDB" >> '(:free-software t)) >> >> (defcustom my-sql-xyz-program "ixyz" >> "Command to start ixyz by XyzDB." >> :type 'file >> :group 'SQL) >> >> ;; NEXT STEP FAILS WITH: >> ;; Debugger entered--Lisp error: (setting-constant nil) >> ;; sql-set-product-feature(xyz :sqli-program my-sql-xyz-program) >> ;; eval((sql-set-product-feature (quote xyz) :sqli-program (quote my-sql-xyz-program)) nil) >> (sql-set-product-feature 'xyz >> :sqli-program 'my-sql-xyz-program) > > Looks like it's probably just a missing nil check in > sql-set-product-feature. > Does the attached patch do the trick ? --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Check-that-feature-exist-in-sql-set-product-feature-.patch Content-Description: Fix bug30494 >From fc0ee63bb0cadb054260ea74d310720ac3068f15 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre=20T=C3=A9choueyres?= Date: Sat, 1 Dec 2018 01:20:45 +0100 Subject: [PATCH] Check that feature exist in `sql-set-product-feature' (Bug#30494). * lisp/progmodes/sql.el: add check for feature existence. --- lisp/progmodes/sql.el | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lisp/progmodes/sql.el b/lisp/progmodes/sql.el index e7d7494d2c..9051a6ad07 100644 --- a/lisp/progmodes/sql.el +++ b/lisp/progmodes/sql.el @@ -2533,13 +2533,17 @@ sql-set-product-feature (let* ((p (assoc product sql-product-alist)) (v (plist-get (cdr p) feature))) - (if p + (if (and p v) (if (and (member feature sql-indirect-features) (symbolp v)) (set v newvalue) (setcdr p (plist-put (cdr p) feature newvalue))) - (error "`%s' is not a known product; use `sql-add-product' to add it first." product)))) + (progn + (when (null p) + (error "`%s' is not a known product; use `sql-add-product' to add it first." product)) + (when (null v) + (error "`%s' is not a known feature for `%s'; use `sql-add-product' to add it first." feature product)))))) (defun sql-get-product-feature (product feature &optional fallback not-indirect) "Lookup FEATURE associated with a SQL PRODUCT. -- 2.19.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 13 14:40:45 2018 Received: (at 30494) by debbugs.gnu.org; 13 Dec 2018 19:40:46 +0000 Received: from localhost ([127.0.0.1]:46751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXWqj-0007ql-ML for submit@debbugs.gnu.org; Thu, 13 Dec 2018 14:40:45 -0500 Received: from smtp3-g21.free.fr ([212.27.42.3]:40842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXWqi-0007qe-8e for 30494@debbugs.gnu.org; Thu, 13 Dec 2018 14:40:44 -0500 Received: from killashandra.ballybran.fr.free.fr (unknown [IPv6:2a01:e35:2e14:eab0:d4dc:72c5:daba:b8ca]) by smtp3-g21.free.fr (Postfix) with ESMTPS id EE0B413F89C; Thu, 13 Dec 2018 20:40:40 +0100 (CET) From: pierre.techoueyres@free.fr (Pierre =?utf-8?Q?T=C3=A9choueyres?=) To: Noam Postavsky Subject: Re: bug#30494: 25.2; (setting-constant nil) error in sql.el References: <20180216214220.GA29493@localhost> <87d10e11xj.fsf@gmail.com> <87pnumccm2.fsf@killashandra.ballybran.fr> Date: Thu, 13 Dec 2018 20:40:40 +0100 In-Reply-To: <87pnumccm2.fsf@killashandra.ballybran.fr> ("Pierre \=\?utf-8\?Q\?T\=C3\=A9choueyres\=22's\?\= message of "Sat, 01 Dec 2018 01:30:29 +0100") Message-ID: <875zvx8bbb.fsf@killashandra.ballybran.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30494 Cc: sciamano@yandex.ru, 30494@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) pierre.techoueyres@free.fr (Pierre T=C3=A9choueyres) writes: > Noam Postavsky writes: > >> tags 30494 + confirmed easy >> quit >> >> sciamano@yandex.ru writes: >> >>> In 'emacs -Q' executing it step-by-step: >>> >>> (require 'sql) >>> >>> (sql-add-product 'xyz "XyzDB" >>> '(:free-software t)) >>> >>> (defcustom my-sql-xyz-program "ixyz" >>> "Command to start ixyz by XyzDB." >>> :type 'file >>> :group 'SQL) >>> >>> ;; NEXT STEP FAILS WITH: >>> ;; Debugger entered--Lisp error: (setting-constant nil) >>> ;; sql-set-product-feature(xyz :sqli-program my-sql-xyz-program) >>> ;; eval((sql-set-product-feature (quote xyz) :sqli-program (quote my-s= ql-xyz-program)) nil) >>> (sql-set-product-feature 'xyz >>> :sqli-program 'my-sql-xyz-program) >> >> Looks like it's probably just a missing nil check in >> sql-set-product-feature. >> > > Does the attached patch do the trick ? > Any interrest on this ? From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 23 14:51:50 2018 Received: (at 30494) by debbugs.gnu.org; 23 Dec 2018 19:51:50 +0000 Received: from localhost ([127.0.0.1]:34053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gb9mw-0001sg-Cr for submit@debbugs.gnu.org; Sun, 23 Dec 2018 14:51:50 -0500 Received: from smtp4-g21.free.fr ([212.27.42.4]:27904) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gb9mv-0001sZ-0q for 30494@debbugs.gnu.org; Sun, 23 Dec 2018 14:51:49 -0500 Received: from killashandra.ballybran.fr.free.fr (unknown [IPv6:2a01:e0a:1e2:f8b0:9cc3:35bf:aa81:ccf7]) by smtp4-g21.free.fr (Postfix) with ESMTPS id 97A6B19F57E; Sun, 23 Dec 2018 20:51:44 +0100 (CET) From: pierre.techoueyres@free.fr (Pierre =?utf-8?Q?T=C3=A9choueyres?=) To: Noam Postavsky Subject: Re: bug#30494: 25.2; (setting-constant nil) error in sql.el References: <20180216214220.GA29493@localhost> <87d10e11xj.fsf@gmail.com> <87pnumccm2.fsf@killashandra.ballybran.fr> <875zvx8bbb.fsf@killashandra.ballybran.fr> Date: Sun, 23 Dec 2018 20:51:44 +0100 In-Reply-To: <875zvx8bbb.fsf@killashandra.ballybran.fr> ("Pierre \=\?utf-8\?Q\?T\=C3\=A9choueyres\=22's\?\= message of "Thu, 13 Dec 2018 20:40:40 +0100") Message-ID: <87bm5cnhrj.fsf@killashandra.ballybran.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30494 Cc: sciamano@yandex.ru, eliz@gnu.org, 30494@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) pierre.techoueyres@free.fr (Pierre T=C3=A9choueyres) writes: > pierre.techoueyres@free.fr (Pierre T=C3=A9choueyres) writes: > >> Noam Postavsky writes: >> >>> tags 30494 + confirmed easy >>> quit >>> >>> sciamano@yandex.ru writes: >>> >>>> In 'emacs -Q' executing it step-by-step: >>>> >>>> (require 'sql) >>>> >>>> (sql-add-product 'xyz "XyzDB" >>>> '(:free-software t)) >>>> >>>> (defcustom my-sql-xyz-program "ixyz" >>>> "Command to start ixyz by XyzDB." >>>> :type 'file >>>> :group 'SQL) >>>> >>>> ;; NEXT STEP FAILS WITH: >>>> ;; Debugger entered--Lisp error: (setting-constant nil) >>>> ;; sql-set-product-feature(xyz :sqli-program my-sql-xyz-program) >>>> ;; eval((sql-set-product-feature (quote xyz) :sqli-program (quote my-= sql-xyz-program)) nil) >>>> (sql-set-product-feature 'xyz >>>> :sqli-program 'my-sql-xyz-program) >>> >>> Looks like it's probably just a missing nil check in >>> sql-set-product-feature. >>> >> >> Does the attached patch do the trick ? >> > Any interrest on this ? Ping ! Or if this isn't desired, maybe it's time to close the bug ? From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 08 17:00:13 2019 Received: (at 30494) by debbugs.gnu.org; 8 Jan 2019 22:00:13 +0000 Received: from localhost ([127.0.0.1]:50593 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggzPx-000485-9L for submit@debbugs.gnu.org; Tue, 08 Jan 2019 17:00:13 -0500 Received: from smtp4-g21.free.fr ([212.27.42.4]:52968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggzPv-00047r-1B for 30494@debbugs.gnu.org; Tue, 08 Jan 2019 17:00:11 -0500 Received: from killashandra.ballybran.fr.free.fr (unknown [IPv6:2a01:e0a:1e2:f8b0:9cc3:35bf:aa81:ccf7]) by smtp4-g21.free.fr (Postfix) with ESMTPS id ACE1319F5CE; Tue, 8 Jan 2019 23:00:06 +0100 (CET) From: pierre.techoueyres@free.fr (Pierre =?utf-8?Q?T=C3=A9choueyres?=) To: Noam Postavsky Subject: Re: bug#30494: 25.2; (setting-constant nil) error in sql.el References: <20180216214220.GA29493@localhost> <87d10e11xj.fsf@gmail.com> <87pnumccm2.fsf@killashandra.ballybran.fr> <875zvx8bbb.fsf@killashandra.ballybran.fr> <87bm5cnhrj.fsf@killashandra.ballybran.fr> Date: Tue, 08 Jan 2019 23:00:06 +0100 In-Reply-To: <87bm5cnhrj.fsf@killashandra.ballybran.fr> ("Pierre \=\?utf-8\?Q\?T\=C3\=A9choueyres\=22's\?\= message of "Sun, 23 Dec 2018 20:51:44 +0100") Message-ID: <87lg3u24k9.fsf@killashandra.ballybran.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30494 Cc: sciamano@yandex.ru, 30494@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) pierre.techoueyres@free.fr (Pierre T=C3=A9choueyres) writes: > pierre.techoueyres@free.fr (Pierre T=C3=A9choueyres) writes: > >> pierre.techoueyres@free.fr (Pierre T=C3=A9choueyres) writes: >> >>> Noam Postavsky writes: >>> >>>> tags 30494 + confirmed easy >>>> quit >>>> >>>> sciamano@yandex.ru writes: >>>> >>>>> In 'emacs -Q' executing it step-by-step: >>>>> >>>>> (require 'sql) >>>>> >>>>> (sql-add-product 'xyz "XyzDB" >>>>> '(:free-software t)) >>>>> >>>>> (defcustom my-sql-xyz-program "ixyz" >>>>> "Command to start ixyz by XyzDB." >>>>> :type 'file >>>>> :group 'SQL) >>>>> >>>>> ;; NEXT STEP FAILS WITH: >>>>> ;; Debugger entered--Lisp error: (setting-constant nil) >>>>> ;; sql-set-product-feature(xyz :sqli-program my-sql-xyz-program) >>>>> ;; eval((sql-set-product-feature (quote xyz) :sqli-program (quote my= -sql-xyz-program)) nil) >>>>> (sql-set-product-feature 'xyz >>>>> :sqli-program 'my-sql-xyz-program) >>>> >>>> Looks like it's probably just a missing nil check in >>>> sql-set-product-feature. >>>> >>> >>> Does the attached patch do the trick ? >>> >> Any interrest on this ? > > Ping ! Or if this isn't desired, maybe it's time to close the bug ? Ping ! Ping ! From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 12 06:35:46 2019 Received: (at 30494-done) by debbugs.gnu.org; 12 Jan 2019 11:35:46 +0000 Received: from localhost ([127.0.0.1]:56572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1giHZq-0003Qu-7r for submit@debbugs.gnu.org; Sat, 12 Jan 2019 06:35:46 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37139) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1giHZo-0003Qg-Mr for 30494-done@debbugs.gnu.org; Sat, 12 Jan 2019 06:35:45 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36132) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1giHZi-0004DY-Kq; Sat, 12 Jan 2019 06:35:38 -0500 Received: from [176.228.60.248] (port=1675 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1giHZe-0001Sb-Ew; Sat, 12 Jan 2019 06:35:36 -0500 Date: Sat, 12 Jan 2019 13:35:14 +0200 Message-Id: <83k1jaf6rx.fsf@gnu.org> From: Eli Zaretskii To: pierre.techoueyres@free.fr (Pierre =?utf-8?Q?T=C3=A9choueyres?=) In-reply-to: <87lg3u24k9.fsf@killashandra.ballybran.fr> (pierre.techoueyres@free.fr) Subject: Re: bug#30494: 25.2; (setting-constant nil) error in sql.el References: <20180216214220.GA29493@localhost> <87d10e11xj.fsf@gmail.com> <87pnumccm2.fsf@killashandra.ballybran.fr> <875zvx8bbb.fsf@killashandra.ballybran.fr> <87bm5cnhrj.fsf@killashandra.ballybran.fr> <87lg3u24k9.fsf@killashandra.ballybran.fr> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30494-done Cc: sciamano@yandex.ru, npostavs@gmail.com, 30494-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: pierre.techoueyres@free.fr (Pierre Téchoueyres) > Date: Tue, 08 Jan 2019 23:00:06 +0100 > Cc: sciamano@yandex.ru, 30494@debbugs.gnu.org > > >>>> Looks like it's probably just a missing nil check in > >>>> sql-set-product-feature. > >>>> > >>> > >>> Does the attached patch do the trick ? > >>> > >> Any interrest on this ? > > > > Ping ! Or if this isn't desired, maybe it's time to close the bug ? > > Ping ! Ping ! Sorry for lack of replies so far. I've now pushed these changes to the master branch, and I'm closing the bug report. In the future, please be sure to state in the log message the function(s) where you make changes. From unknown Mon Jun 23 02:23:18 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 09 Feb 2019 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator