Subject: bug#30494: 25.2; (setting-constant nil) error in sql.el

From: [email-masked] (Pierre Téchoueyres)
Date: Sun, 23 Dec 2018 20:51:44 +0100

[email-masked] (Pierre Téchoueyres) writes:

> [email-masked] (Pierre Téchoueyres) writes:
>
>> Noam Postavsky <[email-masked]> writes:
>>
>>> tags 30494 + confirmed easy
>>> quit
>>>
>>> [email-masked] writes:
>>>
>>>> In 'emacs -Q' executing it step-by-step:
>>>>
>>>> (require 'sql)
>>>>
>>>> (sql-add-product 'xyz "XyzDB"
>>>>                  '(:free-software t))
>>>>
>>>> (defcustom my-sql-xyz-program "ixyz"
>>>>   "Command to start ixyz by XyzDB."
>>>>   :type 'file
>>>>   :group 'SQL)
>>>>
>>>> ;; NEXT STEP FAILS WITH:
>>>> ;; Debugger entered--Lisp error: (setting-constant nil)
>>>> ;;  sql-set-product-feature(xyz :sqli-program my-sql-xyz-program)
>>>> ;;  eval((sql-set-product-feature (quote xyz) :sqli-program (quote my-sql-xyz-program)) nil)
>>>> (sql-set-product-feature 'xyz
>>>>                          :sqli-program 'my-sql-xyz-program)
>>>
>>> Looks like it's probably just a missing nil check in
>>> sql-set-product-feature.
>>>
>>
>> Does the attached patch do the trick ?
>>
> Any interrest on this ?

Ping ! Or if this isn't desired, maybe it's time to close the bug ?