GNU bug report logs - #30489
26.0.91; [PATCH] Data associated with json-readtable-error not a list

Previous Next

Full log

Message #23 received at 30489 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: 30489 <at> debbugs.gnu.org
Subject: Re: bug#30489: 26.0.91;
 [PATCH] Data associated with json-readtable-error not a list
Date: Sun, 18 Mar 2018 00:14:13 +0000

[0001-Pass-json-readtable-error-data-as-a-list-bug-30489.patch (text/x-diff, attachment)]

[Message part 2 (text/plain, inline)]

Noam Postavsky <npostavs <at> gmail.com> writes:

> "Basil L. Contovounesios" <contovob <at> tcd.ie> writes:
>
>> @@ -685,7 +685,7 @@ json-readtable-dispatch
>>        (push (list c 'json-read-number) table))
>>      (pcase-dolist (`(,c . ,rest) table)
>>        (push `((eq ,char ,c) (,@rest)) res))
>> -    `(cond ,@res (t (signal 'json-readtable-error ,char)))))
>> +    `(cond ,@res (t (signal 'json-readtable-error ,(list char))))))
>
> Actually, shouldn't this be (list ,char)?
>
> Otherwise, I get this warning when compiling:
>
> In end of data:
> ../../lisp/json.el:766:1:Warning: the function ‘char’ is not known to be
>     defined.

Right you are; thanks for catching this embarrassing macro mistake.

I attach an updated patch including your fix and the bug number.

Thanks again,

-- 
Basil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.