GNU bug report logs - #30489
26.0.91; [PATCH] Data associated with json-readtable-error not a list

Previous Next

Full log

Message #14 received at 30489 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: contovob <at> tcd.ie, 30489 <at> debbugs.gnu.org
Subject: Re: bug#30489: 26.0.91;
 [PATCH] Data associated with json-readtable-error not a list
Date: Fri, 16 Mar 2018 05:52:06 -0400

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Noam Postavsky <npostavs <at> gmail.com>
>> Date: Thu, 15 Mar 2018 22:39:18 -0400
>> Cc: 30489 <at> debbugs.gnu.org
>> 
>> "Basil L. Contovounesios" <contovob <at> tcd.ie> writes:
>> 
>> > -    `(cond ,@res (t (signal 'json-readtable-error ,char)))))
>> > +    `(cond ,@res (t (signal 'json-readtable-error ,(list char))))))
>> 
>> > When signalling json-readtable-error, the macro json-readtable-dispatch
>> > passes the unrecognised character as error data verbatim, rather than as
>> > a list.  Attached is a patch which fixes this.
>> 
>> Should this be applied to emacs-26?  It seems to fix a regression
>> relative to Emacs 25 (where this error just had `nil' as the data) and
>> the patch looks safe enough.
>
> What change(s) introduced the regression?

[1: 9314e6c56e]: 2017-09-04 03:40:30 -0400
  Embed JSON readtable into json-read
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=9314e6c56e248a5060a6c125e2088c4fbffe123b

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.