From unknown Sat Jun 21 02:55:41 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#30489 <30489@debbugs.gnu.org> To: bug#30489 <30489@debbugs.gnu.org> Subject: Status: 26.0.91; [PATCH] Data associated with json-readtable-error not a list Reply-To: bug#30489 <30489@debbugs.gnu.org> Date: Sat, 21 Jun 2025 09:55:41 +0000 retitle 30489 26.0.91; [PATCH] Data associated with json-readtable-error no= t a list reassign 30489 emacs submitter 30489 "Basil L. Contovounesios" severity 30489 normal tag 30489 fixed patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 16 12:30:05 2018 Received: (at submit) by debbugs.gnu.org; 16 Feb 2018 17:30:05 +0000 Received: from localhost ([127.0.0.1]:47154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emjpl-0000ku-Hp for submit@debbugs.gnu.org; Fri, 16 Feb 2018 12:30:05 -0500 Received: from eggs.gnu.org ([208.118.235.92]:52250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emjpj-0000jv-7Q for submit@debbugs.gnu.org; Fri, 16 Feb 2018 12:30:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emjpd-000857-2G for submit@debbugs.gnu.org; Fri, 16 Feb 2018 12:29:57 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:54059) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1emjpc-00084x-To for submit@debbugs.gnu.org; Fri, 16 Feb 2018 12:29:56 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43220) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emjpb-0002pZ-Pn for bug-gnu-emacs@gnu.org; Fri, 16 Feb 2018 12:29:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emjpY-00082T-Mv for bug-gnu-emacs@gnu.org; Fri, 16 Feb 2018 12:29:55 -0500 Received: from mail-wm0-x229.google.com ([2a00:1450:400c:c09::229]:37448) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1emjpY-00081B-EA for bug-gnu-emacs@gnu.org; Fri, 16 Feb 2018 12:29:52 -0500 Received: by mail-wm0-x229.google.com with SMTP id v71so4436275wmv.2 for ; Fri, 16 Feb 2018 09:29:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:mime-version; bh=EI9TF2CruaKLkZeRMvA3l1U5WZ8hoydhrrpM0dXiTWw=; b=fuXEPVCIPY2E6ke2k532RnNoUS0dP3JQTJzWeml26BQRNBkDF9REnmOrLiH6gtsysE kySY+lf7C87UCPtK8MeXTU6VOdB+GN+D85CsadCeExgExF+0Z1HslI2eEAh7QU0qvR9f cn13SdcE2EfP+zgoKWA9Or2hH47dr+5USKmTrPqeYESRPJGwpsl9moZkN18ujxkQYr/O E3CaThIz+ZbMgojubF8OnlkA5cSZQ8zh63FKz0xugkkF7FvoBfNPeISpmYC7N67f5yrn hrg4dzzaEyrVRmMtJcGAQTPtI+lflpYe02cGWeAaBFXCJ7FbIrZaZT9Tjb4FzCHGmMzA CZgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=EI9TF2CruaKLkZeRMvA3l1U5WZ8hoydhrrpM0dXiTWw=; b=NEAX3KJ+ZtCqXrSmMxV/UvoBhJIqFAUCAutq6n8BdT8j5OQ4H0PshVhyVsJ2H/+df7 ZEYXSuDPqiWNizxPO/al8KeIPtUlwqw2Th81GEyA8XPMBdxUY4nPPnencBBlOd83Mwas h1Jy/8wO5VnnTMH8F0PSd6FzXHsEFlVd+28/MNE/g3ekqMxR1DydPVOB2OzDbYrfOuBS byA7cZG8FHKE27twTSjMy9IbdcEYeWAUBFt9tH0ukyc0EM3yp1Pt9Ha1lndBmDxzoie7 tyipjM4v63w2QoD904jzjp/xamn5C1SvRpPdRZMSvTW0FmK7cqHCXjU6u6aLXMgmEF73 ZZmA== X-Gm-Message-State: APf1xPAzkvk+iXlmbRzRsxfUMAMwzYYDJjRGcmIbFzJTKLbV2wwiWU0L +wRJywVHKEenAgJoCuKy1vbEWIJT X-Google-Smtp-Source: AH8x2261kZ8/vNQRcjqBwuywInN2zoZTIAuMKE650MFBcYPd6QW9KvoNEirpmsAKLC7sAvlF6kym5g== X-Received: by 10.80.168.227 with SMTP id k90mr8955682edc.249.1518802189995; Fri, 16 Feb 2018 09:29:49 -0800 (PST) Received: from localhost ([213.233.149.9]) by smtp.gmail.com with ESMTPSA id s26sm12643528eds.49.2018.02.16.09.29.48 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 16 Feb 2018 09:29:48 -0800 (PST) From: "Basil L. Contovounesios" To: bug-gnu-emacs@gnu.org Subject: 26.0.91; [PATCH] Data associated with json-readtable-error not a list Date: Fri, 16 Feb 2018 17:29:43 +0000 Message-ID: <87sha09720.fsf@tcd.ie> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-lisp-json.el-json-readtable-dispatch-Fix-error-data.patch >From d297d156fec4d141c6287d3da4e7aa538280b43e Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Fri, 16 Feb 2018 17:11:49 +0000 Subject: [PATCH] * lisp/json.el (json-readtable-dispatch): Fix error data --- lisp/json.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/json.el b/lisp/json.el index b03a482ca6..b3267df6e5 100644 --- a/lisp/json.el +++ b/lisp/json.el @@ -685,7 +685,7 @@ json-readtable-dispatch (push (list c 'json-read-number) table)) (pcase-dolist (`(,c . ,rest) table) (push `((eq ,char ,c) (,@rest)) res)) - `(cond ,@res (t (signal 'json-readtable-error ,char))))) + `(cond ,@res (t (signal 'json-readtable-error ,(list char)))))) (defun json-read () "Parse and return the JSON object following point. -- 2.15.1 --=-=-= Content-Type: text/plain When signalling json-readtable-error, the macro json-readtable-dispatch passes the unrecognised character as error data verbatim, rather than as a list. Attached is a patch which fixes this. Thanks, -- Basil In GNU Emacs 26.0.91 (build 3, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2018-02-16 built on thunk Repository revision: edc06adf96f4aa9d8b707181015acfe61d396edb Windowing system distributor 'The X.Org Foundation', version 11.0.11906000 System Description: Debian GNU/Linux testing (buster) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 15 22:39:27 2018 Received: (at 30489) by debbugs.gnu.org; 16 Mar 2018 02:39:27 +0000 Received: from localhost ([127.0.0.1]:35584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewfHD-00058Y-Jr for submit@debbugs.gnu.org; Thu, 15 Mar 2018 22:39:27 -0400 Received: from mail-io0-f175.google.com ([209.85.223.175]:33364) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewfHB-00058L-NE for 30489@debbugs.gnu.org; Thu, 15 Mar 2018 22:39:26 -0400 Received: by mail-io0-f175.google.com with SMTP id f1so10959906iob.0 for <30489@debbugs.gnu.org>; Thu, 15 Mar 2018 19:39:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=kHNroVNLKw0wUwnEUrs5qjjvIvz0x98my5Pwu3f9yOs=; b=ipNrT/+833PLSX70X4eDnqUWAYbeVUWhXqx4i8wTeeQ/ABxckxw+Qkixxq9LPYHNzY XkLzCrVtn1cahginPGBC9DNzUFF8EAZSmRG0Ty/DuMAqipSpmPvBM5vpRttvCQHYfQLK bmP1JOKlQX2TlaS0arwmrV8b6JW4UZZchGEhktQHY40MI8m1IO5S8K++s7AYpTGBaLid FxsJ0Z47Vcyz/GVTLAOA5ctnyrmq+/dM/fW2BRXCq/gB5apYeOL6pqAjrpYPF1z+/DHP 7rPLVCwwZDp1TEJOsUCFKWa1EstOi2GJA2/ySJnNIvPCmv7Wspkhcjs7ytYQOn8RE3RL YLeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=kHNroVNLKw0wUwnEUrs5qjjvIvz0x98my5Pwu3f9yOs=; b=pM8qkpHrN9Xp1UV95jllkj0sifM3662l7T3X1DIpxXtv16l1az5rJadx+sMBrU8QJ0 HEv6JKH6y0LW3UvCfwX94CqdWPGIbtxJJ11H7eB1jsK1pjlDk0sXefkdZzIV7BoWPnjV 8Q2RzCc9eqOBMNcJOirwFZHge+s5NPCl6L1YSYcLGpRPoPWC2LXat6UR8hadvF86TIru qodnBa40t8YzwREtNqdKjVk3blrZckAZE759GqmZuZQ6Tl+wDOeDhoB89GnuXPQGhigQ TuHvXlbztQZMot2vFkFDOP3t7rVMXX+TgUbAYx6KXvUUD2YTiIt9etzUrFP0Q2RMWVft bmdg== X-Gm-Message-State: AElRT7HeelPx17b2Hyj3Pev0JRiTVBwe4Gb0wbToTAbtgUTwd16D3utF DCmNpArHlFQIISG63sApibN4qQ== X-Google-Smtp-Source: AG47ELvk2esmnygPVYS7upuUALVHFbq+kaA8djfDdqZ9hyODGk7BrQ2pEXgkxsOkX5dO7HkMN0X8EA== X-Received: by 10.107.52.146 with SMTP id b140mr116678ioa.8.1521167960114; Thu, 15 Mar 2018 19:39:20 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id v1-v6sm242207ita.4.2018.03.15.19.39.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 15 Mar 2018 19:39:19 -0700 (PDT) From: Noam Postavsky To: "Basil L. Contovounesios" Subject: Re: bug#30489: 26.0.91; [PATCH] Data associated with json-readtable-error not a list References: <87sha09720.fsf@tcd.ie> Date: Thu, 15 Mar 2018 22:39:18 -0400 In-Reply-To: <87sha09720.fsf@tcd.ie> (Basil L. Contovounesios's message of "Fri, 16 Feb 2018 17:29:43 +0000") Message-ID: <874llgwxpl.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30489 Cc: 30489@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) "Basil L. Contovounesios" writes: > - `(cond ,@res (t (signal 'json-readtable-error ,char))))) > + `(cond ,@res (t (signal 'json-readtable-error ,(list char)))))) > When signalling json-readtable-error, the macro json-readtable-dispatch > passes the unrecognised character as error data verbatim, rather than as > a list. Attached is a patch which fixes this. Should this be applied to emacs-26? It seems to fix a regression relative to Emacs 25 (where this error just had `nil' as the data) and the patch looks safe enough. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 15 23:37:02 2018 Received: (at 30489) by debbugs.gnu.org; 16 Mar 2018 03:37:02 +0000 Received: from localhost ([127.0.0.1]:35607 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewgAv-0008O0-Tg for submit@debbugs.gnu.org; Thu, 15 Mar 2018 23:37:02 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewgAv-0008Nj-8z for 30489@debbugs.gnu.org; Thu, 15 Mar 2018 23:37:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ewgAm-0002UH-PE for 30489@debbugs.gnu.org; Thu, 15 Mar 2018 23:36:55 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34863) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewgAm-0002U7-LH; Thu, 15 Mar 2018 23:36:52 -0400 Received: from [176.228.60.248] (port=4302 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ewgAm-0007il-3y; Thu, 15 Mar 2018 23:36:52 -0400 Date: Fri, 16 Mar 2018 05:36:52 +0200 Message-Id: <83woycpu7f.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: <874llgwxpl.fsf@gmail.com> (message from Noam Postavsky on Thu, 15 Mar 2018 22:39:18 -0400) Subject: Re: bug#30489: 26.0.91; [PATCH] Data associated with json-readtable-error not a list References: <87sha09720.fsf@tcd.ie> <874llgwxpl.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30489 Cc: contovob@tcd.ie, 30489@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Noam Postavsky > Date: Thu, 15 Mar 2018 22:39:18 -0400 > Cc: 30489@debbugs.gnu.org > > "Basil L. Contovounesios" writes: > > > - `(cond ,@res (t (signal 'json-readtable-error ,char))))) > > + `(cond ,@res (t (signal 'json-readtable-error ,(list char)))))) > > > When signalling json-readtable-error, the macro json-readtable-dispatch > > passes the unrecognised character as error data verbatim, rather than as > > a list. Attached is a patch which fixes this. > > Should this be applied to emacs-26? It seems to fix a regression > relative to Emacs 25 (where this error just had `nil' as the data) and > the patch looks safe enough. What change(s) introduced the regression? From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 16 05:52:17 2018 Received: (at 30489) by debbugs.gnu.org; 16 Mar 2018 09:52:17 +0000 Received: from localhost ([127.0.0.1]:35728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewm25-000300-1l for submit@debbugs.gnu.org; Fri, 16 Mar 2018 05:52:17 -0400 Received: from mail-io0-f177.google.com ([209.85.223.177]:35193) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewm23-0002zf-1V for 30489@debbugs.gnu.org; Fri, 16 Mar 2018 05:52:15 -0400 Received: by mail-io0-f177.google.com with SMTP id e7so1482339iof.2 for <30489@debbugs.gnu.org>; Fri, 16 Mar 2018 02:52:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=qgrs2FCVVfvmVB6FGt2WM2UBfjNSRlef5ra3nIRW0ew=; b=YDkKsQfs75NqeIASo0LXSWO33s/8YjE2ayTJOP8yH2e2xe3jv10MujlP2pnoiXfERs HLwnogAzpl8CTwL+UyETQsbEQnkfzj1gejGxExDumlB4LeTKEaJDLwezm/EB6T5IHGMZ 7oQ3yf/dMyHDYqfp5qghYhfYyKxgaM0kgVuUpbEnv9vir+FinwwYwClzRa8XFBQBgJaX ueF4IIz8uJq3h5stX3BUlvBlNZwYQfD61O3wzb4vJNfY7asuxmd5NmuCz2zVELInEQAl P5WTxG3pxwc7C6cYmOHzeaz3HYxDu2SjCCdD6QtvFbl92EW9BtUSPNCb0+8LYMrjzCBN 7pqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=qgrs2FCVVfvmVB6FGt2WM2UBfjNSRlef5ra3nIRW0ew=; b=sN21SmiAYdkDC1V5jyveE44BNZoYkXu1qh0rrQCfhuGhupMPG1GYjjw4AU8jK9CzC6 i3/PdvBfxeHGr2Yk1i/wYyI+Wi+Utf4QaW/V7zjmHOCxwsAW7faltWPutiOd9BAk9WTj MZmk0L0rLSn+Y64sEkWlNNp0ZeAZiDXgCaV7oB3O349UeC78ivrYpTDP5EPUvOBI0lHZ pzQgb5Zh/b2ycQUDDMGzOISBhSdVKr/0Db1Ylmv5ioQgVLFcCLKTF5TLcmFxYwW3xdOR JO9O20W2xF40y/A4TJt/Ncn1pTB3OpGUopH+y2OagyS1mB7eRO+FQMOouKiawn1juh8h KTKg== X-Gm-Message-State: AElRT7FYa9caIbmq7sZxgEsCJLa/0/CPbVvMx2e+TWIvm5VSf7zJ4BDy S3DLX49ukavcpcuub5oZW3IfUA== X-Google-Smtp-Source: AG47ELuVI3apxvPdfZd8KW2L0WrV/luyMXvUeLbrEgP9EQgT64R5wryiaLsulK0dytwE2P3IB+KDJQ== X-Received: by 10.107.11.198 with SMTP id 67mr1065091iol.43.1521193929053; Fri, 16 Mar 2018 02:52:09 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id n74sm4473457itc.8.2018.03.16.02.52.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 16 Mar 2018 02:52:07 -0700 (PDT) From: Noam Postavsky To: Eli Zaretskii Subject: Re: bug#30489: 26.0.91; [PATCH] Data associated with json-readtable-error not a list References: <87sha09720.fsf@tcd.ie> <874llgwxpl.fsf@gmail.com> <83woycpu7f.fsf@gnu.org> Date: Fri, 16 Mar 2018 05:52:06 -0400 In-Reply-To: <83woycpu7f.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 16 Mar 2018 05:36:52 +0200") Message-ID: <87y3isuz3t.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30489 Cc: contovob@tcd.ie, 30489@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Eli Zaretskii writes: >> From: Noam Postavsky >> Date: Thu, 15 Mar 2018 22:39:18 -0400 >> Cc: 30489@debbugs.gnu.org >> >> "Basil L. Contovounesios" writes: >> >> > - `(cond ,@res (t (signal 'json-readtable-error ,char))))) >> > + `(cond ,@res (t (signal 'json-readtable-error ,(list char)))))) >> >> > When signalling json-readtable-error, the macro json-readtable-dispatch >> > passes the unrecognised character as error data verbatim, rather than as >> > a list. Attached is a patch which fixes this. >> >> Should this be applied to emacs-26? It seems to fix a regression >> relative to Emacs 25 (where this error just had `nil' as the data) and >> the patch looks safe enough. > > What change(s) introduced the regression? [1: 9314e6c56e]: 2017-09-04 03:40:30 -0400 Embed JSON readtable into json-read https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=9314e6c56e248a5060a6c125e2088c4fbffe123b From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 16 10:07:12 2018 Received: (at 30489) by debbugs.gnu.org; 16 Mar 2018 14:07:12 +0000 Received: from localhost ([127.0.0.1]:36973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewq0l-0004y9-UQ for submit@debbugs.gnu.org; Fri, 16 Mar 2018 10:07:12 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38070) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewq0k-0004xp-VG for 30489@debbugs.gnu.org; Fri, 16 Mar 2018 10:07:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ewq0b-0006BB-8b for 30489@debbugs.gnu.org; Fri, 16 Mar 2018 10:07:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54583) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewq0b-0006B7-5W; Fri, 16 Mar 2018 10:07:01 -0400 Received: from [176.228.60.248] (port=4680 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ewq0a-0007Dd-Li; Fri, 16 Mar 2018 10:07:01 -0400 Date: Fri, 16 Mar 2018 16:07:01 +0200 Message-Id: <83r2okp116.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: <87y3isuz3t.fsf@gmail.com> (message from Noam Postavsky on Fri, 16 Mar 2018 05:52:06 -0400) Subject: Re: bug#30489: 26.0.91; [PATCH] Data associated with json-readtable-error not a list References: <87sha09720.fsf@tcd.ie> <874llgwxpl.fsf@gmail.com> <83woycpu7f.fsf@gnu.org> <87y3isuz3t.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30489 Cc: contovob@tcd.ie, 30489@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Noam Postavsky > Cc: contovob@tcd.ie, 30489@debbugs.gnu.org > Date: Fri, 16 Mar 2018 05:52:06 -0400 > > >> > - `(cond ,@res (t (signal 'json-readtable-error ,char))))) > >> > + `(cond ,@res (t (signal 'json-readtable-error ,(list char)))))) > >> > >> > When signalling json-readtable-error, the macro json-readtable-dispatch > >> > passes the unrecognised character as error data verbatim, rather than as > >> > a list. Attached is a patch which fixes this. > >> > >> Should this be applied to emacs-26? It seems to fix a regression > >> relative to Emacs 25 (where this error just had `nil' as the data) and > >> the patch looks safe enough. > > > > What change(s) introduced the regression? > > [1: 9314e6c56e]: 2017-09-04 03:40:30 -0400 > Embed JSON readtable into json-read > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=9314e6c56e248a5060a6c125e2088c4fbffe123b Thanks, then the patch in question is OK for the release branch. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 16 19:47:29 2018 Received: (at 30489) by debbugs.gnu.org; 16 Mar 2018 23:47:29 +0000 Received: from localhost ([127.0.0.1]:37396 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewz4L-0006Am-N0 for submit@debbugs.gnu.org; Fri, 16 Mar 2018 19:47:29 -0400 Received: from mail-it0-f50.google.com ([209.85.214.50]:50944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewz4J-0006AW-7w for 30489@debbugs.gnu.org; Fri, 16 Mar 2018 19:47:28 -0400 Received: by mail-it0-f50.google.com with SMTP id d13-v6so4015783itf.0 for <30489@debbugs.gnu.org>; Fri, 16 Mar 2018 16:47:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=EFzb9IHsfr0IFWtrGLpvQQ1k08kjaRjdYD+p3vy56qA=; b=uf1PdsC6Q9ZXqJcaMjV2+ncnCYor/t996TaQXTqxiz/v2mhEPyh1ijwCDE9j7BW+jR kz4yVoLrREalrXD4hHZqMQ4+uNwJQoHXvYfIf8Xjl8leLiI9dwhQyYl/kKlNP/xDNMma R45ONfRYAq3rrldOzwQvcx+Ouv0ixIOO7RuvjkbQqD60RWiYf5A6Cf/bYtNyLpM2bfNf 7iL72o3Awz6nO/c98YBDW3qCOlgstIvgbk+dGXISi+kQk+TG5mWJfl0DnrIGcOpdePNs MDS3Ksduyu/D95uW0cZFawL6oxkr5ZDzRCVpjcCTwaIhFYisQe+P1gLZjW9jr/39j1ue 706g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=EFzb9IHsfr0IFWtrGLpvQQ1k08kjaRjdYD+p3vy56qA=; b=pV8ykAbgQNC+Ars8XwAdDsiKGMCy+S+z1967jH/pGh7veoOGoJVE7QnnnJmdPbfz0n 1JN9YHUqIH+8OGlmqkYTQqydMiA9YHLYHRKc1okeqNfuMHpoS39oUrpbI4KSOMD3YvEz E8w1H6hBABNj1lSTCWK5PsAhcbB1LvqRUZDqHEYaHXxCeGkUD7LvXZWmsVIDQISaalN5 E+S5wjXPJx2iPwMjpBl3odQLV+8FkxUtLWnug0YZRMP2bW3vAafpNlUEYLz0TyG/EpPT 7lX7xXmlqVhcO9s0H0MQmLhmT8QxHItiwuPG8tSTPLA2G/CTCH490Iikj1qIrsKj6WSe b0Tw== X-Gm-Message-State: AElRT7GRnJQTtCyiJ0VYphU/kNxR6ZCCqfKX2H68sQTJe8OLvxpJa3B3 LBxNJEY7H0qDF4NSCJg6ZV8AHQ== X-Google-Smtp-Source: AG47ELt23mCOrY61iRhnNw7jBHGYm2SzL85UEXfaEibdTglLIyG+xo2Esyy7lhjNwKrPHIRMcIKmdw== X-Received: by 2002:a24:5781:: with SMTP id u123-v6mr4056130ita.92.1521244041536; Fri, 16 Mar 2018 16:47:21 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id y134sm5516112iod.10.2018.03.16.16.47.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 16 Mar 2018 16:47:20 -0700 (PDT) From: Noam Postavsky To: "Basil L. Contovounesios" Subject: Re: bug#30489: 26.0.91; [PATCH] Data associated with json-readtable-error not a list References: <87sha09720.fsf@tcd.ie> Date: Fri, 16 Mar 2018 19:47:18 -0400 In-Reply-To: <87sha09720.fsf@tcd.ie> (Basil L. Contovounesios's message of "Fri, 16 Feb 2018 17:29:43 +0000") Message-ID: <87vadvvb09.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 30489 Cc: 30489@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) "Basil L. Contovounesios" writes: > @@ -685,7 +685,7 @@ json-readtable-dispatch > (push (list c 'json-read-number) table)) > (pcase-dolist (`(,c . ,rest) table) > (push `((eq ,char ,c) (,@rest)) res)) > - `(cond ,@res (t (signal 'json-readtable-error ,char))))) > + `(cond ,@res (t (signal 'json-readtable-error ,(list char)))))) Actually, shouldn't this be (list ,char)? Otherwise, I get this warning when compiling: In end of data: ../../lisp/json.el:766:1:Warning: the function =E2=80=98char=E2=80=99 is no= t known to be defined. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 17 20:14:23 2018 Received: (at 30489) by debbugs.gnu.org; 18 Mar 2018 00:14:23 +0000 Received: from localhost ([127.0.0.1]:38866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exLxu-0001Fc-QA for submit@debbugs.gnu.org; Sat, 17 Mar 2018 20:14:22 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:53704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exLxt-0001FO-AQ for 30489@debbugs.gnu.org; Sat, 17 Mar 2018 20:14:22 -0400 Received: by mail-wm0-f41.google.com with SMTP id e194so9292375wmd.3 for <30489@debbugs.gnu.org>; Sat, 17 Mar 2018 17:14:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=5FmhQt15Lw+ABQkV50pGJtNQEEPf7Rk206QW1mFJ/A0=; b=KTCehDAnXA0WvaVZ5DIGWjULjEVQanr7DTqSQugoTZplVU+lJecP4TwF7526Zup87o XBiEX45IIKSAFxgnYjbsnZ/Wh68x5vMboRta3u6qHVAUrNS/F9FZEtg3s7q545zAp+iw CBzFQm3wYND7KDmoILIcyTJMPJLvj8HxMuQ0Ny8ppCph68O36qle5IVxKO2dKSA9D4WP n/AqvAsVS9uJci7g2uuLdoogCvRwbmhGyIBNHZDFP6kDDCyXQtg9xbscJshzSSxl9UEN 1GpHh8dTzp8l1+hWQ7YZUjFLbO5y3zm8ZjYXWJXW0rElX/mmiPFKqCEKJgAJ4m4dWHQV IAWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=5FmhQt15Lw+ABQkV50pGJtNQEEPf7Rk206QW1mFJ/A0=; b=Y9bThHOtXK3YY5TpoD7CdqkecexyrnxJt5SDjHfM80uxIg6DwNfkhkt74r5qb1C7Ux +InxdZEzC6KEAdMq/oILSZgTc5d7mJfvK5+S9Ymv3IkHPv7gHoC94Oe4Bv4rzUQSAizk 70N6lxb94KzLMgqAM3FRYTCiVQkgqeLJV3GzCY0A0E5MMBRoCYxVHu6Zh2cB+SKJCGGu PPKEtRkZOW7sBMU7HWn338oZNHlimATJofPOH6T1paKF1di8/FQdLcfRweryerxv0svW FVdLEjva5C1/xfHIHsPpdI7l/RWZBq71m4Wwpk9S5+3zrZH6gnoI2lZWlRgrv/s/0VVz 8hAQ== X-Gm-Message-State: AElRT7HI5atGJS3xZxX0qPurUycPN2UTlZj9m/J1w/1p3lx91ZK9t3et 2GXuvM4zzjy/ix/yb9Gy/f6tvw== X-Google-Smtp-Source: AG47ELu2QcmzFmNskrzCTKSJWHYxesm48mrHLgJeyuYdoWZ1a3l7s2WXb+llrLEuBjM59op8rIYcBA== X-Received: by 10.80.173.75 with SMTP id z11mr8143207edc.306.1521332055324; Sat, 17 Mar 2018 17:14:15 -0700 (PDT) Received: from localhost ([2a02:8084:4f41:8c80:9c34:da08:a010:edfc]) by smtp.gmail.com with ESMTPSA id m7sm7183172eda.36.2018.03.17.17.14.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 17 Mar 2018 17:14:14 -0700 (PDT) From: "Basil L. Contovounesios" To: Noam Postavsky Subject: Re: bug#30489: 26.0.91; [PATCH] Data associated with json-readtable-error not a list References: <87sha09720.fsf@tcd.ie> <87vadvvb09.fsf@gmail.com> Date: Sun, 18 Mar 2018 00:14:13 +0000 In-Reply-To: <87vadvvb09.fsf@gmail.com> (Noam Postavsky's message of "Fri, 16 Mar 2018 19:47:18 -0400") Message-ID: <87tvte44ve.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30489 Cc: 30489@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Pass-json-readtable-error-data-as-a-list-bug-30489.patch >From b917a7409659dde2ccc836d80741ad5a89d8785c Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Fri, 16 Feb 2018 17:11:49 +0000 Subject: [PATCH] Pass json-readtable-error data as a list (bug#30489) * lisp/json.el (json-readtable-dispatch): Fix error data. --- lisp/json.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/json.el b/lisp/json.el index b03a482ca6..d374f452e6 100644 --- a/lisp/json.el +++ b/lisp/json.el @@ -685,7 +685,7 @@ json-readtable-dispatch (push (list c 'json-read-number) table)) (pcase-dolist (`(,c . ,rest) table) (push `((eq ,char ,c) (,@rest)) res)) - `(cond ,@res (t (signal 'json-readtable-error ,char))))) + `(cond ,@res (t (signal 'json-readtable-error (list ,char)))))) (defun json-read () "Parse and return the JSON object following point. -- 2.16.2 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Noam Postavsky writes: > "Basil L. Contovounesios" writes: > >> @@ -685,7 +685,7 @@ json-readtable-dispatch >> (push (list c 'json-read-number) table)) >> (pcase-dolist (`(,c . ,rest) table) >> (push `((eq ,char ,c) (,@rest)) res)) >> - `(cond ,@res (t (signal 'json-readtable-error ,char))))) >> + `(cond ,@res (t (signal 'json-readtable-error ,(list char)))))) > > Actually, shouldn't this be (list ,char)? > > Otherwise, I get this warning when compiling: > > In end of data: > ../../lisp/json.el:766:1:Warning: the function =E2=80=98char=E2=80=99 is = not known to be > defined. Right you are; thanks for catching this embarrassing macro mistake. I attach an updated patch including your fix and the bug number. Thanks again, --=20 Basil --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 17 20:25:38 2018 Received: (at 30489) by debbugs.gnu.org; 18 Mar 2018 00:25:38 +0000 Received: from localhost ([127.0.0.1]:38870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exM8n-0001VK-T3 for submit@debbugs.gnu.org; Sat, 17 Mar 2018 20:25:38 -0400 Received: from mail-it0-f42.google.com ([209.85.214.42]:51697) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exM8m-0001V8-Lq for 30489@debbugs.gnu.org; Sat, 17 Mar 2018 20:25:36 -0400 Received: by mail-it0-f42.google.com with SMTP id g7-v6so6253898itf.1 for <30489@debbugs.gnu.org>; Sat, 17 Mar 2018 17:25:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=BkmPtPl7og0bYSGvE5HXtSYSPUvKjSQji/PlCIhi7m4=; b=vK16rg41hUj7uuuQHOukoOMOdUDjvLV3tD5kzmraKUKK5g4/OxRqZios5SI16gLi+/ Lth4MhuzQCIUENlOvQV2wod+Wngf7QZ/rugvbYg04q5+9Ui3HCHM7DiqpdzaGUk+5jZb V0Jk2j0gCZ5X2xCSl4kiAxkeAL116BTUQkha4TkabedXTIdixEbgIEmwcwN+aFPMCdIS yXW+e3H3PAyHBXyL7yfoshVct5W1HIyhaujRExWCJDotuxAT7GIO5oiCid2uui09Cl0F p+W/Eq+T5RslR/CdReT90+2f/ObLimfiHjZUkNpU4msUYL+F3rOr6kHSbK0o7LK+5989 pe2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=BkmPtPl7og0bYSGvE5HXtSYSPUvKjSQji/PlCIhi7m4=; b=Ic5SdnrlDfEZRWv6hsm/NnXFLP8vGj+qsbSBJ5pOul6R5hMG1QK4EvUqFwGY2rLGdO gVqMrRU5D5dDP5bCWokOzm4Bz1FWIFZFOWC52sZr8S2q/5Ofw6+vxL/RzpVznvKn6TTA sdA2lOp1gCr97BTvSkyZ3adtSTMaQn0dvwdik5fbpXrTsFCMEi/LH6SpdNa+13RWFkhl d1FWv6xJepSsQddWF/OBH5glNgOf3p+JFIwfQP0/2y9QUTc/eBLySrCr2S7EOKssbSZX qfMaQ28tPsg1kR0NMPaqKivdxoH5up8cco0xxa+FnzQVEODd5X3OvL+tOdNx+lWeyu61 mz6Q== X-Gm-Message-State: AElRT7FCM2S48pV52fe3389pkmxiAYbzFG05ZLUejhqN2Ob6KK9ODAVC HNSmEASdFno/E5WhOkJzFt1XeA== X-Google-Smtp-Source: AG47ELuaSAm3+0P7YOJuMfE9fb6n1s2NXgqYXeD6NzW/uciWlnAZGtyLD6DrRUfO4ahnTr62nVaGow== X-Received: by 2002:a24:dd82:: with SMTP id t124-v6mr7311787itf.2.1521332730865; Sat, 17 Mar 2018 17:25:30 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id k13sm2100234ioc.27.2018.03.17.17.25.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 17 Mar 2018 17:25:30 -0700 (PDT) From: Noam Postavsky To: "Basil L. Contovounesios" Subject: Re: bug#30489: 26.0.91; [PATCH] Data associated with json-readtable-error not a list References: <87sha09720.fsf@tcd.ie> <87vadvvb09.fsf@gmail.com> <87tvte44ve.fsf@tcd.ie> Date: Sat, 17 Mar 2018 20:25:29 -0400 In-Reply-To: <87tvte44ve.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 18 Mar 2018 00:14:13 +0000") Message-ID: <87vadutekm.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30489 Cc: 30489@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) "Basil L. Contovounesios" writes: > I attach an updated patch including your fix and the bug number. Thanks, could you add a regression test for this too, please? Since we've already had two mistakes independently generated, it seems likely we'll make more if this code is updated again. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 18 10:23:41 2018 Received: (at 30489) by debbugs.gnu.org; 18 Mar 2018 14:23:41 +0000 Received: from localhost ([127.0.0.1]:40259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exZDo-0006gI-Sz for submit@debbugs.gnu.org; Sun, 18 Mar 2018 10:23:41 -0400 Received: from mail-wm0-f47.google.com ([74.125.82.47]:34279) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exZDm-0006g1-4n for 30489@debbugs.gnu.org; Sun, 18 Mar 2018 10:23:38 -0400 Received: by mail-wm0-f47.google.com with SMTP id a20so9102358wmd.1 for <30489@debbugs.gnu.org>; Sun, 18 Mar 2018 07:23:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=NXl6SHFWg0M+kK56OozhGR9+vuHeb5/FHKtI4ASpn6E=; b=QTkm2wa0bzP04G24S4YPVJTvMTjFHu+53pM7wa5eYnx5fva0fQV7la352NsEil/6g0 exMLPFHpY2HmIGKll4lYfXkdOPb/FpEX1tPlIofePYPrrb7DnUbgjvj0a4DBX0Wmjmoe HtFSN5yx0Bl+FHDhxDfHYkxC5dEoIS1qy+uMTtQPKfu7HMEy8TLnDKEQRtZAAiCJyP+2 HtPxW4EuA9roHnVx+RCtWU/TsNVb/ogKkhQ6ATia88cAcbBcmZ4puC/rgzwgYzrsJeWd GGnVshWP75/ZTvZiPt4rIoQ93MbJ96lsY/UcMAJoe2mb9gNiqdIcpUO/tAoneweAOYTb kYtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=NXl6SHFWg0M+kK56OozhGR9+vuHeb5/FHKtI4ASpn6E=; b=QH1F5GLOheT46iZm/aAjC23Kp5TlcgxWlMhspvJWf/2D2YtPtg2VUzq1Hlz1aYZEuQ 4tOKshGGtvjigRDV56t1sYMer3my4+I+yhtkpUcQ7tL5rhQM6f8rf6yxKDde7g2AzeKl 1VHtzkGakGfPDKDqkBzs/hAG/V4r5ejA5Mi2Ik1rbHn6htKLuo+sdGoIo3G24LWwNPdu qH2z5TcPWljx7yDJR9LuYH/Lu0xecAKMQ68WNJF6tcP3pTkuTQN+SgI5ZE2YihOrh4v2 UXcvJSNR6j/LgawV6W8owQ4pkDUw3PPmq/t62WKeK6DpK5Y4PGXGALworsmCo49CHgVT L2Sw== X-Gm-Message-State: AElRT7EsRyCSASKMXAlJ9mC3g55dshYGvRAbWZVNnPN8coCP7VKFXsLX 6fzBIgzrRsszASYoUqBVuA3WYQ== X-Google-Smtp-Source: AG47ELscj3UywPEXYnrb6KWJfqpoVOFhZgB/4edAx4q3w5DDzvLZCbYvmJ8xmAcAH2leXUna4dptDg== X-Received: by 10.80.231.18 with SMTP id a18mr10099629edn.240.1521383012157; Sun, 18 Mar 2018 07:23:32 -0700 (PDT) Received: from localhost ([2a02:8084:4f41:8c80:9c34:da08:a010:edfc]) by smtp.gmail.com with ESMTPSA id a63sm5772517ede.76.2018.03.18.07.23.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 18 Mar 2018 07:23:31 -0700 (PDT) From: "Basil L. Contovounesios" To: Noam Postavsky Subject: Re: bug#30489: 26.0.91; [PATCH] Data associated with json-readtable-error not a list References: <87sha09720.fsf@tcd.ie> <87vadvvb09.fsf@gmail.com> <87tvte44ve.fsf@tcd.ie> <87vadutekm.fsf@gmail.com> Date: Sun, 18 Mar 2018 14:23:30 +0000 In-Reply-To: <87vadutekm.fsf@gmail.com> (Noam Postavsky's message of "Sat, 17 Mar 2018 20:25:29 -0400") Message-ID: <87muz5ihst.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30489 Cc: 30489@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Pass-json-readtable-error-data-as-a-list-bug-30489.patch >From bed6240056d6ca8f47c5709fbe7033c490c8738c Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Fri, 16 Feb 2018 17:11:49 +0000 Subject: [PATCH] Pass json-readtable-error data as a list (bug#30489) * lisp/json.el (json-readtable-dispatch): Fix error data. * test/lisp/json-tests.el (test-json-read): Check error data is a list. --- lisp/json.el | 2 +- test/lisp/json-tests.el | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lisp/json.el b/lisp/json.el index b03a482ca6..d374f452e6 100644 --- a/lisp/json.el +++ b/lisp/json.el @@ -685,7 +685,7 @@ json-readtable-dispatch (push (list c 'json-read-number) table)) (pcase-dolist (`(,c . ,rest) table) (push `((eq ,char ,c) (,@rest)) res)) - `(cond ,@res (t (signal 'json-readtable-error ,char))))) + `(cond ,@res (t (signal 'json-readtable-error (list ,char)))))) (defun json-read () "Parse and return the JSON object following point. diff --git a/test/lisp/json-tests.el b/test/lisp/json-tests.el index 47f8047b34..ea562e8b13 100644 --- a/test/lisp/json-tests.el +++ b/test/lisp/json-tests.el @@ -309,7 +309,8 @@ json-tests--with-temp-buffer (json-tests--with-temp-buffer "" (should-error (json-read) :type 'json-end-of-file)) (json-tests--with-temp-buffer "xxx" - (should-error (json-read) :type 'json-readtable-error))) + (let ((err (should-error (json-read) :type 'json-readtable-error))) + (should (equal (cdr err) '(?x)))))) (ert-deftest test-json-read-from-string () (let ((json-string "{ \"a\": 1 }")) -- 2.16.2 --=-=-= Content-Type: text/plain Noam Postavsky writes: > Thanks, could you add a regression test for this too, please? Since > we've already had two mistakes independently generated, it seems likely > we'll make more if this code is updated again. Of course. Is the attached up to scratch? Thanks, -- Basil --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 18 23:14:52 2018 Received: (at 30489) by debbugs.gnu.org; 19 Mar 2018 03:14:52 +0000 Received: from localhost ([127.0.0.1]:40550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exlG8-0007zr-Gq for submit@debbugs.gnu.org; Sun, 18 Mar 2018 23:14:52 -0400 Received: from mail-io0-f180.google.com ([209.85.223.180]:40352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exlG6-0007zY-Oc; Sun, 18 Mar 2018 23:14:51 -0400 Received: by mail-io0-f180.google.com with SMTP id e79so10748590ioi.7; Sun, 18 Mar 2018 20:14:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=jKAGMWuX7a4qSoJelBjWEllx0LE3eC0artkSY5H25Pc=; b=pE6y0v4YUQ60Ule/VlCAynjD9C6Jv8tI+6Lvs/CqiCfNh8i2meNa7k1h5luLIn3Nm9 NU5NgUH7t7tn6gXVpNxHEP3y9vsOHkLzh+AGzG4Pf2ivv33RKostAjP0z1QLveDZR9BJ B6GysuwUggGZkPRZ6lFkVRknsf0V+kZ3H3B5N2bB4mcZSHfEnHRy9SmHCROr5PaWL5cr KmgEDb1pM71D1WWr7G1q2czRqOxVxSvmsoCohT6pZy/KvaxJg9tXRSOFIoyDmjQmxHgZ 1VeIeHX8jp3tNWvTzAEOMX2/gXiLrU9+kPG6RJq8B9u9g7usldGtLS/dJZwWkGxFGCvK AVug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=jKAGMWuX7a4qSoJelBjWEllx0LE3eC0artkSY5H25Pc=; b=bHZw3RJ/mP4eYjK5P0zB0o3T3ecUhUx/xC+yufh/lNNCmEfsD89/GGh03CigF+W+DJ 20AlWC3PDbX//8D1pDrBh7+i9P3lnt4nDxriljJwB0n6qwrzenXI/uvxtAtlcAWAluqg LoK3mo4VhpAYwenZyiEncbEIeSTyKFgqjOHX1bKpQxv4bkUtYSUxMYPfCjih7PT3e0iv 0+noe5csSJRl8cqf/GTAQcQz4a5iCbwJ0Y3R6lgMeoNIDs6x1FkEeCrncrowkgNzPGtq Yg/SsTQoNXqSQmKTM4gigVau3Oyqt4yITuRsaGr+lkQosRGxdRINLiQMwr7OgfZyvkQx mNVw== X-Gm-Message-State: AElRT7HJmsQbPJTVlFsk2R7ZZ823nuBBt5Oh7SNkQUB4otk/KBeZaZiU HFypZX/rYkT1/HYuwnfeZY8fOA== X-Google-Smtp-Source: AG47ELuYQAbpJaK49QSSOHN6cB6ApuPs7obcSGy4wqgcfSY/vRySEDYSQ5XfGaf6qebnN2ssfKmaew== X-Received: by 10.107.102.13 with SMTP id a13mr10248787ioc.61.1521429284882; Sun, 18 Mar 2018 20:14:44 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id f201-v6sm7478589itc.12.2018.03.18.20.14.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 18 Mar 2018 20:14:43 -0700 (PDT) From: Noam Postavsky To: "Basil L. Contovounesios" Subject: Re: bug#30489: 26.0.91; [PATCH] Data associated with json-readtable-error not a list References: <87sha09720.fsf@tcd.ie> <87vadvvb09.fsf@gmail.com> <87tvte44ve.fsf@tcd.ie> <87vadutekm.fsf@gmail.com> <87muz5ihst.fsf@tcd.ie> Date: Sun, 18 Mar 2018 23:14:42 -0400 In-Reply-To: <87muz5ihst.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 18 Mar 2018 14:23:30 +0000") Message-ID: <87muz4u57h.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30489 Cc: 30489@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 30489 fixed close 30489 26.1 quit "Basil L. Contovounesios" writes: > Noam Postavsky writes: > >> Thanks, could you add a regression test for this too, please? Since >> we've already had two mistakes independently generated, it seems likely >> we'll make more if this code is updated again. > > Of course. Is the attached up to scratch? Perfect, pushed to emacs-26. [1: 7f27d42f0b]: 2018-03-18 23:13:29 -0400 Pass json-readtable-error data as a list (bug#30489) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=7f27d42f0b64c74625e45909a0bf389d68eddc62 From unknown Sat Jun 21 02:55:41 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 16 Apr 2018 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator