GNU bug report logs - #30480
[PATCH] environment: Add --manifest option.

Previous Next

Package: guix-patches;

Reported by: "Thompson, David" <dthompson2 <at> worcester.edu>

Date: Fri, 16 Feb 2018 02:14:01 UTC

Severity: normal

Tags: patch

Done: Leo Famulari <leo <at> famulari.name>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Leo Famulari <leo <at> famulari.name>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#30480: closed ([PATCH] environment: Add --manifest option.)
Date: Thu, 22 Feb 2018 06:48:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Thu, 22 Feb 2018 01:47:07 -0500
with message-id <20180222064707.GA25321 <at> jasmine.lan>
and subject line Re: [bug#30480] [PATCH] environment: Add --manifest option.
has caused the debbugs.gnu.org bug report #30480,
regarding [PATCH] environment: Add --manifest option.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
30480: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=30480
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: "Thompson, David" <dthompson2 <at> worcester.edu>
To: guix-patches <at> gnu.org
Subject: [PATCH] environment: Add --manifest option.
Date: Thu, 15 Feb 2018 21:12:58 -0500
[Message part 3 (text/plain, inline)]
In my lurkings I've seen people wondering why `guix environment`
doesn't work with manifests. The answer is simply: I never thought to
add it. This patch fixes that. The implementation is kind of
interesting and might seem a little silly to people that know how
manifests work.  In order to support manifests with minimal code and
make --manifest compose with other options I simply decompile the
manifest back into a list of package/output tuples.  That means in the
case of `guix environment --manifest=foo.scm` the manifest is created,
decompiled, and a new manifest created from that.  Seems redundant!
The advantage is that since --manifest composes with all the other
ways to specify packages we can do absolutely bonkers things like
`guix environment guile --ad-hoc ruby --manifest=foo.scm
--manifest=bar.scm --load=frob.scm --expression='(@ (gnu packages
python) python)'`.  More realistically you'd use it to throw in an
extra package or two with --ad-hoc.

Anyway, hope y'all like it.

- Dave
[0001-environment-Add-manifest-option.patch (text/x-patch, attachment)]
[Message part 5 (message/rfc822, inline)]
From: Leo Famulari <leo <at> famulari.name>
To: "Thompson, David" <dthompson2 <at> worcester.edu>
Cc: 30480-done <at> debbugs.gnu.org,
 Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: [bug#30480] [PATCH] environment: Add --manifest option.
Date: Thu, 22 Feb 2018 01:47:07 -0500
[Message part 6 (text/plain, inline)]
On Wed, Feb 21, 2018 at 10:17:33PM -0500, Thompson, David wrote:
> Pushed.  Do I have to do something special to close this ticket?

I'm closing it by appending -done to the bug number in the email
address.
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 7 years and 176 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.