From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 15 10:27:00 2018 Received: (at submit) by debbugs.gnu.org; 15 Feb 2018 15:27:00 +0000 Received: from localhost ([127.0.0.1]:44978 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emLR5-00080r-Ud for submit@debbugs.gnu.org; Thu, 15 Feb 2018 10:27:00 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39165) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emLR4-00080f-Rv for submit@debbugs.gnu.org; Thu, 15 Feb 2018 10:26:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emLQy-0001iG-G6 for submit@debbugs.gnu.org; Thu, 15 Feb 2018 10:26:53 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58593) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1emLQy-0001iC-Bk for submit@debbugs.gnu.org; Thu, 15 Feb 2018 10:26:52 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58342) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emLQt-0006fr-E1 for guix-patches@gnu.org; Thu, 15 Feb 2018 10:26:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emLQp-0001em-Ed for guix-patches@gnu.org; Thu, 15 Feb 2018 10:26:47 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60965) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emLQi-0001cJ-TE; Thu, 15 Feb 2018 10:26:36 -0500 Received: from [193.50.110.160] (port=60094 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1emLQi-0005Rp-DZ; Thu, 15 Feb 2018 10:26:36 -0500 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: guix-patches@gnu.org Subject: [PATCH 0/1] Require Guile >= 2.0.14 Date: Thu, 15 Feb 2018 16:26:27 +0100 Message-Id: <20180215152627.4695-1-ludo@gnu.org> X-Mailer: git-send-email 2.16.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hello Guix, This patch is to require Guile >= 2.0.14, released one year ago, instead of 2.0.9, released in 2013. For the record, here’s the distro status: • Debian unstable has 2.2: . • Older Debian versions have 2.0.13 (not .14): . • Parabola, Gentoo, Homebrew, openSUSE, Fedora 26+ have 2.0.14 and/or 2.2: . I’d like to have this change in place for the next Guix release, 0.14.1 I presume. I’d also like it to be the last release that support Guile 2.0. Thoughts? Ludo’. Ludovic Courtès (1): build: Require Guile >= 2.0.14. README | 2 +- config-daemon.ac | 5 -- configure.ac | 2 +- doc/guix.texi | 2 +- guix/build/download.scm | 10 +-- guix/build/syscalls.scm | 48 +------------- guix/hash.scm | 3 +- guix/http-client.scm | 154 +------------------------------------------- guix/scripts/substitute.scm | 18 ++---- m4/guix.m4 | 17 ----- tests/hash.scm | 11 +--- 11 files changed, 14 insertions(+), 258 deletions(-) -- 2.16.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 15 10:30:41 2018 Received: (at 30469) by debbugs.gnu.org; 15 Feb 2018 15:30:41 +0000 Received: from localhost ([127.0.0.1]:44985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emLUY-00087r-FF for submit@debbugs.gnu.org; Thu, 15 Feb 2018 10:30:41 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40971) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emLUS-00087a-CU for 30469@debbugs.gnu.org; Thu, 15 Feb 2018 10:30:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emLUH-0004bI-46 for 30469@debbugs.gnu.org; Thu, 15 Feb 2018 10:30:23 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:32854) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emLUB-0004Yy-70; Thu, 15 Feb 2018 10:30:11 -0500 Received: from [193.50.110.160] (port=60176 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1emLUA-0002YE-MB; Thu, 15 Feb 2018 10:30:11 -0500 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 30469@debbugs.gnu.org Subject: [PATCH 1/1] build: Require Guile >= 2.0.14. Date: Thu, 15 Feb 2018 16:29:57 +0100 Message-Id: <20180215152957.7614-1-ludo@gnu.org> X-Mailer: git-send-email 2.16.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30469 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * README, configure.ac, doc/guix.texi (Requirements): Increase minimum Guile version from 2.0.9 to 2.0.14. * config-daemon.ac: Remove use of 'GUIX_CHECK_UNBUFFERED_CBIP'. * m4/guix.m4 (GUIX_CHECK_UNBUFFERED_CBIP): Remove. * guix/build/download.scm (current-http-proxy): Remove. * guix/build/syscalls.scm (%libc-errno-pointer, errno): Remove. (syscall->procedure): Use #:return-errno unconditionally. * guix/hash.scm (open-sha256-input-port)[unbuffered]: Remove outdated comment. * guix/http-client.scm (when-guile<=2.0.5-or-otherwise-broken): Remove. : Remove 'when-guile<=2.0.5-or-otherwise-broken' block. * guix/scripts/substitute.scm (fetch): Remove 'guile-version>?' conditional. * tests/hash.scm (supports-unbuffered-cbip?): Remove. : Remove 'test-skip' call. --- README | 2 +- config-daemon.ac | 5 -- configure.ac | 2 +- doc/guix.texi | 2 +- guix/build/download.scm | 10 +-- guix/build/syscalls.scm | 48 +------------- guix/hash.scm | 3 +- guix/http-client.scm | 154 +------------------------------------------- guix/scripts/substitute.scm | 18 ++---- m4/guix.m4 | 17 ----- tests/hash.scm | 11 +--- 11 files changed, 14 insertions(+), 258 deletions(-) diff --git a/README b/README index d96a43bbe..6d1a10ad5 100644 --- a/README +++ b/README @@ -20,7 +20,7 @@ Guix is based on the [[https://nixos.org/nix/][Nix]] package manager. GNU Guix currently depends on the following packages: - - [[https://gnu.org/software/guile/][GNU Guile 2.2.x or 2.0.x]], version 2.0.9 or later + - [[https://gnu.org/software/guile/][GNU Guile 2.2.x or 2.0.x]], version 2.0.14 or later - [[https://gnupg.org/][GNU libgcrypt]] - [[https://www.gnu.org/software/make/][GNU Make]] - [[https://www.gnutls.org][GnuTLS]] compiled with guile support enabled. diff --git a/config-daemon.ac b/config-daemon.ac index 80d84cbdb..524b10b30 100644 --- a/config-daemon.ac +++ b/config-daemon.ac @@ -132,11 +132,6 @@ if test "x$guix_build_daemon" = "xyes"; then AC_DEFINE_UNQUOTED([GUIX_SUBSTITUTE_URLS], ["$guix_substitute_urls"], [Default list of substitute URLs used by 'guix-daemon'.]) - dnl Check whether the 'offload' build hook can be built (uses - dnl 'restore-file-set', which requires unbuffered custom binary input - dnl ports from Guile >= 2.0.10.) - GUIX_CHECK_UNBUFFERED_CBIP - dnl Check for Guile-SSH, which is required by 'guix offload'. GUIX_CHECK_GUILE_SSH diff --git a/configure.ac b/configure.ac index 398846f64..d533c160e 100644 --- a/configure.ac +++ b/configure.ac @@ -98,7 +98,7 @@ if test "x$GUILD" = "x"; then fi if test "x$GUILE_EFFECTIVE_VERSION" = "x2.0"; then - PKG_CHECK_MODULES([GUILE], [guile-2.0 >= 2.0.9]) + PKG_CHECK_MODULES([GUILE], [guile-2.0 >= 2.0.14]) fi dnl Installation directories for .scm and .go files. diff --git a/doc/guix.texi b/doc/guix.texi index 7ed39ff13..9227e0e83 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -601,7 +601,7 @@ in the Guix source tree for additional details. GNU Guix depends on the following packages: @itemize -@item @url{http://gnu.org/software/guile/, GNU Guile}, version 2.0.9 or +@item @url{http://gnu.org/software/guile/, GNU Guile}, version 2.0.14 or later, including 2.2.x; @item @url{http://gnupg.org/, GNU libgcrypt}; @item diff --git a/guix/build/download.scm b/guix/build/download.scm index 1b630a9d6..315a3554e 100644 --- a/guix/build/download.scm +++ b/guix/build/download.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright © 2012, 2013, 2014, 2015, 2016, 2017 Ludovic Courtès +;;; Copyright © 2012, 2013, 2014, 2015, 2016, 2017, 2018 Ludovic Courtès ;;; Copyright © 2015 Mark H Weaver ;;; Copyright © 2017 Tobias Geerinckx-Rice ;;; @@ -321,14 +321,6 @@ host name without trailing dot." ((uri? uri-or-string) uri-or-string) (else (error "Invalid URI" uri-or-string)))) -(define current-http-proxy - ;; XXX: Add a dummy definition for Guile < 2.0.10; this is used in - ;; 'open-socket-for-uri'. - (or (and=> (module-variable (resolve-interface '(web client)) - 'current-http-proxy) - variable-ref) - (const #f))) - (define* (open-socket-for-uri uri-or-string #:key timeout) "Return an open input/output port for a connection to URI. When TIMEOUT is not #f, it must be a (possibly inexact) number denoting the maximum duration diff --git a/guix/build/syscalls.scm b/guix/build/syscalls.scm index 0cb630cfb..25726b885 100644 --- a/guix/build/syscalls.scm +++ b/guix/build/syscalls.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright © 2014, 2015, 2016, 2017 Ludovic Courtès +;;; Copyright © 2014, 2015, 2016, 2017, 2018 Ludovic Courtès ;;; Copyright © 2015 David Thompson ;;; Copyright © 2015 Mark H Weaver ;;; Copyright © 2017 Mathieu Othacehe @@ -350,39 +350,6 @@ expansion-time error is raised if FIELD does not exist in TYPE." ;;; FFI. ;;; -(define %libc-errno-pointer - ;; Glibc's 'errno' pointer, for use with Guile < 2.0.12. - (let ((errno-loc (false-if-exception - (dynamic-func "__errno_location" (dynamic-link))))) - (and errno-loc - (let ((proc (pointer->procedure '* errno-loc '()))) - (proc))))) - -(define errno ;for Guile < 2.0.12 - (if %libc-errno-pointer - (let ((bv (pointer->bytevector %libc-errno-pointer (sizeof int)))) - (lambda () - "Return the current errno." - ;; XXX: We assume that nothing changes 'errno' while we're doing all this. - ;; In particular, that means that no async must be running here. - - ;; Use one of the fixed-size native-ref procedures because they are - ;; optimized down to a single VM instruction, which reduces the risk - ;; that we fiddle with 'errno' (needed on Guile 2.0.5, libc 2.11.) - (let-syntax ((ref (lambda (s) - (syntax-case s () - ((_ bv) - (case (sizeof int) - ((4) - #'(bytevector-s32-native-ref bv 0)) - ((8) - #'(bytevector-s64-native-ref bv 0)) - (else - (error "unsupported 'int' size" - (sizeof int))))))))) - (ref bv)))) - (lambda () 0))) - (define (call-with-restart-on-EINTR thunk) (let loop () (catch 'system-error @@ -406,17 +373,8 @@ the returned procedure is called." (lambda () (let ((ptr (dynamic-func name (dynamic-link)))) ;; The #:return-errno? facility was introduced in Guile 2.0.12. - ;; Support older versions of Guile by catching 'wrong-number-of-args'. - (catch 'wrong-number-of-args - (lambda () - (pointer->procedure return-type ptr argument-types - #:return-errno? #t)) - (lambda (key . rest) - (let ((proc (pointer->procedure return-type ptr argument-types))) - (lambda args - (let ((result (apply proc args)) - (err (errno))) - (values result err)))))))) + (pointer->procedure return-type ptr argument-types + #:return-errno? #t))) (lambda args (lambda _ (error (format #f "~a: syscall->procedure failed: ~s" diff --git a/guix/hash.scm b/guix/hash.scm index 44e447258..773b9d477 100644 --- a/guix/hash.scm +++ b/guix/hash.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright © 2012, 2013, 2014, 2015, 2016 Ludovic Courtès +;;; Copyright © 2012, 2013, 2014, 2015, 2016, 2018 Ludovic Courtès ;;; ;;; This file is part of GNU Guix. ;;; @@ -159,7 +159,6 @@ data read from PORT. The thunk always returns the same value." (define (unbuffered port) ;; Guile <= 2.0.9 does not support 'setvbuf' on custom binary input ports. - ;; If you get a wrong-type-arg error here, the fix is to upgrade Guile. :-) (setvbuf port _IONBF) port) diff --git a/guix/http-client.scm b/guix/http-client.scm index bab31875d..e8a2a23fc 100644 --- a/guix/http-client.scm +++ b/guix/http-client.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright © 2012, 2013, 2014, 2015, 2016, 2017 Ludovic Courtès +;;; Copyright © 2012, 2013, 2014, 2015, 2016, 2017, 2018 Ludovic Courtès ;;; Copyright © 2015 Mark H Weaver ;;; Copyright © 2012, 2015 Free Software Foundation, Inc. ;;; Copyright © 2017 Tobias Geerinckx-Rice @@ -69,158 +69,6 @@ (reason http-get-error-reason)) ; string -(define-syntax when-guile<=2.0.5-or-otherwise-broken - (lambda (s) - (syntax-case s () - ((_ body ...) - ;; Always emit BODY, regardless of VERSION, because sometimes this code - ;; might be compiled with a recent Guile and run with 2.0.5---e.g., - ;; when using "guix pull". - #'(begin body ...))))) - -(when-guile<=2.0.5-or-otherwise-broken - ;; Backport of Guile commits 312e79f8 ("Add HTTP Chunked Encoding support to - ;; web modules."), 00d3ecf2 ("http: Do not buffer HTTP chunks."), and 53b8d5f - ;; ("web: Gracefully handle premature EOF when reading chunk header.") - - (use-modules (ice-9 rdelim)) - - (define %web-http - (resolve-module '(web http))) - - ;; Chunked Responses - (define (read-chunk-header port) - "Read a chunk header from PORT and return the size in bytes of the - upcoming chunk." - (match (read-line port) - ((? eof-object?) - ;; Connection closed prematurely: there's nothing left to read. - 0) - (str - (let ((extension-start (string-index str - (lambda (c) - (or (char=? c #\;) - (char=? c #\return)))))) - (string->number (if extension-start ; unnecessary? - (substring str 0 extension-start) - str) - 16))))) - - (define* (make-chunked-input-port port #:key (keep-alive? #f)) - "Returns a new port which translates HTTP chunked transfer encoded -data from PORT into a non-encoded format. Returns eof when it has -read the final chunk from PORT. This does not necessarily mean -that there is no more data on PORT. When the returned port is -closed it will also close PORT, unless the KEEP-ALIVE? is true." - (define (close) - (unless keep-alive? - (close-port port))) - - (define chunk-size 0) ;size of the current chunk - (define remaining 0) ;number of bytes left from the current chunk - (define finished? #f) ;did we get all the chunks? - - (define (read! bv idx to-read) - (define (loop to-read num-read) - (cond ((or finished? (zero? to-read)) - num-read) - ((zero? remaining) ;get a new chunk - (let ((size (read-chunk-header port))) - (set! chunk-size size) - (set! remaining size) - (if (zero? size) - (begin - (set! finished? #t) - num-read) - (loop to-read num-read)))) - (else ;read from the current chunk - (let* ((ask-for (min to-read remaining)) - (read (get-bytevector-n! port bv (+ idx num-read) - ask-for))) - (if (eof-object? read) - (begin ;premature termination - (set! finished? #t) - num-read) - (let ((left (- remaining read))) - (set! remaining left) - (when (zero? left) - ;; We're done with this chunk; read CR and LF. - (get-u8 port) (get-u8 port)) - (loop (- to-read read) - (+ num-read read)))))))) - (loop to-read 0)) - - (make-custom-binary-input-port "chunked input port" read! #f #f close)) - - ;; Chunked encoding support in Guile <= 2.0.11 would load whole chunks in - ;; memory---see . - (when (module-variable %web-http 'read-chunk-body) - (module-set! %web-http 'make-chunked-input-port make-chunked-input-port)) - - (define (make-delimited-input-port port len keep-alive?) - "Return an input port that reads from PORT, and makes sure that -exactly LEN bytes are available from PORT. Closing the returned port -closes PORT, unless KEEP-ALIVE? is true." - (define bytes-read 0) - - (define (fail) - ((@@ (web response) bad-response) - "EOF while reading response body: ~a bytes of ~a" - bytes-read len)) - - (define (read! bv start count) - ;; Read at most LEN bytes in total. HTTP/1.1 doesn't say what to do - ;; when a server provides more than the Content-Length, but it seems - ;; wise to just stop reading at LEN. - (let ((count (min count (- len bytes-read)))) - (let loop ((ret (get-bytevector-n! port bv start count))) - (cond ((eof-object? ret) - (if (= bytes-read len) - 0 ; EOF - (fail))) - ((and (zero? ret) (> count 0)) - ;; Do not return zero since zero means EOF, so try again. - (loop (get-bytevector-n! port bv start count))) - (else - (set! bytes-read (+ bytes-read ret)) - ret))))) - - (define close - (and (not keep-alive?) - (lambda () - (close-port port)))) - - (make-custom-binary-input-port "delimited input port" read! #f #f close)) - - (define (read-header-line port) - "Read an HTTP header line and return it without its final CRLF or LF. -Raise a 'bad-header' exception if the line does not end in CRLF or LF, -or if EOF is reached." - (match (%read-line port) - (((? string? line) . #\newline) - ;; '%read-line' does not consider #\return a delimiter; so if it's - ;; there, remove it. We are more tolerant than the RFC in that we - ;; tolerate LF-only endings. - (if (string-suffix? "\r" line) - (string-drop-right line 1) - line)) - ((line . _) ;EOF or missing delimiter - ((@@ (web http) bad-header) 'read-header-line line)))) - - (unless (guile-version>? "2.0.11") - ;; Guile <= 2.0.9 had a bug whereby 'response-body-port' would read more - ;; than what 'content-length' says. See Guile commit 802a25b. - ;; Guile <= 2.0.11 had a bug whereby the 'close' method of the response - ;; body port would fail with wrong-arg-num. See Guile commit 5a10e41. - (module-set! (resolve-module '(web response)) - 'make-delimited-input-port make-delimited-input-port) - - ;; Guile <= 2.0.11 was affected by . See Guile - ;; commit 4c7732c. - (when (module-variable %web-http 'read-line*) - (module-set! %web-http 'read-line* read-header-line)))) - - (define* (http-fetch uri #:key port (text? #f) (buffered? #t) keep-alive? (verify-certificate? #t) (headers '((user-agent . "GNU Guile")))) diff --git a/guix/scripts/substitute.scm b/guix/scripts/substitute.scm index 2fd2bf810..8e1119fb4 100755 --- a/guix/scripts/substitute.scm +++ b/guix/scripts/substitute.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright © 2013, 2014, 2015, 2016, 2017 Ludovic Courtès +;;; Copyright © 2013, 2014, 2015, 2016, 2017, 2018 Ludovic Courtès ;;; Copyright © 2014 Nikita Karetnikov ;;; ;;; This file is part of GNU Guix. @@ -212,15 +212,7 @@ provide." (begin (warning (G_ "while fetching ~a: server is somewhat slow~%") (uri->string uri)) - (warning (G_ "try `--no-substitutes' if the problem persists~%")) - - ;; Before Guile v2.0.9-39-gfe51c7b, EINTR was reported to the user, - ;; and thus PORT had to be closed and re-opened. This is not the - ;; case afterward. - (unless (or (guile-version>? "2.0.9") - (version>? (version) "2.0.9.39")) - (when port - (close-connection port)))) + (warning (G_ "try `--no-substitutes' if the problem persists~%"))) (begin (when (or (not port) (port-closed? port)) (set! port (guix:open-connection-for-uri @@ -571,10 +563,8 @@ initial connection on which HTTP requests are sent." ;; XXX: Do our own caching to work around inefficiencies when ;; communicating over TLS: . (let-values (((buffer get) (open-bytevector-output-port))) - ;; On Guile > 2.0.9, inherit the HTTP proxying property from P. - (when (module-variable (resolve-interface '(web http)) - 'http-proxy-port?) - (set-http-proxy-port?! buffer (http-proxy-port? p))) + ;; Inherit the HTTP proxying property from P. + (set-http-proxy-port?! buffer (http-proxy-port? p)) (for-each (cut write-request <> buffer) (at-most 1000 requests)) diff --git a/m4/guix.m4 b/m4/guix.m4 index 721285b01..8e174e92e 100644 --- a/m4/guix.m4 +++ b/m4/guix.m4 @@ -136,23 +136,6 @@ AC_DEFUN([GUIX_ASSERT_GUILE_FEATURES], [ done ]) -dnl GUIX_CHECK_UNBUFFERED_CBIP -dnl -dnl Check whether 'setbvuf' works on custom binary input ports (CBIPs), as is -dnl the case starting with Guile 2.0.10. -AC_DEFUN([GUIX_CHECK_UNBUFFERED_CBIP], [ - AC_CACHE_CHECK([whether Guile's custom binary input ports support 'setvbuf'], - [ac_cv_guix_cbips_support_setvbuf], - [if "$GUILE" -c "(use-modules (rnrs io ports)) \ - (let ((p (make-custom-binary-input-port \"cbip\" pk #f #f #f))) \ - (setvbuf p _IONBF))" >&5 2>&1 - then - ac_cv_guix_cbips_support_setvbuf=yes - else - ac_cv_guix_cbips_support_setvbuf=no - fi]) -]) - dnl GUIX_ASSERT_SYNTAX_OBJECT_EQUAL dnl dnl Guile 2.2.1 was a brown-paper-bag release where 'equal?' wouldn't work diff --git a/tests/hash.scm b/tests/hash.scm index b189e435c..b4cf2b61d 100644 --- a/tests/hash.scm +++ b/tests/hash.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright © 2013, 2014, 2017 Ludovic Courtès +;;; Copyright © 2013, 2014, 2017, 2018 Ludovic Courtès ;;; ;;; This file is part of GNU Guix. ;;; @@ -37,13 +37,6 @@ (base16-string->bytevector "b94d27b9934d3e08a52e52d7da7dabfac484efe37a5380ee9088f7ace2efcde9")) -(define (supports-unbuffered-cbip?) - "Return #t if unbuffered custom binary input ports (CBIPs) are supported. -In Guile <= 2.0.9, CBIPs were always fully buffered, so the -'open-sha256-input-port' does not work there." - (false-if-exception - (setvbuf (make-custom-binary-input-port "foo" pk #f #f #f) _IONBF))) - (test-begin "hash") @@ -77,8 +70,6 @@ In Guile <= 2.0.9, CBIPs were always fully buffered, so the (equal? (sha256 contents) (call-with-input-file file port-sha256)))) -(test-skip (if (supports-unbuffered-cbip?) 0 4)) - (test-equal "open-sha256-input-port, empty" `("" ,%empty-sha256) (let-values (((port get) -- 2.16.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 24 09:30:49 2018 Received: (at 30469) by debbugs.gnu.org; 24 Feb 2018 14:30:49 +0000 Received: from localhost ([127.0.0.1]:58285 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1epaqf-0003Yq-Ip for submit@debbugs.gnu.org; Sat, 24 Feb 2018 09:30:49 -0500 Received: from mail.onyx.syn-alias.com ([206.152.134.66]:24162 helo=smtp.centurylink.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1epaqd-0003Yd-Nf for 30469@debbugs.gnu.org; Sat, 24 Feb 2018 09:30:48 -0500 DKIM-Signature: v=1; a=rsa-sha1; d=centurylink.net; s=ctl201402; c=relaxed/simple; q=dns/txt; i=@centurylink.net; t=1519482642; h=From:Subject:Date:To:MIME-Version:Content-Type; bh=XihP8Ih3PBVfsYWYGPMKMInXTRs=; b=AgZh7pBK0bTZvkTIX4+AXUc9psVAQ4AEFbRb7gYiMDeKadzdERf+N8JJ8MXdyB7g o0EcEL9SkKTvWLLEgBSJ6kEtmvkk1xlL7v8HPSqs2HuMOCpTJXYwOe6E+yid9es3 ou4NluOkXRkx+iaELEeVEDQV36FHL1qzYmDpngWS5RGG0vWknKCJLuRV3cGY4M2V ABGnzXAQKl7DPZQRpWp2RNJ4n7IMwniXl/gUBcqkJXp/e0aC0VnyjTswVhe2mpws X3M2TVSTs8q3uRcdLue+Zk8jZh0AYymhYyKZnnqXrD9dLGoicSgpUs0s6OP/XKEs UqM98DzCv8nzUvjG9JUBxA==; X_CMAE_Category: , , X-CNFS-Analysis: v=2.2 cv=cp3ZqBwi c=1 sm=1 tr=0 a=W5lKcltPwKQpx9E81i/wdA==:117 a=W5lKcltPwKQpx9E81i/wdA==:17 a=KGjhK52YXX0A:10 a=Op4juWPpsa0A:10 a=zSv6zi-ZgakA:10 a=mDV3o1hIAAAA:8 a=xNf9USuDAAAA:8 a=yBR9Qs6oAAAA:8 a=NKHz5U62_LARMlIsG_8A:9 a=QEXdDO2ut3YA:10 a=TKT5KpCyCRZDnZD8rNUA:9 a=_FVE-zBwftR9WsbkzFJk:22 a=SEwjQc04WA-l_NiBhQ7s:22 a=7C5qix1daMSKwVux_nGC:22 X-CM-Score: 0 X-Scanned-by: Cloudmark Authority Engine X-Authed-Username: ZXJpY2JhdmllckBjZW50dXJ5bGluay5uZXQ= Authentication-Results: smtp04.onyx.dfw.sync.lan smtp.user=ericbavier@centurylink.net; auth=pass (LOGIN) Received: from [97.116.104.8] ([97.116.104.8:42944] helo=localhost) by smtp.centurylink.net (envelope-from ) (ecelerity 3.6.25.56547 r(Core:3.6.25.0)) with ESMTPSA (cipher=AES256-GCM-SHA384) id 89/78-22547-117719A5; Sat, 24 Feb 2018 09:30:41 -0500 Date: Sat, 24 Feb 2018 08:30:32 -0600 From: Eric Bavier To: Ludovic =?UTF-8?B?Q291cnTDqHM=?= Subject: Re: [bug#30469] [PATCH 0/1] Require Guile >= 2.0.14 Message-ID: <20180224083032.4f5f1e36@centurylink.net> In-Reply-To: <20180215152627.4695-1-ludo@gnu.org> References: <20180215152627.4695-1-ludo@gnu.org> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/duxHO6erT03F.XNoin4z=Zv"; protocol="application/pgp-signature" X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 30469 Cc: 30469@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.4 (/) --Sig_/duxHO6erT03F.XNoin4z=Zv Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 15 Feb 2018 16:26:27 +0100 Ludovic Court=C3=A8s wrote: > Hello Guix, >=20 > This patch is to require Guile >=3D 2.0.14, released one year ago, instead > of 2.0.9, released in 2013. >=20 > For the record, here=E2=80=99s the distro status: >=20 > =E2=80=A2 Debian unstable has 2.2: > . >=20 > =E2=80=A2 Older Debian versions have 2.0.13 (not .14): > . How much of this patch would change if it were to instead support 2.0.13? Is cutting off users of Debian stable a good idea? >=20 > =E2=80=A2 Parabola, Gentoo, Homebrew, openSUSE, Fedora 26+ have 2.0.14 = and/or > 2.2: . >=20 > I=E2=80=99d like to have this change in place for the next Guix release, = 0.14.1 > I presume. >=20 > I=E2=80=99d also like it to be the last release that support Guile 2.0. Same question. `~Eric --Sig_/duxHO6erT03F.XNoin4z=Zv Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEoMXjUi7471xkzbfw/XPKxxnTJWYFAlqRdwgACgkQ/XPKxxnT JWZnWxAAmR5p2QTXRiNZWY/4sws0217C8l2549fp1JO3oWUvJDvuZlU2u1X4P07H EQG7TznJmjtvKiOCnt75zj0nVUTyL6uPcQgtYxaUVuPRP7eB5GIYaokHO+A1yYRK sIQm7bYpGvxysPUa1O/zVQmOBQW5NluaoznuKGB/Ql+bIcIdywG/mv9L2VFY7J88 P//cQXSijqh/u4xWkJHr4/djK9QUmK/wMks7CuRYCKR0kANlgRp7s8e4IVQxC2yy q0Xa3i4ZAYFEthTB1fSlXy3oXjJnPsxSSMwO8gJS/O7i0sq/jPwDYqyyx868+eDN mNR6BWlK13ctx4xkJ4QsLfPtxuniuToPzTXs88ZYECdcBITsycbMEV0PRc08xwvE Zfie528BzOAuJxtFVwFYXUoyLU4/ryk1MAo6Q+z699qucrUQ+4EgtyiAEUU4hnjA 5puoQyEWamCF7/yXTIxXwMx0oskE8zlWz0OXHMEk+I0Uw/xwOvXxPPV+HsJJ4wv+ MVYkfQZSUIW6bzt7EHF19HS3ELi7u9PdHuU3nL0KWtrSyUpn5lWKi0h5LOWVi75r ts17xw05eVDQDaRbe6vz3Z6gZHoPbv91f1x9zTRYSUt0nHLbke3F/kP5/TkUe9h4 ml5S1rug8bofRbFlPEbbNnQG2lrhvKyXwEq5GbGTBUil4w+yDzk= =tRa+ -----END PGP SIGNATURE----- --Sig_/duxHO6erT03F.XNoin4z=Zv-- From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 24 17:41:29 2018 Received: (at 30469) by debbugs.gnu.org; 24 Feb 2018 22:41:29 +0000 Received: from localhost ([127.0.0.1]:59141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1epiVV-0008U2-BP for submit@debbugs.gnu.org; Sat, 24 Feb 2018 17:41:29 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:36702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1epiVU-0008Tu-79 for 30469@debbugs.gnu.org; Sat, 24 Feb 2018 17:41:28 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 315D410DB8; Sat, 24 Feb 2018 23:41:27 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1Yp4qImKSQhJ; Sat, 24 Feb 2018 23:41:26 +0100 (CET) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id DF6FE107DB; Sat, 24 Feb 2018 23:41:25 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Eric Bavier Subject: Re: [bug#30469] [PATCH 0/1] Require Guile >= 2.0.14 References: <20180215152627.4695-1-ludo@gnu.org> <20180224083032.4f5f1e36@centurylink.net> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 6 =?utf-8?Q?Vent=C3=B4se?= an 226 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 24 Feb 2018 23:41:24 +0100 In-Reply-To: <20180224083032.4f5f1e36@centurylink.net> (Eric Bavier's message of "Sat, 24 Feb 2018 08:30:32 -0600") Message-ID: <87k1v280yz.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 30469 Cc: 30469@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hello, Eric Bavier skribis: > On Thu, 15 Feb 2018 16:26:27 +0100 > Ludovic Court=C3=A8s wrote: > >> Hello Guix, >>=20 >> This patch is to require Guile >=3D 2.0.14, released one year ago, inste= ad >> of 2.0.9, released in 2013. >>=20 >> For the record, here=E2=80=99s the distro status: >>=20 >> =E2=80=A2 Debian unstable has 2.2: >> . >>=20 >> =E2=80=A2 Older Debian versions have 2.0.13 (not .14): >> . > > How much of this patch would change if it were to instead support > 2.0.13? Is cutting off users of Debian stable a good idea? I=E2=80=99ll double-check but I think the patch remains valid if we require 2.0.13. If it works I=E2=80=99ll commit that next week. >> I=E2=80=99d also like it to be the last release that support Guile 2.0. > > Same question. 2.2 is becoming quite widespread in distros. Overall it=E2=80=99s a cost/benefit tradeoff, and we have to take into acco= unt that most users get Guix using the binary tarball or GuixSD. Thanks for your feedback, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 25 06:53:46 2018 Received: (at submit) by debbugs.gnu.org; 25 Feb 2018 11:53:46 +0000 Received: from localhost ([127.0.0.1]:59493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1epusD-0003nI-P6 for submit@debbugs.gnu.org; Sun, 25 Feb 2018 06:53:45 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35940) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1epusC-0003n7-Ok for submit@debbugs.gnu.org; Sun, 25 Feb 2018 06:53:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1epus6-0003ol-7S for submit@debbugs.gnu.org; Sun, 25 Feb 2018 06:53:39 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:35533) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1epus6-0003oX-3w for submit@debbugs.gnu.org; Sun, 25 Feb 2018 06:53:38 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55128) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1epus4-0001tE-Iq for guix-patches@gnu.org; Sun, 25 Feb 2018 06:53:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1epus1-0003j7-GV for guix-patches@gnu.org; Sun, 25 Feb 2018 06:53:36 -0500 Received: from mout.web.de ([212.227.15.14]:40101) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1epus1-0003gr-6L for guix-patches@gnu.org; Sun, 25 Feb 2018 06:53:33 -0500 Received: from [192.168.178.186] ([87.123.199.221]) by smtp.web.de (mrweb003 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MIeTI-1es7n81osq-002E0s for ; Sun, 25 Feb 2018 12:53:30 +0100 Subject: Re: [bug#30469] [PATCH 0/1] Require Guile >= 2.0.14 To: guix-patches@gnu.org References: <20180215152627.4695-1-ludo@gnu.org> <20180224083032.4f5f1e36@centurylink.net> <87k1v280yz.fsf@gnu.org> From: Jonathan Brielmaier Message-ID: Date: Sun, 25 Feb 2018 12:53:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <87k1v280yz.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:w+MlxAoPBwtMGMhTGSSUEgWBYIdXh64JijlCEplAfpu7BdlNunJ A9uY81uYP3LiZTA/agwtrd2Ygp0Yt9ghL1Fz0zedOY/DmL/eLGTL8HzgI3u2z3uFoexSlV/ FAh7BQnfHzpeGh1IXOD7/D1vbbXRz3fZbmQjO0bGOzheKNkWX/6OPwJXJC539jj9jEnd3FK MzgmickILpAz2Kv6VwR/g== X-UI-Out-Filterresults: notjunk:1;V01:K0:VtdZ2PXR2GI=:qG7WOVC+ioepJnvFjHH3hd JBbXuB/768iyUH5NJiFwjMNIFK2+4XHEjA/49hPXtr2vhyuNQawstynWIiCLRxCUtXcH33/BJ 8cVjRL2qTaXWMNOX62ZvJ25Bw1XHKl4A3tZCJcX/R/Fqt1+7TOnqN0BDIHlz6qUW7wc+UOwu5 0ZweMcUUBltdRLupOq6iGzWaWdlW4ETPJ7GVmEKcwuUHkJtlsQWxxanl9NxF3bsL1rK6IBIed trKBCX04IFJQo/S6wScHGAzCZiZIG6JMs5u8mJDoMLIHY9fLcIp4vySotdzNub3WVgBB073Tj kRQAUAAxMI4+CON5OvCjhHHf0fUPBRtGf5/6js0uqEqu3OaDDKwUuZm0Z6trQrvgbcsv+8gHC 61xj8DZdLYrA8Sy++GrgPnNZh9j5nfE7rWSURHjqbTXR3RaMcypX/r3irEKvGscZL6LI5M2e+ Lnr3s6ePNAkCo03k3l6gJDEPkJay9Tl3+2NiA/2MlkNpfFdDE2CdNqFk92PT7epyJr0SVGWoU izKOhtdVYkSmtd1lOgokZd96pi+OvDyyl0qkd6LW8Giauau1mlKvNXo9eSHn0JI2j1YmaztlL 1lB8iQL9je8yEAZRO8AFpKu/HuXO13xGLjvHVDYKVDCv/aEe/buqkFcRzRpLjlVe041fldISd 5tI4MEgIjS1JcdfMZcFvit89WYu+eJJAYXJbC1zFDTSzIFXzhfNDChupchDYpoAF/S3k5JIzF sWRe0OQliUKW5RdLdeBVU4w8iLvCyW9i9KIhF1tboFcvENdsAEoZCWr1EuGAq/LqTedK6VVXB v/VJzRYJGYuPU9iqo91x1zH4Z/TKhG/xZk7Ha+QrthZpl2koiU= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) On 02/24/2018 11:41 PM, Ludovic Courtès wrote:>> How much of this patch would change if it were to instead support >> 2.0.13? Is cutting off users of Debian stable a good idea? > > I’ll double-check but I think the patch remains valid if we require > 2.0.13. Opensuse Leap 15 will have 2.0.14, so I would be okay with it. > If it works I’ll commit that next week. > >>> I’d also like it to be the last release that support Guile 2.0. >> >> Same question. > > 2.2 is becoming quite widespread in distros. > > Overall it’s a cost/benefit tradeoff, and we have to take into account > that most users get Guix using the binary tarball or GuixSD. 2.2 is not as easy as I thought it would be, to bring it to openSUSE Leap. There are packages who still require guile 2.0 (see comments in https://build.opensuse.org/request/show/568553). And the fact that only a handful of packages need guile, makes it not really worthwhile for distros to have two versions of guile present like we see it for python. It would be nice to have guix in Debian, Ubuntu, SUSE land and Red Hat land. I think that would enable far more people to use guix. At the moment it's not easy to install guix from source without having guix in place, at least on openSUSE. You need those guile modules (guile-git, guile-bytestructures) who comes with almost no build documentation. And then you have to fiddle together guile with the right versions... We struggle a lot with bootstrapping rust, go, java etc, so we should make sure that "bootstrapping" guix (install from source) is easy or at least doable. Best Regards Jonathan From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 25 19:59:42 2018 Received: (at 30469) by debbugs.gnu.org; 26 Feb 2018 00:59:42 +0000 Received: from localhost ([127.0.0.1]:60786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eq78n-0000ON-PS for submit@debbugs.gnu.org; Sun, 25 Feb 2018 19:59:42 -0500 Received: from mail.onyx.syn-alias.com ([206.152.134.66]:38946 helo=smtp.centurylink.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eq78l-0000O9-Oh for 30469@debbugs.gnu.org; Sun, 25 Feb 2018 19:59:40 -0500 DKIM-Signature: v=1; a=rsa-sha1; d=centurylink.net; s=ctl201402; c=relaxed/simple; q=dns/txt; i=@centurylink.net; t=1519606773; h=From:Subject:Date:To:MIME-Version:Content-Type; bh=E1BbHMn6C+50/0M18fmCU6ISVZg=; b=h9s+3XL3y6+dkPZnwWWvewJjgOyFZhl8TonLeFl7kXd7qb5IrAgepvyTg2jCKdmU 5hfNBhe8rd7JEyDHgxR3c9RZdoPmx5ehOEzZZjHkS6kre/uVYvLfvTmJ7LpR5UJS zIVnW5YEje2AG17/MIls+EuH/rpbYd2Y1xB83UlVKdQ/wmWSbKtqRnZyMeke/p9U lZyUQwTb5BPWMQ8TbmDjYQoiXOd1hYYVjO2ummzlesZqLFHGJnL7CAg53gBIel2u pGCoclmSU8MJ/L/kHORIb3iVIXMnx+ExOSll2jXIBir8X6U33j0N217jfIqCnN+2 1VN2S+AQzyxMokmT5QTGnw==; X_CMAE_Category: , , X-CNFS-Analysis: v=2.2 cv=MfcugN3f c=1 sm=1 tr=0 a=W5lKcltPwKQpx9E81i/wdA==:117 a=W5lKcltPwKQpx9E81i/wdA==:17 a=KGjhK52YXX0A:10 a=Op4juWPpsa0A:10 a=zSv6zi-ZgakA:10 a=mDV3o1hIAAAA:8 a=I_5RNyk1AAAA:8 a=xNf9USuDAAAA:8 a=Ink1cs2FZfmnNFV1jr8A:9 a=QEXdDO2ut3YA:10 a=W9FGmWz0NAsrlq348V8A:9 a=_FVE-zBwftR9WsbkzFJk:22 a=Eh9yxdLE6B1twWrs3SXz:22 a=SEwjQc04WA-l_NiBhQ7s:22 X-CM-Score: 0 X-Scanned-by: Cloudmark Authority Engine X-Authed-Username: ZXJpY2JhdmllckBjZW50dXJ5bGluay5uZXQ= Authentication-Results: smtp03.onyx.dfw.sync.lan smtp.user=ericbavier@centurylink.net; auth=pass (LOGIN) Received: from [97.116.104.8] ([97.116.104.8:49312] helo=localhost) by smtp.centurylink.net (envelope-from ) (ecelerity 3.6.25.56547 r(Core:3.6.25.0)) with ESMTPSA (cipher=AES256-GCM-SHA384) id 02/B6-11204-5FB539A5; Sun, 25 Feb 2018 19:59:33 -0500 Date: Sun, 25 Feb 2018 18:59:24 -0600 From: Eric Bavier To: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Subject: Re: [bug#30469] [PATCH 0/1] Require Guile >= 2.0.14 Message-ID: <20180225151831.1b413f51@centurylink.net> In-Reply-To: <87k1v280yz.fsf@gnu.org> References: <20180215152627.4695-1-ludo@gnu.org> <20180224083032.4f5f1e36@centurylink.net> <87k1v280yz.fsf@gnu.org> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/7dbrYB8TPJvP3mPb=OhPMdO"; protocol="application/pgp-signature" X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 30469 Cc: 30469@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.4 (/) --Sig_/7dbrYB8TPJvP3mPb=OhPMdO Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sat, 24 Feb 2018 23:41:24 +0100 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > Hello, >=20 > Eric Bavier skribis: >=20 > > On Thu, 15 Feb 2018 16:26:27 +0100 > > Ludovic Court=C3=A8s wrote: > > =20 > >> Hello Guix, > >>=20 > >> This patch is to require Guile >=3D 2.0.14, released one year ago, ins= tead > >> of 2.0.9, released in 2013. > >>=20 > >> For the record, here=E2=80=99s the distro status: > >>=20 > >> =E2=80=A2 Debian unstable has 2.2: > >> . > >>=20 > >> =E2=80=A2 Older Debian versions have 2.0.13 (not .14): > >> . =20 > > > > How much of this patch would change if it were to instead support > > 2.0.13? Is cutting off users of Debian stable a good idea? =20 >=20 > I=E2=80=99ll double-check but I think the patch remains valid if we requi= re > 2.0.13. >=20 > If it works I=E2=80=99ll commit that next week. Cool. >=20 > >> I=E2=80=99d also like it to be the last release that support Guile 2.0= . =20 > > > > Same question. =20 >=20 > 2.2 is becoming quite widespread in distros. >=20 > Overall it=E2=80=99s a cost/benefit tradeoff, and we have to take into ac= count > that most users get Guix using the binary tarball or GuixSD. Right. But this can also become self-fulfilling. If we make it too hard for people to build from source, the binary tarball becomes more and more the only option. >=20 > Thanks for your feedback, Thanks for humoring me. `~Eric --Sig_/7dbrYB8TPJvP3mPb=OhPMdO Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEoMXjUi7471xkzbfw/XPKxxnTJWYFAlqTW+wACgkQ/XPKxxnT JWY7gw/+LMohftkeO99tifvhnjCsu7vRAi6LPM4PFfR+GLUNf1Hl56UNWavO6omC EYB5EdL92WRUEPXZtnk+OzxqQzBUkm0R2xwtBBSHsBPplcByhSxFr7c/yvCfsOQG ky3KDw9Lsh1PI+sad8VTNErzKvJ111M250M2MOFZw7T/1cfhuHXX11fFEAdcJk8N AE4KUSipbYdIpHSUrcasBpMcWR8H22IexXNfIg9Jj86/+hsBbsi+dOhouEb5S7fo /kuzxvm2AgcooTRF5uIx3TDXqdrgRTvO8chxWdAwxoPSTSgwNOus4rvvmsFE0rIC Hl8QDnDMbTgM1POIq+OfwbiQvyYj9bj1TwoLgCsoJOFupAygPrMS/hXUEa8/BiM7 h/3y+nbsDGMuoOd5ZqW//uCbaDx9uRPVkWdut2IAKkPC5rnEjS0LsI2+ediYgQW4 GufGahYlbFyOWirsCr76Pg9II/IZzA5tuyaO1wSi9AhsOjfYbff3s4fo16RHGcgk 2NPPZvzrakalCrogy506mVnrRUB8vlStyRkscGXDWcTPi8UYE3RcCrIpxiBsyvEI FkF4i+GIydCq4CDImyMCA080IdXDCwbOGY3PL04uImyGGO0r4oJvHlN+ksmanqqc ch/SZKOJAi62B26rvQrshry3fN7Z6t4DhZGK0vLrzLbhMbhpOHM= =B7yN -----END PGP SIGNATURE----- --Sig_/7dbrYB8TPJvP3mPb=OhPMdO-- From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 26 13:49:42 2018 Received: (at 30469-done) by debbugs.gnu.org; 26 Feb 2018 18:49:42 +0000 Received: from localhost ([127.0.0.1]:33866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqNqI-0001e3-KB for submit@debbugs.gnu.org; Mon, 26 Feb 2018 13:49:42 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:47230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqNqH-0001dv-LQ for 30469-done@debbugs.gnu.org; Mon, 26 Feb 2018 13:49:42 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 8FE90104EE; Mon, 26 Feb 2018 19:49:40 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4nMkQunI018M; Mon, 26 Feb 2018 19:49:39 +0100 (CET) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 711E2FA; Mon, 26 Feb 2018 19:49:39 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Eric Bavier Subject: Re: [bug#30469] [PATCH 0/1] Require Guile >= 2.0.14 References: <20180215152627.4695-1-ludo@gnu.org> <20180224083032.4f5f1e36@centurylink.net> <87k1v280yz.fsf@gnu.org> <20180225151831.1b413f51@centurylink.net> Date: Mon, 26 Feb 2018 19:49:38 +0100 In-Reply-To: <20180225151831.1b413f51@centurylink.net> (Eric Bavier's message of "Sun, 25 Feb 2018 18:59:24 -0600") Message-ID: <87fu5ntwl9.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 30469-done Cc: 30469-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Eric Bavier skribis: > On Sat, 24 Feb 2018 23:41:24 +0100 > ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > >> Hello, >>=20 >> Eric Bavier skribis: >>=20 >> > On Thu, 15 Feb 2018 16:26:27 +0100 >> > Ludovic Court=C3=A8s wrote: >> >=20=20 >> >> Hello Guix, >> >>=20 >> >> This patch is to require Guile >=3D 2.0.14, released one year ago, in= stead >> >> of 2.0.9, released in 2013. >> >>=20 >> >> For the record, here=E2=80=99s the distro status: >> >>=20 >> >> =E2=80=A2 Debian unstable has 2.2: >> >> . >> >>=20 >> >> =E2=80=A2 Older Debian versions have 2.0.13 (not .14): >> >> .=20=20 >> > >> > How much of this patch would change if it were to instead support >> > 2.0.13? Is cutting off users of Debian stable a good idea?=20=20 >>=20 >> I=E2=80=99ll double-check but I think the patch remains valid if we requ= ire >> 2.0.13. >>=20 >> If it works I=E2=80=99ll commit that next week. > > Cool. Pushed as 1d84d7bf6052c0c80bd212d4524876576e9817d4. Thanks for your feedback! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 27 12:23:39 2018 Received: (at 30469) by debbugs.gnu.org; 27 Feb 2018 17:23:39 +0000 Received: from localhost ([127.0.0.1]:35875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqiyZ-0001lO-KH for submit@debbugs.gnu.org; Tue, 27 Feb 2018 12:23:39 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:53940) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqiyY-0001lG-7r for 30469@debbugs.gnu.org; Tue, 27 Feb 2018 12:23:38 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id AF02511FE2; Tue, 27 Feb 2018 18:23:37 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id D-qsYxwzFOX4; Tue, 27 Feb 2018 18:23:36 +0100 (CET) Received: from ribbon (unknown [193.50.110.216]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 57A0F11A3A; Tue, 27 Feb 2018 18:23:36 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Jonathan Brielmaier Subject: Re: [bug#30469] [PATCH 0/1] Require Guile >= 2.0.14 References: <20180215152627.4695-1-ludo@gnu.org> <20180224083032.4f5f1e36@centurylink.net> <87k1v280yz.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 9 =?utf-8?Q?Vent=C3=B4se?= an 226 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 27 Feb 2018 18:23:35 +0100 In-Reply-To: (Jonathan Brielmaier's message of "Sun, 25 Feb 2018 12:53:29 +0100") Message-ID: <87606iz6qw.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 30469 Cc: 30469@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hi Jonathan, Jonathan Brielmaier skribis: > 2.2 is not as easy as I thought it would be, to bring it to openSUSE > Leap. There are packages who still require guile 2.0 (see comments in > https://build.opensuse.org/request/show/568553). And the fact that only > a handful of packages need guile, makes it not really worthwhile for > distros to have two versions of guile present like we see it for python. > > It would be nice to have guix in Debian, Ubuntu, SUSE land and Red Hat > land. I think that would enable far more people to use guix. > > At the moment it's not easy to install guix from source without having > guix in place, at least on openSUSE. You need those guile modules > (guile-git, guile-bytestructures) who comes with almost no build > documentation. And then you have to fiddle together guile with the right > versions... > > We struggle a lot with bootstrapping rust, go, java etc, so we should > make sure that "bootstrapping" guix (install from source) is easy or at > least doable. Agreed. It becomes clearer to me that we would want to take advantage of Guix=E2=80= =99 modularity here so that one can build just the core of Guix with no dependencies other than Guile and libgcrypt maybe, and from there build higher-level layers, etc. Ludo=E2=80=99. From unknown Sat Sep 13 14:42:42 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 28 Mar 2018 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator