Subject: [bug#30456] [PATCH 1/2] gnu: Add mapnik.

From: Björn Höfling <[email-masked]>
Date: Wed, 14 Feb 2018 23:50:34 +0100

Thanks for adding this!

On Wed, 14 Feb 2018 21:59:03 +0530
Arun Isaac <[email-masked]> wrote:

> * gnu/packages/geo.scm (mapnik): New variable.

[..]

> +    (inputs
> +     `(("boost" ,boost)
> +       ("freetype" ,freetype)
> +       ("harfbuzz" ,harfbuzz)
> +       ("icu4c" ,icu4c)
> +       ("libjpeg-turbo" ,libjpeg-turbo)
> +       ("libpng" ,libpng)
> +       ("libtiff" ,libtiff)
> +       ("proj.4" ,proj.4)
> +       ("zlib" ,zlib)))

Have you tried to add these dependencies to gain potentially more
rendering input/output:

libwebp
cairo
sqlite

[..]

> +    (license license:lgpl2.1+)))

Many files under ./demo are licensed under "license:gpl2.0+". Add that
license, too.

Furthermore, there are:

license:boost1.0 ;; deps/boost
license:bsd3 ;; deps/mapbox and deps/mapnik/sparsehash

Finally, dep/agg has another license. Is it expat or even less? Here it
is:

// Permission to copy, use, modify, sell and distribute this software
// is granted provided this copyright notice appears in all copies.
// This software is provided "as is" without express or implied
// warranty, and with no claim as to its suitability for any purpose.

Otherwise, LGTM.

Björn