From unknown Mon Aug 18 19:25:47 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#30454 <30454@debbugs.gnu.org> To: bug#30454 <30454@debbugs.gnu.org> Subject: Status: [PATCH] gnu: make-linux-libre: Use invoke. Reply-To: bug#30454 <30454@debbugs.gnu.org> Date: Tue, 19 Aug 2025 02:25:47 +0000 retitle 30454 [PATCH] gnu: make-linux-libre: Use invoke. reassign 30454 guix-patches submitter 30454 Danny Milosavljevic severity 30454 normal tag 30454 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 14 03:37:42 2018 Received: (at submit) by debbugs.gnu.org; 14 Feb 2018 08:37:42 +0000 Received: from localhost ([127.0.0.1]:42126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1elsZS-0004pz-2g for submit@debbugs.gnu.org; Wed, 14 Feb 2018 03:37:42 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48744) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1elsZQ-0004pm-Vk for submit@debbugs.gnu.org; Wed, 14 Feb 2018 03:37:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1elsZK-0005Cc-K6 for submit@debbugs.gnu.org; Wed, 14 Feb 2018 03:37:35 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43662) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1elsZK-0005CY-HS for submit@debbugs.gnu.org; Wed, 14 Feb 2018 03:37:34 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39711) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elsZJ-0007KH-4V for guix-patches@gnu.org; Wed, 14 Feb 2018 03:37:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1elsZE-0005Ay-1z for guix-patches@gnu.org; Wed, 14 Feb 2018 03:37:33 -0500 Received: from dd26836.kasserver.com ([85.13.145.193]:44046) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1elsZD-0005AY-Qo for guix-patches@gnu.org; Wed, 14 Feb 2018 03:37:27 -0500 Received: from dayas.3.home (77.118.165.203.wireless.dyn.drei.com [77.118.165.203]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 825943360F00; Wed, 14 Feb 2018 09:37:25 +0100 (CET) From: Danny Milosavljevic To: guix-patches@gnu.org Subject: [PATCH] gnu: make-linux-libre: Use invoke. Date: Wed, 14 Feb 2018 09:37:22 +0100 Message-Id: <20180214083722.12245-1-dannym@scratchpost.org> X-Mailer: git-send-email 2.15.1 Tags: patch X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) * gnu/packages/linux.scm (make-linux-libre): Use invoke. --- gnu/packages/linux.scm | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm index 858f0885c..e01edce9c 100644 --- a/gnu/packages/linux.scm +++ b/gnu/packages/linux.scm @@ -336,7 +336,7 @@ for ARCH and optionally VARIANT, or #f if there is no such configuration." (begin (copy-file config ".config") (chmod ".config" #o666)) - (system* "make" ,defconfig)) + (invoke "make" ,defconfig)) ;; Appending works even when the option wasn't in the ;; file. The last one prevails if duplicated. @@ -345,7 +345,7 @@ for ARCH and optionally VARIANT, or #f if there is no such configuration." (display extra-configuration port) (close-port port)) - (zero? (system* "make" "oldconfig"))))) + (invoke "make" "oldconfig")))) (replace 'install (lambda* (#:key inputs native-inputs outputs #:allow-other-keys) (let* ((out (assoc-ref outputs "out")) @@ -360,13 +360,13 @@ for ARCH and optionally VARIANT, or #f if there is no such configuration." (find-files "." "\\.dtb$")) ;; Install kernel modules (mkdir-p moddir) - (zero? (system* "make" - (string-append "DEPMOD=" kmod "/bin/depmod") - (string-append "MODULE_DIR=" moddir) - (string-append "INSTALL_PATH=" out) - (string-append "INSTALL_MOD_PATH=" out) - "INSTALL_MOD_STRIP=1" - "modules_install")))))) + (invoke "make" + (string-append "DEPMOD=" kmod "/bin/depmod") + (string-append "MODULE_DIR=" moddir) + (string-append "INSTALL_PATH=" out) + (string-append "INSTALL_MOD_PATH=" out) + "INSTALL_MOD_STRIP=1" + "modules_install"))))) #:tests? #f)) (home-page "https://www.gnu.org/software/linux-libre/") (synopsis "100% free redistribution of a cleaned Linux kernel") From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 14 16:41:05 2018 Received: (at 30454) by debbugs.gnu.org; 14 Feb 2018 21:41:05 +0000 Received: from localhost ([127.0.0.1]:43390 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1em4nZ-00025V-F6 for submit@debbugs.gnu.org; Wed, 14 Feb 2018 16:41:05 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:41161) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1em4nY-00025O-42 for 30454@debbugs.gnu.org; Wed, 14 Feb 2018 16:41:04 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 990F020C7F; Wed, 14 Feb 2018 16:41:03 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute4.internal (MEProxy); Wed, 14 Feb 2018 16:41:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= mesmtp; bh=N0c0/Oc6H7PFwRFEjbtM7IWaS3dex3xdo/NB8nY/3pc=; b=OiqzA QGRTOoetLOAuCpVJuB8I/SzHQicjbfwtMKi8Dwc/zAD501ZcElD8mvWLedcquWna kzmPPFJ6Da4b8ZP7SUxUmdUT4Jfjseug3XBaMTGq9VT8BeDMG+KYZhtKMDN0vql5 n3GhC+37b3JKTJbNydkHR2QLDHLrfLp7rnoQtk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=N0c0/Oc6H7PFwRFEjbtM7IWaS3dex 3xdo/NB8nY/3pc=; b=mFEusZAth61dR/+e0e4QSlM4Zc7ZrjuhIX8puumHJrPdP VSxCoSfTRgQxdqMwrFkvzSLSmz3xiphfswG2od9wB/431D804KRMAQBZGZ/Wm6Bm 7rfxK0WfHEh0seszJqQF7IWW4j4Nj5Fr4kQ4UzCMJEG/WEskj+BN1NW3M7pXL516 DSDL3nAzGBz7nr8XOZMdDw1QHYZwryRaz7budP+2B7pqnTs1lllh8JhCA/E04RyV jrD3130ov9hThtGwsAGymTYLYbFdlC5A6N3t2BsZA5ARzf6soTFNmANw80taQTGX IxYqBWP8/4/YoU7LfNS7h7ZTA4dYiTkPvU6/3R4vQ== X-ME-Sender: Received: from localhost (c-76-124-202-137.hsd1.pa.comcast.net [76.124.202.137]) by mail.messagingengine.com (Postfix) with ESMTPA id 4C60424718; Wed, 14 Feb 2018 16:41:03 -0500 (EST) Date: Wed, 14 Feb 2018 16:41:02 -0500 From: Leo Famulari To: Danny Milosavljevic Subject: Re: [bug#30454] [PATCH] gnu: make-linux-libre: Use invoke. Message-ID: <20180214214102.GB22425@jasmine.lan> References: <20180214083722.12245-1-dannym@scratchpost.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OXfL5xGRrasGEqWY" Content-Disposition: inline In-Reply-To: <20180214083722.12245-1-dannym@scratchpost.org> User-Agent: Mutt/1.9.3 (2018-01-21) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 30454 Cc: Mark H Weaver , 30454@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --OXfL5xGRrasGEqWY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 14, 2018 at 09:37:22AM +0100, Danny Milosavljevic wrote: > * gnu/packages/linux.scm (make-linux-libre): Use invoke. Thanks! This will require rebuilding linux-libre, right? If so, we should push it along with updates to those packages. CC-ing Mark, who usually handles linux-libre. --OXfL5xGRrasGEqWY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlqErO4ACgkQJkb6MLrK fwijEA//XouXnwY1ag/Ge0GiwdHAZn/dDSDP+IDWpOIsDYrhtsp8o6SmyF38ypE0 B3CmC3wQRJx6V5pIbiZSSza8kjNM3jrLX9iT02Uty1TxcPPWvB2S8mNLSAWJJths 5m1TbdhRxw+d/B9V9jkLlAMZerlBECZcRxxXdqQiOjRve6m7yQEgvTObOtI5hWYA qbzoe5Vd0g8p107j8rmvQdxRE9Pl3st9H08FqdfLKjedXu717H8MJQm/lU9XCXgH ewlDwnjGdaWs+aKNnkOD+NFZ4yHHl2lsti5/cZHQBr4/pLrDEa8yNQeWLo9RZrAy clQ/GEMSCPatmVfw0MLc2bPxNX2duqjw2FSz9UjrqcPkfZY1kjxUEBRJZNJ4cwpN 7Id++KWgc2YjxS9w5ibGb76wPZTJOwfUTscNXVhPcLLXQn3xwwmntDyBpRUtzDV9 jBTzUZ9nUM1+LidxtPWGnFJm0B410sXp7laMtZgyThiWUUaXg+5V3HeDAMn/K+eA AEvsYWCdhqIbiUHu/hv1aAjHJ+F6fZU3POSVjWb6Cgu/DhY6jvUn4pRMInTZ+kC9 H0k0cmLk6X7L1mHMRYNrj4tjEmowHaL+rqB7QBs4V8e2aqOdhPqEiMMpO7whaupY TPzKjm+S0b0OCHXclVc0QKQUDS6Sd7Z4LWFAT7XqKfjYsjuP2M8= =JbwI -----END PGP SIGNATURE----- --OXfL5xGRrasGEqWY-- From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 15 02:41:09 2018 Received: (at 30454) by debbugs.gnu.org; 15 Feb 2018 07:41:09 +0000 Received: from localhost ([127.0.0.1]:43593 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emEAH-0007mM-34 for submit@debbugs.gnu.org; Thu, 15 Feb 2018 02:41:09 -0500 Received: from world.peace.net ([50.252.239.5]:59966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emEAF-0007mA-GA for 30454@debbugs.gnu.org; Thu, 15 Feb 2018 02:41:07 -0500 Received: from pool-72-93-28-176.bstnma.east.verizon.net ([72.93.28.176] helo=jojen) by world.peace.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1emEA9-0004BM-Km; Thu, 15 Feb 2018 02:41:01 -0500 From: Mark H Weaver To: Leo Famulari Subject: Re: [bug#30454] [PATCH] gnu: make-linux-libre: Use invoke. References: <20180214083722.12245-1-dannym@scratchpost.org> <20180214214102.GB22425@jasmine.lan> Date: Thu, 15 Feb 2018 02:40:27 -0500 In-Reply-To: <20180214214102.GB22425@jasmine.lan> (Leo Famulari's message of "Wed, 14 Feb 2018 16:41:02 -0500") Message-ID: <87eflmog44.fsf@netris.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30454 Cc: Danny Milosavljevic , 30454@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Leo Famulari writes: > On Wed, Feb 14, 2018 at 09:37:22AM +0100, Danny Milosavljevic wrote: >> * gnu/packages/linux.scm (make-linux-libre): Use invoke. > > Thanks! > > This will require rebuilding linux-libre, right? If so, we should push > it along with updates to those packages. Agreed. I'll try to remember to push Danny's commit the next time I push kernel updates, which typically happen every few days anyway. Let's hold off on this until then. Thanks! Mark From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 18 00:10:08 2018 Received: (at 30454-done) by debbugs.gnu.org; 18 Feb 2018 05:10:08 +0000 Received: from localhost ([127.0.0.1]:48889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1enHEm-0004G6-3s for submit@debbugs.gnu.org; Sun, 18 Feb 2018 00:10:08 -0500 Received: from world.peace.net ([50.252.239.5]:48644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1enHEk-0004FZ-Hn for 30454-done@debbugs.gnu.org; Sun, 18 Feb 2018 00:10:06 -0500 Received: from pool-72-93-27-42.bstnma.east.verizon.net ([72.93.27.42] helo=jojen) by world.peace.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1enHEe-0000ch-Ka; Sun, 18 Feb 2018 00:10:00 -0500 From: Mark H Weaver To: Leo Famulari Subject: Re: [bug#30454] [PATCH] gnu: make-linux-libre: Use invoke. References: <20180214083722.12245-1-dannym@scratchpost.org> <20180214214102.GB22425@jasmine.lan> <87eflmog44.fsf@netris.org> Date: Sun, 18 Feb 2018 00:09:26 -0500 In-Reply-To: <87eflmog44.fsf@netris.org> (Mark H. Weaver's message of "Thu, 15 Feb 2018 02:40:27 -0500") Message-ID: <87inauj33t.fsf@netris.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30454-done Cc: Danny Milosavljevic , 30454-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) I just pushed Danny's commit to master along with kernel updates, commit fdd400d82ed83e230331f837aee70e1d504fe58c. I'm marking this as done. Thanks! Mark From unknown Mon Aug 18 19:25:47 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 18 Mar 2018 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator