GNU bug report logs - #30454
[PATCH] gnu: make-linux-libre: Use invoke.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30454 in the body.
You can then email your comments to 30454 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: guix-patches <at> gnu.org
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>
Subject: [PATCH] gnu: make-linux-libre: Use invoke.
Date: Wed, 14 Feb 2018 09:37:22 +0100

* gnu/packages/linux.scm (make-linux-libre): Use invoke.
---
 gnu/packages/linux.scm | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 858f0885c..e01edce9c 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -336,7 +336,7 @@ for ARCH and optionally VARIANT, or #f if there is no such configuration."
                    (begin
                      (copy-file config ".config")
                      (chmod ".config" #o666))
-                   (system* "make" ,defconfig))
+                   (invoke "make" ,defconfig))
 
                ;; Appending works even when the option wasn't in the
                ;; file.  The last one prevails if duplicated.
@@ -345,7 +345,7 @@ for ARCH and optionally VARIANT, or #f if there is no such configuration."
                  (display extra-configuration port)
                  (close-port port))
 
-               (zero? (system* "make" "oldconfig")))))
+               (invoke "make" "oldconfig"))))
          (replace 'install
            (lambda* (#:key inputs native-inputs outputs #:allow-other-keys)
              (let* ((out    (assoc-ref outputs "out"))
@@ -360,13 +360,13 @@ for ARCH and optionally VARIANT, or #f if there is no such configuration."
                          (find-files "." "\\.dtb$"))
                ;; Install kernel modules
                (mkdir-p moddir)
-               (zero? (system* "make"
-                               (string-append "DEPMOD=" kmod "/bin/depmod")
-                               (string-append "MODULE_DIR=" moddir)
-                               (string-append "INSTALL_PATH=" out)
-                               (string-append "INSTALL_MOD_PATH=" out)
-                               "INSTALL_MOD_STRIP=1"
-                               "modules_install"))))))
+               (invoke "make"
+                       (string-append "DEPMOD=" kmod "/bin/depmod")
+                       (string-append "MODULE_DIR=" moddir)
+                       (string-append "INSTALL_PATH=" out)
+                       (string-append "INSTALL_MOD_PATH=" out)
+                       "INSTALL_MOD_STRIP=1"
+                       "modules_install")))))
        #:tests? #f))
     (home-page "https://www.gnu.org/software/linux-libre/")
     (synopsis "100% free redistribution of a cleaned Linux kernel")

Message #8 received at 30454 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: Mark H Weaver <mhw <at> netris.org>, 30454 <at> debbugs.gnu.org
Subject: Re: [bug#30454] [PATCH] gnu: make-linux-libre: Use invoke.
Date: Wed, 14 Feb 2018 16:41:02 -0500

[Message part 1 (text/plain, inline)]

On Wed, Feb 14, 2018 at 09:37:22AM +0100, Danny Milosavljevic wrote:
> * gnu/packages/linux.scm (make-linux-libre): Use invoke.

Thanks!

This will require rebuilding linux-libre, right? If so, we should push
it along with updates to those packages.

CC-ing Mark, who usually handles linux-libre.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 30454 <at> debbugs.gnu.org (full text, mbox):

From: Mark H Weaver <mhw <at> netris.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>, 30454 <at> debbugs.gnu.org
Subject: Re: [bug#30454] [PATCH] gnu: make-linux-libre: Use invoke.
Date: Thu, 15 Feb 2018 02:40:27 -0500

Leo Famulari <leo <at> famulari.name> writes:

> On Wed, Feb 14, 2018 at 09:37:22AM +0100, Danny Milosavljevic wrote:
>> * gnu/packages/linux.scm (make-linux-libre): Use invoke.
>
> Thanks!
>
> This will require rebuilding linux-libre, right? If so, we should push
> it along with updates to those packages.

Agreed.  I'll try to remember to push Danny's commit the next time I
push kernel updates, which typically happen every few days anyway.
Let's hold off on this until then.

     Thanks!
       Mark

Message #16 received at 30454-done <at> debbugs.gnu.org (full text, mbox):

From: Mark H Weaver <mhw <at> netris.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>, 30454-done <at> debbugs.gnu.org
Subject: Re: [bug#30454] [PATCH] gnu: make-linux-libre: Use invoke.
Date: Sun, 18 Feb 2018 00:09:26 -0500

I just pushed Danny's commit to master along with kernel updates, commit
fdd400d82ed83e230331f837aee70e1d504fe58c.  I'm marking this as done.

     Thanks!
       Mark

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.