GNU bug report logs - #30452
25.3; tabulated-list-mode-map should inherit from special-mode-map

Previous Next

Package: emacs;

Reported by: Stephen Jung <tummychow511 <at> gmail.com>

Date: Wed, 14 Feb 2018 04:27:01 UTC

Severity: minor

Found in version 25.3

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Alex Branham <alex.branham <at> gmail.com>, 30452 <at> debbugs.gnu.org
Subject: bug#30452: [PATCH] Use 'make-sparse-keymap' rather than 'copy-keymap'
Date: Sat, 19 Jan 2019 10:33:12 -0500

>>  (defvar tabulated-list-mode-map
>> -  (let ((map (copy-keymap special-mode-map)))
>> +  (let ((map (make-sparse-keymap)))
>>      (set-keymap-parent map button-buffer-map)

Nowadays we can inherit from both with something like

    (set-keymap-parent map (make-composed-keymap
                            button-buffer-map
                            special-mode-map))


-- Stefan
This bug report was last modified 6 years and 172 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.