From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 13 23:26:24 2018 Received: (at submit) by debbugs.gnu.org; 14 Feb 2018 04:26:24 +0000 Received: from localhost ([127.0.0.1]:42061 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eloeG-0007Fd-3Y for submit@debbugs.gnu.org; Tue, 13 Feb 2018 23:26:24 -0500 Received: from eggs.gnu.org ([208.118.235.92]:43771) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1elo7Q-0006St-6l for submit@debbugs.gnu.org; Tue, 13 Feb 2018 22:52:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1elo7J-0003Mh-UH for submit@debbugs.gnu.org; Tue, 13 Feb 2018 22:52:22 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:38202) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1elo7J-0003Mc-Qz for submit@debbugs.gnu.org; Tue, 13 Feb 2018 22:52:21 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34742) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elo7I-00022B-GX for bug-gnu-emacs@gnu.org; Tue, 13 Feb 2018 22:52:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1elo7H-0003Ll-Gf for bug-gnu-emacs@gnu.org; Tue, 13 Feb 2018 22:52:20 -0500 Received: from mail-yw0-x22a.google.com ([2607:f8b0:4002:c05::22a]:35410) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1elo7H-0003LS-Az for bug-gnu-emacs@gnu.org; Tue, 13 Feb 2018 22:52:19 -0500 Received: by mail-yw0-x22a.google.com with SMTP id d77so1771650ywb.2 for ; Tue, 13 Feb 2018 19:52:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=5eRcx0p5KZ/k+T5q2ap22AqJyjCJScEWwF/EEeS5r6c=; b=SMpCSwvgL7L3iarRkgFPPyczGR81NyZXqhd9OtLPFnqxv4vhxYXpEm4d65Bc9RbqVj cum80pqkVRblyqOmajXtNruAHyNG8J5YW4svpbazGq9djfMQLEcd9RiqfD2DI8wY+C6J T2Auuv/yiRLgg3s7o4AYUHf8OrVar7u6yaP+4C8E24GpetNa6MrPlxs3YaaWo4CWif/r yjDiko1zKuOsUaTDwwBZfj8wGCPs3TPUuiGnVNlwA7vRQUrmcq+SLfJB0ff9PhS4JNG8 jF5HoDfE1Y3Lf2vjYH/oUUsL9wukEpZ2pE4lrR1dYFnMSpZnAV4iTiwVdlyb0nvHL4+w yOAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=5eRcx0p5KZ/k+T5q2ap22AqJyjCJScEWwF/EEeS5r6c=; b=qBfv9RYrbbUkpE1zlQkcCVPZt2zjWuIQERgMvD/dkfjVniq6vzwWcPs1YnzwbB8yfA dhkWFawzlOOns4f6v7ClBIxDghcku2/B2MUJ9RaOyN8zpXGiDE+fnY4psSrCTtPdRjzQ Id3nWvUIEFImcC/DgzpfrzoTZVzVAjBNZVxYnHlm8CXLgDcSgPsYYyPMJNkoyh2JwuV6 L7DDlBs9iHmZBYU9OZjnLh8qCARLt2mM9wSO2D0DfWOZbcuoLOpGDcDYDXCPjuUFZl44 043foorby2afMf3T3FFP0eKXFFsB896e/s8jtzi5D2ZvzQhDN5vfJinG5TLeIEQZIQpM f8GQ== X-Gm-Message-State: APf1xPDesSRRGbFTgWWXhunjXUn55EEaiKkO8FQXJW4htZ49ZyAiu0ds uwlztkYKnh8HYB2kmzUqNUceT6OCzhUabA7cgatco1q2 X-Google-Smtp-Source: AH8x22429Bz5zElnBPnjtHQhtGP8qW2OVASCFcGScCIo3pLK7yHWNiKopw4fcbIAgraqKjFS8J6r5w7gW2BMKQ2blNI= X-Received: by 10.129.4.8 with SMTP id 8mr2296374ywe.206.1518580338221; Tue, 13 Feb 2018 19:52:18 -0800 (PST) MIME-Version: 1.0 Received: by 10.37.113.130 with HTTP; Tue, 13 Feb 2018 19:52:17 -0800 (PST) From: Stephen Jung Date: Tue, 13 Feb 2018 19:52:17 -0800 Message-ID: Subject: 25.3; tabulated-list-mode-map should inherit from special-mode-map To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 13 Feb 2018 23:26:22 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) tabulated-list-mode inherits from special-mode, so tabulated-list-mode-map should probably also inherit from special-mode-map. However, it actually copies special-mode-map in its definition (https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/emacs-lisp/tabulated-list.el?h=emacs-25.3#n152). This appears to be the way that the code was written when tabulated-list-mode was first created. I haven't read the mailing list archives, so I'm not sure if there was an explanation of why it was done this way, and there isn't a comment providing details on this approach. Therefore, I think it should just be making a sparse keymap here and inheriting from its parent, like most modes do. In GNU Emacs 25.3.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.26) of 2018-02-08 built on bisson Windowing system distributor 'The X.Org Foundation', version 11.0.11906000 Configured using: 'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/var --with-x-toolkit=gtk3 --with-xft --with-modules 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong -fno-plt' CPPFLAGS=-D_FORTIFY_SOURCE=2 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 MODULES Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix -- Stephen From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 15 12:58:04 2019 Received: (at 30452) by debbugs.gnu.org; 15 Jan 2019 17:58:04 +0000 Received: from localhost ([127.0.0.1]:60337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gjSyS-0001F5-53 for submit@debbugs.gnu.org; Tue, 15 Jan 2019 12:58:04 -0500 Received: from mail-ot1-f41.google.com ([209.85.210.41]:45179) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gjSyP-0001Ea-VS for 30452@debbugs.gnu.org; Tue, 15 Jan 2019 12:58:02 -0500 Received: by mail-ot1-f41.google.com with SMTP id 32so3272414ota.12 for <30452@debbugs.gnu.org>; Tue, 15 Jan 2019 09:58:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:subject:date:message-id:mime-version; bh=wWURqbDEpG5AdwaQCYixZpZebc7E7T4syMOv/RLWaAc=; b=aULeuYzIfr5BIGfiW1HzdB2FSvS/JOtMyXwOSkICyiNYapa4lXfCBOIe7WQTjzsSa9 YNyve2DtaBixIYBlSGRMgjlwgmPpwy/BEqEnDm8cbE27W1pgpLEnGhVUQVybMZBtYOq8 NMvrVyUxToqTANDySKNXlJ2JL+tluA1ykE/1rZyyxqpSuO+YeoWCNOPHiAzRKrzsQoBy I2y7OFVwNRGNgcDPdCq0DodjPM41CwX9zhLHlEr8jlX4K22e6hLMO06WM/GATxE94/CO wpdJyKMfCdOkyuzT/DOImlwiPLkDzvxlUkhzaLYp3O2cM4CtIPVRlU8gH6jB7Xlpz4GH 96Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version; bh=wWURqbDEpG5AdwaQCYixZpZebc7E7T4syMOv/RLWaAc=; b=a4r5oc/wfadtLl2AoFrANcbrBVghZLh38p+ugX6TciyoSCQcgmw503WnsY8sDrXxNT MaX4W/sVhIC9Mdw9ljSllSV4KJjEazSIgsClNDB4GUeTteb1Zb5nCr9oM7xbNRzETmja IZ6UYNpuGwyPnyLOEpIQEfxHj0iqOf+w8hNBAFI2qq8NtZqLUaZwF7Ev+CITtC/Y3t71 jMFKvwdXieWI5E+aDOOQndwUVS/mQhOOaWS5aZgS/nZWLzAJE97Lq2xhYIWxVz2UKxCi ZSX4/rC1Lrj3yhS841UofKbzeDIrDoQbSpTJ/AqCh6caby2M49OrgcwJ92zQ9fz9MHyw FeYg== X-Gm-Message-State: AJcUukeyZ522+OE5mjFa0juG0jewFby4h4DQyOZhk7uCCDKykMbJfRvn sGKqWgEtu1ZV158ZFgqoIyjE0qks X-Google-Smtp-Source: ALg8bN5o7cFQKE0CzXfV1O939b2RI4LIPhz713wRTir6kQeLqqxXSr2ZD1+kgntEkkX9nKjR8rvvAw== X-Received: by 2002:a05:6830:1d1:: with SMTP id r17mr2915825ota.36.1547575075613; Tue, 15 Jan 2019 09:57:55 -0800 (PST) Received: from earth (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id 31sm3509822otw.55.2019.01.15.09.57.54 for <30452@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 Jan 2019 09:57:54 -0800 (PST) User-agent: mu4e 1.1.0; emacs 27.0.50 From: Alex Branham To: 30452@debbugs.gnu.org Subject: [PATCH] Use 'make-sparse-keymap' rather than 'copy-keymap' Date: Tue, 15 Jan 2019 11:57:52 -0600 Message-ID: <8736ptiz1b.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30452 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hello - Here's a tiny patch that changes the call from copy-keymap to make-sparse-keymap. Thanks, Alex >From c7f6db630f720fd26f0f1cc45631326bdcec136c Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Tue, 15 Jan 2019 11:50:55 -0600 Subject: [PATCH] Make tabulated-list-mode-map inherit from special-mode-map * lisp/emacs-lisp/tabulated-list.el (tabulated-list-mode-map): Use 'make-sparse-keymap' rather than copying 'special-mode-map'. Bug #30452 --- lisp/emacs-lisp/tabulated-list.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/tabulated-list.el b/lisp/emacs-lisp/tabulated-list.el index 6fdca2cd08..8c99728fd4 100644 --- a/lisp/emacs-lisp/tabulated-list.el +++ b/lisp/emacs-lisp/tabulated-list.el @@ -151,7 +151,7 @@ tabulated-list-put-tag (forward-line))) (defvar tabulated-list-mode-map - (let ((map (copy-keymap special-mode-map))) + (let ((map (make-sparse-keymap))) (set-keymap-parent map button-buffer-map) (define-key map "n" 'next-line) (define-key map "p" 'previous-line) -- 2.19.2 --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Make-tabulated-list-mode-map-inherit-from-special-mo.patch >From c7f6db630f720fd26f0f1cc45631326bdcec136c Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Tue, 15 Jan 2019 11:50:55 -0600 Subject: [PATCH] Make tabulated-list-mode-map inherit from special-mode-map * lisp/emacs-lisp/tabulated-list.el (tabulated-list-mode-map): Use 'make-sparse-keymap' rather than copying 'special-mode-map'. Bug #30452 --- lisp/emacs-lisp/tabulated-list.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/tabulated-list.el b/lisp/emacs-lisp/tabulated-list.el index 6fdca2cd08..8c99728fd4 100644 --- a/lisp/emacs-lisp/tabulated-list.el +++ b/lisp/emacs-lisp/tabulated-list.el @@ -151,7 +151,7 @@ tabulated-list-put-tag (forward-line))) (defvar tabulated-list-mode-map - (let ((map (copy-keymap special-mode-map))) + (let ((map (make-sparse-keymap))) (set-keymap-parent map button-buffer-map) (define-key map "n" 'next-line) (define-key map "p" 'previous-line) -- 2.19.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 19 03:05:56 2019 Received: (at 30452) by debbugs.gnu.org; 19 Jan 2019 08:05:56 +0000 Received: from localhost ([127.0.0.1]:37273 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkldc-0001fc-04 for submit@debbugs.gnu.org; Sat, 19 Jan 2019 03:05:56 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkldZ-0001fP-Lo for 30452@debbugs.gnu.org; Sat, 19 Jan 2019 03:05:54 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58343) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkldO-0002bS-J3; Sat, 19 Jan 2019 03:05:43 -0500 Received: from [176.228.60.248] (port=3372 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gkldK-0004ur-SP; Sat, 19 Jan 2019 03:05:41 -0500 Date: Sat, 19 Jan 2019 10:05:17 +0200 Message-Id: <83lg3hax8i.fsf@gnu.org> From: Eli Zaretskii To: Alex Branham , Stefan Monnier In-reply-to: <8736ptiz1b.fsf@gmail.com> (message from Alex Branham on Tue, 15 Jan 2019 11:57:52 -0600) Subject: Re: bug#30452: [PATCH] Use 'make-sparse-keymap' rather than 'copy-keymap' References: <8736ptiz1b.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30452 Cc: 30452@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: Alex Branham > Date: Tue, 15 Jan 2019 11:57:52 -0600 > > Here's a tiny patch that changes the call from copy-keymap to make-sparse-keymap. > > Thanks, > Alex > > >From c7f6db630f720fd26f0f1cc45631326bdcec136c Mon Sep 17 00:00:00 2001 > From: Alex Branham > Date: Tue, 15 Jan 2019 11:50:55 -0600 > Subject: [PATCH] Make tabulated-list-mode-map inherit from special-mode-map > > * lisp/emacs-lisp/tabulated-list.el (tabulated-list-mode-map): Use > 'make-sparse-keymap' rather than copying 'special-mode-map'. > > Bug #30452 Maybe I'm missing something, but I thought the original bug report said it should inherit from special-mode's keymap? Your patch doesn't seem to be doing that, or did I miss something? More generally, I wonder why we don't say in the ELisp manual that a derived mode should do this with its keymap. Should we? Thanks. > lisp/emacs-lisp/tabulated-list.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lisp/emacs-lisp/tabulated-list.el b/lisp/emacs-lisp/tabulated-list.el > index 6fdca2cd08..8c99728fd4 100644 > --- a/lisp/emacs-lisp/tabulated-list.el > +++ b/lisp/emacs-lisp/tabulated-list.el > @@ -151,7 +151,7 @@ tabulated-list-put-tag > (forward-line))) > > (defvar tabulated-list-mode-map > - (let ((map (copy-keymap special-mode-map))) > + (let ((map (make-sparse-keymap))) > (set-keymap-parent map button-buffer-map) > (define-key map "n" 'next-line) > (define-key map "p" 'previous-line) > -- > 2.19.2 From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 19 10:33:18 2019 Received: (at 30452) by debbugs.gnu.org; 19 Jan 2019 15:33:18 +0000 Received: from localhost ([127.0.0.1]:38002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkscY-0008P6-0o for submit@debbugs.gnu.org; Sat, 19 Jan 2019 10:33:18 -0500 Received: from chene.dit.umontreal.ca ([132.204.246.20]:54198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkscV-0008Ox-4J for 30452@debbugs.gnu.org; Sat, 19 Jan 2019 10:33:16 -0500 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id x0JFXDOV025719; Sat, 19 Jan 2019 10:33:13 -0500 Received: by pastel.home (Postfix, from userid 20848) id DF7326AB69; Sat, 19 Jan 2019 10:33:12 -0500 (EST) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#30452: [PATCH] Use 'make-sparse-keymap' rather than 'copy-keymap' Message-ID: References: <8736ptiz1b.fsf@gmail.com> <83lg3hax8i.fsf@gnu.org> Date: Sat, 19 Jan 2019 10:33:12 -0500 In-Reply-To: <83lg3hax8i.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 19 Jan 2019 10:05:17 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6464=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6464> : inlines <6998> : streams <1810544> : uri <2782420> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 30452 Cc: Alex Branham , 30452@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> (defvar tabulated-list-mode-map >> - (let ((map (copy-keymap special-mode-map))) >> + (let ((map (make-sparse-keymap))) >> (set-keymap-parent map button-buffer-map) Nowadays we can inherit from both with something like (set-keymap-parent map (make-composed-keymap button-buffer-map special-mode-map)) -- Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 21 10:53:40 2019 Received: (at 30452) by debbugs.gnu.org; 21 Jan 2019 15:53:40 +0000 Received: from localhost ([127.0.0.1]:40353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1glbtM-0000pp-3B for submit@debbugs.gnu.org; Mon, 21 Jan 2019 10:53:40 -0500 Received: from mail-oi1-f193.google.com ([209.85.167.193]:41267) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1glbtK-0000pb-8x for 30452@debbugs.gnu.org; Mon, 21 Jan 2019 10:53:38 -0500 Received: by mail-oi1-f193.google.com with SMTP id j21so14874834oii.8 for <30452@debbugs.gnu.org>; Mon, 21 Jan 2019 07:53:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=pXzve13L8C5kpbL+ruDueXG/P4FtiXc9uqXe3tyZoWA=; b=YOiLvJtE1mriUR5TNpPCB977a6rtyHvpm1SNAl3LZazKVHbeXExIE/vqOxgDLdj2em jJys1g7jrXfDAxZ6BSgxRrazva3XmNeYVhLHuGzu2qZI+xeyHQniQxC93UGo6Nzc3SUT nGzkWdf5VLcByMDCgXWDQY1I8AyOHFK3mL+ih7zF1upVXS532gCrfLbDhyJ/03Kx58WX bqRF51aCSgQJ0QgW7J39Z2xnWm/+eePxLcziXZYcxI2b7mu1pAfX0n8ZBwOY8JyEPPpy rDM1fhx2W2On8aVVjKKhotEX4e+qGS3km/WMo+7GoYeOCDE3dZrUVwiFbx/e/YxCZjV+ KJ3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=pXzve13L8C5kpbL+ruDueXG/P4FtiXc9uqXe3tyZoWA=; b=s6MR/VQiwd3HwDC6FtU0vLmnJfzp2BsDertEVpSPvqXW0kJKVKObBg4KbM8RuoDYUy r2y25APqYjFmYo6LaP6mQwukAbNrFkoBvyEBpWxLS+ZgJi0W+3BZJf2rflS84dVslyKJ ugTYEl3url8h8cA36dBecxf+yHzc6rnZHdBb5g4ji8kiSRlaKmqgNKZgXrFEItXx7DrE rLMVFKVC1pqWKLZ5/4HYOuIkRAjGzA0/OjouDBkKBOi9LjQAbIblV9Kn1e0U38Yyq31l N1AhOBsAXHNwdKT2cjNSAoWBQXmnMtaxIMlu/zNm6T37EJxG/vnqJT4c/Oy+X8Sgt14u 58QQ== X-Gm-Message-State: AJcUuke0fbz1TKj7skAekCARpUp5ge3MBIVPo0he2lFFTtrxODNE7+L3 oFG29qaTEF62IPHv+ty85zLgK6e7 X-Google-Smtp-Source: ALg8bN5MDAS3ZccEnQlSCgmZ1FLdttRzL6RwBrgUODxnPew1qMxe7/D5D83PFRQqzut4gtU0eVjhDw== X-Received: by 2002:aca:54c4:: with SMTP id i187mr5791254oib.238.1548086011927; Mon, 21 Jan 2019 07:53:31 -0800 (PST) Received: from mars (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id i12sm5463848otc.48.2019.01.21.07.53.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Jan 2019 07:53:30 -0800 (PST) References: <8736ptiz1b.fsf@gmail.com> <83lg3hax8i.fsf@gnu.org> User-agent: mu4e 1.1.0; emacs 27.0.50 From: Alex Branham To: Stefan Monnier Subject: Re: bug#30452: [PATCH] Use 'make-sparse-keymap' rather than 'copy-keymap' In-reply-to: Date: Mon, 21 Jan 2019 09:53:29 -0600 Message-ID: <877eeyc8hy.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30452 Cc: Eli Zaretskii , 30452@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat 19 Jan 2019 at 09:33, Stefan Monnier wrote: >>> (defvar tabulated-list-mode-map >>> - (let ((map (copy-keymap special-mode-map))) >>> + (let ((map (make-sparse-keymap))) >>> (set-keymap-parent map button-buffer-map) > > Nowadays we can inherit from both with something like > > (set-keymap-parent map (make-composed-keymap > button-buffer-map > special-mode-map)) Thanks, that's better! Here's the updated patch. Alex >From 6c21fb2434fa9f0499ebff5beabdbfda7b03f534 Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Mon, 21 Jan 2019 09:50:11 -0600 Subject: [PATCH] Make tabulated-list-mode-map inherit from special-mode-map * lisp/emacs-lisp/tabulated-list.el (tabulated-list-mode-map): Use 'make-composed-keymap'. Bug #30452 --- lisp/emacs-lisp/tabulated-list.el | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lisp/emacs-lisp/tabulated-list.el b/lisp/emacs-lisp/tabulated-list.el index 6fdca2cd08..12d0151d67 100644 --- a/lisp/emacs-lisp/tabulated-list.el +++ b/lisp/emacs-lisp/tabulated-list.el @@ -151,8 +151,10 @@ If ADVANCE is non-nil, move forward by one line afterwards." (forward-line))) (defvar tabulated-list-mode-map - (let ((map (copy-keymap special-mode-map))) - (set-keymap-parent map button-buffer-map) + (let ((map (make-sparse-keymap))) + (set-keymap-parent map (make-composed-keymap + button-buffer-map + special-mode-map)) (define-key map "n" 'next-line) (define-key map "p" 'previous-line) (define-key map "S" 'tabulated-list-sort) -- 2.19.2 From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 25 03:50:43 2019 Received: (at 30452-done) by debbugs.gnu.org; 25 Jan 2019 08:50:43 +0000 Received: from localhost ([127.0.0.1]:44513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gmxCF-0007i3-B9 for submit@debbugs.gnu.org; Fri, 25 Jan 2019 03:50:43 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59333) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gmxCD-0007hq-Co for 30452-done@debbugs.gnu.org; Fri, 25 Jan 2019 03:50:42 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60111) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmxC6-0008H6-0o; Fri, 25 Jan 2019 03:50:34 -0500 Received: from [176.228.60.248] (port=3040 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gmxC5-0002D0-Bk; Fri, 25 Jan 2019 03:50:33 -0500 Date: Fri, 25 Jan 2019 10:50:29 +0200 Message-Id: <83zhrp5dey.fsf@gnu.org> From: Eli Zaretskii To: Alex Branham In-reply-to: <877eeyc8hy.fsf@gmail.com> (message from Alex Branham on Mon, 21 Jan 2019 09:53:29 -0600) Subject: Re: bug#30452: [PATCH] Use 'make-sparse-keymap' rather than 'copy-keymap' References: <8736ptiz1b.fsf@gmail.com> <83lg3hax8i.fsf@gnu.org> <877eeyc8hy.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30452-done Cc: monnier@IRO.UMontreal.CA, 30452-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: Alex Branham > Cc: Eli Zaretskii , 30452@debbugs.gnu.org > Date: Mon, 21 Jan 2019 09:53:29 -0600 > > > On Sat 19 Jan 2019 at 09:33, Stefan Monnier wrote: > > >>> (defvar tabulated-list-mode-map > >>> - (let ((map (copy-keymap special-mode-map))) > >>> + (let ((map (make-sparse-keymap))) > >>> (set-keymap-parent map button-buffer-map) > > > > Nowadays we can inherit from both with something like > > > > (set-keymap-parent map (make-composed-keymap > > button-buffer-map > > special-mode-map)) > > Thanks, that's better! Here's the updated patch. Thanks, pushed to the master branch. From unknown Sun Aug 10 16:48:30 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 22 Feb 2019 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator