Subject: Re: bug#30444: 26.0.90; browse-url-emacs sets default-directory to "https://"

From: Michael Albinus <[email-masked]>
Date: Wed, 14 Mar 2018 17:09:22 +0100

Nicolas Petton <[email-masked]> writes:

Hi Nico,

> Here's a first tentative.  It's probably naive though, as there might be
> some corner cases I didn't think of and I'm new to file-handlers.

I haven't tested thoroughly, but your tests look OK.

> +    (should (equal (file-name-directory "https://foo.org")
> +                   "https://foo.org/"))))

This is OK, but I would add also

    (should (equal (file-name-directory "https://foo.org/")
                   "https://foo.org/"))))

Maybe you could add also negative tests, for example for
(file-name-directory "not-a-uri://foo.org")

Best regards, Michael.